RubyGems - html-proofer - Versions diffs - 0.8.0 → 0.9.0 - Mend

@@ -2,5 +2,3 @@
 <a href="index.html">Relative to self</a>
 <a href="folder/">Folder relative to self</a>
 <a href="index.html#anchor">Anchor relative to self</a>
-<img alt="sure thing" src="gpl.png"/>Relative to self

data/spec/html/proofer/fixtures/{rootLink.html → links/rootLink.html} RENAMED Viewed

File without changes

data/spec/html/proofer/fixtures/{tel_link.html → links/tel_link.html} RENAMED Viewed

File without changes

data/spec/html/proofer/fixtures/Screen Shot 2012-08-09 at 7.51.18 AM.png b/data/spec/html/proofer/fixtures/resources/Screen Shot 2012-08-09 at 7.51.18 → AM.png RENAMED Viewed

File without changes

data/spec/html/proofer/fixtures/resources/gpl.png ADDED Viewed

Binary file

data/spec/html/proofer/fixtures/scripts/script.js ADDED Viewed

	@@ -0,0 +1 @@
1	+ var x = 1;

data/spec/html/proofer/fixtures/scripts/script_broken_external.html ADDED Viewed

@@ -0,0 +1,9 @@
+<html>
+<body>
+  <script src="http://www.asdo3IRJ395295jsingrkrg4.com/asdo3IRJ.js"></script>
+</body>
+</html>

data/spec/html/proofer/fixtures/scripts/script_content.html ADDED Viewed

@@ -0,0 +1,9 @@
+<html>
+<body>
+  <script>var x = 1;</script>
+</body>
+</html>

data/spec/html/proofer/fixtures/scripts/script_content_absent.html ADDED Viewed

@@ -0,0 +1,9 @@
+<html>
+<body>
+  <script></script>
+</body>
+</html>

data/spec/html/proofer/fixtures/scripts/script_missing_internal.html ADDED Viewed

@@ -0,0 +1,9 @@
+<html>
+<body>
+  <script src="doesnotexist.js"></script>
+</body>
+</html>

data/spec/html/proofer/fixtures/scripts/script_valid_internal.html ADDED Viewed

@@ -0,0 +1,9 @@
+<html>
+<body>
+  <script src="script.js"></script>
+</body>
+</html>

data/spec/html/proofer/images_spec.rb CHANGED Viewed

@@ -1,56 +1,56 @@
 require "spec_helper"
-describe "Image tests" do
+describe "Images test" do
   it "passes for existing external images" do
-    externalImageFilepath = "#{FIXTURES_DIR}/existingImageExternal.html"
+    externalImageFilepath = "#{FIXTURES_DIR}/images/existingImageExternal.html"
     output = capture_stderr { HTML::Proofer.new(externalImageFilepath).run }
     output.should == ""
   end
   it "fails for image without alt attribute" do
-    missingAltFilepath = "#{FIXTURES_DIR}/missingImageAlt.html"
+    missingAltFilepath = "#{FIXTURES_DIR}/images/missingImageAlt.html"
     output = capture_stderr { HTML::Proofer.new(missingAltFilepath).run }
     output.should match /gpl.png does not have an alt attribute/
   end
   it "fails for image with an empty alt attribute" do
-    missingAltFilepath = "#{FIXTURES_DIR}/missingImageAltText.html"
+    missingAltFilepath = "#{FIXTURES_DIR}/images/missingImageAltText.html"
     output = capture_stderr { HTML::Proofer.new(missingAltFilepath).run }
     output.should match /gpl.png does not have an alt attribute/
   end
   it "fails for missing external images" do
-    externalImageFilepath = "#{FIXTURES_DIR}/missingImageExternal.html"
+    externalImageFilepath = "#{FIXTURES_DIR}/images/missingImageExternal.html"
     output = capture_stderr { HTML::Proofer.new(externalImageFilepath).run }
     output.should match /External link http:\/\/www.whatthehell\/? failed: 0 Couldn't resolve host/
   end
   it "fails for missing internal images" do
-    internalImageFilepath = "#{FIXTURES_DIR}/missingImageInternal.html"
+    internalImageFilepath = "#{FIXTURES_DIR}/images/missingImageInternal.html"
     output = capture_stderr { HTML::Proofer.new(internalImageFilepath).run }
     output.should match /doesnotexist.png does not exist/
   end
   it "fails for image with no src" do
-    imageSrcFilepath = "#{FIXTURES_DIR}/missingImageSrc.html"
+    imageSrcFilepath = "#{FIXTURES_DIR}/images/missingImageSrc.html"
     output = capture_stderr { HTML::Proofer.new(imageSrcFilepath).run }
     output.should match /image has no src attribute/
   end
   it "fails for image with default mac filename" do
-    terribleImageName = "#{FIXTURES_DIR}/terribleImageName.html"
+    terribleImageName = "#{FIXTURES_DIR}/images/terribleImageName.html"
     output = capture_stderr { HTML::Proofer.new(terribleImageName).run }
     output.should match /image has a terrible filename/
   end
   it 'ignores images marked as ignore data-proofer-ignore' do
-    ignorableImages = "#{FIXTURES_DIR}/ignorableImages.html"
+    ignorableImages = "#{FIXTURES_DIR}/images/ignorableImages.html"
     output = capture_stderr { HTML::Proofer.new(ignorableImages).run }
     output.should == ""
   end
   it 'properly checks relative images' do
-    relativeImages = "#{FIXTURES_DIR}/rootRelativeImages.html"
+    relativeImages = "#{FIXTURES_DIR}/images/rootRelativeImages.html"
     output = capture_stderr { HTML::Proofer.new(relativeImages).run }
     output.should == ""
@@ -59,21 +59,27 @@ describe "Image tests" do
     output.should == ""
   end
-  it 'properly checks data URI images' do
-    dataURIImage = "#{FIXTURES_DIR}/workingDataURIImage.html"
+  it 'properly ignores data URI images' do
+    dataURIImage = "#{FIXTURES_DIR}/images/workingDataURIImage.html"
     output = capture_stderr { HTML::Proofer.new(dataURIImage).run }
     output.should == ""
   end
   it "works for valid images missing the protocol" do
-    missingProtocolLink = "#{FIXTURES_DIR}/image_missing_protocol_valid.html"
+    missingProtocolLink = "#{FIXTURES_DIR}/images/image_missing_protocol_valid.html"
     output = capture_stderr { HTML::Proofer.new(missingProtocolLink).run }
     output.should == ""
   end
   it "fails for invalid images missing the protocol" do
-    missingProtocolLink = "#{FIXTURES_DIR}/image_missing_protocol_invalid.html"
+    missingProtocolLink = "#{FIXTURES_DIR}/images/image_missing_protocol_invalid.html"
     output = capture_stderr { HTML::Proofer.new(missingProtocolLink).run }
     output.should match /404 No error/
   end
+  it 'properly checks relative links' do
+    relativeLinks = "#{FIXTURES_DIR}/images/relativeToSelf.html"
+    output = capture_stderr { HTML::Proofer.new(relativeLinks).run }
+    output.should == ""
+  end
 end

data/spec/html/proofer/links_spec.rb CHANGED Viewed

@@ -1,154 +1,168 @@
 require "spec_helper"
-describe "Links tests" do
+describe "Links test" do
   it "fails for broken external hash (even if the file exists)" do
-    brokenHashExternalFilepath = "#{FIXTURES_DIR}/brokenHashExternal.html"
+    brokenHashExternalFilepath = "#{FIXTURES_DIR}/links/brokenHashExternal.html"
     output = capture_stderr { HTML::Proofer.new(brokenHashExternalFilepath).run }
-    output.should match /linking to .\/missingImageAlt.html#asdfasfdkafl, but asdfasfdkafl does not exist/
+    output.should match /linking to ..\/images\/missingImageAlt.html#asdfasfdkafl, but asdfasfdkafl does not exist/
   end
   it "fails for broken internal hash" do
-    brokenHashInternalFilepath = "#{FIXTURES_DIR}/brokenHashInternal.html"
+    brokenHashInternalFilepath = "#{FIXTURES_DIR}/links/brokenHashInternal.html"
     output = capture_stderr { HTML::Proofer.new(brokenHashInternalFilepath).run }
     output.should match /linking to internal hash #noHash that does not exist/
   end
   it "fails for broken external links" do
-    brokenLinkExternalFilepath = "#{FIXTURES_DIR}/brokenLinkExternal.html"
+    brokenLinkExternalFilepath = "#{FIXTURES_DIR}/links/brokenLinkExternal.html"
     output = capture_stderr { HTML::Proofer.new(brokenLinkExternalFilepath).run }
     output.should match /External link http:\/\/www.asdo3IRJ395295jsingrkrg4.com\/? failed: 0 Couldn't resolve host name/
   end
   it "fails for broken internal links" do
-    brokenLinkInternalFilepath = "#{FIXTURES_DIR}/brokenLinkInternal.html"
+    brokenLinkInternalFilepath = "#{FIXTURES_DIR}/links/brokenLinkInternal.html"
     output = capture_stderr { HTML::Proofer.new(brokenLinkInternalFilepath).run }
     output.should match /internally linking to .\/notreal.html, which does not exist/
   end
   it "fails for link with no href" do
-    missingLinkHrefFilepath = "#{FIXTURES_DIR}/missingLinkHref.html"
+    missingLinkHrefFilepath = "#{FIXTURES_DIR}/links/missingLinkHref.html"
     output = capture_stderr { HTML::Proofer.new(missingLinkHrefFilepath).run }
     output.should match /link has no href attribute/
   end
   it "should follow redirects" do
-    linkWithRedirectFilepath = "#{FIXTURES_DIR}/linkWithRedirect.html"
+    linkWithRedirectFilepath = "#{FIXTURES_DIR}/links/linkWithRedirect.html"
     output = capture_stderr { HTML::Proofer.new(linkWithRedirectFilepath).run }
     output.should == ""
   end
+  it "fails on redirects if not following" do
+    options = { :followlocation => false }
+    linkWithRedirectFilepath = "#{FIXTURES_DIR}/links/linkWithRedirect.html"
+    output = capture_stderr { HTML::Proofer.new(linkWithRedirectFilepath, options).run }
+    output.should match /External link https:\/\/help.github.com\/changing-author-info\/ failed: 301 No error/
+  end
   it "should understand https" do
-    linkWithHttpsFilepath = "#{FIXTURES_DIR}/linkWithHttps.html"
+    linkWithHttpsFilepath = "#{FIXTURES_DIR}/links/linkWithHttps.html"
     output = capture_stderr { HTML::Proofer.new(linkWithHttpsFilepath).run }
     output.should == ""
   end
   it "fails for broken hash links with status code numbers" do
-    brokenLinkWithNumberFilepath = "#{FIXTURES_DIR}/brokenLinkWithNumber.html"
+    brokenLinkWithNumberFilepath = "#{FIXTURES_DIR}/links/brokenLinkWithNumber.html"
     output = capture_stderr { HTML::Proofer.new(brokenLinkWithNumberFilepath).run }
     output.should match /linking to internal hash #25-method-not-allowed that does not exist/
   end
   it 'properly resolves implicit /index.html in link paths' do
-    linkToFolder = "#{FIXTURES_DIR}/linkToFolder.html"
+    linkToFolder = "#{FIXTURES_DIR}/links/linkToFolder.html"
     output = capture_stderr { HTML::Proofer.new(linkToFolder).run }
     output.should == ""
   end
   it 'properly checks links to root' do
-    rootLink = "#{FIXTURES_DIR}/rootLink.html"
+    rootLink = "#{FIXTURES_DIR}/links/rootLink.html"
     output = capture_stderr { HTML::Proofer.new(rootLink).run }
     output.should == ""
   end
   it 'properly checks relative links' do
-    relativeLinks = "#{FIXTURES_DIR}/relativeLinks.html"
+    relativeLinks = "#{FIXTURES_DIR}/links/relativeLinks.html"
     output = capture_stderr { HTML::Proofer.new(relativeLinks).run }
     output.should == ""
   end
   it 'properly checks ssl links' do
-    checkSSLLinks = "#{FIXTURES_DIR}/checkSSLLinks.html"
+    checkSSLLinks = "#{FIXTURES_DIR}/links/checkSSLLinks.html"
     output = capture_stderr { HTML::Proofer.new(checkSSLLinks).run }
     output.should == ""
   end
   it 'ignores links marked as ignore data-proofer-ignore' do
-    ignorableLinks = "#{FIXTURES_DIR}/ignorableLinks.html"
+    ignorableLinks = "#{FIXTURES_DIR}/links/ignorableLinks.html"
     output = capture_stderr { HTML::Proofer.new(ignorableLinks).run }
     output.should == ""
   end
   it 'ignores links via href_ignore' do
-    ignorableLinks = "#{FIXTURES_DIR}/ignorableLinksViaOptions.html"
+    ignorableLinks = "#{FIXTURES_DIR}/links/ignorableLinksViaOptions.html"
     output = capture_stderr { HTML::Proofer.new(ignorableLinks, {:href_ignore => [/^http:\/\//, /sdadsad/, "../whaadadt.html"]}).run }
     output.should == ""
   end
   it 'translates links via href_swap' do
-    translatedLink = "#{FIXTURES_DIR}/linkTranslatedViaHrefSwap.html"
+    translatedLink = "#{FIXTURES_DIR}/links/linkTranslatedViaHrefSwap.html"
     output = capture_stderr { HTML::Proofer.new(translatedLink, {:href_swap => { /\A\/articles\/([\w-]+)/ => "\\1.html" }}).run }
     output.should == ""
   end
   it 'finds a mix of broken and unbroken links' do
-    multipleProblems = "#{FIXTURES_DIR}/multipleProblems.html"
+    multipleProblems = "#{FIXTURES_DIR}/links/multipleProblems.html"
     output = capture_stderr { HTML::Proofer.new(multipleProblems).run }
     output.should match /linking to internal hash #anadaasdadsadschor that does not exist/
   end
   it 'ignores valid mailto links' do
-    ignorableLinks = "#{FIXTURES_DIR}/mailto_link.html"
+    ignorableLinks = "#{FIXTURES_DIR}/links/mailto_link.html"
     output = capture_stderr { HTML::Proofer.new(ignorableLinks).run }
     output.should == ""
   end
   it "fails for blank mailto links" do
-    blankMailToLink = "#{FIXTURES_DIR}/blank_mailto_link.html"
+    blankMailToLink = "#{FIXTURES_DIR}/links/blank_mailto_link.html"
     output = capture_stderr { HTML::Proofer.new(blankMailToLink).run }
     output.should match /mailto: is an invalid URL/
   end
   it 'ignores valid tel links' do
-    ignorableLinks = "#{FIXTURES_DIR}/tel_link.html"
+    ignorableLinks = "#{FIXTURES_DIR}/links/tel_link.html"
     output = capture_stderr { HTML::Proofer.new(ignorableLinks).run }
     output.should == ""
   end
   it "fails for blank tel links" do
-    blankTelLink = "#{FIXTURES_DIR}/blank_tel_link.html"
+    blankTelLink = "#{FIXTURES_DIR}/links/blank_tel_link.html"
     output = capture_stderr { HTML::Proofer.new(blankTelLink).run }
     output.should match /tel: is an invalid URL/
   end
   it "works for valid links missing the protocol" do
-    missingProtocolLink = "#{FIXTURES_DIR}/link_missing_protocol_valid.html"
+    missingProtocolLink = "#{FIXTURES_DIR}/links/link_missing_protocol_valid.html"
     output = capture_stderr { HTML::Proofer.new(missingProtocolLink).run }
     output.should == ""
   end
   it "fails for invalid links missing the protocol" do
-    missingProtocolLink = "#{FIXTURES_DIR}/link_missing_protocol_invalid.html"
+    missingProtocolLink = "#{FIXTURES_DIR}/links/link_missing_protocol_invalid.html"
     output = capture_stderr { HTML::Proofer.new(missingProtocolLink).run }
     output.should match /Couldn't resolve host name/
   end
   it "works for valid href within link elements" do
-    head_link = "#{FIXTURES_DIR}/head_link_href.html"
+    head_link = "#{FIXTURES_DIR}/links/head_link_href.html"
     output = capture_stderr { HTML::Proofer.new(head_link).run }
     output.should == ""
   end
   it "fails for empty href within link elements" do
-    head_link = "#{FIXTURES_DIR}/head_link_href_empty.html"
+    head_link = "#{FIXTURES_DIR}/links/head_link_href_empty.html"
     output = capture_stderr { HTML::Proofer.new(head_link).run }
     output.should match /link has no href attribute/
   end
   it "fails for absent href within link elements" do
-    head_link = "#{FIXTURES_DIR}/head_link_href_absent.html"
+    head_link = "#{FIXTURES_DIR}/links/head_link_href_absent.html"
     output = capture_stderr { HTML::Proofer.new(head_link).run }
     output.should match /link has no href attribute/
   end
+  it "fails for internal linking to a directory without trailing slash" do
+    options = { :followlocation => false }
+    internal = "#{FIXTURES_DIR}/links/link_directory_without_slash.html"
+    output = capture_stderr { HTML::Proofer.new(internal, options).run }
+    output.should match /without trailing slash/
+  end
 end

data/spec/html/proofer/scripts_spec.rb ADDED Viewed

@@ -0,0 +1,35 @@
+require "spec_helper"
+describe "Scripts test" do
+  it "fails for broken external src" do
+    file = "#{FIXTURES_DIR}/scripts/script_broken_external.html"
+    output = capture_stderr { HTML::Proofer.new(file).run }
+    output.should match /External link http:\/\/www.asdo3IRJ395295jsingrkrg4.com\/asdo3IRJ.js? failed: 0 Couldn't resolve host name/
+  end
+  it "works for valid internal src" do
+    file = "#{FIXTURES_DIR}/scripts/script_valid_internal.html"
+    output = capture_stderr { HTML::Proofer.new(file).run }
+    output.should == ""
+  end
+  it "fails for missing internal src" do
+    file = "#{FIXTURES_DIR}/scripts/script_missing_internal.html"
+    output = capture_stderr { HTML::Proofer.new(file).run }
+    output.should match /doesnotexist.js does not exist/
+  end
+  it "works for present content" do
+    file = "#{FIXTURES_DIR}/scripts/script_content.html"
+    output = capture_stderr { HTML::Proofer.new(file).run }
+    output.should == ""
+  end
+  it "fails for absent content" do
+    file = "#{FIXTURES_DIR}/scripts/script_content_absent.html"
+    output = capture_stderr { HTML::Proofer.new(file).run }
+    output.should match /script is empty and has no src attribute/
+  end
+end