html-pipeline 3.2.1 → 3.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7d505d0765630595363061d97d8f189a2712fc56b89371542a225d35421af386
-  data.tar.gz: 9d10f5ad3c9d39fe65d6e3b22cd59070997e5774353806affde0a957a52f5812
+  metadata.gz: 4ee767ba855fbce40027a79f0a7847c5455354efe01293d07dd5dfc4cf0ee915
+  data.tar.gz: 0210caf87e60730954c56005ef6cf372a1aad46b72f14554790799e9a3741ba3
 SHA512:
-  metadata.gz: 63b53387dfbb3bc7a9be29f0e6de9930daa773254dc885d0561b59a8d8ff50317ddabe62c364253b6da7142b3c4d169f72ce43f217ec50d18aee450513e88f13
-  data.tar.gz: 948027919009faea3009e0e222491aeae865db4875602a40bbf5a458f8b712f633b6e66d386e95acadbb129bcba33f63afdddbc89b73758cc1b544855eb5b227
+  metadata.gz: bcf817cc462caf0f082aac827c3959dba7aab1b988d072304c450415fdf763ee32d8e6974d95f856fa98bf1b2505115e9e75ee09b242fecb49db0d75dd7056a8
+  data.tar.gz: f4ba81e5b1acba6a6e22b799a2ac802a0ae67822371b9d351ae2d3e033f7495e93e1f64495a280104768453b5c9ed26be5bd7007a2bb95fe077274ce8b2fa524

data/.gitignore

@@ -17,4 +17,4 @@ test/tmp
 test/version_tmp
 tmp
 exec/*
-vendor/gems
+vendor/cache/

data/.rubocop.yml

@@ -15,3 +15,6 @@ AllCops:
     - "vendor/**/*"
     - "tmp/**/*"
     - "test/progit/**/*"
+
+ThreadSafety/ClassAndModuleAttributes:
+  Enabled: false

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# [v3.2.2] - 09-08-2024
+## What's Changed
+* Add support for @ prefix on MentionFilter base_url by @jeremysmithco in https://github.com/gjtorikian/html-pipeline/pull/411
+* Bugfix: sanitization-only filters should still work by @gjtorikian in https://github.com/gjtorikian/html-pipeline/pull/414
+
+## New Contributors
+* @jeremysmithco made their first contribution in https://github.com/gjtorikian/html-pipeline/pull/411
+
+**Full Changelog**: https://github.com/gjtorikian/html-pipeline/compare/v3.2.1...v3.2.2
 # [v3.2.1] - 16-07-2024
 ## What's Changed
 * Update commonmarker requirement from ~> 1.0.0.pre7 to ~> 1.1.2 in the bundler-dependencies group by @dependabot in https://github.com/gjtorikian/html-pipeline/pull/404

data/Gemfile

@@ -25,7 +25,7 @@ group :development do
 end
 
 group :test do
-  gem "commonmarker", "~> 1.1.2", require: false
+  gem "commonmarker", "~> 2.0.1", require: false
   gem "gemoji", "~> 4.1", require: false
   gem "gemojione", "~> 4.3", require: false
 

data/README.md

@@ -343,34 +343,6 @@ service.subscribe "call_text_filters.html_pipeline" do |event, start, ending, tr
 end
 ```
 
-## Third Party Extensions
-
-If you have an idea for a filter, propose it as
-[an issue](https://github.com/gjtorikian/html-pipeline/issues) first. This allows us to discuss
-whether the filter is a common enough use case to belong in this gem, or should be
-built as an external gem.
-
-Here are some extensions people have built:
-
-- [html-pipeline-asciidoc_filter](https://github.com/asciidoctor/html-pipeline-asciidoc_filter)
-- [jekyll-html-pipeline](https://github.com/gjtorikian/jekyll-html-pipeline)
-- [nanoc-html-pipeline](https://github.com/burnto/nanoc-html-pipeline)
-- [html-pipeline-bitly](https://github.com/dewski/html-pipeline-bitly)
-- [html-pipeline-cite](https://github.com/lifted-studios/html-pipeline-cite)
-- [tilt-html-pipeline](https://github.com/bradgessler/tilt-html-pipeline)
-- [html-pipeline-wiki-link'](https://github.com/lifted-studios/html-pipeline-wiki-link) - WikiMedia-style wiki links
-- [task_list](https://github.com/github/task_list) - GitHub flavor Markdown Task List
-- [html-pipeline-nico_link](https://github.com/rutan/html-pipeline-nico_link) - An HTMLPipeline filter for [niconico](http://www.nicovideo.jp) description links
-- [html-pipeline-gitlab](https://gitlab.com/gitlab-org/html-pipeline-gitlab) - This gem implements various filters for html-pipeline used by GitLab
-- [html-pipeline-youtube](https://github.com/st0012/html-pipeline-youtube) - An HTMLPipeline filter for YouTube links
-- [html-pipeline-flickr](https://github.com/st0012/html-pipeline-flickr) - An HTMLPipeline filter for Flickr links
-- [html-pipeline-vimeo](https://github.com/dlackty/html-pipeline-vimeo) - An HTMLPipeline filter for Vimeo links
-- [html-pipeline-hashtag](https://github.com/mr-dxdy/html-pipeline-hashtag) - An HTMLPipeline filter for hashtags
-- [html-pipeline-linkify_github](https://github.com/jollygoodcode/html-pipeline-linkify_github) - An HTMLPipeline filter to autolink GitHub urls
-- [html-pipeline-redcarpet_filter](https://github.com/bmikol/html-pipeline-redcarpet_filter) - Render Markdown source text into Markdown HTML using Redcarpet
-- [html-pipeline-typogruby_filter](https://github.com/bmikol/html-pipeline-typogruby_filter) - Add Typogruby text filters to your HTMLPipeline
-- [korgi](https://github.com/jodeci/korgi) - HTMLPipeline filters for links to Rails resources
-
 ## FAQ
 
 ### 1. Why doesn't my pipeline work when there's no root element in the document?

data/lib/html_pipeline/node_filter/mention_filter.rb

@@ -115,7 +115,8 @@ class HTMLPipeline
         result[:mentioned_usernames] |= [login]
 
         url = base_url.dup
-        url << "/" unless %r{[/~]\z}.match?(url)
+        excluded_prefixes = %r{[/(?:~|@]\z}
+        url << "/" unless excluded_prefixes.match?(url)
 
         "<a href=\"#{url << login}\" class=\"user-mention\">" \
           "@#{login}" \

data/lib/html_pipeline/node_filter/team_mention_filter.rb

@@ -94,7 +94,8 @@ class HTMLPipeline
         result[:mentioned_teams] |= [team]
 
         url = base_url.dup
-        url << "/" unless %r{[/~]\z}.match?(url)
+        excluded_prefixes = %r{[/(?:~|@]\z}
+        url << "/" unless excluded_prefixes.match?(url)
 
         "<a href=\"#{url << org}/#{team}\" class=\"team-mention\">" \
           "@#{org}/#{team}" \

data/lib/html_pipeline/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class HTMLPipeline
-  VERSION = "3.2.1"
+  VERSION = "3.2.3"
 end

data/lib/html_pipeline.rb

@@ -122,7 +122,7 @@ class HTMLPipeline
 
     @convert_filter = convert_filter
 
-    if @convert_filter.nil? && (!@text_filters.empty? && !@node_filters.empty?)
+    if @convert_filter.nil? && !@text_filters.empty? && !@node_filters.empty?
       raise InvalidFilterError, "Must provide `convert_filter` if `text_filters` and `node_filters` are also provided"
     elsif !@convert_filter.nil?
       validate_filter(@convert_filter, HTMLPipeline::ConvertFilter)
@@ -154,13 +154,13 @@ class HTMLPipeline
     if @text_filters.any?
       payload = default_payload({
         text_filters: @text_filters.map { |f| f.class.name },
-        context: context,
-        result: result,
+        context:,
+        result:,
       })
       instrument("call_text_filters.html_pipeline", payload) do
         result[:output] =
           @text_filters.inject(text) do |doc, filter|
-            perform_filter(filter, doc, context: (filter.context || {}).merge(context), result: result)
+            perform_filter(filter, doc, context: (filter.context || {}).merge(context), result:)
           end
       end
     end
@@ -181,18 +181,18 @@ class HTMLPipeline
       },
     }
 
-    if @node_filters.empty?
+    if @node_filters.empty? && !@sanitization_config.nil?
       instrument("sanitization.html_pipeline", payload) do
-        result[:output] = Selma::Rewriter.new(sanitizer: @sanitization_config, handlers: @node_filters, options: rewriter_options).rewrite(html)
-      end unless @convert_filter.nil? # no html, so no sanitization
-    else
+        result[:output] = Selma::Rewriter.new(sanitizer: @sanitization_config, options: rewriter_options).rewrite(html)
+      end
+    elsif @node_filters.any?
       instrument("call_node_filters.html_pipeline", payload) do
         @node_filters.each { |filter| filter.context = (filter.context || {}).merge(context) }
         result[:output] = Selma::Rewriter.new(sanitizer: @sanitization_config, handlers: @node_filters, options: rewriter_options).rewrite(html)
         payload = default_payload({
           node_filters: @node_filters.map { |f| f.class.name },
-          context: context,
-          result: result,
+          context:,
+          result:,
         })
       end
     end
@@ -211,18 +211,18 @@ class HTMLPipeline
   def perform_filter(filter, doc, context: {}, result: {})
     payload = default_payload({
       filter: filter.class.name,
-      context: context,
-      result: result,
+      context:,
+      result:,
     })
 
     instrument("call_filter.html_pipeline", payload) do
-      filter.call(doc, context: context, result: result)
+      filter.call(doc, context:, result:)
     end
   end
 
   # Like call but guarantee the value returned is a string of HTML markup.
   def to_html(input, context: {}, result: {})
-    result = call(input, context: context, result: result)
+    result = call(input, context:, result:)
     output = result[:output]
     if output.respond_to?(:to_html)
       output.to_html

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-pipeline
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 3.2.3
 platform: ruby
 authors:
 - Garen J. Torikian
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-31 00:00:00.000000000 Z
+date: 2025-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selma
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 3.3.22
 requirements: []
 rubygems_version: 3.4.6
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Helpers for processing content through a chain of filters
 test_files: []