html-pipeline 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 398dde5c696c319791f1591c1df00abde348028b
-  data.tar.gz: 55dc9f47d97a18ab166a5fb6016fb4de28611c13
+  metadata.gz: 255c35bcd09c89964eafb3a2f6a6593acc003a9b
+  data.tar.gz: b18754600751cf85ed04a96e44fa16a60070604e
 SHA512:
-  metadata.gz: c3f317bb8ca4615276a9ea0caf6f5d48e5bb9fd4d92b1dc5073cf65d7601e155d3e8bc55b12339dc4eb30eb8d82defb1fbc6219408987bf2e7ecb2bf55a2e057
-  data.tar.gz: 8b40cc7d0b8d3bae252d565e7ac929b4b194659ad2d284657db7ee09a98bda81c14b300484f81a65395dca1847ebc7c138e9fc2a9d67dbab81350c7badfc3f6f
+  metadata.gz: 00048b649ab9e2514e26215265e9b137d2654096fa68c8a183623cb1270a26288c0d65377a432c9893528d7ff367e35dc2feaeed987bb0c562c28d7d7a8257b2
+  data.tar.gz: a8275a10d2ef7dc1dccbcfa454840914519a7e08baef0739de29bd3b9de1e717798dc22330e02cde9b8c46a3d27341d54447e1b4b556c73e3b7b2f906315cbed

data/CHANGELOG.md

@@ -1,14 +1,18 @@
 # CHANGELOG
 
+## 1.1.0
+
+  * escape emoji filenames in urls #92 jayroh
+
 ## 1.0.0
 
 To upgrade to this release, you will need to include separate gems for each of
 the filters. See [this section of the README](/README.md#dependencies) for
 details.
 
-* filter dependencies are no longer included #80 from simeonwillbanks/simple-dependency-management
-* Add link_attr option to Autolink filter #89 from excid3/master
-* Add ActiveSupport back in as dependency for xml-mini #85 from mojavelinux/xml-mini
+  * filter dependencies are no longer included #80 from simeonwillbanks/simple-dependency-management
+  * Add link_attr option to Autolink filter #89 from excid3/master
+  * Add ActiveSupport back in as dependency for xml-mini #85 from mojavelinux/xml-mini
 
 ## 0.3.1
 

data/lib/html/pipeline/emoji_filter.rb

@@ -1,3 +1,5 @@
+require "cgi"
+
 begin
   require "gemoji"
 rescue LoadError => _
@@ -42,7 +44,7 @@ module HTML
 
         text.gsub EmojiPattern do |match|
           name = $1
-          "<img class='emoji' title=':#{name}:' alt=':#{name}:' src='#{File.join(asset_root, "emoji", "#{name}.png")}' height='20' width='20' align='absmiddle' />"
+          "<img class='emoji' title=':#{name}:' alt=':#{name}:' src='#{emoji_url(name)}' height='20' width='20' align='absmiddle' />"
         end
       end
 
@@ -53,6 +55,12 @@ module HTML
       def asset_root
         context[:asset_root]
       end
+
+      private
+
+      def emoji_url(name)
+        File.join(asset_root, "emoji", "#{::CGI.escape(name)}.png")
+      end
     end
   end
 end

data/lib/html/pipeline/version.rb

@@ -1,5 +1,5 @@
 module HTML
   class Pipeline
-    VERSION = "1.0.0"
+    VERSION = "1.1.0"
   end
 end

data/test/html/pipeline/emoji_filter_test.rb

@@ -9,10 +9,16 @@ class HTML::Pipeline::EmojiFilterTest < Test::Unit::TestCase
     assert_match "https://foo.com/emoji/shipit.png", doc.search('img').attr('src').value
   end
   
+  def test_uri_encoding
+    filter = EmojiFilter.new("<p>:+1:</p>", {:asset_root => 'https://foo.com'})
+    doc = filter.call
+    assert_match "https://foo.com/emoji/%2B1.png", doc.search('img').attr('src').value
+  end
+  
   def test_required_context_validation
     exception = assert_raise(ArgumentError) { 
       EmojiFilter.call("", {}) 
     }
     assert_match /:asset_root/, exception.message
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: html-pipeline
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Ryan Tomayko
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-29 00:00:00.000000000 Z
+date: 2013-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri