hstore_attributes 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 396066b7fdc41c0c1039d85ebad2b42e5d04355b
-  data.tar.gz: eb91ce7217c92ef41ff6f953304da15d9143d31e
+  metadata.gz: 9cde79926055a503605a9ad31cbad8853ec47766
+  data.tar.gz: 3cecb728f3de2f143665d98b37b4b391f1f35bbb
 SHA512:
-  metadata.gz: 159f4b7ce845ba685475e02bf293422bc985cbcfc8a9da3655f6a5c74180d64114879cebaedb82c1381d0b92d0190feb3aaa2709623a141411de7df05dcae4df
-  data.tar.gz: b2bea8c6b9b38134e8d416ec5e1ce096738ee19989fe30aeb9385c170657951cc2fd24019c53893e793870dba450db9ff6f35dffd8934c233d845202ac5af862
+  metadata.gz: eb3396da7e19369d6ee3e17ffb8df48b068fb02f975f84c03f49bb5b561bef6747ead9645d0171a26f6fee4e2da053b507dbf10fc576b59f2261c052873a246a
+  data.tar.gz: 022ef8515b44f9eb34e4f68bfe745c61d9e371f91a4fa4e05a78340379086dca0051c0030a6b3ea5b05b716dbcb5969d1d1cfa880010f57a34f59d0c7295b1e3

data/lib/hstore_attributes.rb

@@ -1,29 +1,29 @@
 require "hstore_attributes/version"
 
 module HstoreAttributes
-  def hstore_reader(hstore, *symbols)
-    options = symbols.extract_options!
-    symbols.each do |symbol|
-      define_method(symbol) do
-        value = (send(hstore) || {})[symbol.to_s]
+  def hstore_reader(hstore, *attributes)
+    options = attributes.extract_options!
+    attributes.map(&:to_s).each do |attribute|
+      define_method(attribute) do
+        value = (send(hstore) || {})[attribute]
         value = options[:type_cast].to_proc.call(value) if options[:type_cast]
         value
       end
     end
   end
 
-  def hstore_writer(hstore, *symbols)
-    options = symbols.extract_options!
-    symbols.each do |symbol|
-      define_method("#{symbol}=") do |value|
+  def hstore_writer(hstore, *attributes)
+    options = attributes.extract_options!
+    attributes.map(&:to_s).each do |attribute|
+      define_method("#{attribute}=") do |value|
         value = options[:type_cast].to_proc.call(value) if options[:type_cast]
-        send("#{hstore}=", (send(hstore) || {}).merge(symbol.to_s => value.to_s))
+        send("#{hstore}=", (send(hstore) || {}).merge(attribute => value))
       end
     end
   end
 
-  def hstore_accessor(hstore, *symbols)
-    hstore_reader(hstore, *symbols)
-    hstore_writer(hstore, *symbols)
+  def hstore_accessor(hstore, *attributes)
+    hstore_reader(hstore, *attributes)
+    hstore_writer(hstore, *attributes)
   end
 end

data/lib/hstore_attributes/version.rb

@@ -1,3 +1,3 @@
 module HstoreAttributes
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/hstore_accessor_test.rb

@@ -1,6 +1,7 @@
 require "test_helper"
 
-class Product < DummyModel
+class Product
+  attr_accessor :data
   extend HstoreAttributes
 
   hstore_accessor :data, :name, :description, type_cast: ->(value) { value.to_s.upcase }

data/test/hstore_reader_test.rb

@@ -1,6 +1,7 @@
 require "test_helper"
 
-class Product < DummyModel
+class Product
+  attr_accessor :data
   extend HstoreAttributes
 
   hstore_reader :data, :price, :price_2, type_cast: :to_i

data/test/hstore_writer_test.rb

@@ -1,6 +1,7 @@
 require "test_helper"
 
-class Product < DummyModel
+class Product
+  attr_accessor :data
   extend HstoreAttributes
 
   hstore_writer :data, :name, :name_2
@@ -18,6 +19,11 @@ describe "hstore_writer" do
     assert_equal({"name" => "zomg"}, @product.data)
   end
 
+  it "sets name to nil if no hstore" do
+    @product.name = nil
+    assert_equal({"name" => nil}, @product.data)
+  end
+
   it "sets name if empty hstore" do
     hstore = {}
     @product.data = hstore
@@ -26,6 +32,14 @@ describe "hstore_writer" do
     refute_same hstore, @product.data
   end
 
+  it "sets name to nil if empty hstore" do
+    hstore = {}
+    @product.data = hstore
+    @product.name = nil
+    assert_equal({"name" => nil}, @product.data)
+    refute_same hstore, @product.data
+  end
+
   it "sets name if already in hstore" do
     hstore = {"name" => "trolololo"}
     @product.data = hstore
@@ -34,6 +48,14 @@ describe "hstore_writer" do
     refute_same hstore, @product.data
   end
 
+  it "sets name to nil if already in hstore" do
+    hstore = {"name" => "trolololo"}
+    @product.data = hstore
+    @product.name = nil
+    assert_equal({"name" => nil}, @product.data)
+    refute_same hstore, @product.data
+  end
+
   it "sets name_2 if no hstore" do
     @product.name_2 = "lolo"
     assert_equal({"name_2" => "lolo"}, @product.data)
@@ -41,11 +63,11 @@ describe "hstore_writer" do
 
   it "sets price if no hstore" do
     @product.price = 0
-    assert_equal({"price" => "0"}, @product.data)
+    assert_equal({"price" => 0}, @product.data)
   end
 
   it "sets cents using type_cast function" do
     @product.cents = "1"
-    assert_equal({"cents" => "100"}, @product.data)
+    assert_equal({"cents" => 100}, @product.data)
   end
 end

data/test/test_helper.rb

@@ -1,15 +1,3 @@
 require "minitest/autorun"
 require "active_support"
 require "hstore_attributes"
-
-# DummyModel emulates an ActiveRecord model with hstore "data"
-
-class DummyModel
-  def data
-    @data
-  end
-
-  def data=(data)
-    @data = data
-  end
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hstore_attributes
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Kuba Kuźma
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-06 00:00:00.000000000 Z
+date: 2013-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport