hstore_accessor 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 762278330d698c66a6d2926e1595c539da4fbaf7
-  data.tar.gz: e4f38f9cb7e9b43384f2880a5b46860b63c3e0d9
+  metadata.gz: 460ba6cc8bae8307b3ddfdfd57af74ba02294934
+  data.tar.gz: cfd99b46a2ec13e2307c849720f5044315bf36f9
 SHA512:
-  metadata.gz: 29530074370a555d44d91a2b60a5b7621935f4f062585e9c329a6ba508e762564f7548d2d6220a247b5c83779a6684545cc39668b48a0d44d905c5575ccce786
-  data.tar.gz: 7c9227822c95e61b23b900aebd2f93f76ba3302e095e202fd0e50376a2f229278b9bc603d5b0136211a5058b0e9a9ea9a82ed09d6d4384b5bf45713ad04404d2
+  metadata.gz: 89245110259014870177d5b8c221d035909c1c8a635dd8a16a57384047ed00bfc80628aa265d2af317a58718d975e0134323e2208f08985c9af9b08b999e3635
+  data.tar.gz: a55c4ca8c1aea4ba9b85dae96f79fd1c7a2144e0737a645dac690597115ad2d124139d189cc63f78a18635c21a0903e5de5dde34eeda62af60e5747f6257bdf7

data/README.md

@@ -131,6 +131,13 @@ Product.is_popular    # => when populer is set to true
 Product.not_popular   # => when populer is set to false
 ```
 
+Predicate methods are also available on instances:
+
+```ruby
+product = Product.new(popular: true)
+product.popular?  #=> true
+```
+
 ### Single-table Inheritance
 
 One of the big issues with `ActiveRecord` single-table inheritance (STI)

data/hstore_accessor.gemspec

@@ -26,4 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "pry"
+  spec.add_development_dependency "database_cleaner"
 end

data/lib/hstore_accessor.rb

@@ -18,7 +18,7 @@ module HstoreAccessor
     :array    => -> value { (value && value.join(SEPARATOR)) || nil },
     :hash     => -> value { (value && value.to_json) || nil },
     :time     => -> value { value.to_i },
-    :boolean  => -> value { (value == true).to_s },
+    :boolean  => -> value { (value.to_s == "true").to_s },
     :date     => -> value { (value && value.to_s) || nil }
   }
 
@@ -57,6 +57,8 @@ module HstoreAccessor
           store_key = type[:store_key]
         end
 
+        data_type = data_type.to_sym
+
         raise InvalidDataTypeError unless VALID_TYPES.include?(data_type)
 
         define_method("#{key}=") do |value|
@@ -69,6 +71,12 @@ module HstoreAccessor
           deserialize(data_type, value)
         end
 
+        if type == :boolean
+          define_method("#{key}?") do
+            return send("#{key}")
+          end
+        end
+
         query_field = "#{hstore_attribute} -> '#{store_key}'"
 
         case data_type

data/lib/hstore_accessor/version.rb

@@ -1,3 +1,3 @@
 module HstoreAccessor
-  VERSION = "0.4.1"
+  VERSION = "0.5.0"
 end

data/spec/hstore_accessor_spec.rb

@@ -54,6 +54,7 @@ describe HstoreAccessor do
   end
 
   context "nil values" do
+
     let!(:timestamp) { Time.now }
     let!(:datestamp) { Date.today }
     let!(:product)   { Product.new }
@@ -73,6 +74,27 @@ describe HstoreAccessor do
     end
 
   end
+
+  describe "predicate methods" do
+
+    let!(:product) { Product.new }
+
+    it "return the state for true boolean fields" do
+      product.popular = true
+      product.save
+      product.reload
+      expect(product.popular?).to be_true
+    end
+
+    it "return the state for false boolean fields" do
+      product.popular = false
+      product.save
+      product.reload
+      expect(product.popular?).to be_false
+    end
+
+  end
+
   describe "scopes" do
 
     let!(:timestamp) { Time.now }
@@ -270,6 +292,24 @@ describe HstoreAccessor do
       expect(product.released_at).to eq datestamp
     end
 
+    context "correctly stores boolean values" do
+
+      it "when string 'true' is passed" do
+        product.popular = 'true'
+        product.save
+        product.reload
+        expect(product.popular).to be_true
+      end
+
+      it "when a real boolean is passed" do
+        product.popular = true
+        product.save
+        product.reload
+        expect(product.popular).to be_true
+      end
+
+    end
+
     it "setters call the _will_change! method of the store attribute" do
       product.should_receive(:options_will_change!)
       product.color = "green"

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require "hstore_accessor"
+require "database_cleaner"
 
 ActiveRecord::Base.establish_connection(
   adapter: "postgresql",
@@ -13,10 +14,12 @@ ActiveRecord::Base.connection.create_table(:products) do |t|
   t.hstore :options
 end
 
+DatabaseCleaner.strategy = :truncation
+
 RSpec.configure do |config|
   config.mock_with :rspec
 
-  config.after do
-    Product.delete_all
+  config.before do
+    DatabaseCleaner.clean
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hstore_accessor
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Joe Hirn
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-30 00:00:00.000000000 Z
+date: 2013-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
@@ -110,6 +110,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: database_cleaner
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Adds typed hstore backed fields to an ActiveRecord model.
 email:
 - joe@devmynd.com