hr_lite 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1716d66b8a6859e70f044dc0025b2052a8085ad83c82567540cbad04a216be9d
-  data.tar.gz: bc4d26d3c69be4f280e55820672892fac8ae6a93c190be3b6b4272adda7754b2
+  metadata.gz: 7ddcf4d252c3b0830d1b345dd44f63dc997cab9db77a408249cd8940ad2256c1
+  data.tar.gz: d525ae88d6a0b5c12ca68caff325bb655cd2ff7dfa0ac9afb7f178cbc8d362de
 SHA512:
-  metadata.gz: a0ce5511c8c763eac022ee7f900d3c92a0267057c0f6805e49d753076c9c07f6a842285c6d2f034cd3ee6fe40a2343865a4295fd696ef2f0ab4e2a44291c2ffe
-  data.tar.gz: bdfac21210c1a26383b2d9bed8782f093f651c479e5fe150fad94ad46a012a3612057098d4ea78a8f79f1a80652099c214e47954901cd546a8dd4b340e726b84
+  metadata.gz: 155c04f716bbf5907b17ce1dd86c06f44de4f3f8021afda1e2ed3570db8cf14aed2373db7791d4c65441e96b6d4e0318faeb8dc1116b35bea235ed4cb31775d8
+  data.tar.gz: be25c7f77087ae53dccb3e991167cc78282de562c5ef9f12739db9bc2bece99ad8b1e743577dc21d3aeb935cd1ca270ae64652bd036459c8c704b438db1ed8c0

data/CHANGELOG.md

@@ -7,6 +7,42 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.8.0] - 2026-08-18
+
+The deprecation 0.6.0 opened, closed. **Breaking** only for an install still
+setting `config.legacy_tier_checks`; no migration.
+
+### Removed
+
+- **`config.legacy_tier_checks` and the pre-0.6.0 tier lambdas no longer
+  decide access.** `HrLite.admin?`, `.leadership?` and `.superadmin?` read
+  roles, full stop. Two of those lambdas matched the user's `email` — mutable,
+  host-owned, unverified — and a host that kept the flag on kept that hole
+  open.
+- The flag is gone from the configuration object entirely, so an initializer
+  that still sets it now fails loudly at boot rather than silently doing
+  nothing. That is the intended way to find out.
+
+### Changed
+
+- `admin_check`, `leadership_emails` / `leadership_check` and
+  `superadmin_emails` / `superadmin_check` remain on the configuration, and
+  are now **migration input only**: the 0.6.0 upgrade migration reads them to
+  derive role assignments. An install jumping 0.5.x → 0.8.0 in one step still
+  needs them present for that migration to have something to read, which is
+  why they were not deleted outright. Setting them on a current install has no
+  effect on who can reach what.
+- `HrLite.leadership_users` and `.admin_users` are one query over the grant
+  tables. The legacy paths that instantiated every employee and ran a host
+  lambda per row are gone.
+
+### Upgrading
+
+If you set `legacy_tier_checks = true`, delete that line. Before you do, open
+the Roles screen and confirm the people who need access hold it — the 0.6.0
+migration will have assigned them already unless you had turned the flag on
+before it ran.
+
 ## [0.7.0] - 2026-08-18
 
 Statutory figures stop being code. **Adds one migration** (rate cards and
@@ -513,7 +549,8 @@ Initial release.
   bus with per-event channel matrix (bell, email, leadership email/bell),
   daily leadership digest and an append-only audit trail.
 
-[Unreleased]: https://github.com/kshtzkr/hr_lite/compare/v0.7.0...HEAD
+[Unreleased]: https://github.com/kshtzkr/hr_lite/compare/v0.8.0...HEAD
+[0.8.0]: https://github.com/kshtzkr/hr_lite/compare/v0.7.0...v0.8.0
 [0.7.0]: https://github.com/kshtzkr/hr_lite/compare/v0.6.0...v0.7.0
 [0.6.0]: https://github.com/kshtzkr/hr_lite/compare/v0.5.3...v0.6.0
 [0.5.3]: https://github.com/kshtzkr/hr_lite/compare/v0.5.2...v0.5.3

data/README.md

@@ -210,8 +210,9 @@ where they already were: `superadmin_emails` to Super Admin,
 It prints who it put where, and it leaves a host that has already assigned
 roles by hand alone.
 
-Set `config.legacy_tier_checks = true` to keep the old lambdas in charge while
-you migrate. It is honoured for one minor version and removed in 0.8.0.
+As of 0.8.0 those lambdas decide nothing. They are read only by that
+migration, so an install jumping several versions at once still has something
+for it to derive from; setting them on a current install has no effect.
 
 ## Features
 

data/lib/generators/hr_lite/install/templates/initializer.rb

@@ -15,11 +15,6 @@ HrLite.configure do |c|
   #   HrLite::RoleAssignment.create!(
   #     user_id: User.find_by!(email: "you@example.com").id,
   #     role: HrLite::Role.find_by!(name: HrLite::Role::SUPER_ADMIN))
-  #
-  # Upgrading from pre-0.6.0 and not ready to move? Uncomment this and keep
-  # your leadership_emails / superadmin_emails / admin_check as they were.
-  # It is honoured until 0.8.0.
-  # c.legacy_tier_checks = true
 
   # Where the portal is reachable (subdomain or path). Enables email link
   # buttons and HrLite.public_url / HrLite.public_url? for deep links.

data/lib/hr_lite/configuration.rb

@@ -7,11 +7,9 @@ module HrLite
                   :authenticate_method, :admin_check, :display_name_method,
                   :employees_scope, :mentionable_users, :notify, :render_pdf, :company,
                   :time_zone, :currency_symbol, :on_designation_change,
-                  :leadership_emails, :leadership_check, :extra_stylesheets,
-                  :superadmin_emails, :superadmin_check,
+                  :leadership_emails, :extra_stylesheets, :superadmin_emails,
                   :mailer_from, :public_url_base, :notification_matrix, :back_link,
-                  :onboard_user, :offboard_user, :invite_url_for,
-                  :legacy_tier_checks
+                  :onboard_user, :offboard_user, :invite_url_for
 
     attr_reader :leave_year_start_month
 
@@ -46,21 +44,20 @@ module HrLite
       @time_zone             = "Asia/Kolkata"
       @currency_symbol      = "₹"
       @on_designation_change = ->(user, designation) { }
-      # Access came from three lambdas before 0.6.0, two of which matched the
-      # user's EMAIL — a mutable, host-owned, unverified column that a host
-      # then had to remember never to let anyone edit. Roles replace them.
-      # This flag hands authority back to the old lambdas for a host that has
-      # not finished migrating; honoured for one more minor version, gone in 0.8.0.
-      @legacy_tier_checks    = false
+      # --- pre-0.6.0 access, now MIGRATION INPUT ONLY ------------------------
+      #
+      # These three governed access until 0.6.0, and two of them matched the
+      # user's EMAIL — a mutable, host-owned, unverified column that every
+      # host then had to remember never to let anybody edit. They decide
+      # nothing now: `HrLite.admin?` and friends read roles.
+      #
+      # They are still read in exactly one place — the 0.6.0 upgrade
+      # migration, which derives role assignments from whatever a 0.5.x host
+      # had configured. An install upgrading across several versions at once
+      # needs them present for that migration to have anything to read, which
+      # is why they were not deleted outright.
       @leadership_emails     = []
-      @leadership_check      = ->(user) { HrLite.email_listed?(user, HrLite.config.leadership_emails) }
-      # Money tier: salary structures, payroll, slips, appraisals. Empty
-      # list means "same as leadership" (pre-0.5.0 behaviour).
       @superadmin_emails     = []
-      @superadmin_check      = ->(user) do
-        list = HrLite.normalize_email_list(HrLite.config.superadmin_emails)
-        list.empty? ? HrLite.leadership?(user) : HrLite.email_listed?(user, list)
-      end
       @extra_stylesheets     = [] # host stylesheets linked AFTER hr_lite.css (CSS-var overrides)
       @mailer_from           = "hr@example.com"
       @public_url_base       = nil # e.g. "https://hr.example.com" — enables email links + HrLite.public_url

data/lib/hr_lite/version.rb

@@ -1,3 +1,3 @@
 module HrLite
-  VERSION = "0.7.0"
+  VERSION = "0.8.0"
 end

data/lib/hr_lite.rb

@@ -51,62 +51,43 @@ module HrLite
 
     def access_for(user) = Access.for(user)
 
-    # --- legacy tier predicates --------------------------------------------
+    # --- tier predicates ----------------------------------------------------
     #
-    # Kept because views, hosts and the notification fan-out all call them.
-    # They are now READ OFF ROLES rather than off a mutable email column; the
-    # configured lambdas survive only as an explicit opt-in for a host that
-    # has not migrated yet (see Configuration#legacy_tier_checks).
+    # Shorthands over the permissions, kept because views, hosts and the
+    # notification fan-out all read better asking "is this person leadership"
+    # than "do they hold profile.manage at all scope". They are ROLES all the
+    # way down; the pre-0.6.0 lambdas no longer decide anything.
 
     def admin?(user)
       return false if user.blank?
-      return !!config.admin_check.call(user) if config.legacy_tier_checks
 
       can?(user, "leave.approve", scope: :all) || can?(user, "attendance.manage", scope: :all)
     end
 
     def leadership?(user)
       return false if user.blank?
-      return !!config.leadership_check.call(user) if config.legacy_tier_checks
 
       can?(user, "profile.manage", scope: :all)
     end
 
     def superadmin?(user)
       return false if user.blank?
-      return !!config.superadmin_check.call(user) if config.legacy_tier_checks
 
       can?(user, "payroll.manage", scope: :all)
     end
 
-    # An access list, cleaned. "a@x.com,,b@x.com".split(",") — one stray
-    # comma in an ENV var — used to put "" in the list, and a user whose
-    # email was blank then MATCHED it and was handed the tier.
+    # An access list, cleaned — read now only by the 0.6.0 upgrade migration.
+    # One stray comma in an ENV var ("a@x.com,,b@x.com") used to put "" in the
+    # list, and a user whose email was blank then MATCHED it and was handed
+    # the tier. Kept honest here so the migration cannot repeat that.
     def normalize_email_list(emails)
       Array(emails).map { |e| e.to_s.downcase.strip }.reject(&:empty?)
     end
 
-    # Whether a user's own email is on a configured access list. A blank
-    # email is never on any list, however the list is spelled.
-    def email_listed?(user, emails)
-      address = user.respond_to?(:email) ? user.email.to_s.downcase.strip : ""
-      return false if address.empty?
-
-      normalize_email_list(emails).include?(address)
-    end
-
     # Leadership members resolvable to actual user records (for bell
-    # notifications). On a legacy host, emails configured but absent from the
-    # user table are still reachable by email — see Notifications.
+    # notifications).
     def leadership_users
-      unless config.legacy_tier_checks
-        return users_holding("profile.manage", scope: :all)
-      end
-
-      emails = normalize_email_list(config.leadership_emails)
-      return user_klass.none if emails.empty?
-
-      user_klass.where("LOWER(#{user_klass.table_name}.email) IN (?)", emails)
+      users_holding("profile.manage", scope: :all)
     end
 
     # Everyone whose roles grant `key` at `scope` or wider. One query over
@@ -121,13 +102,9 @@ module HrLite
       user_klass.where(id: ids)
     end
 
-    # Every domain event that bells the admins calls this. On roles it is one
-    # query over the grant tables; on a legacy host it still has to run the
-    # host's lambda per row, which is why it starts from employees_scope
-    # (narrowed to real staff) rather than every row that exists.
+    # Every domain event that bells the admins calls this. One query over the
+    # grant tables — it used to instantiate every employee and ask each one.
     def admin_users
-      return employees.select { |u| admin?(u) } if config.legacy_tier_checks
-
       users_holding("leave.approve", scope: :all).sort_by { |u| display_name(u).downcase }
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hr_lite
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - kshitiz sinha