hr_lite 0.64.0 → 0.65.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86b218a8a46bb4b5c3527df1fb637aee4b7617e8ef8abfd4e018274bc08e05af
-  data.tar.gz: 3e645c3511f89479289ac9169317183232d54c7443846208062d9b764bf692f0
+  metadata.gz: e8bac47ad9084b5f1b56da93a9a4658b0657ad90078ad5a51cda3de73d46e93a
+  data.tar.gz: e0a6f0dadbda02b024ece4ff00292586077c815022f71cea914a342ccc4a14df
 SHA512:
-  metadata.gz: 8ac6f7b8261f2dbaa74acb697effd3deb137d6f3d84647df9260c602ea457d7cb7067b631bdcbef4c09d56555f5688884bcac7607b48ae52002b0946291e4597
-  data.tar.gz: dfd0bb1099a90b72051f91569303e321d1d3a4cd216baf3cd9ba11f4dae720e5738be651fb584863b2fbe080702f0b8b517c70f49c9223f3ae6563cf72c0b6e6
+  metadata.gz: 36a34342b03fe802f84fe9cde43196dc22beeac2fffeb17572d79e8e5cf3b15a4efca9a59616c598f91e7d37efce0fffc8bb7830d35997015982f009477cbeb8
+  data.tar.gz: 45a7023d60f36f461dce9fb26482622fb69ef72464b5ff58043284dd785edf2d5ee714c40bec8ffd20f4f5ec07cd905b9f18553c5f1e54eee39bccd31885d385

data/CHANGELOG.md

@@ -7,6 +7,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.65.0] - 2026-10-28
+
+Expense claims have categories to pick from. No migrations.
+
+- **`hr_lite:seed` adds 15 travel-company expense categories** (local conveyance, flights and trains, hotel stay, meals, client meetings, site inspections, visa fees, fuel and tolls, airport transfers, phone, courier, printing, trade fairs, tips, Other) when the table is empty. The "What kind of expense" picker was blank on installs nobody had configured. Every category needs a receipt except tips; "Other" uses the required "What it was for" note. An install that already has categories is left alone.
+
+## [0.64.2] - 2026-10-24
+
+Leadership's leave-decision emails open the leave. No migrations.
+
+- **"Leave approved/rejected" emails to leadership linked to the employee's own page** (`/leave_requests/:id`), which 404s for anyone else. Leadership's copy now names the employee and links to `/admin/leave_requests/:id`. The employee's email is unchanged.
+
+## [0.64.1] - 2026-10-23
+
+Interview slots hand out 30-minute turns. No migrations.
+
+- **Up to 4 people per 2-hour slot, a 30-minute turn each.** Turns go in booking order: the 1st at the slot's start, the 2nd 30 minutes later, and so on. A full slot disappears from the form, and a day with no free slots says "Fully booked". A late fifth booking is refused with "Someone just booked that slot".
+- **Everyone sees the turn.** The candidate's thank-you page shows their interview time. HR's candidate page shows it, and "Schedule round N" is prefilled with that start time, so HR never retypes it. Turns are worked out from booking order and never stored.
+- **No email box on the reply page.** Each link already identifies its candidate, and the page still says "This form is for <name>".
+
 ## [0.64.0] - 2026-10-22
 
 Decision emails. One migration: `purpose` on hiring templates.

data/app/controllers/hr_lite/hiring_replies_controller.rb

@@ -19,7 +19,8 @@ module HrLite
     def show; end
 
     def create
-      @reply.submit!(email: params[:email], interested: params[:interested].to_s, date: params[:date], slot: params[:slot], joining: params[:joining],
+      date, slot = params[:pick].to_s.split("|", 2) # one radio per free day + slot
+      @reply.submit!(interested: params[:interested].to_s, date: date, slot: slot, joining: params[:joining],
                      yes_no: params.permit(*HiringReply::YES_NO.keys).to_h, alternate_phone: params[:alternate_phone].to_s.strip,
                      files: params.fetch(:documents, {}).permit(*HiringReply::DOCUMENTS.fetch(@reply.round, {}).keys).to_h,
                      kyc: params.permit(:aadhaar_number, :pan_number, :pan_pending, :no_salary_slips, :consent).to_h.symbolize_keys)

data/app/models/hr_lite/hiring_reply.rb

@@ -5,7 +5,8 @@ module HrLite
   class HiringReply < ApplicationRecord
     SLOTS = { "10-12" => "10 AM – 12 PM", "12-2" => "12 – 2 PM", "2-4" => "2 – 4 PM", "4-6" => "4 – 6 PM", "6-8" => "6 – 8 PM" }.freeze
     SLOT_START = { "10-12" => "10:00", "12-2" => "12:00", "2-4" => "14:00", "4-6" => "16:00", "6-8" => "18:00" }.freeze
-    SLOT_CAPACITY = 4 # candidates per slot per day; HR calls each to confirm
+    SLOT_CAPACITY = 4 # people per 2-hour slot per day, then it is gone from the form
+    TURN = 30.minutes # each booking gets its own turn, in the order they booked
     JOINING = { "immediately" => "Immediately", "two_weeks" => "Within 2 weeks", "one_month" => "Within a month" }.freeze
     YES_NO = { "stipend_ok" => "Fine with the stipend", "location_ok" => "Fine with the office location",
                "schedule_ok" => "Fine with the schedule", "programme_ok" => "Commits to the programme" }.freeze
@@ -36,6 +37,13 @@ module HrLite
 
     def self.slot_full?(date, slot) = responded.where(preferred_date: date, preferred_slot: slot).count >= SLOT_CAPACITY
 
+    # The slots still free on each offered day, for the reply form.
+    def self.open_slots(allow_sunday:)
+      days = dates(allow_sunday: allow_sunday)
+      booked = responded.where(preferred_date: days).group(:preferred_date, :preferred_slot).count
+      days.to_h { |day| [ day, SLOTS.keys.reject { |slot| booked[[ day, slot ]].to_i >= SLOT_CAPACITY } ] }
+    end
+
     # The next ten interview days. Sunday is off unless the campaign allows it.
     def self.dates(allow_sunday:, from: Date.current) = (1..20).map { |i| from + i }.reject { |d| d.sunday? && !allow_sunday }.first(10)
 
@@ -45,6 +53,18 @@ module HrLite
     end
 
     # What this round asks for; round 3 skips PAN and slips the candidate says they lack.
+    # Their 30-minute turn inside the slot: 1st booking at the start, 2nd 30
+    # minutes later, and so on. Worked out from booking order, never stored.
+    def turn_starts_at
+      return unless responded_at && preferred_slot
+
+      earlier = self.class.responded.where(preferred_date:, preferred_slot:)
+                    .where("responded_at < :at OR (responded_at = :at AND id < :id)", at: responded_at, id: id).count
+      Time.zone.parse("#{preferred_date} #{SLOT_START.fetch(preferred_slot)}") + (TURN * earlier)
+    end
+
+    def turn_label = (at = turn_starts_at) && "#{at.strftime('%-l:%M')}–#{(at + TURN).strftime('%-l:%M %p')}"
+
     def documents_asked
       asked = DOCUMENTS.fetch(round, {})
       asked = asked.except("pan") if pan_pending
@@ -61,10 +81,8 @@ module HrLite
 
     # Saves the reply, moves round 1's candidate to interested / not interested,
     # puts it on their timeline and rings the HR person who emailed them.
-    def submit!(email: nil, interested: nil, date: nil, slot: nil, joining: nil, yes_no: {}, alternate_phone: nil, files: {}, kyc: {})
+    def submit!(interested: nil, date: nil, slot: nil, joining: nil, yes_no: {}, alternate_phone: nil, files: {}, kyc: {})
       raise ArgumentError, "You have already replied. Thank you." if responded_at
-      # The link is personal: the email it was sent to proves the right person opened it.
-      raise ArgumentError, "That email does not match this link. Use the link from your own email." unless email.to_s.strip.casecmp?(candidate.email)
 
       assign_kyc!(kyc) if round == 3
 
@@ -76,7 +94,7 @@ module HrLite
         date = self.class.dates(allow_sunday: candidate.campaign.allow_sunday).find { |day| day.iso8601 == date.to_s }
         raise ArgumentError, "Pick a day for the interview." unless date
         raise ArgumentError, "Pick a time slot." unless SLOTS.key?(slot)
-        raise ArgumentError, "That slot just filled up. Pick another one." if self.class.slot_full?(date, slot)
+        raise ArgumentError, "Someone just booked that slot. Pick another one." if self.class.slot_full?(date, slot)
         raise ArgumentError, "That phone number does not look right." if alternate_phone.present? && !alternate_phone.to_s.gsub(/[\s-]/, "").match?(/\A\+?\d{7,15}\z/)
 
         if round == 1

data/app/models/hr_lite/leave_request.rb

@@ -310,7 +310,10 @@ module HrLite
         body: decision_note.presence,
         path: "/leave_requests/#{id}",
         bell_to: [ user ],
-        email_to: [ user ]
+        email_to: [ user ],
+        # The employee's path 404s for anyone else; leadership opens the admin record.
+        leadership: { title: "#{title} — #{HrLite.display_name(user)}, #{leave_type.name} (#{date_range_label})",
+                      path: "/admin/leave_requests/#{id}" }
       )
     end
 

data/app/views/hr_lite/admin/hiring_candidates/show.html.erb

@@ -34,9 +34,9 @@
         <h2 class="hrl-card__title">Schedule round <%= @interviews.select { |i| %w[scheduled unknown].include?(i.status) }.map(&:round).max.to_i + 1 %></h2>
         <%= form_with url: hr_lite.admin_hiring_candidate_hiring_interviews_path(@candidate), method: :post, local: true do %>
           <% picked = @next_reply %>
-          <% if picked %><p class="hrl-small">They picked <strong><%= picked.preferred_date.strftime("%A, %-d %B") %>, <%= HrLite::HiringReply::SLOTS[picked.preferred_slot] %></strong>. Call to confirm, then send the invite.</p><% end %>
+          <% if picked %><p class="hrl-small">Their turn: <strong><%= picked.preferred_date.strftime("%A, %-d %B") %>, <%= picked.turn_label %></strong> (in the <%= HrLite::HiringReply::SLOTS[picked.preferred_slot] %> slot). Call to confirm, then send the invite.</p><% end %>
           <div class="hrl-field"><label for="date">Date</label><input type="date" name="date" id="date" required value="<%= picked&.preferred_date&.iso8601 %>"></div>
-          <div class="hrl-field"><label for="time">Time</label><input type="time" name="time" id="time" required value="<%= HrLite::HiringReply::SLOT_START[picked&.preferred_slot] %>"></div>
+          <div class="hrl-field"><label for="time">Time</label><input type="time" name="time" id="time" required value="<%= picked&.turn_starts_at&.strftime("%H:%M") %>"></div>
           <div class="hrl-field">
             <label for="minutes">Length</label>
             <select name="minutes" id="minutes"><% HrLite::Admin::HiringInterviewsController::LENGTHS.each do |m| %><option value="<%= m %>"><%= m %> minutes</option><% end %></select>
@@ -87,7 +87,7 @@
       <h2 class="hrl-card__title">Round <%= reply.round %> reply</h2>
       <dl class="hrl-deflist">
         <% if reply.round == 1 %><dt>Interested</dt><dd><%= reply.answers["interested"] == "yes" ? "Yes" : "No" %></dd><% end %>
-        <% if reply.preferred_slot %><dt>Slot</dt><dd><%= reply.preferred_date.strftime("%A, %-d %B") %>, <%= HrLite::HiringReply::SLOTS[reply.preferred_slot] %></dd><% end %>
+        <% if reply.preferred_slot %><dt>Interview time</dt><dd><%= reply.preferred_date.strftime("%A, %-d %B") %>, <%= reply.turn_label %> (<%= HrLite::HiringReply::SLOTS[reply.preferred_slot] %> slot)</dd><% end %>
         <% if reply.answers["joining"] %>
           <dt>Can join</dt><dd><%= HrLite::HiringReply::JOINING[reply.answers["joining"]] %></dd>
           <% HrLite::HiringReply::YES_NO.each do |key, label| %><dt><%= label %></dt><dd><%= reply.answers[key] == "yes" ? "Yes" : "No" %></dd><% end %>

data/app/views/hr_lite/hiring_replies/show.html.erb

@@ -9,17 +9,15 @@
 <% if @reply.responded_at %>
   <section class="hrl-card">
     <h2 class="hrl-card__title">Thanks, we have your answers</h2>
-    <p><%= @reply.answers["interested"] == "no" ? "We have noted that you do not want to go ahead. All the best." : "Our HR team will call you to confirm your round #{round} interview slot." %></p>
+    <% if @reply.answers["interested"] == "no" %>
+      <p>We have noted that you do not want to go ahead. All the best.</p>
+    <% else %>
+      <% if (turn = @reply.turn_label) %><p>Your round <%= round %> interview time: <strong><%= @reply.preferred_date.strftime("%A, %-d %B") %>, <%= turn %></strong>.</p><% end %>
+      <p>Our HR team will call you to confirm it.</p>
+    <% end %>
   </section>
 <% else %>
   <%= form_with url: hr_lite.hiring_reply_path(@reply.token), method: :post, local: true, multipart: true do %>
-    <section class="hrl-card">
-      <div class="hrl-field">
-        <label for="email">Your email (the one this link was sent to)</label>
-        <input type="email" name="email" id="email" autocomplete="email" required value="<%= params[:email] %>">
-      </div>
-    </section>
-
     <% if round == 1 %>
       <section class="hrl-card">
         <fieldset class="hrl-field">
@@ -32,19 +30,20 @@
 
     <section class="hrl-card">
       <h2 class="hrl-card__title"><%= round == 1 ? "If yes: pick" : "Pick" %> a day and one time slot for round <%= round %></h2>
-      <p class="hrl-small hrl-muted">Each slot is 2 hours. HR will call you to confirm.</p>
-      <fieldset class="hrl-field">
-        <legend>Day</legend>
-        <% HrLite::HiringReply.dates(allow_sunday: campaign.allow_sunday).each do |day| %>
-          <label class="hrl-field--check"><input type="radio" name="date" value="<%= day.iso8601 %>" <%= "checked" if params[:date] == day.iso8601 %>> <%= day.strftime("%A, %-d %B") %></label>
-        <% end %>
-      </fieldset>
-      <fieldset class="hrl-field">
-        <legend>Time slot</legend>
-        <% HrLite::HiringReply::SLOTS.each do |key, label| %>
-          <label class="hrl-field--check"><input type="radio" name="slot" value="<%= key %>" <%= "checked" if params[:slot] == key %>> <%= label %></label>
-        <% end %>
-      </fieldset>
+      <p class="hrl-small hrl-muted">Each 2-hour slot takes up to 4 people. You get your own 30-minute interview time inside it, in the order you book. HR will call you to confirm.</p>
+      <% HrLite::HiringReply.open_slots(allow_sunday: campaign.allow_sunday).each do |day, slots| %>
+        <fieldset class="hrl-field">
+          <legend><%= day.strftime("%A, %-d %B") %></legend>
+          <% if slots.empty? %>
+            <p class="hrl-small hrl-muted">Fully booked</p>
+          <% else %>
+            <% slots.each do |slot| %>
+              <% value = "#{day.iso8601}|#{slot}" %>
+              <label class="hrl-field--check"><input type="radio" name="pick" value="<%= value %>" <%= "checked" if params[:pick] == value %>> <%= HrLite::HiringReply::SLOTS[slot] %></label>
+            <% end %>
+          <% end %>
+        </fieldset>
+      <% end %>
       <div class="hrl-field">
         <label for="alternate_phone">Alternate phone number (optional)</label>
         <input type="tel" name="alternate_phone" id="alternate_phone" inputmode="tel" autocomplete="tel" value="<%= params[:alternate_phone] %>">

data/lib/hr_lite/seeds.rb

@@ -10,8 +10,28 @@ module HrLite
       { code: "CO", name: "Comp off", color: "#8b5cf6", paid: true, annual_quota: 0, accrual: "yearly_upfront", carry_forward_cap: 0, position: 5, comp_off: true }
     ].freeze
 
+    # A travel company's staff claims. "Other" takes anything else; the
+    # required "What it was for" field carries the note.
+    DEFAULT_EXPENSE_CATEGORIES = [
+      "Local conveyance (cab, auto, metro)", "Flights and trains", "Hotel stay",
+      "Meals on duty", "Client meeting and entertainment", "Site inspection and FAM trip",
+      "Visa, permit and passport fees", "Fuel, tolls and parking", "Airport transfers",
+      "Phone and internet", "Courier and documents", "Printing and stationery",
+      "Trade fair and events", "Tips and guide payments", "Other"
+    ].freeze
+
     def self.run!
-      seed_leave_types! + seed_holidays!
+      seed_leave_types! + seed_holidays! + seed_expense_categories!
+    end
+
+    # Only into an empty table, so renamed or removed categories stay that way.
+    def self.seed_expense_categories!
+      return [] if ExpenseCategory.exists?
+
+      DEFAULT_EXPENSE_CATEGORIES.map do |name|
+        ExpenseCategory.create!(name: name, receipt_required: name != "Tips and guide payments")
+        "expense_category #{name}"
+      end
     end
 
     # Deliberately NOT auto-run from run!: an operator unticking every

data/lib/hr_lite/version.rb

@@ -1,3 +1,3 @@
 module HrLite
-  VERSION = "0.64.0"
+  VERSION = "0.65.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hr_lite
 version: !ruby/object:Gem::Version
-  version: 0.64.0
+  version: 0.65.0
 platform: ruby
 authors:
 - kshitiz sinha