hr_lite 0.55.0 → 0.56.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 901c6516adf77c589f4e570c477d7aa2a7b05f279e5ef9d205cf868796074939
-  data.tar.gz: d3a6e968a40f6e5fe9d8503a174f8ce004c18ee6cf25218372e21a78d5fecc76
+  metadata.gz: 5deeac7b0eead75adc631a3fe868844a5db7712aaa8297089d6a7ab305c1c610
+  data.tar.gz: fd6b50aa2589eaba50c53703f3a8d4c22a96c61d469989045e1dc7113005a546
 SHA512:
-  metadata.gz: 43c25d542b2eacd2af96e5ff8b281f608fb202be4c1c8ecdd4790b440843fb79ceb32596e8d641bb72beffc8c606dd558d65cd0bba5fbc4a860a8a59e5f24790
-  data.tar.gz: 2e1af9569c33bce9ca0ea5ef790b855d397e6ebf6c88a656757001849f0d197ee8901c057d19de835d999d80005dab3fd6e505ef26829167d3be7f9a101c834c
+  metadata.gz: 14b6853b122a691166a5f2b884a52451d3893bff7b82d33df1ab5e69bfbf71dc00644fe07221588f914a2e7082b95e1164a64f7545d830ccb26c88792c82a701
+  data.tar.gz: 5dbf80c20826f0f3baaff056627d2bb7478914dfce0eb3e140976564e8d60fc4e4a98684fdf37b2cc3c77f5fbc5de5314b6048470fec9c33af7baaeb7053f06e

data/CHANGELOG.md

@@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.56.0] - 2026-10-17
+
+Owner decisions on the HRMS audit (#133–#138). **Two migrations**: the host runs `bin/rails db:migrate` and refreshes `db/schema.rb`.
+
+- **Claims paid with payroll** (FB-5). "Pay with payroll" books an approved claim to a month. The claim is added to that month's slip as a reimbursement line. It is outside gross, so PF, ESI, PT and TDS do not change. Publishing the run marks the claim reimbursed. Booking or moving a claim after compute blocks the run until it is recomputed. A month whose run is finalized or published is refused. Claims marked reimbursed before this release are not picked up again.
+- **Loan instalments never take more than the month's pay** (FB-4). The deduction is capped at what is left after every other deduction. Only the amount taken is booked, the rest stays owed, and the run shows a warning naming the person.
+- **Re-enrol in a benefit after cover ends** (FB-17). The unique index on enrolments now covers only open rows (`ended_on IS NULL`), and the validation matches it. A new index on `work_mode_events.attendance_record_id` (PF-14).
+- **Super Admin may change their own record** (SE-1). The edit is audited. HR and Leadership still cannot edit their own pay, profile or exit.
+- **Menu** (NV-2): Tax checks, Team loans and Team benefits move from Pay to Admin.
+- **Phone**: the Team loans and person-documents "Open" links are 44 px buttons.
+
 ## [0.55.0] - 2026-10-17
 
 The second pass of the HRMS audit of 0.54.0 covers bugs, security, performance and the remaining screen fixes (#115–#131). No migrations.

data/app/controllers/hr_lite/admin/employees_controller.rb

@@ -114,8 +114,8 @@ module HrLite
 
       private
 
-      # Nobody edits or offboards their own record here (auto-approve would publish it); someone else does.
-      def others_profile = EmployeeProfile.find(params[:id]).tap { |p| raise ActiveRecord::RecordNotFound if p.user_id == hr_current_user.id }
+      # Nobody but Super Admin edits or offboards their own record here (auto-approve would publish it).
+      def others_profile = EmployeeProfile.find(params[:id]).tap { |p| raise ActiveRecord::RecordNotFound if p.user_id == hr_current_user.id && !hr_superadmin? }
 
       def profile_params
         params.require(:employee_profile).permit(

data/app/controllers/hr_lite/admin/expenses_controller.rb

@@ -34,9 +34,9 @@ module HrLite
         expense = decidable.find(params[:id])
         month = parse_month_param(params[:period_month])
         expense.reimburse!(actor: hr_current_user, period_month: month)
-        redirect_to admin_expenses_path, notice: "Marked reimbursed with #{month.strftime('%B %Y')}."
+        redirect_to admin_expenses_path, notice: "Will be paid with #{month.strftime('%B %Y')} payroll."
       rescue ActiveRecord::RecordInvalid
-        redirect_to admin_expenses_path, alert: "Only an approved claim can be reimbursed."
+        redirect_to admin_expenses_path, alert: "Only an approved claim can go on payroll, and only on a month not yet paid."
       end
 
       # The receipt the employee had to upload, for the person deciding; same rules as a document download.

data/app/controllers/hr_lite/admin/salary_structures_controller.rb

@@ -38,10 +38,10 @@ module HrLite
 
       private
 
-      # Nobody sets their own pay.
+      # Nobody but Super Admin sets their own pay (the owner has nobody above them).
       def set_profile
         @profile = EmployeeProfile.find(params[:employee_id])
-        raise ActiveRecord::RecordNotFound if @profile.user_id == hr_current_user.id
+        raise ActiveRecord::RecordNotFound if @profile.user_id == hr_current_user.id && !hr_superadmin?
       end
 
       def structure_params

data/app/helpers/hr_lite/application_helper.rb

@@ -64,11 +64,7 @@ module HrLite
         { label: "Benefits", path: :benefits_path, match: [ "/benefits" ], if: -> { hr_can?("benefit.view") } },
         # HR approves payroll without running it; Super Admin runs it. One page.
         { label: "Payroll", path: :admin_payroll_runs_path, match: [ "/admin/payroll_runs", "/admin/salary_slips", "/admin/payroll_line_items" ],
-          if: -> { hr_superadmin? || (hr_can?("payroll.approve", scope: :all) && instance_exec(&MANAGE_OR_CLAIMS)) } },
-        { label: "Tax checks", path: :admin_tax_declarations_path, match: [ "/admin/tax_declarations" ],
-          if: -> { hr_superadmin? || (hr_can?("tax.view", scope: :all) && instance_exec(&MANAGE_OR_CLAIMS)) } },
-        { label: "Team loans", path: :admin_loans_path, match: [ "/admin/loans" ], if: SUPER },
-        { label: "Team benefits", path: :admin_benefits_path, match: [ "/admin/benefits" ], if: MANAGE }
+          if: -> { hr_superadmin? || (hr_can?("payroll.approve", scope: :all) && instance_exec(&MANAGE_OR_CLAIMS)) } }
       ] },
       { label: "People", match: [ "/people" ], tabs: [
         { label: "Team board", path: :team_path, match: [ "/team" ] },
@@ -99,7 +95,11 @@ module HrLite
         { label: "Statutory rates", path: :admin_statutory_rate_cards_path, match: [ "/admin/statutory_rate_cards" ], if: SUPER },
         { label: "Reports", path: :admin_reports_path, match: [ "/admin/reports" ], if: -> { hr_can?("expense.approve", scope: :all) || %w[leave.view attendance.view profile.view].any? { |key| hr_can?(key, scope: :team) } } },
         { label: "Assets", path: :admin_assets_path, match: [ "/admin/assets" ], if: -> { hr_can?("asset.manage", scope: :all) } },
-        { label: "Audit trail", path: :admin_audit_logs_path, match: [ "/admin/audit_logs" ], if: LEAD }
+        { label: "Audit trail", path: :admin_audit_logs_path, match: [ "/admin/audit_logs" ], if: LEAD },
+        { label: "Tax checks", path: :admin_tax_declarations_path, match: [ "/admin/tax_declarations" ],
+          if: -> { hr_superadmin? || (hr_can?("tax.view", scope: :all) && instance_exec(&MANAGE_OR_CLAIMS)) } },
+        { label: "Team loans", path: :admin_loans_path, match: [ "/admin/loans" ], if: SUPER },
+        { label: "Team benefits", path: :admin_benefits_path, match: [ "/admin/benefits" ], if: MANAGE }
       ] }
     ].freeze
 

data/app/models/hr_lite/benefit_enrolment.rb

@@ -9,7 +9,9 @@ module HrLite
     belongs_to :user, class_name: HrLite.config.user_class
 
     validates :enrolled_on, presence: true
-    validates :user_id, uniqueness: { scope: :benefit_id, message: "is already enrolled" }
+    # Mirrors the partial unique index: ended cover is history, not a clash.
+    validates :user_id, uniqueness: { scope: :benefit_id, conditions: -> { where(ended_on: nil) },
+                                      message: "is already enrolled" }, unless: :ended_on?
     validates :dependants, numericality: { greater_than_or_equal_to: 0 }
     validate :ended_after_it_started
 

data/app/models/hr_lite/expense.rb

@@ -53,21 +53,26 @@ module HrLite
       settle!("rejected", actor, note)
     end
 
-    # Paid out with a payroll month. Kept separate from `approved` because
-    # agreeing to pay somebody and actually paying them are different days,
-    # and the person waiting cares about the second one.
+    # Booked onto a payroll month: that month's slip pays it, and publishing
+    # the run marks it reimbursed. Agreeing to pay somebody and actually
+    # paying them are different days, and the person waiting cares about the second.
     def reimburse!(actor:, period_month:)
+      months = [ reimbursed_in, period_month.beginning_of_month ].compact.uniq # moving it touches both runs
       raise ActiveRecord::RecordInvalid.new(self), "not approved" unless approved?
+      raise ActiveRecord::RecordInvalid.new(self), "month already paid" if PayrollRun.exists?(period_month: months, status: %w[finalized published])
 
       transaction do
-        update!(status: "reimbursed", reimbursed_in: period_month.beginning_of_month)
+        update!(reimbursed_in: months.last)
         AuditLog.record!(action: "expense.reimbursed", subject: self, actor: actor,
                          changes: { "employee" => HrLite.display_name(user),
                                     "period" => period_month.strftime("%B %Y") })
       end
+      PayrollRun.where(period_month: months, status: "review").find_each do |run|
+        run.update!(warnings: run.warnings + [ "#{HrLite.display_name(user)}'s #{category.name} claim changed after compute — recompute" ])
+      end
       Notifications.publish(
         "expense.reimbursed",
-        title: "Your #{category.name} claim was reimbursed with #{period_month.strftime('%B %Y')} payroll",
+        title: "Your #{category.name} claim will be paid with #{period_month.strftime('%B %Y')} payroll",
         path: "/expenses", bell_to: [ user ], email_to: [ user ]
       )
       true

data/app/models/hr_lite/payroll_run.rb

@@ -137,6 +137,9 @@ module HrLite
       transaction do
         update!(status: "published", published_at: Time.current, published_by_id: actor&.id)
         audit!("payroll.published", actor, "slips" => salary_slips.count)
+        # The claims these slips carry are paid now.
+        Expense.awaiting_reimbursement.where(reimbursed_in: period_month, user_id: salary_slips.select(:user_id))
+               .update_all(status: "reimbursed", updated_at: Time.current) # rubocop:disable Rails/SkipsModelValidations
       end
 
       # config.slip_release_day holds the employee notice until the slip opens

data/app/services/hr_lite/payroll_run_processor.rb

@@ -50,6 +50,9 @@ module HrLite
           end
 
           slip.assign_attributes(attributes)
+          if slip.deductions_rows.any? { |row| row.dig("meta", "carried_forward") }
+            warnings << "#{HrLite.display_name(user)}'s loan instalment cut (pay too low); the rest is carried forward on the loan"
+          end
           slip.save!
           keep_ids << slip.id
         end

data/app/services/hr_lite/slip_builder.rb

@@ -71,10 +71,8 @@ module HrLite
       deductions << { code: "pt", label: "Professional tax", amount: pt } if pt.positive?
 
       deductions.concat(extra_deductions)
-      loan = loan_instalment
-      deductions << loan if loan
 
-      fy = SalarySlip.fy_to_date(@user, @run.period_month)
+      fy =SalarySlip.fy_to_date(@user, @run.period_month)
       tds = Calculators::Tds.call(
         regime: tax_regime,
         structure_monthly_gross: @structure.monthly_gross,
@@ -90,9 +88,16 @@ module HrLite
         rates: @rates[:income_tax],
         override: @tds_override
       )
+      loan = loan_instalment(gross_earned - deductions.sum(BigDecimal(0)) { |row| row[:amount] } - tds.monthly)
+      deductions << loan if loan
       deductions << { code: "tds", label: "Income tax (TDS)", amount: tds.monthly } if tds.monthly.positive?
 
       total_deductions = deductions.sum(BigDecimal(0)) { |row| row[:amount] }
+      # Claims booked onto this month: paid back with the salary but not
+      # salary, so outside gross and every PF, ESI, PT and TDS base.
+      claims = Expense.awaiting_reimbursement.where(user_id: @user.id, reimbursed_in: @run.period_month).includes(:category).map do |claim|
+        { code: "reimbursement", label: "#{claim.category.name} claim (reimbursement, outside gross)", amount: claim.amount }
+      end
 
       {
         period_month: @run.period_month,
@@ -104,7 +109,7 @@ module HrLite
         lop_days: Money.d(summary[:lop_days]),
         lop_override: @lop_override,
         tds_override: @tds_override,
-        earnings: serialize_rows(earnings),
+        earnings: serialize_rows(earnings + claims),
         deductions: serialize_rows(deductions),
         employer_costs: employer_costs.transform_values { |v| v.to_s("F") }.to_json,
         tax_details: tds.details.to_json,
@@ -113,7 +118,7 @@ module HrLite
         # A heavy-LOP month can leave TDS (projected from the full structure)
         # larger than what was actually earned. Nobody is paid a negative
         # salary; PayrollRunProcessor warns when this floor bites.
-        net_pay: [ gross_earned - total_deductions, BigDecimal(0) ].max,
+        net_pay: [ gross_earned + claims.sum(BigDecimal(0)) { |row| row[:amount] } - total_deductions, BigDecimal(0) ].max,
         computed_at: Time.current
       }
     end
@@ -172,13 +177,16 @@ module HrLite
     # The month's loan instalment, as one deduction line. Computed here and
     # BOOKED only when the run is finalized — a draft is recomputed freely,
     # and booking at compute would take a repayment on every pass.
-    def loan_instalment
-      total = Loan.active.where(user_id: @user.id).sum(BigDecimal(0)) do |loan|
+    # Never more than `room` (pay left after every other deduction); the rest stays owed.
+    def loan_instalment(room)
+      due = Loan.active.where(user_id: @user.id).sum(BigDecimal(0)) do |loan|
         loan.instalment_for(@run.period_month)
       end
-      return nil unless total.positive?
+      return nil unless due.positive?
 
-      { code: "loan_repayment", label: "Loan repayment", amount: total }
+      amount = room.clamp(BigDecimal(0), due)
+      row = { code: "loan_repayment", label: "Loan repayment", amount: amount }
+      amount < due ? row.merge(meta: { carried_forward: (due - amount).to_s("F") }) : row
     end
 
     # Months left in the Indian FY (Apr–Mar) including the run month itself:

data/app/views/hr_lite/admin/documents/show.html.erb

@@ -32,7 +32,7 @@
               </td>
               <td data-label="">
                 <% if doc.readable_by?(hr_current_user) && doc.file.attached? %>
-                  <a class="hrl-small" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
+                  <a class="hrl-btn" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
                 <% end %>
               </td>
             </tr>

data/app/views/hr_lite/admin/employees/show.html.erb

@@ -1,7 +1,7 @@
 <% content_for(:page_title) { @profile.employee_code } %>
 <% content_for(:tabrow) { render "hr_lite/shared/person_tabs", user: @profile.user } %>
 <% content_for(:back, "Employees") %>
-<% own = @profile.user_id == hr_current_user.id # your own pay and record are for someone else to change %>
+<% own = @profile.user_id == hr_current_user.id && !hr_superadmin? # your own pay and record are for someone else to change, unless you are Super Admin %>
 <div class="hrl-page__head">
   <h1 class="hrl-page__title"><%= hr_display_name(@profile.user) %> <span class="hrl-muted">(<%= @profile.employee_code %>)</span></h1>
   <div class="hrl-page__actions">

data/app/views/hr_lite/admin/expenses/index.html.erb

@@ -42,8 +42,8 @@
                 <% elsif expense.approved? %>
                   <%= form_with url: hr_lite.reimburse_admin_expense_path(expense), method: :post do %>
                     <%= label_tag "reimburse-month-#{expense.id}", "Paid with the payroll of", class: "hrl-sr-only" %>
-                    <%= month_field_tag :period_month, Date.current.strftime("%Y-%m"), id: "reimburse-month-#{expense.id}", required: true, class: "hrl-input" %>
-                    <%= submit_tag "Mark reimbursed", class: "hrl-btn" %>
+                    <%= month_field_tag :period_month, (expense.reimbursed_in || Date.current).strftime("%Y-%m"), id: "reimburse-month-#{expense.id}", required: true, class: "hrl-input" %>
+                    <%= submit_tag "Pay with payroll", class: "hrl-btn" %>
                   <% end %>
                 <% end %>
               </td>

data/app/views/hr_lite/admin/loans/index.html.erb

@@ -31,7 +31,7 @@
               <td data-label="Instalment" class="hrl-num"><%= hrl_money(loan.monthly_instalment) %></td>
               <td data-label="Outstanding" class="hrl-num"><%= hrl_money(loan.outstanding) %></td>
               <td data-label="">
-                <a class="hrl-small" href="<%= hr_lite.admin_loan_path(loan) %>">Open</a>
+                <a class="hrl-btn" href="<%= hr_lite.admin_loan_path(loan) %>">Open</a>
               </td>
             </tr>
           <% end %>

data/db/migrate/20261017161441_make_hr_lite_benefit_enrolments_unique_while_open.rb

@@ -0,0 +1,8 @@
+class MakeHrLiteBenefitEnrolmentsUniqueWhileOpen < ActiveRecord::Migration[8.1]
+  # One open enrolment per person per plan; ended ones stay as history.
+  def change
+    remove_index :hr_lite_benefit_enrolments, %i[benefit_id user_id], unique: true, if_exists: true
+    add_index :hr_lite_benefit_enrolments, %i[benefit_id user_id], unique: true, where: "ended_on IS NULL",
+              name: "index_hr_lite_benefit_enrolments_one_open", if_not_exists: true
+  end
+end

data/db/migrate/20261017161443_add_attendance_record_id_index_to_hr_lite_work_mode_events.rb

@@ -0,0 +1,5 @@
+class AddAttendanceRecordIdIndexToHrLiteWorkModeEvents < ActiveRecord::Migration[8.1]
+  def change
+    add_index :hr_lite_work_mode_events, :attendance_record_id, if_not_exists: true
+  end
+end

data/lib/hr_lite/version.rb

@@ -1,3 +1,3 @@
 module HrLite
-  VERSION = "0.55.0"
+  VERSION = "0.56.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hr_lite
 version: !ruby/object:Gem::Version
-  version: 0.55.0
+  version: 0.56.0
 platform: ruby
 authors:
 - kshitiz sinha
@@ -505,6 +505,8 @@ files:
 - db/migrate/20261016090000_add_penalty_leave_type_to_hr_lite_settings.rb
 - db/migrate/20261016091000_create_hr_lite_penalty_removals.rb
 - db/migrate/20261016100000_add_hours_allowance_repeat_to_hr_lite_employee_profiles.rb
+- db/migrate/20261017161441_make_hr_lite_benefit_enrolments_unique_while_open.rb
+- db/migrate/20261017161443_add_attendance_record_id_index_to_hr_lite_work_mode_events.rb
 - lib/generators/hr_lite/install/install_generator.rb
 - lib/generators/hr_lite/install/templates/AFTER_INSTALL
 - lib/generators/hr_lite/install/templates/initializer.rb