hr_lite 0.53.0 → 0.55.0

data/app/models/hr_lite/regularization_request.rb

@@ -135,7 +135,7 @@ module HrLite
       transition!("cancelled", actor, nil)
       Notifications.publish(
         "regularization.cancelled",
-        title: "#{HrLite.display_name(user)} cancelled a regularization ticket (#{date.strftime('%d %b')})",
+        title: "#{HrLite.display_name(user)} cancelled a day fix request (#{date.strftime('%d %b')})",
         path: "/admin/regularization_requests",
         bell_to: HrLite.admin_users
       )
@@ -220,7 +220,7 @@ module HrLite
     def notify_requested
       Notifications.publish(
         "regularization.requested",
-        title: "#{HrLite.display_name(user)} raised a regularization ticket for #{date.strftime('%d %b')} " \
+        title: "#{HrLite.display_name(user)} asked to fix #{date.strftime('%d %b')} " \
                "(#{times_label})",
         body: reason.presence,
         path: "/admin/regularization_requests/#{id}",

data/app/models/hr_lite/resignation.rb

@@ -20,6 +20,7 @@ module HrLite
     STATUSES.each { |s| define_method("#{s}?") { status == s } }
 
     after_create :notify_submitted
+    after_create { audit!("submitted", user) }
 
     def accept!(actor:, last_day: nil, note: nil)
       raise ActiveRecord::RecordInvalid.new(self), "not pending" unless pending?
@@ -34,6 +35,7 @@ module HrLite
         # nothing was stamped, because the screen used to claim it was.
         @exit_date_recorded = profile.present?
         profile&.update!(date_of_exit: final_day)
+        audit!("accepted", actor)
       end
 
       # Notice periods are the normal case, so access is revoked here only
@@ -55,7 +57,7 @@ module HrLite
     def withdraw!(actor:)
       raise ActiveRecord::RecordInvalid.new(self), "not pending" unless pending? && actor.id == user_id
 
-      update!(status: "withdrawn", decided_at: Time.current)
+      transaction { update!(status: "withdrawn", decided_at: Time.current) && audit!("withdrawn", actor) }
       Notifications.publish(
         "resignation.withdrawn",
         title: "#{HrLite.display_name(user)} withdrew their resignation",
@@ -72,6 +74,8 @@ module HrLite
 
     private
 
+    def audit!(action, actor) = AuditLog.record!(action: "resignation.#{action}", subject: self, actor: actor, changes: { "last_day" => proposed_last_day.to_s })
+
     # Best-effort, like every other call of this hook: a host that cannot
     # revoke must not roll back an accepted resignation.
     def revoke_access!

data/app/models/hr_lite/role.rb

@@ -36,12 +36,17 @@ module HrLite
     # permission being taken away, not one left alone.
     def replace_grants!(grants)
       transaction do
+        before = grant_map
         role_grants.destroy_all
         grants.each do |key, scope|
           next if scope.blank? || scope.to_s == "none"
 
           role_grants.create!(permission_key: Permissions.validate!(key), scope: scope.to_s)
         end
+        role_grants.reload
+        after = grant_map
+        changed = (before.keys | after.keys).reject { |key| before[key] == after[key] }
+        AuditLog.record!(action: "role.grants_changed", subject: self, changes: changed.to_h { |key| [ key, [ before[key], after[key] ] ] }) if changed.any?
       end
       reload
     end

data/app/models/hr_lite/salary_slip.rb

@@ -61,8 +61,9 @@ module HrLite
       row ? Money.d(row["amount"]) : BigDecimal(0)
     end
 
+    # Bump the version when the PDF template changes, or the old layout serves until the cache expires.
     def pdf_cache_key
-      [ "hr_lite_slip", id, updated_at.to_i, payroll_run.status,
+      [ "hr_lite_slip_v3", id, updated_at.to_i, payroll_run.status,
         user_profile&.updated_at.to_i ].join("/")
     end
 

data/app/models/hr_lite/statutory_rate_card_record.rb

@@ -7,6 +7,9 @@ module HrLite
 
     self.table_name = "hr_lite_statutory_rate_cards"
 
+    # Shipped cards count as verified so payroll can auto-approve, but no person checked them.
+    SHIPPED_SIGN_OFF = "Shipped defaults, not checked by a person".freeze
+
     validates :effective_from, presence: true, uniqueness: true
     validate :effective_from_opens_a_financial_year
     validate :carries_every_figure_payroll_reads
@@ -22,6 +25,9 @@ module HrLite
 
     def verified? = verified_by.present? && verified_on.present?
 
+    # Cards seeded before this read "hr_lite 0.52.0 (official source …)": a version is not a sign-off.
+    def verified_by = super&.start_with?("hr_lite ") ? SHIPPED_SIGN_OFF : super
+
     # The shape SlipBuilder and the calculators expect: symbol keys and
     # BigDecimal everywhere, because JSON gives back strings and floats and
     # a float has no business in a PF calculation.

data/app/models/hr_lite/tax_declaration.rb

@@ -86,6 +86,11 @@ module HrLite
 
     def verify!(actor:, note: nil)
       raise ActiveRecord::RecordInvalid.new(self), "not submitted" unless submitted?
+      # A blank verified amount would count as ₹0 allowed once verified.
+      if tax_declaration_items.any? { |item| item.verified_amount.nil? }
+        errors.add(:base, "Every line needs a verified amount — enter 0 where the proof supports nothing")
+        raise ActiveRecord::RecordInvalid, self
+      end
 
       update!(status: "verified", verified_by_id: actor.id, verified_at: Time.current,
               note: note.presence)

data/app/services/hr_lite/attendance_puncher.rb

@@ -247,6 +247,10 @@ module HrLite
     # Late ladder against slot + buffer; after 11:00 also +1h on the next two
     # working days; after 11:30 the day is a half day. The buffer shifts all three.
     def apply_slot_rules(record)
+      # No slot to be late for on a weekly off, a holiday, or leave that starts the day (full or first half).
+      return unless WorkingCalendar.for_user(@user.id, record.date..record.date).working_day?(record.date)
+      return if LeaveRequest.active_on(record.date).where(user_id: @user.id, half_day_part: [ nil, "", "first" ]).exists?
+
       local = record.check_in_at.in_time_zone(HrLite.config.time_zone)
       arrived = local.hour * 60 + local.min - EmployeeProfile.where(user_id: @user.id).pick(:buffer_minutes).to_i
       late = AttendanceSlot.penalty_minutes(arrived - AttendanceSlot.start_minute_for(@user.id, record.date))

data/app/services/hr_lite/overview_query.rb

@@ -17,17 +17,6 @@ module HrLite
       reach(LeaveRequest.active_on(@date).includes(:leave_type, :user).order(:start_date))
     end
 
-    # Comp-off and regularization are approvals too. Counting leave alone made
-    # the board announce "All present and accounted for" while both queues
-    # still had work in them.
-    def pending_comp_offs
-      reach(CompOffRequest.pending.includes(:user).recent_first)
-    end
-
-    def pending_regularizations
-      reach(RegularizationRequest.pending.includes(:user).recent_first)
-    end
-
     def flagged_today
       reach(AttendanceRecord.for_date(@date).flagged.includes(:user))
     end
@@ -41,7 +30,6 @@ module HrLite
 
     def kpis
       {
-        pending: pending_requests.count + pending_comp_offs.count + pending_regularizations.count,
         on_leave: on_leave_today.count,
         flagged: flagged_today.count,
         missing_checkout: missing_checkout_yesterday.count

data/app/services/hr_lite/work_status.rb

@@ -16,8 +16,11 @@ module HrLite
     def self.for(user_id, at: Time.current) = for_users([ user_id ], at: at)[user_id]
 
     # When an open Busy or Meeting ends, or nil when the person is reachable.
-    def self.do_not_disturb_until(user_id, at: Time.current)
-      WorkModeEvent.open.overlay.where(user_id: user_id, mode: %w[busy meeting]).where("ends_at > ?", at).maximum(:ends_at)
+    def self.do_not_disturb_until(user_id, at: Time.current) = do_not_disturb_for([ user_id ], at: at)[user_id]
+
+    # The same for many people in one query: { user_id => ends_at }, reachable people absent.
+    def self.do_not_disturb_for(user_ids, at: Time.current)
+      WorkModeEvent.open.overlay.where(user_id: user_ids, mode: %w[busy meeting]).where("ends_at > ?", at).group(:user_id).maximum(:ends_at)
     end
 
     def self.for_users(user_ids, at: Time.current)

data/app/views/hr_lite/admin/assets/index.html.erb

@@ -22,6 +22,9 @@
 <% end %>
 
 <section class="hrl-card">
+  <% if @assets.empty? %>
+    <p class="hrl-muted">No assets recorded yet. Add the first one above.</p>
+  <% else %>
   <div class="hrl-table-wrap">
     <table class="hrl-table hrl-table--stack">
       <thead><tr><th>Asset</th><th>Status</th><th>With</th><th></th></tr></thead>
@@ -39,13 +42,16 @@
             <td data-label="">
               <% if asset.assigned? %>
                 <%= form_with url: hr_lite.take_back_admin_asset_path(asset), method: :post do %>
-                  <%= text_field_tag :condition_note, nil, placeholder: "Condition", class: "hrl-input" %>
+                  <%= label_tag "asset-condition-#{asset.id}", "Condition on return", class: "hrl-sr-only" %>
+                  <%= text_field_tag :condition_note, nil, id: "asset-condition-#{asset.id}", placeholder: "Condition on return", class: "hrl-input" %>
                   <%= submit_tag "Take back", class: "hrl-btn" %>
                 <% end %>
               <% elsif asset.available? %>
                 <%= form_with url: hr_lite.assign_admin_asset_path(asset), method: :post do %>
+                  <%= label_tag "asset-holder-#{asset.id}", "Hand over to", class: "hrl-sr-only" %>
                   <%= select_tag :user_id,
-                        options_for_select(HrLite.employees.map { |u| [ hr_display_name(u), u.id ] }), class: "hrl-input",
+                        options_for_select(HrLite.employees.map { |u| [ hr_display_name(u), u.id ] }), id: "asset-holder-#{asset.id}",
+                        include_blank: "Choose…", required: true, class: "hrl-input",
                         data: { hrl_filter: "Type a name to filter" } %>
                   <%= submit_tag "Hand over", class: "hrl-btn" %>
                 <% end %>
@@ -56,5 +62,6 @@
       </tbody>
     </table>
   </div>
+  <% end %>
   <%= hrl_pagination %>
 </section>

data/app/views/hr_lite/admin/attendances/index.html.erb

@@ -15,10 +15,8 @@
 
 <div class="hrl-kpis">
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @records.values.count { |r| r.check_in_at } %></div><div class="hrl-kpi__label">Checked in</div></div>
-  <%# Derived from the same predicate as "Checked in". Counting rows instead
-      dropped a record with no check-in out of BOTH tiles, so the numbers
-      quietly stopped adding up to the headcount. %>
-  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @employees.size - @records.values.count { |r| r.check_in_at } %></div><div class="hrl-kpi__label">No punch</div></div>
+  <%# Expected in and not checked in: people on leave, a holiday or a weekly off are not counted. %>
+  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @employees.count { |u| @days[u.id]&.kind == :absent } %></div><div class="hrl-kpi__label">No punch</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @flagged_count %></div><div class="hrl-kpi__label">Flagged</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @records.values.count { |r| r.check_in_at && r.check_out_at.nil? } %></div><div class="hrl-kpi__label">Still in</div></div>
 </div>
@@ -71,6 +69,8 @@
               <span class="hrl-badge hrl-badge--bad">Flagged</span> <span class="hrl-small"><%= record.flag_note %></span>
             <% elsif record&.check_in_at %>
               <span class="hrl-badge hrl-badge--ok"><%= record.status.humanize %><%= " (#{record.half_day_part} half)" if record.half_day_part %></span>
+            <% elsif @days[employee.id] %>
+              <%= hrl_team_status(@days[employee.id]) %>
             <% else %>
               <span class="hrl-badge hrl-badge--muted">No punch</span>
             <% end %>

data/app/views/hr_lite/admin/attendances/show.html.erb

@@ -1,5 +1,6 @@
 <% content_for(:page_title) { "Attendance — #{hr_display_name(@employee)}" } %>
 <% content_for(:tabrow) { render "hr_lite/shared/person_tabs", user: @employee } %>
+<% content_for(:back, "Team") %>
 <div class="hrl-page__head">
   <h1 class="hrl-page__title"><%= hr_display_name(@employee) %></h1>
   <div class="hrl-page__actions">
@@ -33,6 +34,7 @@
 <% if @punches.any? %>
   <section class="hrl-card">
     <h2 class="hrl-card__title">Where they punched</h2>
+    <% all_punches = HrLite::AttendancePunch.where(user_id: @employee.id, date: @punches.map(&:date)).order(:at, :id).group_by(&:date) # one query, not one a day %>
     <% @punches.each do |record| %>
       <div class="hrl-feed__item hrl-small">
         <div class="hrl-feed__body">
@@ -47,7 +49,7 @@
               <% end %>
             </div>
           <% end %>
-          <% if record.check_in_place %><%= render "hr_lite/attendance/trail", record: record %><% end %>
+          <% if record.check_in_place %><%= render "hr_lite/attendance/trail", record: record, punches: all_punches.fetch(record.date, []) %><% end %>
           <% if (gap = record.punch_gap_m) %>
             <div class="<%= gap > HrLite::AttendanceRecord::PUNCH_GAP_ALERT_M ? "hrl-badge hrl-badge--warn" : "hrl-muted" %>"><%= (gap / 1000.0).round(1) %> km apart</div>
           <% end %>
@@ -80,7 +82,7 @@
       </div>
       <div class="hrl-field">
         <%= f.label :regularization_note, "Why is this being fixed? (required)" %>
-        <%= f.text_area :regularization_note %>
+        <%= f.text_area :regularization_note, required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= f.submit "Save fix", class: "hrl-btn hrl-btn--primary" %>

data/app/views/hr_lite/admin/attendances/summary.html.erb

@@ -25,14 +25,17 @@
   <% end %>
 </section>
 
+<% fixes_pending = HrLite::RegularizationRequest.pending.where(user_id: @employee.id, date: @period.from..@period.to).pluck(:date) %>
 <section class="hrl-card">
   <h2 class="hrl-card__title">Days</h2>
   <% (@period.from..@period.to).each do |date| %>
-    <% day = @days.for(date); rec = day.record; punches = @punches[date].to_a %>
+    <% day = @days.for(date); rec = day.record; punches = @punches[date].to_a
+       not_in_yet = date == Date.current && day.kind == :absent # the day is not over %>
     <div class="hrl-feed__item hrl-row">
       <div class="hrl-feed__body hrl-small">
         <strong><%= date.strftime("%a %-d %b") %></strong>
-        <span class="hrl-badge <%= tones[day.kind] %>"><%= HrLite::ApplicationHelper::DAY_STATES[day.kind][1] %></span>
+        <span class="hrl-badge <%= not_in_yet ? "hrl-badge--muted" : tones[day.kind] %>"><%= not_in_yet ? "Not in yet" : HrLite::ApplicationHelper::DAY_STATES[day.kind][1] %></span>
+        <% if fixes_pending.include?(date) %><span class="hrl-badge hrl-badge--warn">Fix pending</span><% end %>
         <% if @profile&.hours_allowance_minutes && (length = HrLite::EmployeeProfile.day_minutes_for(@employee.id, on: date)) < HrLite::Setting.instance.day_minutes %>
           <span class="hrl-badge hrl-badge--muted">Day <%= hrl_duration(length * 60) %></span>
         <% end %>

data/app/views/hr_lite/admin/audit_logs/index.html.erb

@@ -1,6 +1,8 @@
+<% content_for(:page_title) { "Audit trail" } %>
 <div class="hrl-page__head">
   <h1 class="hrl-page__title">Audit trail</h1>
-  <p class="hrl-page__sub">Every policy, settings and payroll change — append-only.</p>
+  <p class="hrl-page__sub">Every policy, settings and payroll change — append-only.
+    <% if params[:views] %><a href="<%= hr_lite.admin_audit_logs_path %>">Hide page views</a><% else %><a href="<%= hr_lite.admin_audit_logs_path(views: 1) %>">Show page views too</a><% end %></p>
 </div>
 
 <% if @audit_logs.any? %>
@@ -13,15 +15,15 @@
         <% @audit_logs.each do |log| %>
           <tr>
             <td data-label="When"><%= log.created_at.strftime("%d %b %Y, %H:%M") %></td>
-            <td data-label="Who"><%= hr_display_name(log.actor) %></td>
-            <td data-label="Action"><span class="hrl-badge hrl-badge--muted"><%= log.action %></span></td>
+            <td data-label="Who"><%= log.actor ? hr_display_name(log.actor) : "System" %></td>
+            <td data-label="Action"><span class="hrl-badge hrl-badge--muted"><%= log.action.tr("._", "  ").humanize %></span></td>
             <td data-label="Subject"><%= log.subject_type.demodulize.underscore.humanize %> #<%= log.subject_id %></td>
             <td data-label="Changes">
               <% log.audited_changes.each do |attr, change| %>
                 <div class="hrl-small">
                   <span class="hrl-muted"><%= attr.humanize %>:</span>
                   <% if change.is_a?(Array) %>
-                    <%= change[0].inspect %> → <%= change[1].inspect %>
+                    <%= change[0].to_s.presence || "blank" %> → <%= change[1].to_s.presence || "blank" %>
                   <% else %>
                     <%= change %>
                   <% end %>

data/app/views/hr_lite/admin/benefits/index.html.erb

@@ -20,7 +20,8 @@
     <%= form_with url: hr_lite.enrol_admin_benefit_path(benefit), method: :post, local: true do %>
       <div class="hrl-field">
         <%= label_tag "enrol_user_#{benefit.id}", "Employee" %>
-        <%= select_tag :user_id, options_for_select(people), id: "enrol_user_#{benefit.id}" %>
+        <%= select_tag :user_id, options_for_select(people), id: "enrol_user_#{benefit.id}", include_blank: "Choose…", required: true,
+                       data: { hrl_filter: "Type a name to filter" } %>
       </div>
       <div class="hrl-field">
         <%= label_tag "enrol_on_#{benefit.id}", "Covered from" %>
@@ -49,10 +50,15 @@
               <td data-label="Since"><%= enrolment.enrolled_on.strftime("%d %b %Y") %></td>
               <td data-label="Dependants" class="hrl-num"><%= enrolment.dependants %></td>
               <td data-label="">
-                <%= form_with url: hr_lite.unenrol_admin_benefit_path(enrolment.benefit), method: :post do %>
+                <% if enrolment.ended_on %>
+                  <p class="hrl-small">Cover ends <%= enrolment.ended_on.strftime("%d %b %Y") %></p>
+                <% end %>
+                <%= form_with url: hr_lite.unenrol_admin_benefit_path(enrolment.benefit), method: :post, class: "hrl-row",
+                              data: { turbo_confirm: "End #{enrolment.benefit.name} for #{hr_display_name(enrolment.user)} on the date picked?" } do %>
                   <%= hidden_field_tag :user_id, enrolment.user_id %>
-                  <%= date_field_tag :ended_on, Date.current, class: "hrl-input", "aria-label": "Last day of cover" %>
-                  <%= submit_tag "End cover", class: "hrl-btn" %>
+                  <%= label_tag "ended-on-#{enrolment.id}", "Last day of cover", class: "hrl-small" %>
+                  <%= date_field_tag :ended_on, enrolment.ended_on || Date.current, id: "ended-on-#{enrolment.id}", class: "hrl-input" %>
+                  <%= submit_tag enrolment.ended_on ? "Change end" : "End cover", class: "hrl-btn" %>
                 <% end %>
               </td>
             </tr>

data/app/views/hr_lite/admin/ca_reviews/index.html.erb

@@ -22,12 +22,12 @@
 </div>
 
 <div class="hrl-row hrl-row--mb" role="tablist">
-  <a class="hrl-btn <%= "hrl-btn--primary" if @tab == "slips" %>" href="<%= hr_lite.admin_ca_reviews_path(keep.(tab: "slips", status: @status)) %>" aria-current="<%= @tab == "slips" ? "page" : nil %>">Salary slips</a>
-  <a class="hrl-btn <%= "hrl-btn--primary" if @tab == "declarations" %>" href="<%= hr_lite.admin_ca_reviews_path(keep.(tab: "declarations", status: @status)) %>" aria-current="<%= @tab == "declarations" ? "page" : nil %>">Tax declarations</a>
+  <a class="hrl-btn" <%= "aria-current=true" if @tab == "slips" %> href="<%= hr_lite.admin_ca_reviews_path(keep.(tab: "slips", status: @status)) %>">Salary slips</a>
+  <a class="hrl-btn" <%= "aria-current=true" if @tab == "declarations" %> href="<%= hr_lite.admin_ca_reviews_path(keep.(tab: "declarations", status: @status)) %>">Tax declarations</a>
 </div>
 <div class="hrl-row hrl-row--mb">
   <% [ [ nil, "All" ], [ "unreviewed", "To review" ], [ "flagged", "Flagged" ], [ "verified", "Verified" ], [ "resolved", "Resolved" ] ].each do |value, label| %>
-    <a class="hrl-btn <%= "hrl-btn--primary" if @status == value %>" href="<%= hr_lite.admin_ca_reviews_path(keep.(status: value)) %>"><%= label %></a>
+    <a class="hrl-btn" <%= "aria-current=true" if @status == value %> href="<%= hr_lite.admin_ca_reviews_path(keep.(status: value)) %>"><%= label %></a>
   <% end %>
 </div>
 

data/app/views/hr_lite/admin/checklists/index.html.erb

@@ -4,8 +4,7 @@
 <section class="hrl-card">
   <div class="hrl-row">
     <% HrLite::ChecklistTemplate::KINDS.each do |kind| %>
-      <a class="hrl-btn <%= "hrl-btn--primary" if kind == @kind %>"
-         href="<%= hr_lite.admin_checklists_path(kind: kind) %>"><%= kind.humanize %></a>
+      <%= link_to kind.humanize, hr_lite.admin_checklists_path(kind: kind), class: "hrl-btn", aria: { current: ("true" if kind == @kind) } %>
     <% end %>
   </div>
 </section>
@@ -37,7 +36,8 @@
               <td data-label="Due"><%= item.due_on&.strftime("%d %b %Y") || "—" %></td>
               <td data-label="">
                 <%= form_with url: hr_lite.complete_admin_checklist_path(item), method: :post do %>
-                  <%= text_field_tag :note, nil, placeholder: "Note", class: "hrl-input" %>
+                  <%= label_tag "checklist-note-#{item.id}", "Note (optional)", class: "hrl-sr-only" %>
+                  <%= text_field_tag :note, nil, id: "checklist-note-#{item.id}", placeholder: "Note (optional)", class: "hrl-input" %>
                   <%= submit_tag "Done", class: "hrl-btn hrl-btn--primary" %>
                 <% end %>
               </td>

data/app/views/hr_lite/admin/comp_off_requests/index.html.erb

@@ -6,8 +6,7 @@
 <div class="hrl-row hrl-row--mb">
   <span class="hrl-small hrl-muted">Status</span>
   <% HrLite::CompOffRequest::STATUSES.each do |status| %>
-    <a class="hrl-btn <%= 'hrl-btn--primary' if @status == status %>"
-       href="<%= hr_lite.admin_comp_off_requests_path(status: status) %>"><%= status.humanize %></a>
+    <%= link_to status.humanize, hr_lite.admin_comp_off_requests_path(status: status), class: "hrl-btn", aria: { current: ("true" if @status == status) } %>
   <% end %>
 </div>
 

data/app/views/hr_lite/admin/comp_off_requests/show.html.erb

@@ -1,9 +1,7 @@
 <% content_for(:page_title) { "Comp-off — #{hr_display_name(@request.user)}" } %>
+<a class="hrl-backlink" href="<%= hr_lite.admin_comp_off_requests_path %>"><span aria-hidden="true">‹</span> Approvals</a>
 <div class="hrl-page__head">
   <h1 class="hrl-page__title">Comp-off — <%= hr_display_name(@request.user) %></h1>
-  <div class="hrl-page__actions">
-    <a class="hrl-btn" href="<%= hr_lite.admin_comp_off_requests_path %>">All requests</a>
-  </div>
 </div>
 
 <section class="hrl-card">
@@ -34,7 +32,8 @@
       `formaction:` can never pass verification on the second endpoint. %>
   <section class="hrl-card">
     <h2 class="hrl-card__title">Approve</h2>
-    <%= form_with url: hr_lite.approve_admin_comp_off_request_path(@request), method: :post, local: true do |f| %>
+    <%= form_with url: hr_lite.approve_admin_comp_off_request_path(@request), method: :post, local: true,
+                  html: { data: { turbo_confirm: "Credit #{hrl_days(@request.credit_days)} day of comp-off to #{hr_display_name(@request.user)}?" } } do |f| %>
       <div class="hrl-field">
         <%= f.label :decision_note, "Note (optional)", for: "approve_note" %>
         <%= f.text_area :decision_note, id: "approve_note" %>
@@ -48,10 +47,11 @@
 
   <section class="hrl-card">
     <h2 class="hrl-card__title">Reject</h2>
-    <%= form_with url: hr_lite.reject_admin_comp_off_request_path(@request), method: :post, local: true do |f| %>
+    <%= form_with url: hr_lite.reject_admin_comp_off_request_path(@request), method: :post, local: true,
+                  html: { data: { turbo_confirm: "Reject #{hr_display_name(@request.user)}'s comp-off for #{@request.date_worked.strftime('%d %b %Y')}?" } } do |f| %>
       <div class="hrl-field">
         <%= f.label :decision_note, "Reason (required)", for: "reject_note" %>
-        <%= f.text_area :decision_note, id: "reject_note" %>
+        <%= f.text_area :decision_note, id: "reject_note", required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= f.button "Reject", type: :submit, class: "hrl-btn hrl-btn--danger" %>

data/app/views/hr_lite/admin/designation_changes/new.html.erb

@@ -1,6 +1,6 @@
-<% content_for(:page_title) { "Role change" } %>
+<% content_for(:page_title) { "Designation change" } %>
 <div class="hrl-page__head">
-  <h1 class="hrl-page__title">Role change — <%= hr_display_name(@profile.user) %></h1>
+  <h1 class="hrl-page__title">Designation change — <%= hr_display_name(@profile.user) %></h1>
 </div>
 
 <section class="hrl-card">
@@ -12,7 +12,8 @@
     <div class="hrl-field"><%= f.label :effective_date %><%= f.date_field :effective_date %></div>
     <div class="hrl-field"><%= f.label :note, "Note (optional)" %><%= f.text_area :note %></div>
     <div class="hrl-form-actions">
-      <%= f.submit "Record change", class: "hrl-btn hrl-btn--primary" %>
+      <%= f.submit "Record change", class: "hrl-btn hrl-btn--primary",
+                   data: { turbo_confirm: "Record this designation change? #{hr_display_name(@profile.user)} is told at once." } %>
       <a class="hrl-btn" href="<%= hr_lite.admin_employee_path(@profile) %>">Cancel</a>
     </div>
   <% end %>

data/app/views/hr_lite/admin/documents/index.html.erb

@@ -8,10 +8,10 @@
     visibility allows.
   </p>
   <div class="hrl-row">
-    <a class="hrl-btn <%= "hrl-btn--primary" if @category.nil? %>"
+    <a class="hrl-btn" <%= "aria-current=true" if @category.nil? %>
        href="<%= hr_lite.admin_documents_path %>">All</a>
     <% @categories.each do |category| %>
-      <a class="hrl-btn <%= "hrl-btn--primary" if @category == category %>"
+      <a class="hrl-btn" <%= "aria-current=true" if @category == category %>
          href="<%= hr_lite.admin_documents_path(category: category) %>"><%= category.humanize %></a>
     <% end %>
   </div>
@@ -35,7 +35,7 @@
               </td>
               <td data-label="File">
                 <% if doc.readable_by?(hr_current_user) && doc.file.attached? %>
-                  <a class="hrl-small" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
+                  <a class="hrl-btn" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
                 <% else %>
                   <span class="hrl-small hrl-muted">Not yours to open</span>
                 <% end %>
@@ -44,7 +44,8 @@
                 <%= button_to "Verify", hr_lite.verify_admin_document_path(doc),
                       method: :post, class: "hrl-btn hrl-btn--primary" %>
                 <%= form_with url: hr_lite.reject_admin_document_path(doc), method: :post, local: true do %>
-                  <%= text_field_tag :note, nil, placeholder: "What is wrong with it", class: "hrl-input" %>
+                  <%= label_tag "reject-doc-#{doc.id}", "What is wrong with it", class: "hrl-sr-only" %>
+                  <%= text_field_tag :note, nil, id: "reject-doc-#{doc.id}", placeholder: "What is wrong with it", class: "hrl-input", required: true %>
                   <%= submit_tag "Reject", class: "hrl-btn" %>
                 <% end %>
               </td>
@@ -58,6 +59,9 @@
 
 <section class="hrl-card">
   <h2 class="hrl-card__title">Everything on file</h2>
+  <% if @documents.empty? %>
+    <p class="hrl-muted">No documents on file yet. People upload them from Me › Documents; you can upload for someone from their page.</p>
+  <% else %>
   <div class="hrl-table-wrap">
     <table class="hrl-table hrl-table--stack">
       <thead><tr><th>Person</th><th>Document</th><th>Expires</th><th>Checked</th></tr></thead>
@@ -85,5 +89,6 @@
       </tbody>
     </table>
   </div>
+  <% end %>
   <%= hrl_pagination %>
 </section>

data/app/views/hr_lite/admin/documents/show.html.erb

@@ -1,5 +1,6 @@
 <% content_for(:page_title) { hr_display_name(@employee) } %>
 <% content_for(:tabrow) { render "hr_lite/shared/person_tabs", user: @employee } %>
+<% content_for(:back, "Documents to verify") %>
 <div class="hrl-page__head">
   <h1 class="hrl-page__title"><%= hr_display_name(@employee) %> — documents</h1>
 </div>

data/app/views/hr_lite/admin/employees/_form.html.erb

@@ -1,6 +1,7 @@
 <section class="hrl-card">
   <%= form_with model: profile, url: url, method: method, scope: :employee_profile, local: true do |f| %>
     <%= render "hr_lite/shared/form_errors", record: profile %>
+    <h2 class="hrl-card__title">Identity</h2>
     <% if profile.new_record? && profile.user_id.blank? %>
       <div class="hrl-field">
         <%= f.label :user_id, "Existing staff member" %>
@@ -22,7 +23,7 @@
         </div>
         <div class="hrl-field">
           <%= f.label :new_user_password, "Starting password (optional)" %>
-          <%= f.text_field :new_user_password %>
+          <%= f.password_field :new_user_password, autocomplete: "new-password" %>
           <p class="hrl-hint">Leave blank (recommended): they get an email invite and set their own
             password. Fill it only if you want to hand a password over yourself.</p>
         </div>
@@ -40,6 +41,7 @@
       <p class="hrl-hint">The employee code is assigned automatically
         (<%= HrLite::Setting.instance.employee_code_prefix %> + next number).</p>
     <% end %>
+    <h2 class="hrl-card__title hrl-mt">Work</h2>
     <div class="hrl-field"><%= f.label :designation %><%= f.text_field :designation %></div>
     <div class="hrl-field">
       <%= f.label :manager_id, "Reports to (their L1)" %>
@@ -64,7 +66,7 @@
         <%= f.select :office_location_id, offices, { include_blank: "None — only all-office holidays" }, data: { hrl_filter: ("Type an office" if offices.size > 5) } %></div>
     <% end %>
     <div class="hrl-field"><%= f.label :date_of_birth %><%= f.date_field :date_of_birth %></div>
-    <div class="hrl-field"><%= f.label :date_of_joining %><%= f.date_field :date_of_joining %></div>
+    <div class="hrl-field"><%= f.label :date_of_joining %><%= f.date_field :date_of_joining, required: true %></div>
     <div class="hrl-field">
       <%= f.label :blood_group, id: "hrl-blood-group", for: nil %>
       <div class="hrl-chiprow" role="radiogroup" aria-labelledby="hrl-blood-group">
@@ -79,6 +81,7 @@
       <%= f.label :probation_until, "On probation until (blank = not on probation)" %>
       <%= f.date_field :probation_until %>
     </div>
+    <h2 class="hrl-card__title hrl-mt">Attendance rules</h2>
     <% if HrLite.config.attendance_slots %>
       <div class="hrl-field">
         <%= f.label :buffer_minutes, "Late buffer (delays late penalties; colleagues see the reason category)" %>
@@ -99,12 +102,16 @@
       <%= f.label :date_of_exit, "Date of exit (leave blank while employed)" %>
       <%= f.date_field :date_of_exit %>
     </div>
-    <div class="hrl-field"><%= f.label :pan_number, "PAN" %><%= f.text_field :pan_number %></div>
-    <div class="hrl-field"><%= f.label :pf_uan, "PF UAN" %><%= f.text_field :pf_uan %></div>
+    <h2 class="hrl-card__title hrl-mt">Pay &amp; statutory</h2>
+    <div class="hrl-field"><%= f.label :pan_number, "PAN" %><%= f.text_field :pan_number %>
+      <p class="hrl-hint">10 characters in capitals, like ABCDE1234F.</p></div>
+    <div class="hrl-field"><%= f.label :pf_uan, "PF UAN" %><%= f.text_field :pf_uan %>
+      <p class="hrl-hint">12 digits.</p></div>
     <div class="hrl-field"><%= f.label :esi_number, "ESI number" %><%= f.text_field :esi_number %></div>
     <div class="hrl-field"><%= f.label :bank_name %><%= f.text_field :bank_name %></div>
     <div class="hrl-field"><%= f.label :bank_account_number %><%= f.text_field :bank_account_number %></div>
-    <div class="hrl-field"><%= f.label :bank_ifsc, "IFSC" %><%= f.text_field :bank_ifsc %></div>
+    <div class="hrl-field"><%= f.label :bank_ifsc, "IFSC" %><%= f.text_field :bank_ifsc %>
+      <p class="hrl-hint">11 characters in capitals, fifth is a zero, like HDFC0001234.</p></div>
     <div class="hrl-field">
       <%= f.label :tax_regime %>
       <%= f.select :tax_regime, HrLite::EmployeeProfile::TAX_REGIMES.map { |r| [ "#{r.humanize} regime", r ] } %>