hr_lite 0.53.0 → 0.54.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21dc6e39c0cac6008a3b99d4fe74a6d1b81a335e5fc58fe615f1cb4a98dfd32f
-  data.tar.gz: 715135ae1cda08faafe28049aa51c0cac73ae4e0a6c45aeefc1889417bc5224c
+  metadata.gz: 2914dd05ed8eb6c4e9974e4f4d84ee8149f6158e976ee6f7ec07958b8046a894
+  data.tar.gz: 36bc28076ab2d1d16a6ac20df8171c28ae50b317081ec3e2a6b205cf32591d05
 SHA512:
-  metadata.gz: bfb1bf34635704206cc890a4acee68684c7033b3d5dbbda67fa1b4c44b3c377e05f2f74271a30ad7174cc221d0d7bbed4d6afb244133082d64945f3066c8018f
-  data.tar.gz: 1f8e31b31cad07625f8540f4ed3f8e6dd3ada6e4415c91c96d34eb86d899a056d3ee9668b2cc78f71ee4d6367dc22d42de8641112b5e50f422a054ad302a6d81
+  metadata.gz: 1235ee079d20011f1d966c605814f028ece64a6d148c6ad8e28be4b1a9db7cb1b9ac98ded5b1f7c87a6c10536c7d524788b0f87096be4146f2fbe2458b08d0c4
+  data.tar.gz: a770905bf3daeab581c3edc9a3fb7d4902824d3c47a491e5af540123df3c6aaad711d9d6de88b6a0055acc9432750dd9802ce3c0426c74b1070293d81e24a835

data/CHANGELOG.md

@@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.54.0] - 2026-10-17
+
+Fixes from the HRMS UI/UX audit of 0.52.0. No migrations.
+
+- Approvals: Home, the HR overview and the Inbox badge show one count. Decision lists leave out your own requests, which used to open a blank 404. "Review requests" opens Inbox › All, and each row there names the request ("Sick leave, 30 Oct (half day) · 0.5 days") and opens it. Home locations opens on Pending. Every reject reason is required before the form submits.
+- Confirms before one-way actions: resigning, accepting a resignation, saving a PIP, giving someone a role (the picker now starts blank and filters by name), changing a role's permissions, publishing a policy ("Publish and notify 4 people by email?"), recomputing a run that has an approval, approving past blocking warnings, ending health cover, and accepting all tax claims (names the claims without proof).
+- Money: payroll run totals no longer wrap mid-number on a phone. "Employer cost" reads "Employer contributions". The payslip spells the paise its figure shows. The earnings table stacks on phones. Tax-working amounts stay on one line. My loans totals active loans only. Leave chips show days pending.
+- Phones: tab-row links, list Edit/Open links and the fix-a-punch links are 44px targets. Work-time chart labels are readable at any range. The tax-slab editor is a labelled three-column grid. The bulk holiday box has a label. Employee pickers on pay items, loans and benefits start blank, are required and filter by name.
+- Attendance: the check-in card says "Check in by 10:05" and what lateness costs. A day counts its penalty minutes when deciding whether it was short, so the card no longer says "day done" under "short by 20m". The status picker offers word quick picks instead of emoji. Team attendance shows leave, holidays and weekly offs instead of "No punch".
+- Tax and rate cards: "Record and verify" saves the amounts on screen before verifying. A new financial year defaults to 1 April. Shipped rate cards still count as verified, but the sign-off reads "Shipped defaults, not checked by a person".
+- Admin: approvers can open a claim's receipt (permission-checked, audited, 5-minute link). Working-day settings have their own HR settings tab. New run shows only to those who can run payroll.
+- Branding: HR emails show `company[:email_logo_url]` as an image and a "Questions:" line from `phone`, `email` and `website`. The slip PDF prints the same contact line, and its cache key is versioned so cached slips are re-rendered. Hosts pass the new keys in `config.company`; without `email_logo_url` an email has no logo image, as before.
+
 ## [0.53.0] - 2026-10-16
 
 - HR runs inside the host's iOS and Android staff apps: pages opened by a Hotwire Native shell load Turbo (vendored 8.0.23) with `turbo-visit-control: reload`, so every visit is a full page load and the engine's plain scripts run exactly as in a browser. Browsers still get no Turbo. `config.native_app = ->(request) { … }` lets the host say which requests are its app; the default matches the Hotwire Native user agent.

data/README.md

@@ -132,9 +132,12 @@ HrLite.configure do |c|
   c.mailer_from     = "hr@example.com"
   c.public_url_base = "https://hr.example.com"  # enables deep links in emails
   # brand + phone are optional; the ID card prints brand, and its QR holds
-  # brand, address and phone as plain text.
+  # brand, address and phone as plain text. Emails print email_logo_url (an
+  # absolute https URL: mail clients drop data: URIs) and, with the slip PDF,
+  # a contact line from phone, email and website.
   c.company         = -> { { name: "Acme", brand: "acme.in", address: "Head office address",
-                            phone: "+91 00000 00000", logo_url: nil } }
+                            phone: "+91 00000 00000", email: "hr@acme.in", website: "acme.in",
+                            logo_url: nil, email_logo_url: "https://acme.in/logo.png" } }
 
   # Salary-slip PDFs: plug your renderer, or add wicked_pdf to the bundle and
   # the built-in renderer takes over. With neither, PDF export is disabled.

data/app/assets/javascripts/hr_lite/emoji_pick.js

@@ -1,11 +1,11 @@
-// Emoji grid for the status form: a tap puts that emoji in the input.
+// Quick picks for the status form: a tap puts that status in the text box.
 (function () {
   "use strict";
   document.addEventListener("click", function (e) {
-    var b = e.target.closest && e.target.closest("[data-hrl-emoji]");
+    var b = e.target.closest && e.target.closest("[data-hrl-pick]");
     if (!b) return;
-    var input = b.closest("form").querySelector("input[name=emoji]");
-    input.value = b.dataset.hrlEmoji;
+    var input = b.closest("form").querySelector("input[name=text]");
+    input.value = b.dataset.hrlPick;
     input.focus();
   });
 })();

data/app/assets/stylesheets/hr_lite/hr_lite.css

@@ -124,7 +124,7 @@ html:has(.hrl-body) { scroll-padding-top: 4rem; scroll-padding-bottom: calc(4.4r
 .hrl-nav__link--active .hrl-nav__hint { color: inherit; }
 /* Tab row: the current place's tabs on one line; it scrolls sideways, never the page. */
 .hrl-tabrow { display: flex; gap: var(--hrl-gap-target); overflow-x: auto; margin: 0 0 var(--hrl-s-4); padding-bottom: var(--hrl-s-2); border-bottom: 1px solid var(--hrl-line); }
-.hrl-tabrow .hrl-nav__link { flex: 0 0 auto; white-space: nowrap; }
+.hrl-tabrow .hrl-nav__link { flex: 0 0 auto; white-space: nowrap; min-width: var(--hrl-target); justify-content: center; }
 .hrl-side__divider { height: 1px; background: var(--hrl-line); margin: var(--hrl-s-2) var(--hrl-s-1); }
 
 /* Mobile app bar */
@@ -415,12 +415,14 @@ fieldset { border: 0; margin: 0; padding: 0; min-width: 0; }
 .hrl-card--private .hrl-badge--muted { background: var(--hrl-card); }
 
 /* Tax: the two regimes side by side, then the working as a plain table. */
+.hrl-slabs { display: grid; grid-template-columns: repeat(3, minmax(0, 1fr)); gap: var(--hrl-gap-target); align-items: end; }
 .hrl-tax-compare { display: grid; grid-template-columns: 1fr 1fr; gap: var(--hrl-s-3); margin: var(--hrl-s-4) 0 var(--hrl-s-2); }
 .hrl-tax-compare__col { border: 1px solid var(--hrl-line); border-radius: var(--hrl-radius-sm); padding: var(--hrl-s-3); min-width: 0; }
 .hrl-tax-compare__col--chosen { border: 2px solid var(--hrl-accent); }
 .hrl-tax-compare__amount { font-size: var(--hrl-t-title); font-weight: 700; margin-top: var(--hrl-s-1); overflow-wrap: anywhere; }
 .hrl-tax-working { margin-top: var(--hrl-s-3); }
-.hrl-tax-working__table td { vertical-align: top; overflow-wrap: anywhere; }
+.hrl-tax-working__table td { vertical-align: top; overflow-wrap: break-word; } /* anywhere let the table squeeze amounts mid-number */
+.hrl-tax-working__table td.hrl-num { white-space: nowrap; }
 .hrl-tax-working__total td { font-weight: 700; border-top: 1px solid var(--hrl-line); }
 .hrl-tax-cap { display: block; width: 100%; height: 8px; margin-top: var(--hrl-s-1); accent-color: var(--hrl-accent); }
 
@@ -621,8 +623,9 @@ a.hrl-tree__name { display: inline-flex; align-items: center; min-height: var(--
 .hrl-donut__track { stroke: var(--hrl-bg); }
 .hrl-swatch { display: inline-block; width: .7rem; height: .7rem; border-radius: var(--hrl-radius-pill); vertical-align: middle; }
 .hrl-chart-scroll { overflow-x: auto; }
-.hrl-bars { width: 100%; min-width: 16rem; height: 10rem; }
-.hrl-bars__label { font-size: 5px; fill: var(--hrl-muted); }
+/* Wide enough per bar that the height (10rem) sets the scale, so labels render ~12.6px and long ranges scroll. */
+.hrl-bars { width: 100%; min-width: max(16rem, calc(var(--hrl-bars-n, 0) * 1.4rem)); height: 10rem; }
+.hrl-bars__label { font-size: 9px; fill: var(--hrl-muted); }
 .hrl-daystrip { width: 100%; height: 2rem; background: var(--hrl-bg); border-radius: var(--hrl-radius-sm); }
 .hrl-timeline__auto { stroke: var(--hrl-card); stroke-width: .3; stroke-dasharray: .6 .4; }
 .hrl-timeline__axis { display: flex; justify-content: space-between; }
@@ -630,8 +633,6 @@ a.hrl-tree__name { display: inline-flex; align-items: center; min-height: var(--
 .hrl-chart-tip { position: absolute; z-index: 30; max-width: 16rem; padding: .4rem .6rem; border-radius: var(--hrl-radius-sm); background: var(--hrl-ink); color: var(--hrl-card); font-size: var(--hrl-t-small); pointer-events: none; }
 [data-hrl-tip]:focus { outline: 2px solid var(--hrl-accent); outline-offset: 1px; }
 .hrl-custom-status { display: inline-flex; gap: .3rem; align-items: center; overflow-wrap: anywhere; }
-.hrl-emoji-grid { display: grid; grid-template-columns: repeat(auto-fill, minmax(2.75rem, 1fr)); gap: var(--hrl-gap-target); margin-top: var(--hrl-gap-target); }
-.hrl-emoji { min-height: var(--hrl-target); border: 1px solid var(--hrl-line); border-radius: var(--hrl-radius-sm); background: var(--hrl-card); font-size: 1.25rem; cursor: pointer; }
 /* Today's check-ins: one initials badge per person; hover/tap shows times. */
 .hrl-checkins + .hrl-checkins { margin-top: .6rem; }
 .hrl-checkins__people { display: flex; flex-wrap: wrap; gap: var(--hrl-gap-target); margin: .4rem 0 0; padding: 0; list-style: none; }

data/app/controllers/hr_lite/admin/attendances_controller.rb

@@ -11,6 +11,8 @@ module HrLite
         @employees = @employees.select { |user| visible.include?(user.id) } if visible
         @records = AttendanceRecord.for_date(@date).where(user_id: @employees.map(&:id)).index_by(&:user_id)
         @flagged_count = @records.values.count(&:flagged?)
+        # Leave, holidays and weekly offs are not "No punch": the team board's day status says which.
+        @days = TeamDay.new(date: @date).rows.index_by { |row| row.user.id }
         @penalty_minutes = AttendancePenalty.held_minutes(@employees.map(&:id))
         # "How many people punched where": off-site punches count as one place.
         @offices = OfficeLocation.active.to_a

data/app/controllers/hr_lite/admin/comp_off_requests_controller.rb

@@ -4,7 +4,7 @@ module HrLite
       def index
         @status = params[:status].presence_in(CompOffRequest::STATUSES) || "pending"
         @requests = paginate(hr_scope(CompOffRequest.includes(:user).where(status: @status).recent_first,
-                                      "leave.view"))
+                                      "leave.view").where.not(user_id: hr_current_user.id))
       end
 
       def show

data/app/controllers/hr_lite/admin/documents_controller.rb

@@ -11,7 +11,7 @@ module HrLite
         @category = params[:category].presence
         scope = hr_scope(Document.includes(:user).recent_first, "document.view")
         scope = scope.where(category: @category) if @category
-        @pending = scope.where(verification: "pending").limit(50).to_a
+        @pending = scope.where(verification: "pending").where.not(user_id: hr_current_user.id).limit(50).to_a
         @documents = paginate(scope)
         @categories = Document.distinct.order(:category).pluck(:category)
       end

data/app/controllers/hr_lite/admin/expenses_controller.rb

@@ -8,7 +8,7 @@ module HrLite
       def index
         @status = params[:status].presence_in(Expense::STATUSES) || "submitted"
         scope = Expense.where(status: @status).includes(:user, :category).recent_first
-        @expenses = paginate(hr_scope(scope, "expense.approve"))
+        @expenses = paginate(hr_scope(scope, "expense.approve").where.not(user_id: hr_current_user.id))
       end
 
       def approve
@@ -35,6 +35,18 @@ module HrLite
         redirect_to admin_expenses_path, alert: "Only an approved claim can be reimbursed."
       end
 
+      # The receipt the employee had to upload, for the person deciding; same rules as a document download.
+      def receipt
+        expense = decidable.find(params[:id])
+        raise ActiveRecord::RecordNotFound unless expense.receipt.attached?
+
+        AuditLog.record!(action: "expense.receipt_viewed", subject: expense, actor: hr_current_user,
+                         changes: { "owner" => HrLite.display_name(expense.user) })
+        redirect_to Rails.application.routes.url_helpers.rails_blob_path(
+          expense.receipt, disposition: "inline", only_path: true, expires_in: 5.minutes
+        ), allow_other_host: false
+      end
+
       private
 
       def require_deciding! = hr_require_permission!("expense.approve", scope: :team)

data/app/controllers/hr_lite/admin/leave_requests_controller.rb

@@ -8,7 +8,7 @@ module HrLite
         # the LIST as well as the decision matters: an index that shows a row
         # the member action then refuses is a worse screen than one that never
         # showed it.
-        @requests = paginate(hr_scope(scope.where(status: @status), "leave.view"))
+        @requests = paginate(hr_scope(scope.where(status: @status), "leave.view").where.not(user_id: hr_current_user.id))
       end
 
       def show

data/app/controllers/hr_lite/admin/regularization_requests_controller.rb

@@ -4,7 +4,7 @@ module HrLite
       def index
         @status = params[:status].presence_in(RegularizationRequest::STATUSES) || "pending"
         @requests = paginate(hr_scope(RegularizationRequest.includes(:user).where(status: @status).recent_first,
-                                      "attendance.view"))
+                                      "attendance.view").where.not(user_id: hr_current_user.id))
       end
 
       def show

data/app/controllers/hr_lite/admin/statutory_rate_cards_controller.rb

@@ -52,7 +52,8 @@ module HrLite
       def next_financial_year(newest)
         return FinancialYear.start_for(Date.current) if newest.nil?
 
-        [ newest.effective_from.next_year, FinancialYear.start_for(Date.current) ].max
+        # A mid-year card (1 Oct) must not push the next one to 1 Oct: years start on 1 April.
+        [ FinancialYear.start_for(newest.effective_from.next_year), FinancialYear.start_for(Date.current) ].max
       end
 
       # The figures arrive as flat strings from number fields and are stored

data/app/controllers/hr_lite/admin/tax_declarations_controller.rb

@@ -11,7 +11,7 @@ module HrLite
         @status = params[:status].presence_in(TaxDeclaration::STATUSES) || "submitted"
         @declarations = paginate(
           hr_scope(TaxDeclaration.includes(:user, :tax_declaration_items), "tax.view")
-            .where(status: @status).order(created_at: :desc)
+            .where(status: @status).where.not(user_id: hr_current_user.id).order(created_at: :desc)
         )
       end
 
@@ -69,6 +69,7 @@ module HrLite
         # Recording what the proof supported is a separate act from deciding
         # — an amount can be corrected while the decision is still pending.
         if @declaration.update(verification_params)
+          return verify if params[:verify] # "Record and verify": the typed amounts are saved first
           redirect_to admin_tax_declaration_path(@declaration), notice: "Amounts recorded."
         else
           @tax = TaxComputation.new(user: @declaration.user, declaration: @declaration)

data/app/controllers/hr_lite/admin/work_locations_controller.rb

@@ -5,7 +5,7 @@ module HrLite
     # Coordinates are only shown here, inside attendance.view reach.
     class WorkLocationsController < BaseController
       def index
-        @status = params[:status].presence_in(WorkLocation::STATUSES) || "approved"
+        @status = params[:status].presence_in(WorkLocation::STATUSES) || "pending"
         @locations = paginate(hr_scope(WorkLocation.where(status: @status), "attendance.view")
                                 .includes(:user).order(created_at: :desc))
       end

data/app/controllers/hr_lite/home_controller.rb

@@ -8,7 +8,6 @@ module HrLite
                               .sort_by { |leave| hr_display_name(leave.user).downcase }
       @attention = attention_days
       @waiting = Approval.pending_for(hr_current_user).count
-      @queue = queue_count
       @mine_pending = [ LeaveRequest.includes(:leave_type), RegularizationRequest, CompOffRequest ]
                       .flat_map { |scope| scope.pending.where(user_id: hr_current_user.id).order(created_at: :desc).limit(5) }
                       .max_by(5, &:created_at)
@@ -16,14 +15,6 @@ module HrLite
 
     private
 
-    # Requests with no routed flow are decided straight off the HR queues, scoped as those queues decide them.
-    def queue_count
-      leave = ApprovalFlow.for(LeaveRequest.name) ? 0 : decidable(LeaveRequest, "leave.approve")
-      leave + decidable(CompOffRequest, "leave.approve") + decidable(RegularizationRequest, "attendance.manage")
-    end
-
-    def decidable(model, key) = hr_scope(model.pending, key).where.not(user_id: hr_current_user.id).count
-
     # Last week's days that still need a fix (absent, no check-out, flagged, short), minus those with a pending ticket.
     def attention_days
       range = (Date.current - 7)..(Date.current - 1)

data/app/controllers/hr_lite/loans_controller.rb

@@ -4,7 +4,7 @@ module HrLite
   class LoansController < ApplicationController
     def index
       @loans = Loan.where(user_id: hr_current_user.id).order(starts_on: :desc)
-      @outstanding = @loans.sum(BigDecimal(0), &:outstanding)
+      @outstanding = @loans.active.sum(BigDecimal(0), &:outstanding)
       @next_month = Date.current.next_month.beginning_of_month
     end
   end

data/app/helpers/hr_lite/application_helper.rb

@@ -44,7 +44,7 @@ module HrLite
         { label: "Attendance fixes", path: :admin_regularization_requests_path, match: [ "/admin/regularization_requests" ], if: OPS,
           queue: -> { hrl_queue(HrLite::RegularizationRequest.pending, "attendance.manage") } },
         { label: "WFH", path: :admin_wfh_requests_path, match: [ "/admin/wfh_requests" ], if: OPS,
-          queue: -> { hrl_queue(HrLite::WfhRequest.pending, "attendance.manage") } },
+          queue: -> { hrl_queue(HrLite::WfhRequest.pending.overlapping(Date.current, Date.current + HrLite::WfhRequest::MAX_DAYS_AHEAD), "attendance.manage") } },
         { label: "Home locations", path: :admin_work_locations_path, match: [ "/admin/work_locations" ], if: OPS,
           queue: -> { hrl_queue(HrLite::WorkLocation.pending, "attendance.manage") } },
         { label: "Claims", path: :admin_expenses_path, match: [ "/admin/expenses" ], if: -> { hr_can?("expense.approve", scope: :team) },
@@ -91,7 +91,8 @@ module HrLite
         { label: "Manage policies", path: :admin_policies_path, match: [ "/admin/policies" ], if: -> { hr_can?("policy.manage", scope: :all) } }
       ] },
       { label: "Admin", divider: true, tabs: [
-        { label: "Settings", path: :admin_leave_types_path, match: [ "/admin/leave_types", "/admin/office_locations", "/admin/holidays", "/admin/setting", "/admin/expense_categories" ], if: LEAD },
+        { label: "Settings", path: :admin_leave_types_path, match: [ "/admin/leave_types", "/admin/office_locations", "/admin/holidays", "/admin/expense_categories" ], if: LEAD },
+        { label: "HR settings", path: :edit_admin_setting_path, match: [ "/admin/setting" ], if: LEAD },
         { label: "Roles", path: :admin_roles_path, match: [ "/admin/roles" ], if: -> { hr_can?("role.manage", scope: :all) } },
         { label: "Statutory rates", path: :admin_statutory_rate_cards_path, match: [ "/admin/statutory_rate_cards" ], if: SUPER },
         { label: "Reports", path: :admin_reports_path, match: [ "/admin/reports" ], if: -> { hr_can?("expense.approve", scope: :all) || %w[leave.view attendance.view profile.view].any? { |key| hr_can?(key, scope: :team) } } },
@@ -151,6 +152,24 @@ module HrLite
     # What a queue page lets this viewer decide: their reach, never their own requests.
     def hrl_queue(relation, key) = hr_access.scope_relation(relation, key).where.not(user_id: hr_current_user.id)
 
+    # The Inbox badge's number; Home and the overview board show the same one.
+    def hrl_inbox_count
+      inbox = hrl_sections.find { |s| s[:label] == "Inbox" }
+      inbox ? hrl_waiting(inbox).to_i : 0
+    end
+
+    # One queued request in words, and where it is decided.
+    def hrl_inbox_item(tab, record)
+      case record
+      when HrLite::LeaveRequest
+        [ "#{record.leave_type.name}, #{record.date_range_label} · #{pluralize(hrl_days(record.days_count), 'day')}", hr_lite.admin_leave_request_path(record) ]
+      when HrLite::CompOffRequest then [ "Comp-off for #{record.date_worked.strftime('%a %-d %b')}", hr_lite.admin_comp_off_request_path(record) ]
+      when HrLite::RegularizationRequest then [ "Attendance fix, #{record.date.strftime('%a %-d %b')}", hr_lite.admin_regularization_request_path(record) ]
+      when HrLite::WfhRequest then [ "WFH, #{record.dates_label}", hr_lite.admin_wfh_request_path(record) ]
+      else [ tab[:label], hr_lite.public_send(tab[:path]) ]
+      end
+    end
+
     # Everything waiting in this viewer's queues, oldest first, as [tab, record].
     def hrl_inbox_rows(limit = 50)
       inbox = hrl_sections.find { |s| s[:label] == "Inbox" } or return []

data/app/models/hr_lite/attendance_record.rb

@@ -57,9 +57,11 @@ module HrLite
       EmployeeProfile.day_minutes_for(user_id, on: date) unless HrLite.config.work_hours.nil? || date.saturday?
     end
 
-    # Hours worked, not the clock: an early start counts.
+    # Hours worked, not the clock: an early start counts. The day's penalty
+    # minutes count too, the same rule as required_check_out_at, so the card
+    # never says "day done" above "short by 20m".
     def short?
-      worked_under?(required_minutes)
+      worked_under?(required_minutes && required_minutes + penalty_minutes)
     end
 
     def below_half_day?
@@ -70,10 +72,11 @@ module HrLite
     def required_check_out_at
       return unless HrLite.config.attendance_slots && check_in_at
 
-      extra = AttendancePenalty.active.where(user_id: user_id, date: date).sum(:minutes)
-      check_in_at + (EmployeeProfile.day_minutes_for(user_id, on: date) + extra).minutes
+      check_in_at + (EmployeeProfile.day_minutes_for(user_id, on: date) + penalty_minutes).minutes
     end
 
+    def penalty_minutes = AttendancePenalty.active.where(user_id: user_id, date: date).sum(:minutes)
+
     def worked_under?(minutes) = !!(minutes && worked_duration && worked_duration < minutes.minutes)
 
     # Check in again after checking out: once a day, inside the hours HR sets in

data/app/models/hr_lite/salary_slip.rb

@@ -61,8 +61,9 @@ module HrLite
       row ? Money.d(row["amount"]) : BigDecimal(0)
     end
 
+    # Bump the version when the PDF template changes, or the old layout serves until the cache expires.
     def pdf_cache_key
-      [ "hr_lite_slip", id, updated_at.to_i, payroll_run.status,
+      [ "hr_lite_slip_v2", id, updated_at.to_i, payroll_run.status,
         user_profile&.updated_at.to_i ].join("/")
     end
 

data/app/models/hr_lite/statutory_rate_card_record.rb

@@ -7,6 +7,9 @@ module HrLite
 
     self.table_name = "hr_lite_statutory_rate_cards"
 
+    # Shipped cards count as verified so payroll can auto-approve, but no person checked them.
+    SHIPPED_SIGN_OFF = "Shipped defaults, not checked by a person".freeze
+
     validates :effective_from, presence: true, uniqueness: true
     validate :effective_from_opens_a_financial_year
     validate :carries_every_figure_payroll_reads
@@ -22,6 +25,9 @@ module HrLite
 
     def verified? = verified_by.present? && verified_on.present?
 
+    # Cards seeded before this read "hr_lite 0.52.0 (official source …)": a version is not a sign-off.
+    def verified_by = super&.start_with?("hr_lite ") ? SHIPPED_SIGN_OFF : super
+
     # The shape SlipBuilder and the calculators expect: symbol keys and
     # BigDecimal everywhere, because JSON gives back strings and floats and
     # a float has no business in a PF calculation.

data/app/views/hr_lite/admin/attendances/index.html.erb

@@ -15,10 +15,8 @@
 
 <div class="hrl-kpis">
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @records.values.count { |r| r.check_in_at } %></div><div class="hrl-kpi__label">Checked in</div></div>
-  <%# Derived from the same predicate as "Checked in". Counting rows instead
-      dropped a record with no check-in out of BOTH tiles, so the numbers
-      quietly stopped adding up to the headcount. %>
-  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @employees.size - @records.values.count { |r| r.check_in_at } %></div><div class="hrl-kpi__label">No punch</div></div>
+  <%# Expected in and not checked in: people on leave, a holiday or a weekly off are not counted. %>
+  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @employees.count { |u| @days[u.id]&.kind == :absent } %></div><div class="hrl-kpi__label">No punch</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @flagged_count %></div><div class="hrl-kpi__label">Flagged</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @records.values.count { |r| r.check_in_at && r.check_out_at.nil? } %></div><div class="hrl-kpi__label">Still in</div></div>
 </div>
@@ -71,6 +69,8 @@
               <span class="hrl-badge hrl-badge--bad">Flagged</span> <span class="hrl-small"><%= record.flag_note %></span>
             <% elsif record&.check_in_at %>
               <span class="hrl-badge hrl-badge--ok"><%= record.status.humanize %><%= " (#{record.half_day_part} half)" if record.half_day_part %></span>
+            <% elsif @days[employee.id] %>
+              <%= hrl_team_status(@days[employee.id]) %>
             <% else %>
               <span class="hrl-badge hrl-badge--muted">No punch</span>
             <% end %>

data/app/views/hr_lite/admin/attendances/show.html.erb

@@ -80,7 +80,7 @@
       </div>
       <div class="hrl-field">
         <%= f.label :regularization_note, "Why is this being fixed? (required)" %>
-        <%= f.text_area :regularization_note %>
+        <%= f.text_area :regularization_note, required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= f.submit "Save fix", class: "hrl-btn hrl-btn--primary" %>

data/app/views/hr_lite/admin/benefits/index.html.erb

@@ -20,7 +20,8 @@
     <%= form_with url: hr_lite.enrol_admin_benefit_path(benefit), method: :post, local: true do %>
       <div class="hrl-field">
         <%= label_tag "enrol_user_#{benefit.id}", "Employee" %>
-        <%= select_tag :user_id, options_for_select(people), id: "enrol_user_#{benefit.id}" %>
+        <%= select_tag :user_id, options_for_select(people), id: "enrol_user_#{benefit.id}", include_blank: "Choose…", required: true,
+                       data: { hrl_filter: "Type a name to filter" } %>
       </div>
       <div class="hrl-field">
         <%= label_tag "enrol_on_#{benefit.id}", "Covered from" %>
@@ -49,10 +50,15 @@
               <td data-label="Since"><%= enrolment.enrolled_on.strftime("%d %b %Y") %></td>
               <td data-label="Dependants" class="hrl-num"><%= enrolment.dependants %></td>
               <td data-label="">
-                <%= form_with url: hr_lite.unenrol_admin_benefit_path(enrolment.benefit), method: :post do %>
+                <% if enrolment.ended_on %>
+                  <p class="hrl-small">Cover ends <%= enrolment.ended_on.strftime("%d %b %Y") %></p>
+                <% end %>
+                <%= form_with url: hr_lite.unenrol_admin_benefit_path(enrolment.benefit), method: :post, class: "hrl-row",
+                              data: { turbo_confirm: "End #{enrolment.benefit.name} for #{hr_display_name(enrolment.user)} on the date picked?" } do %>
                   <%= hidden_field_tag :user_id, enrolment.user_id %>
-                  <%= date_field_tag :ended_on, Date.current, class: "hrl-input", "aria-label": "Last day of cover" %>
-                  <%= submit_tag "End cover", class: "hrl-btn" %>
+                  <%= label_tag "ended-on-#{enrolment.id}", "Last day of cover", class: "hrl-small" %>
+                  <%= date_field_tag :ended_on, enrolment.ended_on || Date.current, id: "ended-on-#{enrolment.id}", class: "hrl-input" %>
+                  <%= submit_tag enrolment.ended_on ? "Change end" : "End cover", class: "hrl-btn" %>
                 <% end %>
               </td>
             </tr>

data/app/views/hr_lite/admin/comp_off_requests/show.html.erb

@@ -51,7 +51,7 @@
     <%= form_with url: hr_lite.reject_admin_comp_off_request_path(@request), method: :post, local: true do |f| %>
       <div class="hrl-field">
         <%= f.label :decision_note, "Reason (required)", for: "reject_note" %>
-        <%= f.text_area :decision_note, id: "reject_note" %>
+        <%= f.text_area :decision_note, id: "reject_note", required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= f.button "Reject", type: :submit, class: "hrl-btn hrl-btn--danger" %>

data/app/views/hr_lite/admin/documents/index.html.erb

@@ -35,7 +35,7 @@
               </td>
               <td data-label="File">
                 <% if doc.readable_by?(hr_current_user) && doc.file.attached? %>
-                  <a class="hrl-small" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
+                  <a class="hrl-btn" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
                 <% else %>
                   <span class="hrl-small hrl-muted">Not yours to open</span>
                 <% end %>
@@ -44,7 +44,7 @@
                 <%= button_to "Verify", hr_lite.verify_admin_document_path(doc),
                       method: :post, class: "hrl-btn hrl-btn--primary" %>
                 <%= form_with url: hr_lite.reject_admin_document_path(doc), method: :post, local: true do %>
-                  <%= text_field_tag :note, nil, placeholder: "What is wrong with it", class: "hrl-input" %>
+                  <%= text_field_tag :note, nil, placeholder: "What is wrong with it", class: "hrl-input", required: true %>
                   <%= submit_tag "Reject", class: "hrl-btn" %>
                 <% end %>
               </td>

data/app/views/hr_lite/admin/employees/show.html.erb

@@ -30,7 +30,8 @@
       <dt>Proposed last day</dt><dd><%= @pending_resignation.proposed_last_day.strftime("%d %B %Y") %></dd>
       <% if @pending_resignation.reason.present? %><dt>Reason</dt><dd><%= @pending_resignation.reason %></dd><% end %>
     </dl>
-    <%= form_with url: hr_lite.accept_admin_resignation_path(@pending_resignation), method: :post, local: true do %>
+    <%= form_with url: hr_lite.accept_admin_resignation_path(@pending_resignation), method: :post, local: true,
+                  data: { turbo_confirm: "Accept #{hr_display_name(@profile.user)}'s resignation? Payroll and attendance end on the last day you set." } do %>
       <div class="hrl-field">
         <label for="res_last_day">Confirm last working day</label>
         <input type="date" id="res_last_day" name="last_day" class="hrl-input"

data/app/views/hr_lite/admin/expense_categories/index.html.erb

@@ -18,7 +18,7 @@
               <td data-label="Monthly cap" class="hrl-num"><%= category.uncapped? ? "No cap" : hrl_money(category.monthly_cap) %></td>
               <td data-label="Receipt"><%= category.receipt_required ? "Required" : "Optional" %></td>
               <td data-label="Active"><%= category.active ? "Yes" : "No" %></td>
-              <td data-label=""><a class="hrl-small" href="<%= hr_lite.edit_admin_expense_category_path(category) %>">Edit</a></td>
+              <td data-label=""><a class="hrl-btn" href="<%= hr_lite.edit_admin_expense_category_path(category) %>">Edit</a></td>
             </tr>
           <% end %>
         </tbody>

data/app/views/hr_lite/admin/expenses/index.html.erb

@@ -26,6 +26,7 @@
                 <div class="hrl-small hrl-muted">
                   <%= expense.description %> · <%= expense.spent_on.strftime("%d %b %Y") %>
                 </div>
+                <% if expense.receipt.attached? %><a class="hrl-card__link" href="<%= hr_lite.receipt_admin_expense_path(expense) %>">Open receipt</a><% end %>
               </td>
               <td data-label="Amount" class="hrl-num"><%= hrl_money(expense.amount) %></td>
               <td data-label="">
@@ -33,8 +34,9 @@
                   <%= form_with url: hr_lite.approve_admin_expense_path(expense), method: :post do %>
                     <%= submit_tag "Approve", class: "hrl-btn hrl-btn--primary" %>
                   <% end %>
-                  <%= form_with url: hr_lite.reject_admin_expense_path(expense), method: :post do %>
-                    <%= text_field_tag :decision_note, nil, placeholder: "Why not", class: "hrl-input" %>
+                  <%= form_with url: hr_lite.reject_admin_expense_path(expense), method: :post, class: "hrl-row hrl-mt" do %>
+                    <%= label_tag "reject-expense-#{expense.id}", "Reason to reject", class: "hrl-sr-only" %>
+                    <%= text_field_tag :decision_note, nil, id: "reject-expense-#{expense.id}", placeholder: "Reason to reject", required: true, class: "hrl-input" %>
                     <%= submit_tag "Reject", class: "hrl-btn" %>
                   <% end %>
                 <% elsif expense.approved? %>

data/app/views/hr_lite/admin/holidays/index.html.erb

@@ -58,7 +58,8 @@
           <%= select_tag :office_location_id, options_for_select(@offices), include_blank: "All offices", id: "bulk-office", data: { hrl_filter: ("Type an office" if @offices.size > 5) } %></div>
       <% end %>
       <div class="hrl-field">
-        <textarea name="lines" class="hrl-input" rows="6" placeholder="2026-11-09, Diwali&#10;2026-03-04, Holi"></textarea>
+        <label for="bulk-lines">One holiday a line: date, name</label>
+        <textarea name="lines" id="bulk-lines" class="hrl-input" rows="6" placeholder="2026-11-09, Diwali&#10;2026-03-04, Holi"></textarea>
       </div>
       <div class="hrl-form-actions">
         <button type="submit" class="hrl-btn hrl-btn--primary">Add all</button>

data/app/views/hr_lite/admin/hr_requests/index.html.erb

@@ -21,7 +21,7 @@
           <% @requests.each do |request| %>
             <tr>
               <td data-label="Request">
-                <a href="<%= hr_lite.admin_hr_request_path(request) %>"><%= request.subject %></a>
+                <a class="hrl-card__link" href="<%= hr_lite.admin_hr_request_path(request) %>"><%= request.subject %></a>
                 <div class="hrl-small hrl-muted"><%= request.category_label %></div>
               </td>
               <td data-label="Who"><%= hr_display_name(request.user) %></td>
@@ -29,7 +29,7 @@
                 <%= request.assigned_to ? hr_display_name(request.assigned_to) : "—" %>
               </td>
               <td data-label="">
-                <a class="hrl-small" href="<%= hr_lite.admin_hr_request_path(request) %>">Open</a>
+                <a class="hrl-btn" href="<%= hr_lite.admin_hr_request_path(request) %>">Open</a>
               </td>
             </tr>
           <% end %>

data/app/views/hr_lite/admin/hr_requests/show.html.erb

@@ -21,7 +21,7 @@
     <%= form_with url: hr_lite.resolve_admin_hr_request_path(@request), method: :post do %>
       <div class="hrl-field">
         <%= label_tag :resolution, "What you did" %>
-        <%= text_area_tag :resolution, nil, rows: 4 %>
+        <%= text_area_tag :resolution, nil, rows: 4, required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= submit_tag "Send answer", class: "hrl-btn hrl-btn--primary" %>

data/app/views/hr_lite/admin/leave_requests/show.html.erb

@@ -76,7 +76,7 @@
     <%= form_with url: hr_lite.reject_admin_leave_request_path(@request), method: :post, local: true do %>
       <div class="hrl-field">
         <label for="reject_note">Reason (required)</label>
-        <textarea name="decision_note" id="reject_note" class="hrl-input"></textarea>
+        <textarea name="decision_note" id="reject_note" class="hrl-input" required></textarea>
       </div>
       <div class="hrl-form-actions">
         <button class="hrl-btn hrl-btn--danger" type="submit">Reject</button>

data/app/views/hr_lite/admin/leave_types/index.html.erb

@@ -23,7 +23,7 @@
             <td data-label="Carry cap" class="hrl-num"><%= type.carry_forward_cap.to_f %></td>
             <td data-label="Paid"><%= type.paid ? "Yes" : "No" %></td>
             <td data-label="">
-              <a class="hrl-small" href="<%= hr_lite.edit_admin_leave_type_path(type) %>">Edit</a>
+              <a class="hrl-btn" href="<%= hr_lite.edit_admin_leave_type_path(type) %>">Edit</a>
             </td>
           </tr>
         <% end %>
@@ -36,5 +36,5 @@
   <a class="hrl-btn" href="<%= hr_lite.admin_office_locations_path %>">Office locations</a>
   <a class="hrl-btn" href="<%= hr_lite.admin_holidays_path %>">Holidays</a>
   <a class="hrl-btn" href="<%= hr_lite.admin_expense_categories_path %>">Expense categories</a>
-  <a class="hrl-btn" href="<%= hr_lite.edit_admin_setting_path %>">Weekend policy</a>
+  <a class="hrl-btn" href="<%= hr_lite.edit_admin_setting_path %>">HR settings</a>
 </div>

data/app/views/hr_lite/admin/loans/new.html.erb

@@ -13,7 +13,7 @@
       <%= f.label :user_id, "Employee" %>
       <%= f.select :user_id, options_for_select(HrLite.employees.map { |u| [ hr_display_name(u), u.id ] },
                                                 @loan.user_id),
-                   {}, data: { hrl_filter: "Type a name to filter" } %>
+                   { include_blank: "Choose…" }, required: true, data: { hrl_filter: "Type a name to filter" } %>
     </div>
     <div class="hrl-field">
       <%= f.label :principal, "Amount lent (₹)" %>

data/app/views/hr_lite/admin/office_locations/index.html.erb

@@ -18,7 +18,7 @@
               <td data-label="Coordinates"><%= office.lat %>, <%= office.lng %></td>
               <td data-label="Radius" class="hrl-num"><%= office.radius_m %> m</td>
               <td data-label="Active"><%= office.active ? "Yes" : "No" %></td>
-              <td data-label=""><a class="hrl-small" href="<%= hr_lite.edit_admin_office_location_path(office) %>">Edit</a></td>
+              <td data-label=""><a class="hrl-btn" href="<%= hr_lite.edit_admin_office_location_path(office) %>">Edit</a></td>
             </tr>
           <% end %>
         </tbody>