hr_lite 0.52.0 → 0.54.0

data/app/helpers/hr_lite/application_helper.rb

@@ -44,7 +44,7 @@ module HrLite
         { label: "Attendance fixes", path: :admin_regularization_requests_path, match: [ "/admin/regularization_requests" ], if: OPS,
           queue: -> { hrl_queue(HrLite::RegularizationRequest.pending, "attendance.manage") } },
         { label: "WFH", path: :admin_wfh_requests_path, match: [ "/admin/wfh_requests" ], if: OPS,
-          queue: -> { hrl_queue(HrLite::WfhRequest.pending, "attendance.manage") } },
+          queue: -> { hrl_queue(HrLite::WfhRequest.pending.overlapping(Date.current, Date.current + HrLite::WfhRequest::MAX_DAYS_AHEAD), "attendance.manage") } },
         { label: "Home locations", path: :admin_work_locations_path, match: [ "/admin/work_locations" ], if: OPS,
           queue: -> { hrl_queue(HrLite::WorkLocation.pending, "attendance.manage") } },
         { label: "Claims", path: :admin_expenses_path, match: [ "/admin/expenses" ], if: -> { hr_can?("expense.approve", scope: :team) },
@@ -91,7 +91,8 @@ module HrLite
         { label: "Manage policies", path: :admin_policies_path, match: [ "/admin/policies" ], if: -> { hr_can?("policy.manage", scope: :all) } }
       ] },
       { label: "Admin", divider: true, tabs: [
-        { label: "Settings", path: :admin_leave_types_path, match: [ "/admin/leave_types", "/admin/office_locations", "/admin/holidays", "/admin/setting", "/admin/expense_categories" ], if: LEAD },
+        { label: "Settings", path: :admin_leave_types_path, match: [ "/admin/leave_types", "/admin/office_locations", "/admin/holidays", "/admin/expense_categories" ], if: LEAD },
+        { label: "HR settings", path: :edit_admin_setting_path, match: [ "/admin/setting" ], if: LEAD },
         { label: "Roles", path: :admin_roles_path, match: [ "/admin/roles" ], if: -> { hr_can?("role.manage", scope: :all) } },
         { label: "Statutory rates", path: :admin_statutory_rate_cards_path, match: [ "/admin/statutory_rate_cards" ], if: SUPER },
         { label: "Reports", path: :admin_reports_path, match: [ "/admin/reports" ], if: -> { hr_can?("expense.approve", scope: :all) || %w[leave.view attendance.view profile.view].any? { |key| hr_can?(key, scope: :team) } } },
@@ -151,6 +152,24 @@ module HrLite
     # What a queue page lets this viewer decide: their reach, never their own requests.
     def hrl_queue(relation, key) = hr_access.scope_relation(relation, key).where.not(user_id: hr_current_user.id)
 
+    # The Inbox badge's number; Home and the overview board show the same one.
+    def hrl_inbox_count
+      inbox = hrl_sections.find { |s| s[:label] == "Inbox" }
+      inbox ? hrl_waiting(inbox).to_i : 0
+    end
+
+    # One queued request in words, and where it is decided.
+    def hrl_inbox_item(tab, record)
+      case record
+      when HrLite::LeaveRequest
+        [ "#{record.leave_type.name}, #{record.date_range_label} · #{pluralize(hrl_days(record.days_count), 'day')}", hr_lite.admin_leave_request_path(record) ]
+      when HrLite::CompOffRequest then [ "Comp-off for #{record.date_worked.strftime('%a %-d %b')}", hr_lite.admin_comp_off_request_path(record) ]
+      when HrLite::RegularizationRequest then [ "Attendance fix, #{record.date.strftime('%a %-d %b')}", hr_lite.admin_regularization_request_path(record) ]
+      when HrLite::WfhRequest then [ "WFH, #{record.dates_label}", hr_lite.admin_wfh_request_path(record) ]
+      else [ tab[:label], hr_lite.public_send(tab[:path]) ]
+      end
+    end
+
     # Everything waiting in this viewer's queues, oldest first, as [tab, record].
     def hrl_inbox_rows(limit = 50)
       inbox = hrl_sections.find { |s| s[:label] == "Inbox" } or return []

data/app/models/hr_lite/attendance_record.rb

@@ -57,9 +57,11 @@ module HrLite
       EmployeeProfile.day_minutes_for(user_id, on: date) unless HrLite.config.work_hours.nil? || date.saturday?
     end
 
-    # Hours worked, not the clock: an early start counts.
+    # Hours worked, not the clock: an early start counts. The day's penalty
+    # minutes count too, the same rule as required_check_out_at, so the card
+    # never says "day done" above "short by 20m".
     def short?
-      worked_under?(required_minutes)
+      worked_under?(required_minutes && required_minutes + penalty_minutes)
     end
 
     def below_half_day?
@@ -70,10 +72,11 @@ module HrLite
     def required_check_out_at
       return unless HrLite.config.attendance_slots && check_in_at
 
-      extra = AttendancePenalty.active.where(user_id: user_id, date: date).sum(:minutes)
-      check_in_at + (EmployeeProfile.day_minutes_for(user_id, on: date) + extra).minutes
+      check_in_at + (EmployeeProfile.day_minutes_for(user_id, on: date) + penalty_minutes).minutes
     end
 
+    def penalty_minutes = AttendancePenalty.active.where(user_id: user_id, date: date).sum(:minutes)
+
     def worked_under?(minutes) = !!(minutes && worked_duration && worked_duration < minutes.minutes)
 
     # Check in again after checking out: once a day, inside the hours HR sets in

data/app/models/hr_lite/salary_slip.rb

@@ -61,8 +61,9 @@ module HrLite
       row ? Money.d(row["amount"]) : BigDecimal(0)
     end
 
+    # Bump the version when the PDF template changes, or the old layout serves until the cache expires.
     def pdf_cache_key
-      [ "hr_lite_slip", id, updated_at.to_i, payroll_run.status,
+      [ "hr_lite_slip_v2", id, updated_at.to_i, payroll_run.status,
         user_profile&.updated_at.to_i ].join("/")
     end
 

data/app/models/hr_lite/statutory_rate_card_record.rb

@@ -7,6 +7,9 @@ module HrLite
 
     self.table_name = "hr_lite_statutory_rate_cards"
 
+    # Shipped cards count as verified so payroll can auto-approve, but no person checked them.
+    SHIPPED_SIGN_OFF = "Shipped defaults, not checked by a person".freeze
+
     validates :effective_from, presence: true, uniqueness: true
     validate :effective_from_opens_a_financial_year
     validate :carries_every_figure_payroll_reads
@@ -22,6 +25,9 @@ module HrLite
 
     def verified? = verified_by.present? && verified_on.present?
 
+    # Cards seeded before this read "hr_lite 0.52.0 (official source …)": a version is not a sign-off.
+    def verified_by = super&.start_with?("hr_lite ") ? SHIPPED_SIGN_OFF : super
+
     # The shape SlipBuilder and the calculators expect: symbol keys and
     # BigDecimal everywhere, because JSON gives back strings and floats and
     # a float has no business in a PF calculation.

data/app/views/hr_lite/admin/attendances/index.html.erb

@@ -15,10 +15,8 @@
 
 <div class="hrl-kpis">
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @records.values.count { |r| r.check_in_at } %></div><div class="hrl-kpi__label">Checked in</div></div>
-  <%# Derived from the same predicate as "Checked in". Counting rows instead
-      dropped a record with no check-in out of BOTH tiles, so the numbers
-      quietly stopped adding up to the headcount. %>
-  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @employees.size - @records.values.count { |r| r.check_in_at } %></div><div class="hrl-kpi__label">No punch</div></div>
+  <%# Expected in and not checked in: people on leave, a holiday or a weekly off are not counted. %>
+  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @employees.count { |u| @days[u.id]&.kind == :absent } %></div><div class="hrl-kpi__label">No punch</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @flagged_count %></div><div class="hrl-kpi__label">Flagged</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @records.values.count { |r| r.check_in_at && r.check_out_at.nil? } %></div><div class="hrl-kpi__label">Still in</div></div>
 </div>
@@ -71,6 +69,8 @@
               <span class="hrl-badge hrl-badge--bad">Flagged</span> <span class="hrl-small"><%= record.flag_note %></span>
             <% elsif record&.check_in_at %>
               <span class="hrl-badge hrl-badge--ok"><%= record.status.humanize %><%= " (#{record.half_day_part} half)" if record.half_day_part %></span>
+            <% elsif @days[employee.id] %>
+              <%= hrl_team_status(@days[employee.id]) %>
             <% else %>
               <span class="hrl-badge hrl-badge--muted">No punch</span>
             <% end %>

data/app/views/hr_lite/admin/attendances/show.html.erb

@@ -80,7 +80,7 @@
       </div>
       <div class="hrl-field">
         <%= f.label :regularization_note, "Why is this being fixed? (required)" %>
-        <%= f.text_area :regularization_note %>
+        <%= f.text_area :regularization_note, required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= f.submit "Save fix", class: "hrl-btn hrl-btn--primary" %>

data/app/views/hr_lite/admin/benefits/index.html.erb

@@ -20,7 +20,8 @@
     <%= form_with url: hr_lite.enrol_admin_benefit_path(benefit), method: :post, local: true do %>
       <div class="hrl-field">
         <%= label_tag "enrol_user_#{benefit.id}", "Employee" %>
-        <%= select_tag :user_id, options_for_select(people), id: "enrol_user_#{benefit.id}" %>
+        <%= select_tag :user_id, options_for_select(people), id: "enrol_user_#{benefit.id}", include_blank: "Choose…", required: true,
+                       data: { hrl_filter: "Type a name to filter" } %>
       </div>
       <div class="hrl-field">
         <%= label_tag "enrol_on_#{benefit.id}", "Covered from" %>
@@ -49,10 +50,15 @@
               <td data-label="Since"><%= enrolment.enrolled_on.strftime("%d %b %Y") %></td>
               <td data-label="Dependants" class="hrl-num"><%= enrolment.dependants %></td>
               <td data-label="">
-                <%= form_with url: hr_lite.unenrol_admin_benefit_path(enrolment.benefit), method: :post do %>
+                <% if enrolment.ended_on %>
+                  <p class="hrl-small">Cover ends <%= enrolment.ended_on.strftime("%d %b %Y") %></p>
+                <% end %>
+                <%= form_with url: hr_lite.unenrol_admin_benefit_path(enrolment.benefit), method: :post, class: "hrl-row",
+                              data: { turbo_confirm: "End #{enrolment.benefit.name} for #{hr_display_name(enrolment.user)} on the date picked?" } do %>
                   <%= hidden_field_tag :user_id, enrolment.user_id %>
-                  <%= date_field_tag :ended_on, Date.current, class: "hrl-input", "aria-label": "Last day of cover" %>
-                  <%= submit_tag "End cover", class: "hrl-btn" %>
+                  <%= label_tag "ended-on-#{enrolment.id}", "Last day of cover", class: "hrl-small" %>
+                  <%= date_field_tag :ended_on, enrolment.ended_on || Date.current, id: "ended-on-#{enrolment.id}", class: "hrl-input" %>
+                  <%= submit_tag enrolment.ended_on ? "Change end" : "End cover", class: "hrl-btn" %>
                 <% end %>
               </td>
             </tr>

data/app/views/hr_lite/admin/comp_off_requests/show.html.erb

@@ -51,7 +51,7 @@
     <%= form_with url: hr_lite.reject_admin_comp_off_request_path(@request), method: :post, local: true do |f| %>
       <div class="hrl-field">
         <%= f.label :decision_note, "Reason (required)", for: "reject_note" %>
-        <%= f.text_area :decision_note, id: "reject_note" %>
+        <%= f.text_area :decision_note, id: "reject_note", required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= f.button "Reject", type: :submit, class: "hrl-btn hrl-btn--danger" %>

data/app/views/hr_lite/admin/documents/index.html.erb

@@ -35,7 +35,7 @@
               </td>
               <td data-label="File">
                 <% if doc.readable_by?(hr_current_user) && doc.file.attached? %>
-                  <a class="hrl-small" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
+                  <a class="hrl-btn" href="<%= hr_lite.download_document_path(doc) %>">Open</a>
                 <% else %>
                   <span class="hrl-small hrl-muted">Not yours to open</span>
                 <% end %>
@@ -44,7 +44,7 @@
                 <%= button_to "Verify", hr_lite.verify_admin_document_path(doc),
                       method: :post, class: "hrl-btn hrl-btn--primary" %>
                 <%= form_with url: hr_lite.reject_admin_document_path(doc), method: :post, local: true do %>
-                  <%= text_field_tag :note, nil, placeholder: "What is wrong with it", class: "hrl-input" %>
+                  <%= text_field_tag :note, nil, placeholder: "What is wrong with it", class: "hrl-input", required: true %>
                   <%= submit_tag "Reject", class: "hrl-btn" %>
                 <% end %>
               </td>

data/app/views/hr_lite/admin/employees/show.html.erb

@@ -30,7 +30,8 @@
       <dt>Proposed last day</dt><dd><%= @pending_resignation.proposed_last_day.strftime("%d %B %Y") %></dd>
       <% if @pending_resignation.reason.present? %><dt>Reason</dt><dd><%= @pending_resignation.reason %></dd><% end %>
     </dl>
-    <%= form_with url: hr_lite.accept_admin_resignation_path(@pending_resignation), method: :post, local: true do %>
+    <%= form_with url: hr_lite.accept_admin_resignation_path(@pending_resignation), method: :post, local: true,
+                  data: { turbo_confirm: "Accept #{hr_display_name(@profile.user)}'s resignation? Payroll and attendance end on the last day you set." } do %>
       <div class="hrl-field">
         <label for="res_last_day">Confirm last working day</label>
         <input type="date" id="res_last_day" name="last_day" class="hrl-input"

data/app/views/hr_lite/admin/expense_categories/index.html.erb

@@ -18,7 +18,7 @@
               <td data-label="Monthly cap" class="hrl-num"><%= category.uncapped? ? "No cap" : hrl_money(category.monthly_cap) %></td>
               <td data-label="Receipt"><%= category.receipt_required ? "Required" : "Optional" %></td>
               <td data-label="Active"><%= category.active ? "Yes" : "No" %></td>
-              <td data-label=""><a class="hrl-small" href="<%= hr_lite.edit_admin_expense_category_path(category) %>">Edit</a></td>
+              <td data-label=""><a class="hrl-btn" href="<%= hr_lite.edit_admin_expense_category_path(category) %>">Edit</a></td>
             </tr>
           <% end %>
         </tbody>

data/app/views/hr_lite/admin/expenses/index.html.erb

@@ -26,6 +26,7 @@
                 <div class="hrl-small hrl-muted">
                   <%= expense.description %> · <%= expense.spent_on.strftime("%d %b %Y") %>
                 </div>
+                <% if expense.receipt.attached? %><a class="hrl-card__link" href="<%= hr_lite.receipt_admin_expense_path(expense) %>">Open receipt</a><% end %>
               </td>
               <td data-label="Amount" class="hrl-num"><%= hrl_money(expense.amount) %></td>
               <td data-label="">
@@ -33,8 +34,9 @@
                   <%= form_with url: hr_lite.approve_admin_expense_path(expense), method: :post do %>
                     <%= submit_tag "Approve", class: "hrl-btn hrl-btn--primary" %>
                   <% end %>
-                  <%= form_with url: hr_lite.reject_admin_expense_path(expense), method: :post do %>
-                    <%= text_field_tag :decision_note, nil, placeholder: "Why not", class: "hrl-input" %>
+                  <%= form_with url: hr_lite.reject_admin_expense_path(expense), method: :post, class: "hrl-row hrl-mt" do %>
+                    <%= label_tag "reject-expense-#{expense.id}", "Reason to reject", class: "hrl-sr-only" %>
+                    <%= text_field_tag :decision_note, nil, id: "reject-expense-#{expense.id}", placeholder: "Reason to reject", required: true, class: "hrl-input" %>
                     <%= submit_tag "Reject", class: "hrl-btn" %>
                   <% end %>
                 <% elsif expense.approved? %>

data/app/views/hr_lite/admin/holidays/index.html.erb

@@ -58,7 +58,8 @@
           <%= select_tag :office_location_id, options_for_select(@offices), include_blank: "All offices", id: "bulk-office", data: { hrl_filter: ("Type an office" if @offices.size > 5) } %></div>
       <% end %>
       <div class="hrl-field">
-        <textarea name="lines" class="hrl-input" rows="6" placeholder="2026-11-09, Diwali&#10;2026-03-04, Holi"></textarea>
+        <label for="bulk-lines">One holiday a line: date, name</label>
+        <textarea name="lines" id="bulk-lines" class="hrl-input" rows="6" placeholder="2026-11-09, Diwali&#10;2026-03-04, Holi"></textarea>
       </div>
       <div class="hrl-form-actions">
         <button type="submit" class="hrl-btn hrl-btn--primary">Add all</button>

data/app/views/hr_lite/admin/hr_requests/index.html.erb

@@ -21,7 +21,7 @@
           <% @requests.each do |request| %>
             <tr>
               <td data-label="Request">
-                <a href="<%= hr_lite.admin_hr_request_path(request) %>"><%= request.subject %></a>
+                <a class="hrl-card__link" href="<%= hr_lite.admin_hr_request_path(request) %>"><%= request.subject %></a>
                 <div class="hrl-small hrl-muted"><%= request.category_label %></div>
               </td>
               <td data-label="Who"><%= hr_display_name(request.user) %></td>
@@ -29,7 +29,7 @@
                 <%= request.assigned_to ? hr_display_name(request.assigned_to) : "—" %>
               </td>
               <td data-label="">
-                <a class="hrl-small" href="<%= hr_lite.admin_hr_request_path(request) %>">Open</a>
+                <a class="hrl-btn" href="<%= hr_lite.admin_hr_request_path(request) %>">Open</a>
               </td>
             </tr>
           <% end %>

data/app/views/hr_lite/admin/hr_requests/show.html.erb

@@ -21,7 +21,7 @@
     <%= form_with url: hr_lite.resolve_admin_hr_request_path(@request), method: :post do %>
       <div class="hrl-field">
         <%= label_tag :resolution, "What you did" %>
-        <%= text_area_tag :resolution, nil, rows: 4 %>
+        <%= text_area_tag :resolution, nil, rows: 4, required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= submit_tag "Send answer", class: "hrl-btn hrl-btn--primary" %>

data/app/views/hr_lite/admin/leave_requests/show.html.erb

@@ -76,7 +76,7 @@
     <%= form_with url: hr_lite.reject_admin_leave_request_path(@request), method: :post, local: true do %>
       <div class="hrl-field">
         <label for="reject_note">Reason (required)</label>
-        <textarea name="decision_note" id="reject_note" class="hrl-input"></textarea>
+        <textarea name="decision_note" id="reject_note" class="hrl-input" required></textarea>
       </div>
       <div class="hrl-form-actions">
         <button class="hrl-btn hrl-btn--danger" type="submit">Reject</button>

data/app/views/hr_lite/admin/leave_types/index.html.erb

@@ -23,7 +23,7 @@
             <td data-label="Carry cap" class="hrl-num"><%= type.carry_forward_cap.to_f %></td>
             <td data-label="Paid"><%= type.paid ? "Yes" : "No" %></td>
             <td data-label="">
-              <a class="hrl-small" href="<%= hr_lite.edit_admin_leave_type_path(type) %>">Edit</a>
+              <a class="hrl-btn" href="<%= hr_lite.edit_admin_leave_type_path(type) %>">Edit</a>
             </td>
           </tr>
         <% end %>
@@ -36,5 +36,5 @@
   <a class="hrl-btn" href="<%= hr_lite.admin_office_locations_path %>">Office locations</a>
   <a class="hrl-btn" href="<%= hr_lite.admin_holidays_path %>">Holidays</a>
   <a class="hrl-btn" href="<%= hr_lite.admin_expense_categories_path %>">Expense categories</a>
-  <a class="hrl-btn" href="<%= hr_lite.edit_admin_setting_path %>">Weekend policy</a>
+  <a class="hrl-btn" href="<%= hr_lite.edit_admin_setting_path %>">HR settings</a>
 </div>

data/app/views/hr_lite/admin/loans/new.html.erb

@@ -13,7 +13,7 @@
       <%= f.label :user_id, "Employee" %>
       <%= f.select :user_id, options_for_select(HrLite.employees.map { |u| [ hr_display_name(u), u.id ] },
                                                 @loan.user_id),
-                   {}, data: { hrl_filter: "Type a name to filter" } %>
+                   { include_blank: "Choose…" }, required: true, data: { hrl_filter: "Type a name to filter" } %>
     </div>
     <div class="hrl-field">
       <%= f.label :principal, "Amount lent (₹)" %>

data/app/views/hr_lite/admin/office_locations/index.html.erb

@@ -18,7 +18,7 @@
               <td data-label="Coordinates"><%= office.lat %>, <%= office.lng %></td>
               <td data-label="Radius" class="hrl-num"><%= office.radius_m %> m</td>
               <td data-label="Active"><%= office.active ? "Yes" : "No" %></td>
-              <td data-label=""><a class="hrl-small" href="<%= hr_lite.edit_admin_office_location_path(office) %>">Edit</a></td>
+              <td data-label=""><a class="hrl-btn" href="<%= hr_lite.edit_admin_office_location_path(office) %>">Edit</a></td>
             </tr>
           <% end %>
         </tbody>

data/app/views/hr_lite/admin/overview/index.html.erb

@@ -3,50 +3,29 @@
   <h1 class="hrl-page__title">HR overview</h1>
 </div>
 
+<%# The Inbox badge's count and rows, so the board never counts what the Inbox hides. %>
+<% pending = hrl_inbox_count %>
 <div class="hrl-kpis">
-  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @kpis[:pending] %></div><div class="hrl-kpi__label">Pending approvals</div></div>
+  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= pending %></div><div class="hrl-kpi__label">Pending approvals</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @kpis[:on_leave] %></div><div class="hrl-kpi__label">On leave today</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @kpis[:flagged] %></div><div class="hrl-kpi__label">Flagged punches</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @kpis[:missing_checkout] %></div><div class="hrl-kpi__label">Missing checkouts</div></div>
 </div>
 
-<% if @query.empty? %>
+<% if pending.zero? && @kpis.except(:pending).values.all?(&:zero?) %>
   <p class="hrl-card hrl-card--empty">All present and accounted for.</p>
 <% else %>
-  <% if @kpis[:pending].positive? %>
+  <% if pending.positive? %>
     <section class="hrl-card">
       <h2 class="hrl-card__title">Pending approvals</h2>
-      <% @query.pending_requests.limit(HrLite::Admin::OverviewController::SECTION_CAP).each do |request| %>
+      <% hrl_inbox_rows(HrLite::Admin::OverviewController::SECTION_CAP).each do |tab, request| %>
+        <% what, href = hrl_inbox_item(tab, request) %>
         <div class="hrl-feed__item">
-          <div class="hrl-feed__body">
-            <strong><%= hr_display_name(request.user) %></strong>
-            — <%= request.leave_type.name %>, <%= request.date_range_label %> (<%= hrl_days(request.days_count) %> d)
-          </div>
-          <a class="hrl-btn" href="<%= hr_lite.admin_leave_request_path(request) %>">Decide</a>
-        </div>
-      <% end %>
-      <%# Comp-off and regularization are approvals too. Listing leave alone
-          left both queues invisible on the board that exists to surface work. %>
-      <% @query.pending_comp_offs.limit(HrLite::Admin::OverviewController::SECTION_CAP).each do |request| %>
-        <div class="hrl-feed__item">
-          <div class="hrl-feed__body">
-            <strong><%= hr_display_name(request.user) %></strong>
-            — comp-off for <%= request.date_worked.strftime("%d %b") %>
-            (<%= hrl_days(request.credit_days) %> d)
-          </div>
-          <a class="hrl-btn" href="<%= hr_lite.admin_comp_off_request_path(request) %>">Decide</a>
-        </div>
-      <% end %>
-      <% @query.pending_regularizations.limit(HrLite::Admin::OverviewController::SECTION_CAP).each do |request| %>
-        <div class="hrl-feed__item">
-          <div class="hrl-feed__body">
-            <strong><%= hr_display_name(request.user) %></strong>
-            — attendance fix for <%= request.date.strftime("%d %b") %>
-          </div>
-          <a class="hrl-btn" href="<%= hr_lite.admin_regularization_request_path(request) %>">Decide</a>
+          <div class="hrl-feed__body"><strong><%= hr_display_name(request.user) %></strong> — <%= what %></div>
+          <a class="hrl-btn" href="<%= href %>">Decide</a>
         </div>
       <% end %>
-      <a class="hrl-card__link" href="<%= hr_lite.admin_leave_requests_path %>">All requests</a>
+      <a class="hrl-card__link" href="<%= hr_lite.approvals_path %>">All requests</a>
     </section>
   <% end %>
 

data/app/views/hr_lite/admin/payroll_line_items/new.html.erb

@@ -13,7 +13,8 @@
     <div class="hrl-field">
       <%= f.label :user_id, "Employee" %>
       <%= f.select :user_id, options_for_select(HrLite.employees.map { |u| [ hr_display_name(u), u.id ] },
-                                                @item.user_id) %>
+                                                @item.user_id),
+                   { include_blank: "Choose…" }, required: true, data: { hrl_filter: "Type a name to filter" } %>
     </div>
     <div class="hrl-field">
       <%= f.label :component_id, "Item" %>

data/app/views/hr_lite/admin/payroll_runs/index.html.erb

@@ -2,7 +2,7 @@
 <div class="hrl-page__head">
   <h1 class="hrl-page__title">Payroll runs</h1>
   <div class="hrl-page__actions">
-    <a class="hrl-btn hrl-btn--primary" href="<%= hr_lite.new_admin_payroll_run_path %>">New run</a>
+    <% if hr_can?("payroll.manage", scope: :all) %><a class="hrl-btn hrl-btn--primary" href="<%= hr_lite.new_admin_payroll_run_path %>">New run</a><% end %>
   </div>
 </div>
 

data/app/views/hr_lite/admin/payroll_runs/show.html.erb

@@ -7,11 +7,11 @@
   </div>
 </div>
 
-<div class="hrl-kpis">
+<div class="hrl-kpis hrl-kpis--money">
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= @slips.size %></div><div class="hrl-kpi__label">Slips</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= hrl_money(@run.total_gross) %></div><div class="hrl-kpi__label">Gross</div></div>
   <div class="hrl-kpi"><div class="hrl-kpi__value"><%= hrl_money(@run.total_net) %></div><div class="hrl-kpi__label">Net payout</div></div>
-  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= hrl_money(@run.total_employer_cost) %></div><div class="hrl-kpi__label">Employer cost</div></div>
+  <div class="hrl-kpi"><div class="hrl-kpi__value"><%= hrl_money(@run.total_employer_cost) %></div><div class="hrl-kpi__label">Employer contributions</div></div>
 </div>
 
 <% if @run.warnings.any? %>
@@ -29,12 +29,14 @@
     <% manager = hr_can?("payroll.manage", scope: :all) %>
     <% if manager && (@run.draft? || @run.review? || @run.processing?) %>
       <%= button_to @run.draft? ? "Compute" : "Recompute", hr_lite.compute_admin_payroll_run_path(@run),
-                    method: :post, class: "hrl-btn" %>
+                    method: :post, class: "hrl-btn",
+                    form: { data: { turbo_confirm: ("Recompute #{@run.label}? This clears #{hr_display_name(@run.first_approved_by)}'s approval." if @run.first_approved_by) } } %>
     <% end %>
     <% if @run.review? && hr_can?("payroll.approve", scope: :all) && @run.first_approved_by_id != hr_current_user.id %>
       <%= button_to @run.first_approved_by_id ? "Approve and publish" : "Approve", hr_lite.approve_admin_payroll_run_path(@run),
                     method: :post, class: "hrl-btn hrl-btn--primary",
-                    form: { data: { turbo_confirm: @run.first_approved_by_id ? "Approve #{@run.label}? This finalizes the run and publishes the slips." : "Approve #{@run.label}?" } } %>
+                    form: { data: { turbo_confirm: [ @run.first_approved_by_id ? "Approve #{@run.label}? This finalizes the run and publishes the slips." : "Approve #{@run.label}?",
+                                                     *("Blocking warnings: #{@run.blocking_warnings.join('; ')}" if @run.blocking_warnings.any?) ].join("\n\n") } } %>
     <% end %>
     <% if manager && @run.finalized? %>
       <%= button_to "Unlock", hr_lite.unlock_admin_payroll_run_path(@run), method: :post, class: "hrl-btn" %>

data/app/views/hr_lite/admin/performance_plans/_form.html.erb

@@ -22,7 +22,8 @@
       <div class="hrl-field"><%= f.label :outcome_note, "Outcome note" %><%= f.text_area :outcome_note, rows: 3 %></div>
     <% end %>
     <div class="hrl-form-actions">
-      <%= f.submit plan.persisted? ? "Save" : "Start PIP", class: "hrl-btn hrl-btn--primary" %>
+      <%= f.submit plan.persisted? ? "Save" : "Start PIP", class: "hrl-btn hrl-btn--primary",
+                   data: { turbo_confirm: ("Save? Passed or failed closes the plan for good and tells the employee." if plan.persisted?) } %>
       <a class="hrl-btn" href="<%= hr_lite.admin_performance_plans_path %>">Cancel</a>
     </div>
   <% end %>

data/app/views/hr_lite/admin/policies/index.html.erb

@@ -14,7 +14,7 @@
         <tbody>
           <% @policies.each do |policy| %>
             <tr>
-              <td data-label="Title"><%= policy.title %> <span class="hrl-badge hrl-badge--muted">v<%= policy.version %></span></td>
+              <td data-label="Title"><a class="hrl-card__link" href="<%= hr_lite.policy_path(policy) %>"><%= policy.title %></a> <span class="hrl-badge hrl-badge--muted">v<%= policy.version %></span></td>
               <td data-label="Kind"><%= policy.announcement? ? "Announcement" : "Policy" %></td>
               <td data-label="In force"><%= policy.effective_from.strftime("%d %b %Y") %></td>
               <td data-label="Still to acknowledge"><%= policy.announcement? ? "—" : policy.outstanding_for.count %></td>

data/app/views/hr_lite/admin/policies/new.html.erb

@@ -15,7 +15,8 @@
       <%= f.label :acknowledgement_required, "Policy — everyone must acknowledge it (untick for an announcement)" %>
     </div>
     <div class="hrl-form-actions">
-      <%= f.submit "Publish", class: "hrl-btn hrl-btn--primary" %>
+      <%= f.submit "Publish", class: "hrl-btn hrl-btn--primary",
+                   data: { turbo_confirm: "Publish and notify #{pluralize(HrLite.active_employees.size, 'person')} by email?" } %>
       <a class="hrl-btn" href="<%= hr_lite.admin_policies_path %>">Cancel</a>
     </div>
   <% end %>

data/app/views/hr_lite/admin/regularization_requests/show.html.erb

@@ -54,7 +54,7 @@
     <%= form_with url: hr_lite.reject_admin_regularization_request_path(@request), method: :post, local: true do |f| %>
       <div class="hrl-field">
         <%= f.label :decision_note, "Reason (required)", for: "reject_note" %>
-        <%= f.text_area :decision_note, id: "reject_note" %>
+        <%= f.text_area :decision_note, id: "reject_note", required: true %>
       </div>
       <div class="hrl-form-actions">
         <%= f.button "Reject", type: :submit, class: "hrl-btn hrl-btn--danger" %>

data/app/views/hr_lite/admin/roles/_form.html.erb

@@ -40,7 +40,8 @@
     <% end %>
 
     <div class="hrl-form-actions">
-      <%= f.submit "Save", class: "hrl-btn hrl-btn--primary" %>
+      <%= f.submit "Save", class: "hrl-btn hrl-btn--primary",
+                   data: { turbo_confirm: ("Save? Everyone holding #{role.name} gets these permissions at once." if role.persisted?) } %>
       <a class="hrl-btn" href="<%= hr_lite.admin_roles_path %>">Cancel</a>
     </div>
   <% end %>

data/app/views/hr_lite/admin/roles/edit.html.erb

@@ -38,13 +38,15 @@
     </div>
   <% end %>
 
-  <%= form_with url: hr_lite.admin_role_assignments_path(@role), method: :post, local: true do %>
+  <%= form_with url: hr_lite.admin_role_assignments_path(@role), method: :post, local: true,
+                data: { turbo_confirm: "Give the #{@role.name} role to the person you picked? Their access changes at once." } do %>
     <div class="hrl-field">
       <%= label_tag :user_id, "Add somebody to this role" %>
       <% held = @role.role_assignments.map(&:user_id) %>
       <%= select_tag :user_id,
             options_for_select(HrLite.employees.reject { |u| held.include?(u.id) }
-                                     .map { |u| [ hr_display_name(u), u.id ] }) %>
+                                     .map { |u| [ hr_display_name(u), u.id ] }),
+            include_blank: "Choose…", required: true, data: { hrl_filter: "Type a name to filter" } %>
     </div>
     <div class="hrl-form-actions">
       <%= submit_tag "Add", class: "hrl-btn hrl-btn--primary" %>

data/app/views/hr_lite/admin/roles/index.html.erb

@@ -39,7 +39,7 @@
               <% end %>
             </td>
             <td data-label="">
-              <a class="hrl-small" href="<%= hr_lite.edit_admin_role_path(role) %>">Edit</a>
+              <a class="hrl-btn" href="<%= hr_lite.edit_admin_role_path(role) %>">Edit</a>
             </td>
           </tr>
         <% end %>

data/app/views/hr_lite/admin/statutory_rate_cards/_form.html.erb

@@ -68,16 +68,20 @@
           the open-ended top rate.
         </p>
         <% slabs = Array(table["slabs"]) %>
-        <% (slabs + [ nil, nil ]).each_with_index do |row, index| %>
-          <div class="hrl-row">
+        <% num = ->(v) { v && number_with_precision(v, precision: 4, strip_insignificant_zeros: true) } %>
+        <div class="hrl-slabs">
+          <span class="hrl-small" aria-hidden="true">From ₹</span>
+          <span class="hrl-small" aria-hidden="true">Up to ₹</span>
+          <span class="hrl-small" aria-hidden="true">Rate (0.05 = 5%)</span>
+          <% (slabs + [ nil, nil ]).each_with_index do |row, index| %>
             <%= text_field_tag "statutory_rate_card[income_tax][#{regime}][slabs][#{index}][from]",
-                               row&.first, placeholder: "From ₹", inputmode: "decimal" %>
+                               num.(row&.first), class: "hrl-input", inputmode: "decimal", "aria-label": "Band #{index + 1} from ₹" %>
             <%= text_field_tag "statutory_rate_card[income_tax][#{regime}][slabs][#{index}][to]",
-                               row&.at(1), placeholder: "Up to ₹ (blank = top)", inputmode: "decimal" %>
+                               num.(row&.at(1)), class: "hrl-input", inputmode: "decimal", "aria-label": "Band #{index + 1} up to ₹ (blank = top)" %>
             <%= text_field_tag "statutory_rate_card[income_tax][#{regime}][slabs][#{index}][rate]",
-                               row&.last, placeholder: "Rate (0.05)", inputmode: "decimal" %>
-          </div>
-        <% end %>
+                               num.(row&.last), class: "hrl-input", inputmode: "decimal", "aria-label": "Band #{index + 1} rate" %>
+          <% end %>
+        </div>
       </fieldset>
     <% end %>
 

data/app/views/hr_lite/admin/tax_declarations/show.html.erb

@@ -48,6 +48,7 @@
     <% end %>
     <div class="hrl-form-actions">
       <%= f.submit "Record amounts", class: "hrl-btn" %>
+      <%= f.submit "Record and verify", name: "verify", class: "hrl-btn" %>
     </div>
   </section>
 <% end %>
@@ -55,16 +56,17 @@
 <section class="hrl-card">
   <h2 class="hrl-card__title">Decide</h2>
   <div class="hrl-row">
+    <% unproven = @declaration.tax_declaration_items.reject { |item| item.proofs.attached? }.map { |item| item.section_label.split(" — ").first } %>
     <%= button_to "Accept all and verify", hr_lite.accept_all_admin_tax_declaration_path(@declaration),
-          method: :post, class: "hrl-btn hrl-btn--primary" %>
-    <%= button_to "Verify the amounts recorded above", hr_lite.verify_admin_tax_declaration_path(@declaration),
-          method: :post, class: "hrl-btn" %>
+          method: :post, class: "hrl-btn hrl-btn--primary",
+          form: { data: { turbo_confirm: [ "Accept every claimed amount and verify? The employee can no longer edit it.",
+                                           ("No proof attached: #{unproven.to_sentence}." if unproven.any?) ].compact.join(" ") } } %>
   </div>
   <%= form_with url: hr_lite.reject_admin_tax_declaration_path(@declaration),
                 method: :post, local: true do %>
     <div class="hrl-field">
       <%= label_tag :note, "What is missing (required to send back)" %>
-      <%= text_field_tag :note %>
+      <%= text_field_tag :note, nil, class: "hrl-input" %>
     </div>
     <%= submit_tag "Send back", class: "hrl-btn" %>
   <% end %>