hq-graphql 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ab6e40470755691d1fe10f268c3652f19ad894ec
-  data.tar.gz: fb75a2bfa83aed220ef40b5461429923dd5f56f5
+  metadata.gz: aa14b61d384dece960be3b49e3ebae1405d36fbf
+  data.tar.gz: aeb81df536b57a6e9477c0d1d7ddadb25e395687
 SHA512:
-  metadata.gz: cce3a3348a0cee0faf0c4edd5055296cdd4907aadfb953e36615bca342e203fcf70a05f83a84754cc05fef1c3756d94e2c3e97addce552adbc535c733f1035e2
-  data.tar.gz: 9641b93d8845695db06a950b9236f0566df6371ba5c1c960ddd4ec6422cb60ecd369be6b3678595529bbeae1495402a69868e9107b5f7591055d9e226eec4a63
+  metadata.gz: 51693b229e820257b9d1814d500a009e3e010ec5bce8a7b530d56296c31c0872b6b9e1f012d6234bb4a516da59854ef06e63123272cb37e51e02a960ca7024db
+  data.tar.gz: b454283ef63f2fc698aa3990a8fe7c1547cc0aa99cfdfc769b2e23d7d864791031054d9261c050d2cdd6feaef8e24a41f875a934e154a9d2a91579365289c8f3

data/lib/hq/graphql/resource.rb

@@ -127,7 +127,7 @@ module HQ
                   if resource.destroy
                     {
                       resource: resource,
-                      errors: [],
+                      errors: {},
                     }
                   else
                     {

data/lib/hq/graphql/resource/mutation.rb

@@ -8,7 +8,7 @@ module HQ
             graphql_name graphql_name
 
             lazy_load do
-              field :errors, ::HQ::GraphQL::Types::JSON, null: false
+              field :errors, ::HQ::GraphQL::Types::Object, null: false
               field :resource, ::HQ::GraphQL::Types[model_name], null: true
             end
 

data/lib/hq/graphql/scalars.rb

@@ -1,10 +1,10 @@
-require "hq/graphql/types/json"
+require "hq/graphql/types/object"
 require "hq/graphql/types/uuid"
 
 module HQ
   module GraphQL
     module Scalars
-      JSON = ::HQ::GraphQL::Types::JSON
+      Object = ::HQ::GraphQL::Types::Object
       UUID = ::HQ::GraphQL::Types::UUID
     end
   end

data/lib/hq/graphql/types/object.rb

@@ -0,0 +1,34 @@
+module HQ
+  module GraphQL
+    module Types
+      class Object < ::GraphQL::Schema::Scalar
+        description "Object"
+
+        class << self
+          def coerce_input(value, context)
+            validate_and_return_object(value)
+          end
+
+          def coerce_result(value, context)
+            validate_and_return_object(value)
+          end
+
+          private
+
+          def validate_and_return_object(value)
+            if validate_object(value)
+              value
+            else
+              raise ::GraphQL::CoercionError, "#{value.inspect} is not a valid Object"
+            end
+          end
+
+          def validate_object(value)
+            value.is_a?(Hash)
+          end
+
+        end
+      end
+    end
+  end
+end

data/lib/hq/graphql/version.rb

@@ -1,5 +1,5 @@
 module HQ
   module GraphQL
-    VERSION = "1.0.1"
+    VERSION = "1.1.0"
   end
 end

data/spec/lib/graphql/types/object_spec.rb

@@ -0,0 +1,96 @@
+require 'rails_helper'
+
+describe ::HQ::GraphQL::Types::Object do
+  let(:hql_object_klass) do
+    Class.new(::HQ::GraphQL::Object) do
+      graphql_name "TestQuery"
+
+      field :valid_object, ::HQ::GraphQL::Types::Object, null: false
+      field :invalid_object, ::HQ::GraphQL::Types::Object, null: false
+
+      def valid_object
+        { name: object.name }
+      end
+
+      def invalid_object
+        :not_an_object
+      end
+    end
+  end
+
+  let(:query) do
+    Class.new(::HQ::GraphQL::Object) do
+      graphql_name "Query"
+
+      field :advisor, AdvisorType, null: false do
+        argument :filters, ::HQ::GraphQL::Types::Object, required: true
+      end
+
+      def advisor(filters:)
+        Advisor.find_by(filters)
+      end
+    end
+  end
+
+  let(:schema) do
+    Class.new(GraphQL::Schema) do
+      query(Query)
+    end
+  end
+
+  let(:query_str) do
+    <<-gql
+      query findAdvisor($filters: Object!){
+        advisor(filters: $filters) {
+          validObject
+        }
+      }
+    gql
+  end
+
+  let(:invalid_query_str) do
+    <<-gql
+      query findAdvisor($filters: Object!){
+        advisor(filters: $filters) {
+          invalidObject
+        }
+      }
+    gql
+  end
+
+  let(:advisor) { FactoryBot.create(:advisor) }
+  let(:advisor_filter) { { name: advisor.name } }
+
+  before(:each) do
+    stub_const("AdvisorType", hql_object_klass)
+    stub_const("Query", query)
+  end
+
+  describe ".coerce_result" do
+    it "returns an object" do
+      results = schema.execute(query_str, variables: { filters: advisor_filter })
+      expect(results["data"]["advisor"]["validObject"]).to eql({ name: advisor.name })
+    end
+
+    it "raises an error when returning am invalid object " do
+      expect { schema.execute(invalid_query_str, variables: { filters: advisor_filter }) }.to raise_error(
+        ::GraphQL::CoercionError, ":not_an_object is not a valid Object"
+      )
+    end
+  end
+
+  describe ".coerce_input" do
+    it "accepts an object as input" do
+      result = schema.execute(query_str, variables: { filters: advisor_filter })
+      expect(result["data"]["advisor"]["validObject"]).to eql({ name: advisor.name })
+    end
+
+    it "raises an error when an argument is an invalid object" do
+      result = schema.execute(query_str, variables: { filters: advisor.name })
+      aggregate_failures do
+        expect(result["errors"].length).to eql(1)
+        expect(result["errors"][0]["message"]).to eql("Variable filters of type Object! was provided invalid value")
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hq-graphql
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Danny Jones
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-29 00:00:00.000000000 Z
+date: 2018-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -108,7 +108,7 @@ files:
 - lib/hq/graphql/root_query.rb
 - lib/hq/graphql/scalars.rb
 - lib/hq/graphql/types.rb
-- lib/hq/graphql/types/json.rb
+- lib/hq/graphql/types/object.rb
 - lib/hq/graphql/types/uuid.rb
 - lib/hq/graphql/version.rb
 - spec/factories/advisors.rb
@@ -125,6 +125,7 @@ files:
 - spec/lib/graphql/inputs_spec.rb
 - spec/lib/graphql/object_spec.rb
 - spec/lib/graphql/resource_spec.rb
+- spec/lib/graphql/types/object_spec.rb
 - spec/lib/graphql/types/uuid_spec.rb
 - spec/lib/graphql/types_spec.rb
 - spec/rails_helper.rb
@@ -164,6 +165,7 @@ test_files:
 - spec/factories/organizations.rb
 - spec/factories/advisors.rb
 - spec/factories/users.rb
+- spec/lib/graphql/types/object_spec.rb
 - spec/lib/graphql/types/uuid_spec.rb
 - spec/lib/graphql/active_record_extensions_spec.rb
 - spec/lib/graphql/object_spec.rb

data/lib/hq/graphql/types/json.rb

@@ -1,20 +0,0 @@
-module HQ
-  module GraphQL
-    module Types
-      class JSON < ::GraphQL::Schema::Scalar
-        description "JSON"
-
-        class << self
-          def coerce_input(value, context)
-            JSON.parse(value)
-          end
-
-          def coerce_result(value, context)
-            value
-          end
-
-        end
-      end
-    end
-  end
-end