hpricot 0.8.3-i386-mswin32 → 0.8.4-i386-mswin32

data/CHANGELOG

@@ -1,3 +1,7 @@
+= 0.8.4
+=== 28 February, 2011
+* GH #21, #32, #33, #36: Fix for reported segfaults
+
 = 0.8.3
 === 3 November, 2010
 * GH#8: Nil-check before downcasing attribute key

data/ext/hpricot_scan/hpricot_scan.c

@@ -6811,8 +6811,14 @@ void hstruct_mark(void* ptr) {
   struct hpricot_struct* st = (struct hpricot_struct*)ptr;
   int i;
 
-  for(i = 0; i < st->len; i++) {
-    rb_gc_mark(st->ptr[i]);
+  /* it's likely to hit GC when allocating st->ptr.
+   * that should be checked to avoid segfault.
+   * and simply ignore it.
+   */
+  if (st->ptr) {
+    for(i = 0; i < st->len; i++) {
+      rb_gc_mark(st->ptr[i]);
+    }
   }
 }
 

data/ext/hpricot_scan/hpricot_scan.rl

@@ -668,8 +668,14 @@ void hstruct_mark(void* ptr) {
   struct hpricot_struct* st = (struct hpricot_struct*)ptr;
   int i;
 
-  for(i = 0; i < st->len; i++) {
-    rb_gc_mark(st->ptr[i]);
+  /* it's likely to hit GC when allocating st->ptr.
+   * that should be checked to avoid segfault.
+   * and simply ignore it.
+   */
+  if (st->ptr) {
+    for(i = 0; i < st->len; i++) {
+      rb_gc_mark(st->ptr[i]);
+    }
   }
 }
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hpricot
 version: !ruby/object:Gem::Version 
-  hash: 57
+  hash: 55
   prerelease: false
   segments: 
   - 0
   - 8
-  - 3
-  version: 0.8.3
+  - 4
+  version: 0.8.4
 platform: i386-mswin32
 authors: 
 - why the lucky stiff
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-03 00:00:00 -05:00
+date: 2011-02-28 00:00:00 -06:00
 default_executable: 
 dependencies: []