houston-core 0.7.0 → 0.8.0.pre

data/test/unit/controllers/deploys_controller_test.rb

@@ -1,4 +1,5 @@
 require "test_helper"
+require "support/houston/adapters/ci_server/mock_adapter"
 
 
 class DeploysControllerTest < ActionController::TestCase
@@ -6,34 +7,39 @@ class DeploysControllerTest < ActionController::TestCase
   setup do
     @project = create(:project, ci_server_name: "Mock")
     @environment = "production"
+    Timecop.freeze
+  end
+
+  teardown do
+    Timecop.return
   end
 
 
   should "not require a logged in user" do
-    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: nil)
+    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: nil, duration: nil, successful: true, completed_at: Time.now)
     post :create, project_id: @project.slug, environment: @environment, commit: "hi"
   end
 
 
   should "work with a Heroku-style deploy hook" do
-    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: "deployer@heroku.com")
+    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: "deployer@heroku.com", duration: nil, successful: true, completed_at: Time.now)
     post :create, project_id: @project.slug, environment: @environment, head_long: "hi", user: "deployer@heroku.com"
   end
 
 
   should "work with title-cased environments" do
-    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: nil)
+    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: nil, duration: nil, successful: true, completed_at: Time.now)
     post :create, project_id: @project.slug, environment: "Production", commit: "hi"
   end
 
   should "work with lowercased environments" do
-    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: nil)
+    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: nil, duration: nil, successful: true, completed_at: Time.now)
     post :create, project_id: @project.slug, environment: "production", commit: "hi"
   end
 
 
   should "record the deployer if it is supplied" do
-    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: "Bob Lail <bob.lail@cph.org>")
+    mock(Deploy).create!(project: @project, environment_name: @environment, sha: "hi", branch: nil, deployer: "Bob Lail <bob.lail@cph.org>", duration: nil, successful: true, completed_at: Time.now)
     post :create, project_id: @project.slug, environment: @environment, commit: "hi", deployer: "Bob Lail <bob.lail@cph.org>"
   end
 

data/test/unit/controllers/users_controller_test.rb

@@ -0,0 +1,46 @@
+require "test_helper"
+
+class UsersControllerTest < ActionController::TestCase
+  include Devise::TestHelpers
+
+
+  context "Owners" do
+    setup do
+      sign_in owner
+    end
+
+    should "be able to change other users' roles" do
+      put :update, id: a_user.id, user: {role: "Owner"}
+      assert_equal "Owner", a_user.reload.role
+    end
+
+    should "not be able to change their own role" do
+      put :update, id: owner.id, user: {role: "Member"}
+      assert_equal "Owner", owner.reload.role
+    end
+  end
+
+
+  context "Non-Owners" do
+    setup do
+      sign_in a_user
+    end
+
+    should "not be able to change their own role" do
+      put :update, id: a_user.id, user: {role: "Owner"}
+      refute_equal "Owner", a_user.reload.role
+    end
+  end
+
+
+private
+
+  def owner
+    @owner ||= User.first
+  end
+
+  def a_user
+    @a_user ||= create(:user)
+  end
+
+end

data/test/unit/models/release_test.rb

@@ -17,22 +17,13 @@ class ReleaseTest < ActiveSupport::TestCase
     should "trigger `released!` on each ticket" do
       a_ticket = Object.new
       stub(release).tickets { [a_ticket] }
-      stub(release).antecedents { [] }
       mock(a_ticket).released!(release)
       release.save!
     end
 
-    should "trigger `released!` on each antecedent" do
-      an_antecedent = TicketAntecedent.new(nil, "Test", 4)
-      stub(release).antecedents { [an_antecedent] }
-      mock(an_antecedent).released!(release)
-      release.save!
-    end
-
     should "trigger `released!` on each task" do
       a_task = Object.new
       stub(release).tasks { [a_task] }
-      stub(release).antecedents { [] }
       mock(a_task).released!(release)
       release.save!
     end

data/test/unit/models/serializer_test.rb

@@ -38,14 +38,6 @@ class SerializerTest < ActiveSupport::TestCase
       like: /"class":"Project","attributes":{.*},"\^S":"Houston::ActiveRecordSerializer"/)
   end
 
-  should "serialize objects that refer to ActiveRecord objects" do
-    project = Project.create!(name: "Test", slug: "test")
-    commit = Commit.new(project: project, message: "Commit Message")
-    antecedent = TicketAntecedent.new(commit, "Err", 45)
-    assert_serializes(antecedent,
-      like: /"ticket_or_commit":{"class":"Commit".*},"kind":"Err","id":45,"\^S":"Houston::TicketAntecedentSerializer"/)
-  end
-
   should "work even when you set a value" do
     project = Project.create!(name: "Test", slug: "test")
     project.updated_at = 1.week.after(project.updated_at) # ActiveSupport::TimeWithZone

data/test/unit/models/ticket_test.rb

@@ -66,38 +66,6 @@ class TicketTest < ActiveSupport::TestCase
 
 
 
-  context "#resolve!" do
-    setup do
-      @ticket = create(:ticket, project: project)
-    end
-
-    should "resolve antecedents" do
-      antecedent = TicketAntecedent.new(ticket, "Test", 4)
-      mock(antecedent).resolve!
-      stub(ticket).antecedents { [antecedent] }
-
-      ticket.resolve!
-    end
-  end
-
-
-
-  context "#close!" do
-    setup do
-      @ticket = create(:ticket, project: project)
-    end
-
-    should "close antecedents" do
-      antecedent = TicketAntecedent.new(ticket, "Test", 4)
-      mock(antecedent).close!
-      stub(ticket).antecedents { [antecedent] }
-
-      ticket.close!
-    end
-  end
-
-
-
   context "#reopen!" do
     setup do
       @ticket = Ticket.create!(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: houston-core
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0.pre
 platform: ruby
 authors:
 - Bob Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-06 00:00:00.000000000 Z
+date: 2016-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -774,7 +774,6 @@ files:
 - app/assets/javascripts/houston/app/models/user.coffee
 - app/assets/javascripts/houston/app/mousetrap-bind-scoped.js
 - app/assets/javascripts/houston/app/releases.coffee
-- app/assets/javascripts/houston/app/table_row_expander.coffee
 - app/assets/javascripts/houston/app/ticket_tracker_refresh.coffee
 - app/assets/javascripts/houston/app/views/_show_sprint_view.coffee
 - app/assets/javascripts/houston/app/views/_tickets_view.coffee
@@ -785,7 +784,6 @@ files:
 - app/assets/javascripts/houston/app/views/keyboard_shortcuts_modal.coffee
 - app/assets/javascripts/houston/app/views/new_ticket_modal.coffee
 - app/assets/javascripts/houston/app/views/new_ticket_view.coffee
-- app/assets/javascripts/houston/app/views/problems_view.coffee
 - app/assets/javascripts/houston/app/views/ticket_modal_view.coffee
 - app/assets/javascripts/houston/application.js
 - app/assets/javascripts/houston/core/app.coffee
@@ -809,7 +807,6 @@ files:
 - app/assets/stylesheets/houston/application/emoji.scss
 - app/assets/stylesheets/houston/application/exceptions.scss
 - app/assets/stylesheets/houston/application/find_or_create_ticket.scss
-- app/assets/stylesheets/houston/application/follow_up.scss
 - app/assets/stylesheets/houston/application/forms.scss
 - app/assets/stylesheets/houston/application/freight_train.css.scss
 - app/assets/stylesheets/houston/application/full_screen.scss
@@ -833,6 +830,7 @@ files:
 - app/assets/stylesheets/houston/application/sortable_table.scss
 - app/assets/stylesheets/houston/application/sprint.scss
 - app/assets/stylesheets/houston/application/tables.scss
+- app/assets/stylesheets/houston/application/teams.scss
 - app/assets/stylesheets/houston/application/test.scss
 - app/assets/stylesheets/houston/application/test_run.scss
 - app/assets/stylesheets/houston/application/ticket.scss
@@ -907,10 +905,8 @@ files:
 - app/controllers/hooks_controller.rb
 - app/controllers/oauth/providers_controller.rb
 - app/controllers/omnibar_controller.rb
-- app/controllers/project_exceptions_controller.rb
 - app/controllers/project_hooks_controller.rb
 - app/controllers/project_options_controller.rb
-- app/controllers/project_pretickets_controller.rb
 - app/controllers/project_roles_controller.rb
 - app/controllers/project_tests_controller.rb
 - app/controllers/project_tickets_controller.rb
@@ -922,6 +918,7 @@ files:
 - app/controllers/sprint_task_locks_controller.rb
 - app/controllers/sprints_controller.rb
 - app/controllers/tasks_controller.rb
+- app/controllers/teams_controller.rb
 - app/controllers/test_runs_controller.rb
 - app/controllers/tester_bar_controller.rb
 - app/controllers/tickets_controller.rb
@@ -967,7 +964,6 @@ files:
 - app/jobs/sync_project_tickets_job.rb
 - app/mailers/.gitkeep
 - app/mailers/.keep
-- app/mailers/deploy_notification.rb
 - app/mailers/project_notification.rb
 - app/mailers/view_mailer.rb
 - app/models/.gitkeep
@@ -975,7 +971,6 @@ files:
 - app/models/ability.rb
 - app/models/action.rb
 - app/models/activity_feed.rb
-- app/models/antecedent.rb
 - app/models/authorization.rb
 - app/models/code_climate/coverage_report.rb
 - app/models/commit.rb
@@ -1022,30 +1017,28 @@ files:
 - app/models/static_chart.rb
 - app/models/static_chart/area.rb
 - app/models/task.rb
+- app/models/team.rb
+- app/models/team_user.rb
 - app/models/test.rb
 - app/models/test_error.rb
 - app/models/test_result.rb
 - app/models/test_run.rb
 - app/models/test_run_statistics.rb
 - app/models/ticket.rb
-- app/models/ticket_antecedent.rb
 - app/models/ticket_comment.rb
 - app/models/ticket_committer.rb
 - app/models/ticket_tag.rb
 - app/models/user.rb
 - app/models/user_credentials.rb
-- app/models/value_statement.rb
 - app/presenters/commit_presenter.rb
 - app/presenters/full_ticket_presenter.rb
 - app/presenters/measurements_presenter.rb
 - app/presenters/one_or_many.rb
-- app/presenters/problem_presenter.rb
 - app/presenters/project_presenter.rb
 - app/presenters/release_presenter.rb
 - app/presenters/sprint_task_presenter.rb
 - app/presenters/task_presenter.rb
 - app/presenters/tasks_excel_presenter.rb
-- app/presenters/tester_presenter.rb
 - app/presenters/ticket_presenter.rb
 - app/views/actions/_actions.html.erb
 - app/views/actions/index.html.erb
@@ -1094,10 +1087,8 @@ files:
 - app/views/oauth/providers/index.html.erb
 - app/views/oauth/providers/new.html.erb
 - app/views/project_notification/ci_configuration_error.html.erb
-- app/views/project_notification/follow_up.html.erb
 - app/views/project_notification/new_release.html.erb
 - app/views/project_notification/test_run.html.erb
-- app/views/project_pretickets/show.html.erb
 - app/views/project_tests/_commits.html.erb
 - app/views/project_tests/index.html.erb
 - app/views/project_tests/show.html.erb
@@ -1121,7 +1112,6 @@ files:
 - app/views/projects/index.html.erb
 - app/views/projects/new.html.erb
 - app/views/projects/new_from_github.html.erb
-- app/views/releases/_antecedents.html.erb
 - app/views/releases/_changelog.html.erb
 - app/views/releases/_commits.html.erb
 - app/views/releases/_form.html.erb
@@ -1136,6 +1126,10 @@ files:
 - app/views/settings/show.html.erb
 - app/views/sprints/dashboard.html.erb
 - app/views/sprints/show.html.erb
+- app/views/teams/_form.html.erb
+- app/views/teams/edit.html.erb
+- app/views/teams/index.html.erb
+- app/views/teams/new.html.erb
 - app/views/test_runs/confirm_retry.html.erb
 - app/views/tickets/new.html.erb
 - app/views/triggers/index.html.erb
@@ -1165,7 +1159,6 @@ files:
 - config/initializers/cookies_serializer.rb
 - config/initializers/devise.rb
 - config/initializers/filter_parameter_logging.rb
-- config/initializers/hard_coded_knowledge.rb
 - config/initializers/houston_async.rb
 - config/initializers/houston_benchmark.rb
 - config/initializers/houston_deliver.rb
@@ -1260,7 +1253,6 @@ files:
 - db/migrate/20130420172322_rename_projects_ci_adapter_to_ci_server_name.rb
 - db/migrate/20130420174002_rename_projects_errbit_app_id_to_error_tracker_id.rb
 - db/migrate/20130420174126_add_error_tracker_name_to_projects.rb
-- db/migrate/20130427223925_create_project_quotas.rb
 - db/migrate/20130428005808_create_settings.rb
 - db/migrate/20130504014802_add_extended_attributes_to_projects.rb
 - db/migrate/20130504135741_add_antecedents_to_tickets.rb
@@ -1316,7 +1308,6 @@ files:
 - db/migrate/20140428023146_prevent_ticket_number_from_being_null.rb
 - db/migrate/20140429000919_add_feature_states_to_projects.rb
 - db/migrate/20140506032958_add_locked_to_sprints.rb
-- db/migrate/20140506035755_create_value_statements.rb
 - db/migrate/20140515174322_create_tasks.rb
 - db/migrate/20140515200824_link_tasks_and_commits.rb
 - db/migrate/20140516005310_link_tasks_and_releases.rb
@@ -1393,6 +1384,8 @@ files:
 - db/migrate/20160711170921_rename_jobs_to_actions.rb
 - db/migrate/20160713204605_add_trigger_and_params_to_actions.rb
 - db/migrate/20160715173039_create_persistent_triggers.rb
+- db/migrate/20160812233255_repurpose_users_role.rb
+- db/migrate/20160813001242_create_teams.rb
 - db/seeds.rb
 - db/structure.sql
 - houston-core.gemspec
@@ -1415,7 +1408,6 @@ files:
 - lib/houston/boot/readonly_hash_serializer.rb
 - lib/houston/boot/serializer.rb
 - lib/houston/boot/server.rb
-- lib/houston/boot/ticket_antecedent_serializer.rb
 - lib/houston/boot/timer.rb
 - lib/houston/boot/triggers.rb
 - lib/houston/cli.rb
@@ -1477,6 +1469,7 @@ files:
 - templates/new-instance/config/events/deploy/checkout_mentioned_alerts.rb
 - templates/new-instance/config/events/deploy/notify_deployer_when_finished.rb
 - templates/new-instance/config/events/github/publish_comments_on_slack.rb
+- templates/new-instance/config/events/tests/email_when_completed.rb
 - templates/new-instance/config/events/tests/slack_when_analyzed.rb
 - templates/new-instance/config/events/tests/slack_when_completed.rb
 - templates/new-instance/config/events/tickets/mark_tasks_completed_on_commit.rb
@@ -3318,6 +3311,8 @@ files:
 - test/fixtures/.gitkeep
 - test/fixtures/.keep
 - test/fixtures/simplecov_sample.rb
+- test/fixtures/teams.yml
+- test/fixtures/teams_users.yml
 - test/fixtures/users.yml
 - test/integration/.gitkeep
 - test/integration/.keep
@@ -3346,6 +3341,7 @@ files:
 - test/unit/controllers/sprints_controller_test.rb
 - test/unit/controllers/test_runs_controller_test.rb
 - test/unit/controllers/user_options_controller_test.rb
+- test/unit/controllers/users_controller_test.rb
 - test/unit/initializers/sync_commits_on_post_receive_test.rb
 - test/unit/models/actions_test.rb
 - test/unit/models/code_climate_coverage_report_test.rb
@@ -3365,7 +3361,6 @@ files:
 - test/unit/models/sprint_test.rb
 - test/unit/models/task_test.rb
 - test/unit/models/test_run_test.rb
-- test/unit/models/ticket_antecedents_test.rb
 - test/unit/models/ticket_test.rb
 - test/unit/models/triggers_test.rb
 - test/unit/models/user_test.rb
@@ -3486,9 +3481,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.5.1
@@ -3544,6 +3539,8 @@ test_files:
 - test/fixtures/.gitkeep
 - test/fixtures/.keep
 - test/fixtures/simplecov_sample.rb
+- test/fixtures/teams.yml
+- test/fixtures/teams_users.yml
 - test/fixtures/users.yml
 - test/integration/.gitkeep
 - test/integration/.keep
@@ -3572,6 +3569,7 @@ test_files:
 - test/unit/controllers/sprints_controller_test.rb
 - test/unit/controllers/test_runs_controller_test.rb
 - test/unit/controllers/user_options_controller_test.rb
+- test/unit/controllers/users_controller_test.rb
 - test/unit/initializers/sync_commits_on_post_receive_test.rb
 - test/unit/models/actions_test.rb
 - test/unit/models/code_climate_coverage_report_test.rb
@@ -3591,7 +3589,6 @@ test_files:
 - test/unit/models/sprint_test.rb
 - test/unit/models/task_test.rb
 - test/unit/models/test_run_test.rb
-- test/unit/models/ticket_antecedents_test.rb
 - test/unit/models/ticket_test.rb
 - test/unit/models/triggers_test.rb
 - test/unit/models/user_test.rb

data/app/assets/javascripts/houston/app/table_row_expander.coffee

@@ -1,52 +0,0 @@
-class @TableRowExpander
-
-  setupForViews: (views)->
-    @expandedView = null
-    views.each (view)=>
-      view.on 'expanding', => @onViewExpanding(view)
-
-      view.expand = _.bind ->
-          @trigger('expanding')
-          @$el.addClass('expanded in-transition')
-          @$expandedRow = @renderExpandedRow()
-          @$expandedRow.slideDown =>
-            @$el.removeClass('in-transition')
-            @trigger('expanded')
-        , view
-
-      view.collapse = _.bind (speed)->
-          return unless @$expandedRow
-
-          finish = =>
-            @$el.removeClass('expanded in-transition')
-            @$expandedRow.closest('tr').remove()
-            @$expandedRow = null
-
-          if speed == 'fast'
-            finish()
-          else
-            @$el.addClass('in-transition')
-            @$expandedRow.slideUp(finish)
-        , view
-
-      view.$el.click (e)=>
-        return if $(e.target).is('button, a, input')
-        @expandOrCollapseView(view)
-
-    $('.table-sortable').bind 'sortStart', => @collapseExpandedView('fast')
-
-  expandOrCollapseView: (view)->
-    return if view.$el.hasClass('in-transition')
-    return if view.$el.hasClass('deleting')
-
-    if view.$el.hasClass('expanded')
-      view.collapse()
-    else
-      view.expand()
-
-  onViewExpanding: (view)->
-    @collapseExpandedView()
-    @expandedView = view
-
-  collapseExpandedView: (speed)->
-    @expandedView.collapse(speed) if @expandedView