houston-core 0.7.0.beta4 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f6c7d2f0537e31c913013579570a403c3ed71e62
-  data.tar.gz: bae46e8b42c70baaeebef413cfe6b38fdc72aab1
+  metadata.gz: 7313503e6891a81d74ee02d5c9b06315dce2df20
+  data.tar.gz: aa75366ce3181bebdb91e6f883a1c8879adbcdf9
 SHA512:
-  metadata.gz: 01c289fcc4cd1aaff9496d2273b3703d87184f9ec4d1742f518fdf0d3861215cae4ef92889ba952fa3e7a6b3fe09ed3d8c2278cd30b61aee1601900e24b055fd
-  data.tar.gz: b2f67d2a12797f57aa6e246889c051b6a68ac5733eb743c433e75f21f12b3beb00def052249166e4c258c9af992abed167248d31b115e389bfd29cc274438e02
+  metadata.gz: db72d7a2dcc0808d565cd6a2262e63d1ab0ffb8b144b4a701086126d92c6f1f9ceb944352209ed35bbf5d8a5777ecf80c6186ac9e986ae1ebbf319a6f89bf537
+  data.tar.gz: 4a99188cdd551613eac66106a3b0a86e79df16a64dc6f019e74137fb9bccd562ebc0fde7c4a78e575283aeaeb7ee3f00619a74fd9c1cc5b0f6c167ee41ce24a4

data/.gitignore

@@ -8,8 +8,10 @@
 /.bundle
 
 # Ignore all logfiles and tempfiles.
-/log/*.log
-/tmp
+/log/*
+/tmp/*
+!/log/.keep
+!/tmp/.keep
 
 # Ignore built gems
 /pkg

data/.travis.yml

@@ -0,0 +1,50 @@
+# .travis.yml
+language: ruby
+
+# By default, Travis clones the last 50 commits
+# git:
+#   depth: 50
+
+rvm:
+
+  # I would use 2.3.0, but Travis loads that binary on-demand
+  # whereas it has the 2.2.0 binary handy for the Ruby VM.
+  # This saves about 20 seconds.
+  - 2.2.0
+
+addons:
+
+  # Travis's default version is 9.1; but Houston uses jsonb columns
+  postgresql: "9.4"
+
+services:
+  - postgresql
+
+before_install:
+
+  # This fixes a bug with the build:
+  # https://github.com/travis-ci/travis-ci/issues/5239
+  - gem update bundler
+
+  # This is required so that the Rugged gem can
+  # build libgit2 with support for the SSH protocol
+  - sudo apt-get install libssh2-1-dev
+
+before_script:
+
+   # Create the test database
+  - psql -c 'create database houston_core_test;' -U postgres
+
+  # Give the VM public and private SSH keys.
+  # These aren't secret: we don't need to authenticate as anyone,
+  # we just need the keys to be able to clone a public repo from
+  # GitHub via the SSH protocol.
+  - echo -e "Host *\n\tStrictHostKeyChecking no\n" >> ~/.ssh/config
+  - echo -e "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDkTcgXnHuqR0gbwegnr9Zxz4hTkjjV/SpgJNPJz7mo/HKNbx0rqjj1P0yGR053R9GSFFim2ut4NK9DPPUkQdyucw+DoLkYRHJmlJ4BNa9NTCD0sl+eSXO2969kZojCYSOgbmkCJx8mdgTwhzdgE/jhBrsY0hPE6pRTlU+H68/zeNdJUAIJf0LLXOm3hpTKLA19VICltl/j9VvBJpgRHdBylXEyL8HokYpjkQQk1ZXj3m7Nlo8yDdg4VcljOJWC+Xh8kxRMfK5x/VRVsYKCQXN5QlzKeqf7USRDUS/7mFoPUBW+d4kwKtGxRsWuIL2yeqzifZUTOgsh9+ZWAWxWffQZ your_email@example.com" > ~/.ssh/id_rsa.pub
+  - echo -e "-----BEGIN RSA PRIVATE KEY-----\nMIIEpAIBAAKCAQEA5E3IF5x7qkdIG8HoJ6/Wcc+IU5I41f0qYCTTyc+5qPxyjW8d\nK6o49T9MhkdOd0fRkhRYptrreDSvQzz1JEHcrnMPg6C5GERyZpSeATWvTUwg9LJf\nnklztvevZGaIwmEjoG5pAicfJnYE8Ic3YBP44Qa7GNITxOqUU5VPh+vP83jXSVAC\nCX9Cy1zpt4aUyiwNfVSApbZf4/VbwSaYER3QcpVxMi/B6JGKY5EEJNWV495uzZaP\nMg3YOFXJYziVgvl4fJMUTHyucf1UVbGCgkFzeUJcynqn+1EkQ1Ev+5haD1AVvneJ\nMCrRsUbFriC9snqs4n2VEzoLIffmVgFsVn30GQIDAQABAoIBAQDPQm2sQbti0mN8\nD4Uawl8D40v30n8WhUa7EbPTOmlqKAQ2sfDhex9KRbTLEmEBmImA/Eee8o9iCTIy\n8Fv8Fm6pUHt9G6Pti/XvemwW3Q3QNpSUkHqN0FDkgecQVqVBEb6uHo3mDm4RFINX\neOmkp30BjIK9/blEw1D0sFALLOEUPaDdPMwiXtFgqfrFSgpDET3TvQIwZ2LxxTm0\ncNmP3sCSlZHJNkZI4hBEWaaXR+V5/+C1qblDCo5blAWTcX3UzqrwUUJgFi6VnBuh\n7S9Q6+CEIU+4JRyWQNmY8YgZFaAp6IOr/kyfPxTP1+UEVVgcLn3WDYwfG9og0tmz\nfzlruAgBAoGBAPfz73Pey86tNZEanhJhbX8gVjzy2hvyhT0paHg0q/H6c1VWOtUH\nOwZ3Ns2xAZqJhlDqCHnQYSCZDly042U/theP4N8zo1APb4Yg4qdmXF9QE1+2M03r\nkS6138gU/CSCLf8pCYa6pA/GmsaXxloeJGLvT4fzOZRsVav80/92XHRhAoGBAOu2\nmKh4Gr1EjgN9QNbk9cQTSFDtlBEqO/0pTepvL73UvNp/BAn4iYZFU4WnklFVBSWc\nL84Sc732xU12TAbTTUsa6E7W29pS8u7zVTxlIdQIIU5pzDyU1pNNk2kpxzte5p3Y\nPDtniPFsoYLWoH0LpsKL93t2pLAj+IOkE6f3XBq5AoGAIKaYo5N1FxQr952frx/x\nQUpK0N/R5Ng8v18SiLG26rhmM5iVSrQXC7TrHI7wfR8a9tC6qP/NqnM9NuwC/bQ0\nEEo7/GhaWxKNRwZRkmWiSFLNGk9t1hbtGU+N1lUdFtmloPIQdRNiw0kN3JTj474Q\nYI7O1EItFORnK6yxZfR6HEECgYEA1CT7MGUoa8APsMRCXyaiq15Pb8bjxK8mXquW\nHLEFXuzhLCW1FORDoj0y9s/iuKC0iS0ROX8R/J7k5NrbgikbH8WP36UxKkYNr1IC\nHOFImPTYRSKjVsL+fIUNb1DSp3S6SsYbL7v3XJJQqtlQiDq8U8x1aQFXJ9C4EoLR\nzhKrKsECgYBtU/TSF/TATZY5XtrN9O+HX1Fbz70Ci8XgvioheVI2fezOcXPRzDcC\nOYPaCMNKA5E8gHdg4s0TN7uDvKTJ+KhSg2V7gZ39A28dHrJaRX7Nz4k6t2uEBjX9\na1JidpAIbJ+3w7+hj6L299tVZvS+Y/6Dz/uuEQGXfJg/l/5CCvQPsA==\n-----END RSA PRIVATE KEY-----" > ~/.ssh/id_rsa
+  - chmod 600 ~/.ssh/id_rsa*
+  - eval `ssh-agent -s`
+  - ssh-add ~/.ssh/id_rsa
+
+script:
+  - script/cibuild

data/Gemfile

@@ -16,9 +16,8 @@ group :test do
   gem "webmock", require: "webmock/minitest"
   gem "factory_girl_rails"
   gem "test_after_commit"
-  
+
   # For Jenkins
-  gem "therubyracer"
   gem "simplecov-json", require: false
   gem "minitest-reporters", require: false
   gem "minitest-reporters-turn_reporter", require: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    houston-core (0.7.0.beta4)
+    houston-core (0.7.0)
       activerecord-import
       activerecord-pluck_in_batches
       addressable (~> 2.3.8)
@@ -192,7 +192,6 @@ GEM
     jwt (1.5.4)
     launchy (2.4.3)
       addressable (~> 2.3)
-    libv8 (3.16.14.13)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
     mail (2.6.4)
@@ -282,7 +281,6 @@ GEM
       thor (>= 0.18.1, < 2.0)
     rake (11.2.2)
     redcarpet (3.3.4)
-    ref (2.0.0)
     responders (2.2.0)
       railties (>= 4.2.0, < 5.1)
     rest-client (1.8.0)
@@ -326,9 +324,6 @@ GEM
       activerecord
     test_after_commit (1.0.0)
       activerecord (>= 3.2)
-    therubyracer (0.12.2)
-      libv8 (~> 3.16.14.0)
-      ref
     thor (0.19.1)
     thread_safe (0.3.5)
     tilt (2.0.5)
@@ -367,7 +362,6 @@ DEPENDENCIES
   shoulda-context
   simplecov-json
   test_after_commit
-  therubyracer
   timecop
   webmock
 

data/README.md

@@ -1,10 +1,14 @@
-# Houston Core [![Code Climate](https://codeclimate.com/github/houston/houston-core.png)](https://codeclimate.com/github/houston/houston-core)
+# Houston Core
 
-##### Mission Control for your projects and team
+[![Gem Version](https://badge.fury.io/rb/houston-core.svg)](https://rubygems.org/gems/houston-core)
+[![Code Climate](https://codeclimate.com/github/houston/houston-core.svg)](https://codeclimate.com/github/houston/houston-core)
+[![Build Status](https://travis-ci.org/houston/houston-core.svg)](https://travis-ci.org/houston/houston-core)
+
+Mission Control for your projects and teams.
 
 Houston interfaces with your version-control, ticket-tracking, continuous integration, and other systems to stitch together a picture of your projects and teams.
 
-It makes it easy to set up **triggers** and **notifications** like:
+It makes it easy to set up **[triggers](https://github.com/houston/houston-core/wiki/Triggers)** to perform tasks like:
 
  - Resolving an exception report when a commit that mentions it is deployed
  - Slacking team members when a pull request is labeled or unlabeled
@@ -12,23 +16,26 @@ It makes it easy to set up **triggers** and **notifications** like:
 
 And it provides a foundation for custom views like **dashboards** and **reports**.
 
-Houston is also extensible through **[Modules](https://github.com/houston/houston-core/wiki/Modules)**.
-
+Houston is also extensible through **[Modules](https://github.com/houston/houston-core/wiki/Modules)** like:
 
+ - [Houston::Slack](https://github.com/houston/houston-slack), which gives Houston the ability to listen to messages—and respond—via Slack
+ - [Houston::Alerts](https://github.com/houston/houston-alerts), which gives Houston the ability to treat tasks from arbitrary sources as a unified queue
+ - [Houston::Feedback](https://github.com/houston/houston-feedback), which adds a view for quickly importing, tagging, and searching customer feedback
+ - [Houston::Roadmaps](https://github.com/houston/houston-roadmaps), which adds a view for planning project milestones
 
-## Getting Started with Houston
 
-##### System Requirements
+## Requirements
 
 To use Houston, you must have
 
  - [Ruby 2.0+](https://www.ruby-lang.org/en/downloads)
  - [Postgres 9.4+](http://www.postgresql.org/download)
 
-##### Hello World
+
+## Getting Started
 
  1. Install houston-core
-    
+
     ```
     gem install houston-core
     ```
@@ -52,3 +59,8 @@ To use Houston, you must have
     ```
     bundle exec rails server
     ```
+
+
+## License
+
+Houston is released under the [MIT License](http://www.opensource.org/licenses/MIT).

data/app/assets/stylesheets/houston/application/actions.scss

@@ -8,8 +8,29 @@ td.action-reliability {
   padding-right: 16px !important;
 }
 
-.action-success-rate {
-  font-size: 0.75em;
-  line-height: 20px;
-  float: right;
+.action-params {
+  pre {
+    border: none;
+    border-radius: 0;
+    background: 0;
+    font-size: 12px;
+    line-height: 16px;
+    max-width: 600px;
+    white-space: pre;
+    overflow-x: scroll;
+    margin: 0;
+  }
+
+  .action-params-short {
+    display: inline-block;
+    vertical-align: middle;
+    cursor: pointer;
+    margin: -6px -8px;
+
+    &:hover {
+      background: rgba(0, 136, 204, 0.08);
+      color: #0088cc;
+    }
+  }
+  .action-params-full { display: none; }
 }

data/app/assets/stylesheets/houston/application/sprint.scss

@@ -56,7 +56,7 @@ h2.light {
   .task-worker { white-space: nowrap; }
 
   #average_effort {
-    font-weight: 800;
+    font-weight: 700;
   }
 }
 

data/app/assets/stylesheets/houston/application/test.scss

@@ -60,7 +60,7 @@
 .project-tests tbody {
   .test-suite-name {
     color: #777;
-    font-weight: 800;
+    font-weight: 700;
   }
 
   .test-name {

data/app/assets/stylesheets/houston/application/test_run.scss

@@ -24,7 +24,7 @@ h2.test-result-banner {
     font-size: 1.5em;
     margin: 0;
 
-    .test-result-committer { font-weight: 800; }
+    .test-result-committer { font-weight: 700; }
     img { width: 1em; height: 1em; }
   }
 }
@@ -126,7 +126,7 @@ h2.test-result-banner {
   text-transform: uppercase;
   border-radius: 2px;
   color: white;
-  font-weight: 800;
+  font-weight: 700;
   text-indent: 0;
 
   &.pass  { color: #5DB64C; } // grass

data/app/assets/stylesheets/houston/application/timeline.scss

@@ -186,7 +186,7 @@ $lightGray: #eee;
 
     .ticket-resolution {
       font-size: 0.88em;
-      font-weight: 800;
+      font-weight: 700;
       color: #aaa;
 
       &::after { content: ':'; }

data/app/assets/stylesheets/houston/core/roboto.scss.erb

@@ -27,7 +27,7 @@
          url('<%= font_path("roboto-bold-webfont.woff") %>') format('woff'),
          url('<%= font_path("roboto-bold-webfont.ttf") %>') format('truetype'),
          url('<%= font_path("roboto-bold-webfont.svg") %>#robotobold') format('svg');
-    font-weight: 800;
+    font-weight: 700;
     font-style: normal;
 }
 
@@ -71,7 +71,7 @@
          url('<%= font_path("roboto-bolditalic-webfont.woff") %>') format('woff'),
          url('<%= font_path("roboto-bolditalic-webfont.ttf") %>') format('truetype'),
          url('<%= font_path("roboto-bolditalic-webfont.svg") %>#robotobold_italic') format('svg');
-    font-weight: 800;
+    font-weight: 700;
     font-style: italic;
 }
 

data/app/controllers/actions_controller.rb

@@ -1,9 +1,10 @@
 class ActionsController < ApplicationController
 
   def index
-    authorize! :show, :actions
+    authorize! :read, Action
 
-    actions_by_name = Houston.actions.names.each_with_object({}) { |name, map| map[name] = { name: name } }
+    actions_by_name = Houston.actions.to_a.each_with_object({}) { |action, map|
+      map[action.name] = { name: action.name, required_params: action.required_params } }
     actions = Action.where(name: actions_by_name.keys)
 
     most_recent_actions = actions.joins(<<-SQL)
@@ -25,13 +26,20 @@ class ActionsController < ApplicationController
   end
 
   def show
-    authorize! :show, :actions
+    authorize! :read, Action
     @action_name = params[:slug]
-    @actions = Action.where(name: @action_name).preload(:error)
+    @actions = Action.where(name: @action_name).preload(:error).limit(50)
+    @actions = @actions.where(Action.arel_table[:started_at].lt(params[:before])) if params[:before]
+    render partial: "actions/actions" if request.xhr?
+  end
+
+  def running
+    authorize! :read, Action
+    @actions = Action.where(finished_at: nil)
   end
 
   def run
-    authorize! :run, :actions
+    authorize! :run, Action
     Houston.actions.run params[:slug]
     redirect_to "/actions", notice: "#{params[:slug]} is running"
   end

data/app/controllers/errors_controller.rb

@@ -1,8 +1,8 @@
 class ErrorsController < ApplicationController
 
   def index
-    authorize! :show, Error
-    @actions = Action.reorder(finished_at: :desc).where.not(error_id: nil).includes(:error).limit(50)
+    authorize! :read, Action
+    @actions = Action.reorder(finished_at: :desc).where.not(error_id: nil).preload(:error).limit(50)
     @actions = @actions.where(Action.arel_table[:finished_at].lt(params[:before])) if params[:before]
     render partial: "errors/actions" if request.xhr?
   end

data/app/controllers/releases_controller.rb

@@ -50,7 +50,7 @@ class ReleasesController < ApplicationController
     authorize! :create, @release
 
     if @release.save
-      ProjectNotification.release(@release).deliver! if params[:send_release_email]
+      Houston.deliver! ProjectNotification.release(@release) if params[:send_release_email]
       @release.tickets.resolve_all! if params[:resolve_tickets]
 
       redirect_to @release

data/app/controllers/triggers_controller.rb

@@ -1,7 +1,7 @@
 class TriggersController < ApplicationController
 
   def index
-    authorize! :show, :triggers
+    authorize! :read, Action
     @triggers = Houston.triggers
   end
 

data/app/helpers/actions_helper.rb

@@ -1,7 +1,42 @@
 module ActionsHelper
 
   def format_action_params(params)
-    MultiJson.dump params
+    return "<pre>{}</pre>".html_safe if params == {}
+    <<-HTML.html_safe
+      <div class="action-params-short">
+        <pre>{ #{params.keys.map(&:inspect).join(", ")} }</pre>
+      </div>
+      <div class="action-params-full">
+        <pre>#{_add_white_space Houston::ParamsSerializer.new.dump(params)}</pre>
+      </div>
+    HTML
+  end
+
+  def _add_white_space(json)
+    scanner = StringScanner.new(json)
+    output = ""
+    indent = 0
+    until scanner.eos?
+      match = scanner.scan(/(?:[\[\]\{\}":,]|[^\[\]\{\}":,]+)/)
+      case match
+      when "{", "["
+        indent += 2
+        output << "#{match}\n#{" " * indent}"
+      when "}", "]"
+        indent -= 2
+        output << "\n#{" " * indent}#{match}"
+      when "\""
+        # hopefully this grabs the entire string
+        output << "\"" << scanner.scan(/.*?(?<!\\)"/)
+      when ":"
+        output << ": "
+      when ","
+        output << ",\n#{" " * indent}"
+      else
+        output << match
+      end
+    end
+    output
   end
 
 end

data/app/helpers/navigation_helper.rb

@@ -2,7 +2,9 @@ module NavigationHelper
 
   def render_navigation(key)
     renderer = Houston.get_navigation_renderer(key)
-    instance_eval &renderer
+    return unless renderer.permitted?(current_ability)
+
+    render_nav_link renderer.name, renderer.path, icon: renderer.icon
   rescue KeyError
     Rails.logger.error "\e[31;1mThere is no navigation renderer named #{key.inspect}\e[0m"
     nil
@@ -20,6 +22,9 @@ module NavigationHelper
     return unless feature.permitted?(current_ability, current_project)
 
     render_nav_link feature.name, feature.project_path(current_project), icon: feature.icon
+  rescue KeyError
+    Rails.logger.error "\e[31;1mThere is no project feature named #{feature.inspect}\e[0m"
+    nil
   end
 
   def render_nav_menu(name, items: [], icon: "fa-circle-thin")

data/app/models/github/pull_request.rb

@@ -4,7 +4,7 @@ module Github
 
     self.table_name = "pull_requests"
 
-    attr_readonly :project_id, :user_id, :repo, :number, :username, :base_ref, :base_sha, :url
+    attr_readonly :project_id, :user_id, :repo, :number, :username, :base_ref, :url
     attr_accessor :actor
 
     belongs_to :project
@@ -19,12 +19,14 @@ module Github
 
     after_create do
       Houston.observer.fire "github:pull:opened", pull_request: self
+      true
     end
 
     after_update do
       Houston.observer.fire "github:pull:updated", pull_request: self, changes: changes
       Houston.observer.fire "github:pull:closed", pull_request: self if closed_at_changed? && closed_at
       Houston.observer.fire "github:pull:reopened", pull_request: self if closed_at_changed? && !closed_at
+      true
     end
 
     validates :project_id, :title, :number, :repo, :url, :base_ref, :base_sha, :head_ref, :head_sha, :username, presence: true
@@ -88,8 +90,10 @@ module Github
 
       def sync!(projects = Project.unretired)
         expected_pulls = fetch!(projects)
+        existing_pulls = Houston.benchmark "Loading pull requests" do
+          open.where(project_id: projects.ids).to_a
+        end
         Houston.benchmark "Syncing pull requests" do
-          existing_pulls = all.to_a
 
           # Fetch unexpected pulls so that we know
           # when they were closed and whether they
@@ -108,10 +112,15 @@ module Github
               expected_pr["base"]["repo"]["name"] == existing_pr.repo &&
               expected_pr["number"] == existing_pr.number }
 
+            # Maybe the pull request was closed?
+            existing_pr ||= where(repo: expected_pr["base"]["repo"]["name"], number: expected_pr["number"]).first
+
             existing_pr ||= Github::PullRequest.new
             existing_pr.merge_attributes(expected_pr)
-            unless existing_pr.save
-              Rails.logger.warn "\e[31m[pulls] Invalid PR: #{existing_pr.errors.full_messages.join("; ")}\e[0m"
+            if existing_pr.changes.any?
+              unless existing_pr.save
+                Rails.logger.warn "\e[31m[pulls] Invalid PR: #{existing_pr.errors.full_messages.join("; ")}\e[0m"
+              end
             end
             existing_pr
           end