houston-core 0.7.0.beta3 → 0.7.0.beta4

data/app/controllers/test_runs_controller.rb

@@ -4,7 +4,18 @@ class TestRunsController < ApplicationController
 
   def show
     @title = "Test Results for #{@test_run.sha[0...8]}"
-    render template: "project_notification/test_run"
+
+    if request.format.oembed?
+      render json: MultiJson.dump({
+        version: "1.0",
+        type: "link",
+        provider_name: "Houston",
+        author_name: @project.slug,
+        title: @test_run.summary,
+        html: @test_run.short_description(with_duration: true) })
+    else
+      render template: "project_notification/test_run"
+    end
   end
 
   def confirm_retry
@@ -43,8 +54,8 @@ class TestRunsController < ApplicationController
 private
 
   def find_test_run
-    @project = Project.find_by_slug!(params[:slug])
-    @test_run = @project.test_runs.find_by_sha!(params[:commit])
+    @test_run = TestRun.find_by_sha!(params[:commit])
+    @project = @test_run.project if @test_run
   end
 
 end

data/app/controllers/triggers_controller.rb

@@ -0,0 +1,8 @@
+class TriggersController < ApplicationController
+
+  def index
+    authorize! :show, :triggers
+    @triggers = Houston.triggers
+  end
+
+end

data/app/helpers/actions_helper.rb

@@ -0,0 +1,7 @@
+module ActionsHelper
+
+  def format_action_params(params)
+    MultiJson.dump params
+  end
+
+end

data/app/helpers/application_helper.rb

@@ -70,7 +70,7 @@ module ApplicationHelper
     end
   end
 
-  def format_job_state(job)
+  def format_action_state(job)
     if job.in_progress?
       '<i class="fa fa-spinner fa-pulse"></i>'.html_safe
     elsif job.succeeded?

data/app/interactors/cache_key_dependencies.rb

@@ -15,7 +15,7 @@ class CacheKeyDependencies
   def perform!
     KeyDependency.all.each do |dependency|
       version = ProjectDependency.new(project, dependency).version
-      project.props["keyDependency.#{dependency.slug}"] = version
+      project.props["keyDependency.#{dependency.slug}"] = version.to_s
     end
     project.update_column :props, project.props.to_h
   end

data/app/interactors/test_run_comparer.rb

@@ -27,7 +27,7 @@ class TestRunComparer
 
       test_run2.update_attribute :compared, true
 
-      Houston.observer.fire "test_run:compared", test_run2
+      Houston.observer.fire "test_run:compared", test_run: test_run2
     end
   end
 

data/app/mailers/project_notification.rb

@@ -34,37 +34,6 @@ class ProjectNotification < ViewMailer
   end
 
 
-  def testing_note(testing_note, recipients)
-    @note = testing_note
-    @tester = testing_note.user
-    @ticket = testing_note.ticket
-    @project = testing_note.project
-    @verdict = testing_note.verdict
-
-    case @verdict
-    when "fails"
-      @verb = "failed"
-      @noun = "Failing Verdict"
-    when "none"
-      @verb = "commented on"
-      @noun = "Comment"
-    when "works"
-      @verb = "passed"
-      @noun = "Passing Verdict"
-    else
-      Rails.logger.warn "[project_notification] Unhandled TestingNote verdict: #{@verdict.inspect}"
-      return
-    end
-
-    mail({
-      from:     @tester,
-      to:       recipients - [@tester],
-      subject:  "#{@tester.name} #{@verb} ticket ##{@ticket.number}",
-      template: "testing_note"
-    })
-  end
-
-
   def maintainer_of_deploy(maintainer, deploy)
     @project = deploy.project
     @release = deploy.build_release

data/app/models/ability.rb

@@ -25,17 +25,6 @@ class Ability
       # If you're logged in, you can update yourself
       can :update, user
 
-
-      if user.developer? or user.tester?
-
-        # Developers and Testers can see and comment on Testing Reports
-        # They can also edit their own notes
-        can [:create, :read], TestingNote
-        can [:update, :destroy], TestingNote, user_id: user.id
-
-      end
-
-
       if user.developer?
 
         # Developers can manage projects and releases

data/app/models/{job.rb → action.rb}

@@ -1,18 +1,20 @@
-class Job < ActiveRecord::Base
+class Action < ActiveRecord::Base
 
   validates :name, :started_at, presence: true
   belongs_to :error
 
   default_scope -> { order(started_at: :desc) }
 
+  serialize :params, Houston::ParamsSerializer.new
+
 
 
   def self.started_before(time)
     where arel_table[:started_at].lteq time
   end
 
-  def self.record(job_name)
-    job = Job.create!(name: job_name, started_at: Time.now)
+  def self.record(action_name, params, trigger)
+    action = create!(name: action_name, started_at: Time.now, trigger: trigger, params: params)
     begin
       exception = nil
 
@@ -35,22 +37,32 @@ class Job < ActiveRecord::Base
            Net::OpenTimeout,
            exceptions_wrapping(PG::ConnectionBad)
 
-      # Note that the job failed, but do not report _these_ exceptions
+      # Note that the action failed, but do not report _these_ exceptions
       exception = $!
 
     rescue Exception # rescues StandardError by default; but we want to rescue and report all errors
 
       # Report all other exceptions
       exception = $!
-      Houston.report_exception($!, parameters: {job_id: job.id, job_name: job_name})
+      Houston.report_exception($!, parameters: {
+        action_id: action.id,
+        action_name: action_name,
+        trigger: trigger,
+        params: params
+      })
 
     ensure
       begin
         Houston.reconnect do
-          job.finish! exception
+          action.finish! exception
         end
       rescue Exception # rescues StandardError by default; but we want to rescue and report all errors
-        Houston.report_exception($!, parameters: {job_id: job.id, job_name: job_name})
+        Houston.report_exception($!, parameters: {
+          action_id: action.id,
+          action_name: action_name,
+          trigger: trigger,
+          params: params
+        })
       end
     end
   end

data/app/models/commit.rb

@@ -15,10 +15,10 @@ class Commit < ActiveRecord::Base
   after_create :associate_committers_with_self
   after_create :associate_tickets_with_self
   after_create :associate_tasks_with_self
-  after_create { Houston.observer.fire "commit:create", self }
+  after_create { Houston.observer.fire "commit:create", commit: self }
 
   validates :project, presence: true
-  validates :sha, presence: true, :uniqueness => {scope: :project_id}
+  validates :sha, presence: true, uniqueness: true
   validates :message, presence: true
   validates :authored_at, presence: true
   validates :committer, presence: true

data/app/models/deploy.rb

@@ -105,11 +105,11 @@ private
     if just_completed?
       update_column :duration, completed_at - created_at if duration.nil?
       if successful?
-        Houston.observer.fire "deploy:succeeded", self
+        Houston.observer.fire "deploy:succeeded", deploy: self
       else
-        Houston.observer.fire "deploy:failed", self
+        Houston.observer.fire "deploy:failed", deploy: self
       end
-      Houston.observer.fire "deploy:completed", self
+      Houston.observer.fire "deploy:completed", deploy: self
     end
   end
 

data/app/models/github/comment_event.rb

@@ -16,14 +16,20 @@ module Github
     def initialize(payload)
       super
       @comment = payload.fetch "comment"
-      @action = payload.fetch "action", "created"
+      @action = ACTION_MAP.fetch(payload.fetch "action", "created")
       comment["project"] = Project.find_by_slug payload["repository"]["name"]
     end
 
     def process!
-      Houston.observer.fire "github:comment:#{action}", comment
-      Houston.observer.fire "github:comment:#{action}:#{type}", comment
+      Houston.observer.fire "github:comment:#{action}", comment: comment
+      Houston.observer.fire "github:comment:#{type}:#{action}", comment: comment
     end
 
+    ACTION_MAP = {
+      "created" => "create",
+      "edited" => "update",
+      "deleted" => "delete"
+    }.freeze
+
   end
 end

data/app/models/github/post_receive_event.rb

@@ -7,7 +7,7 @@ module Github
     def process!
       Rails.logger.info "\e[34m[github] Processing Post-Receive Event\e[0m"
       project = Project.find_by_slug! payload["repository"]["name"]
-      Houston.observer.fire "hooks:post_receive", project, payload
+      Houston.observer.fire "hooks:project:post_receive", project: project, params: payload
     end
 
   end

data/app/models/github/pull_request.rb

@@ -18,13 +18,13 @@ module Github
     after_commit :associate_commits_with_self
 
     after_create do
-      Houston.observer.fire "github:pull:opened", self
+      Houston.observer.fire "github:pull:opened", pull_request: self
     end
 
     after_update do
-      Houston.observer.fire "github:pull:updated", self, changes
-      Houston.observer.fire "github:pull:closed", self if closed_at_changed? && closed_at
-      Houston.observer.fire "github:pull:reopened", self if closed_at_changed? && !closed_at
+      Houston.observer.fire "github:pull:updated", pull_request: self, changes: changes
+      Houston.observer.fire "github:pull:closed", pull_request: self if closed_at_changed? && closed_at
+      Houston.observer.fire "github:pull:reopened", pull_request: self if closed_at_changed? && !closed_at
     end
 
     validates :project_id, :title, :number, :repo, :url, :base_ref, :base_sha, :head_ref, :head_sha, :username, presence: true
@@ -258,7 +258,7 @@ module Github
         self.commits = project.commits.between(base_sha, head_sha)
       end
 
-      Houston.observer.fire "github:pull:synchronize", self
+      Houston.observer.fire "github:pull:synchronize", pull_request: self
     end
 
     def commits_changes_before_commit?

data/app/models/persistent_trigger.rb

@@ -0,0 +1,46 @@
+class PersistentTrigger < ActiveRecord::Base
+  self.inheritance_column = nil
+
+  serialize :value, Houston::Serializer.new
+  serialize :params, Houston::ParamsSerializer.new
+
+  TYPES = [:at, :on, :every].freeze
+  validates :type, inclusion: { in: TYPES, message: "{value} is not valid Trigger type; use #{TYPES.map(&:inspect).to_sentence(two_words_connector: " or ", last_word_connector: ", or ")}" }
+  validate :action_must_be_defined
+
+  after_create :register!
+
+
+  TYPES.each do |type|
+    instance_eval <<-RUBY, __FILE__, __LINE__ + 1
+      def #{type}(value, action, params={})
+        self.new(type: :#{type}, value: value, action: action, params: params)
+      end
+    RUBY
+  end
+
+
+  def self.load_all
+    all.find_each(&:register!)
+  end
+
+
+  def type
+    super && super.to_sym
+  end
+
+
+  def register!
+    trigger = Houston.config.triggers.build(type, value, action, params)
+    Houston.config.triggers.push(trigger) unless Houston.config.triggers.member?(trigger)
+  end
+
+
+private
+
+  def action_must_be_defined
+    return if Houston.config.actions.exists?(action)
+    errors.add :action, "#{action.inspect} is not defined"
+  end
+
+end

data/app/models/project.rb

@@ -9,7 +9,6 @@ class Project < ActiveRecord::Base
   has_many :tickets, dependent: :destroy, extend: TicketSynchronizer
   has_many :milestones, dependent: :destroy, extend: MilestoneSynchronizer
   has_many :uncompleted_milestones, -> { uncompleted }, class_name: "Milestone"
-  has_many :testing_notes, dependent: :destroy
   has_many :test_runs, dependent: :destroy
   has_many :tests, dependent: :destroy
   has_many :deploys

data/app/models/release.rb

@@ -4,7 +4,7 @@ class Release < ActiveRecord::Base
   after_create :release_each_ticket!
   after_create :release_each_task!
   after_create :release_each_antecedent!
-  after_create { Houston.observer.fire "release:create", self }
+  after_create { Houston.observer.fire "release:create", release: self }
   after_save :update_search_vector, :if => :search_vector_should_change?
 
   belongs_to :project

data/app/models/run_tests_on_post_receive.rb

@@ -16,20 +16,20 @@ class RunTestsOnPostReceive
     #   1. GitHub receives a `git push` and triggers all Web Hooks:
     #      POST /projects/houston/hooks/post_receive.
     #   2. Houston receives this request and fires the
-    #      'hooks:post_receive' event.
+    #      'hooks:project:post_receive' event.
     #   3. Houston creates a TestRun and tells a CI server to build
     #      then corresponding job:
     #      POST /job/houston/buildWithParameters.
-    Houston.observer.on "hooks:post_receive" do |project, params|
-      Rails.logger.info "\e[34m[hooks:post_receive] creating a TestRun\e[0m"
-      create_a_test_run(project, params)
+    Houston.observer.on "hooks:project:post_receive" do |e|
+      Rails.logger.info "\e[34m[hooks:project:post_receive] creating a TestRun\e[0m"
+      create_a_test_run(e.project, e.params)
     end
 
     #   4. Houston notifies GitHub that the test run has started:
     #      POST /repos/houston/houston/statuses/:sha
-    Houston.observer.on "test_run:start" do |test_run|
+    Houston.observer.on "test_run:start" do |e|
       Rails.logger.info "\e[34m[test_run:start] publishing status on GitHub\e[0m"
-      publish_status_to_github(test_run)
+      publish_status_to_github(e.test_run)
     end
 
     #   5. Jenkins checks out the project, runs the tests, and
@@ -40,22 +40,22 @@ class RunTestsOnPostReceive
     #   7. Houston updates the TestRun,
     #      fetching additional details from Jenkins:
     #      GET /job/houston/19/testReport/api/json
-    Houston.observer.on "hooks:post_build" do |project, params|
+    Houston.observer.on "hooks:post_build" do |e|
       Rails.logger.info "\e[34m[hooks:post_build] fetching TestRun results\e[0m"
-      fetch_test_run_results(project, params)
+      fetch_test_run_results(e.project, e.params)
     end
 
     #   8. Houston publishes results to GitHub:
     #      POST /repos/houston/houston/statuses/:sha
-    Houston.observer.on "test_run:complete" do |test_run|
+    Houston.observer.on "test_run:complete" do |e|
       Rails.logger.info "\e[34m[test_run:complete] publishing status on GitHub\e[0m"
-      publish_status_to_github(test_run)
+      publish_status_to_github(e.test_run)
     end
 
     #   9. Houston publishes results to Code Climate.
-    Houston.observer.on "test_run:complete" do |test_run|
+    Houston.observer.on "test_run:complete" do |e|
       Rails.logger.info "\e[34m[test_run:complete] publishing status on CodeClimate\e[0m"
-      publish_coverage_to_code_climate(test_run)
+      publish_coverage_to_code_climate(e.test_run)
     end
   end
 
@@ -63,26 +63,26 @@ class RunTestsOnPostReceive
 
   def create_a_test_run(project, params)
     unless project.has_ci_server?
-      Rails.logger.warn "[hooks:post_receive] the project #{project.name} is not configured to be used with a Continuous Integration server"
+      Rails.logger.warn "[hooks:project:post_receive] the project #{project.name} is not configured to be used with a Continuous Integration server"
       return
     end
 
     payload = PostReceivePayload.new(params)
 
     unless payload.commit
-      Rails.logger.error "[hooks:post_receive] no commit found in payload"
+      Rails.logger.error "[hooks:project:post_receive] no commit found in payload"
       return
     end
 
     if payload.commit == Houston::NULL_GIT_COMMIT
-      Rails.logger.error "[hooks:post_receive] branch was deleted; not running tests again"
+      Rails.logger.error "[hooks:project:post_receive] branch was deleted; not running tests again"
       return
     end
 
     test_run = project.test_runs.find_by_sha(payload.commit)
 
     if test_run
-      Rails.logger.warn "[hooks:post_receive] a test run exists for #{test_run.short_commit}; doing nothing"
+      Rails.logger.warn "[hooks:project:post_receive] a test run exists for #{test_run.short_commit}; doing nothing"
       return
     end
 
@@ -97,7 +97,7 @@ class RunTestsOnPostReceive
     end
 
   rescue ActiveRecord::RecordNotUnique
-    Rails.logger.warn "[hooks:post_receive] a test run exists for #{test_run.short_commit}; doing nothing"
+    Rails.logger.warn "[hooks:project:post_receive] a test run exists for #{test_run.short_commit}; doing nothing"
   rescue Exception # rescues StandardError by default; but we want to rescue and report all errors
     Houston.report_exception $!, parameters: params.merge(project: project.slug)
   end

data/app/models/task.rb

@@ -115,7 +115,7 @@ class Task < ActiveRecord::Base
   def released!(release)
     self.releases << release unless releases.exists?(release.id)
     update_column :first_release_at, release.created_at unless released?
-    Houston.observer.fire "task:released", self
+    Houston.observer.fire "task:released", task: self
   end
 
   def released?
@@ -126,7 +126,7 @@ class Task < ActiveRecord::Base
 
   def mark_committed!(commit)
     update_column :first_commit_at, commit.authored_at unless committed?
-    Houston.observer.fire "task:committed", self
+    Houston.observer.fire "task:committed", task: self
   end
 
   def committed?
@@ -138,7 +138,7 @@ class Task < ActiveRecord::Base
   def completed!
     return if completed?
     touch :completed_at
-    Houston.observer.fire "task:completed", self
+    Houston.observer.fire "task:completed", task: self
   end
   alias :complete! :completed!
 
@@ -160,7 +160,7 @@ class Task < ActiveRecord::Base
   def reopen!
     return unless manually_completed?
     update_column :completed_at, nil
-    Houston.observer.fire "task:reopened", self
+    Houston.observer.fire "task:reopened", task: self
   end
 
   def open?

data/app/models/test_run.rb

@@ -10,7 +10,8 @@ class TestRun < ActiveRecord::Base
     end
   end
 
-  validates_presence_of :project_id, :sha
+  validates :project, presence: true
+  validates :sha, presence: true, uniqueness: true
   validates :results_url, :presence => true, :if => :completed?
   validates :result, inclusion: {in: %w{aborted pass fail error}, allow_nil: true, message: "\"%{value}\" is unknown. It must be pass, fail, error, or aborted"}
   validates_associated :test_results
@@ -127,6 +128,15 @@ class TestRun < ActiveRecord::Base
     project.test_runs.find_by_sha(last_tested_ancestor.sha).failed_or_errored?
   end
 
+  def summary
+    branch = "#{project.slug}/#{self.branch}"
+    case result
+    when "pass" then "All tests passed on #{branch}"
+    when "fail" then "#{fail_count} #{fail_count == 1 ? "test" : "tests"} failed on #{branch}"
+    else "The tests are broken on #{branch}"
+    end
+  end
+
   def short_description(with_duration: false)
     passes = "#{pass_count} #{pass_count == 1 ? "test" : "tests"} passed"
     fails = "#{fail_count} #{fail_count == 1 ? "test" : "tests"} failed"
@@ -148,7 +158,7 @@ class TestRun < ActiveRecord::Base
 
 
   def url
-    "https://#{Houston.config.host}/projects/#{project.slug}/test_runs/#{sha}"
+    "https://#{Houston.config.host}/test_runs/#{sha}"
   end
 
 
@@ -213,7 +223,7 @@ class TestRun < ActiveRecord::Base
 
   def trigger_build!
     project.ci_server.build!(sha)
-    Houston.observer.fire "test_run:start", self
+    Houston.observer.fire "test_run:start", test_run: self
   end
 
   def completed!(results_url)
@@ -236,7 +246,7 @@ class TestRun < ActiveRecord::Base
   end
 
   def fire_complete!
-    Houston.observer.fire "test_run:complete", self
+    Houston.observer.fire "test_run:complete", test_run: self
   end
 
 
@@ -246,6 +256,10 @@ class TestRun < ActiveRecord::Base
     write_attribute :tests, value
   end
 
+  def failing_tests
+    tests.select { |test| test[:status] == "fail" }
+  end
+
   def tests
     @tests ||= test_results.includes(:error).joins(:test).select("test_results.*", "tests.suite", "tests.name").map do |test_result|
       message, backtrace = test_result.error.output.split("\n\n") if test_result.error
@@ -319,7 +333,6 @@ class TestRun < ActiveRecord::Base
 
         { test_run_id: id,
           test_id: tests_map[[suite, name]],
-          error_id: output.blank? ? nil : output,
           status: status,
           error_id: error_id,
           duration: test_attributes.fetch(:duration, nil) }

data/app/models/ticket.rb

@@ -10,7 +10,6 @@ class Ticket < ActiveRecord::Base
   belongs_to :project
   belongs_to :reporter, class_name: "User"
   belongs_to :milestone, counter_cache: true
-  has_many :testing_notes
   has_many :tasks, validate: false
   has_and_belongs_to_many :releases
   has_and_belongs_to_many :commits, -> { where(unreachable: false) }
@@ -36,7 +35,7 @@ class Ticket < ActiveRecord::Base
 
   attr_readonly :number, :project_id
 
-  delegate :testers, :maintainers, :min_passing_verdicts, :ticket_tracker, to: :project
+  delegate :testers, :maintainers, :ticket_tracker, to: :project
   delegate :nosync?, to: "self.class"
 
 
@@ -253,7 +252,7 @@ class Ticket < ActiveRecord::Base
 
   def released!(release)
     cache_release_attributes(release)
-    Houston.observer.fire "ticket:release", self, release
+    Houston.observer.fire "ticket:release", ticket: self, release: release
   end
 
   def resolve!
@@ -287,24 +286,6 @@ class Ticket < ActiveRecord::Base
 
 
 
-  def testing_notes_since_last_release
-    last_release_at ? testing_notes.where(["created_at > ?", last_release_at]) : testing_notes
-  end
-
-
-
-  def participants
-    @participants ||= begin              # Participants in a Ticket include:
-      User.unretired.where(id:           #
-        Array(reporter_id) +             #   - its reporter
-        testing_notes.pluck(:user_id) +  #   - anyone who has commented on it
-        releases.pluck(:user_id)) +      #   - anyone who has released it
-        committers                       #   - anyone who has comitted to it
-    end                                  #
-  end
-
-
-
 private
 
   def find_reporter?

data/app/models/ticket_antecedent.rb

@@ -25,15 +25,15 @@ class TicketAntecedent
 
 
   def released!(release=nil)
-    Houston.observer.fire "antecedent:#{kind.downcase.underscore}:released", self
+    Houston.observer.fire "antecedent:#{kind.downcase.underscore}:released", antecedent: self
   end
 
   def resolve!
-    Houston.observer.fire "antecedent:#{kind.downcase.underscore}:resolved", self
+    Houston.observer.fire "antecedent:#{kind.downcase.underscore}:resolved", antecedent: self
   end
 
   def close!
-    Houston.observer.fire "antecedent:#{kind.downcase.underscore}:closed", self
+    Houston.observer.fire "antecedent:#{kind.downcase.underscore}:closed", antecedent: self
   end
 
 end

data/app/models/user.rb

@@ -2,7 +2,6 @@ class User < ActiveRecord::Base
   include Retirement
   include Houston::Props
 
-  has_many :testing_notes
   has_many :roles, :dependent => :destroy
   has_many :credentials, :class_name => "UserCredentials", :dependent => :destroy
   has_many :tickets, foreign_key: "reporter_id"