houston-core 0.5.6 → 0.6.0

data/templates/new-instance/config/triggers/tests/slack_when_completed.rb

@@ -5,7 +5,7 @@ Houston.config do
     next if test_run.branch.nil?
     next if test_run.aborted?
 
-    nickname = SLACK_USERNAME_FOR_USER[test_run.user.email] if test_run.user
+    nickname = test_run.user.slack_username if test_run.user
     project_slug = test_run.project.slug
     project_channel = "##{project_slug}"
     branch = "#{project_slug}/#{test_run.branch}"

data/templates/new-instance/lib/slack_helpers.rb

@@ -1,6 +1,6 @@
 def slack_send_message_to(message, channel, options={})
   if channel.is_a?(User)
-    channel = SLACK_USERNAME_FOR_USER[channel.email]
+    channel = channel.slack_username
 
     unless channel
       Rails.logger.info "\e[34m[slack:say] I don't know the Slack username for #{channel.email}\e[0m"

data/test/integration/ticket_tasks_api_test.rb

@@ -60,7 +60,7 @@ class TicketTasksApiTest < ActionDispatch::IntegrationTest
 private
 
   def tasks_path
-    "api/v1/projects/#{project.slug}/tickets/by_number/#{ticket.number}/tasks"
+    "/api/v1/projects/#{project.slug}/tickets/by_number/#{ticket.number}/tasks"
   end
 
   def env

data/test/unit/adapters/git_adapter_test.rb

@@ -106,19 +106,24 @@ STR
   end
 
 
+
   test "should return a NullRepo if you give it an invalid path" do
-    path = Rails.root.join("nope")
-    repo = GitAdapter.build(Project.new, path)
-    assert_equal NullRepo, repo
+    repo = GitAdapter.build Project.new, Rails.root.join("nope")
+    assert_equal Houston::Adapters::VersionControl::NullRepo, repo
+  end
+
+  test "should return a NullRepo if you give it an invalid endpoint" do
+    repo = GitAdapter.build Project.new, "git@github.com:houston/nope.git"
+    assert_equal Houston::Adapters::VersionControl::NullRepo, repo
   end
 
 
 
   test "RemoteRepo should try pulling changes when a commit is not found" do
-    connection = OpenStruct.new(path: test_path)
+    repo = new_remote_repo
+    connection = repo.send :connection
     stub(connection).lookup { |*args| raise CommitNotFound }
     stub(connection).close
-    repo = GitAdapter::RemoteRepo.new(connection, :location)
     mock(repo).pull!(async: false)
 
     assert_raises CommitNotFound do
@@ -128,20 +133,20 @@ STR
 
 
 
-  context "GitAdapter.clone!" do
+  context "clone!" do
     setup do
       system "rm -rf #{Shellwords.escape temporary_path}"
     end
 
     should "work with a remote repo using the SSH transport" do
       remote_path = "git@github.com:houston/fixture.git"
-      GitAdapter.clone! remote_path, temporary_path
+      GitAdapter::RemoteRepo.new(temporary_path, remote_path).clone!
       assert File.exists?(fetch_head)
     end
 
     should "work with a remote repo using the Git transport" do
       remote_path = "git://github.com/houston/fixture.git"
-      GitAdapter.clone! remote_path, temporary_path
+      GitAdapter::RemoteRepo.new(temporary_path, remote_path).clone!
       assert File.exists?(fetch_head)
     end
   end
@@ -177,6 +182,18 @@ STR
 
 
 
+  context "Given a GitHub repo, it" do
+    should "be able to identify the repo name" do
+      repo = GitAdapter::GithubRepo.new temporary_path, "git://github.com/houston/fixture.git"
+      assert_equal "houston/fixture", repo.repo_name
+
+      repo = GitAdapter::GithubRepo.new temporary_path, "git@github.com:houston/fixture.git"
+      assert_equal "houston/fixture", repo.repo_name
+    end
+  end
+
+
+
 private
 
   def new_local_repo
@@ -187,6 +204,10 @@ private
     GitAdapter.connect "git://github.com/houston/fixture.git", temporary_path
   end
 
+  def github_repo
+    "git://github.com/houston/fixture.git"
+  end
+
   def test_path
     @test_path ||= Rails.root.join("test", "data", "bare_repo.git").to_s
   end

data/test/unit/adapters/version_control_adapters_api_test.rb

@@ -26,6 +26,7 @@ class VersionControlAdatersApiTest < ActiveSupport::TestCase
       assert_respond_to repo, :all_commits
       assert_respond_to repo, :ancestors
       assert_respond_to repo, :ancestors_until
+      assert_respond_to repo, :branch
       assert_respond_to repo, :branches
       assert_respond_to repo, :branches_at
       assert_respond_to repo, :commits_between
@@ -33,6 +34,7 @@ class VersionControlAdatersApiTest < ActiveSupport::TestCase
       assert_respond_to repo, :native_commit
       assert_respond_to repo, :read_file
       assert_respond_to repo, :refresh!
+      assert_respond_to repo, :exists?
     end
   end
 

data/test/unit/controllers/hooks_controller_test.rb

@@ -40,18 +40,18 @@ class HooksControllerTest < ActionController::TestCase
       pr = Object.new
       stub(Github::PullRequest).upsert! { pr }
       stub(pr).persisted? { true }
-      mock(pr).add_label!("new-label", as: "baxterthehacker")
+      mock(pr).add_label!({"name" => "new-label", "color" => "#445566"}, as: "baxterthehacker")
       post :github, hook: github_pull_request_event_payload(action: "labeled",
-        label: {name: "new-label"})
+        label: {"name" => "new-label", "color" => "#445566"})
     end
 
     should "remove a label to GitHub::PullRequest when the action is \"unlabeled\"" do
       pr = Object.new
       stub(Github::PullRequest).upsert! { pr }
       stub(pr).persisted? { true }
-      mock(pr).remove_label!("removed-label", as: "baxterthehacker")
+      mock(pr).remove_label!({"name" => "removed-label", "color" => "#445566"}, as: "baxterthehacker")
       post :github, hook: github_pull_request_event_payload(action: "unlabeled",
-        label: {name: "removed-label"})
+        label: {"name" => "removed-label", "color" => "#445566"})
     end
   end
 

data/test/unit/models/commit_test.rb

@@ -178,9 +178,9 @@ class CommitTest < ActiveSupport::TestCase
         assert_equal [], task.commits
       end
 
-      should "trigger `committed!` on each task" do
+      should "trigger `mark_committed!` on each task" do
         commit = Commit.new params(message: "[skip] Hi [#378b]")
-        mock.instance_of(Task).committed!(commit)
+        mock.instance_of(Task).mark_committed!(commit)
         commit.save!
       end
     end

data/test/unit/models/project_test.rb

@@ -11,13 +11,13 @@ class ProjectTest < ActiveSupport::TestCase
     should "validate version control parameters when a version control adapter is specified" do
       project = Project.new(version_control_name: "Git", extended_attributes: {"git_location" => "/wrong/path"})
       project.valid?
-      assert_match(/Houston can't seem to connect to it/, project.errors.full_messages.to_sentence)
+      assert project.errors[:git_location].any?
     end
 
     should "not validate version control parameters if no adapter is specified" do
       project = Project.new(version_control_name: "None", extended_attributes: {"git_location" => "/wrong/path"})
       project.valid?
-      assert_no_match(/Houston can't seem to connect to it/, project.errors.full_messages.to_sentence)
+      refute project.errors[:git_location].any?
     end
   end
 

data/test/unit/models/pull_request_test.rb

@@ -5,6 +5,11 @@ class PullRequestTest < ActiveSupport::TestCase
   attr_reader :project, :pull_request
 
 
+  def setup
+    stub(User).find_by_github_username { |*args| User.first }
+  end
+
+
   context "Given GitHub API's description of a pull request" do
     setup do
       @project = Project.create!(
@@ -98,19 +103,19 @@ class PullRequestTest < ActiveSupport::TestCase
         base_sha: "e0e4580f44317a084dd5142fef6b4144a4394819",
         head_ref: "divergent-branch",
         head_sha: "baa3ef218a40f23fe542f98d8b8e60a2e8e0bff0",
-        labels: %w{old-label})
+        labels: [{"name" => "old-label"}])
     end
 
     context "#add_label!" do
       should "add a label to the pull request" do
-        @pull_request.add_label! "new-label"
-        assert_equal %w{old-label new-label}, @pull_request.reload.labels
+        @pull_request.add_label!("name" => "new-label")
+        assert_equal [{"name" => "old-label"}, {"name" => "new-label"}], @pull_request.reload.labels
       end
     end
 
     context "#remove_label!" do
       should "remove a label from the pull request" do
-        @pull_request.remove_label! "old-label"
+        @pull_request.remove_label!("name" => "old-label")
         assert_equal [], @pull_request.reload.labels
       end
     end

data/test/unit/models/task_test.rb

@@ -90,7 +90,7 @@ class TaskTest < ActiveSupport::TestCase
     context "is committed, it" do
       should "fire 'task:committed'" do
         assert_triggered "task:committed" do
-          task.committed! Struct.new(:authored_at).new(time)
+          task.mark_committed! Struct.new(:authored_at).new(time)
         end
       end
     end

data/test/unit/models/ticket_test.rb

@@ -33,7 +33,7 @@ class TicketTest < ActiveSupport::TestCase
 
     context "on a ticket that has been released" do
       setup do
-        project = Project.new(version_control_name: "Mock")
+        project.update_column :version_control_name, "Mock"
         @ticket.update_column :first_release_at, 5.days.ago
         @ticket.releases << Release.create!(user_id: 1, project: project)
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: houston-core
 version: !ruby/object:Gem::Version
-  version: 0.5.6
+  version: 0.6.0
 platform: ruby
 authors:
 - Bob Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-28 00:00:00.000000000 Z
+date: 2015-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.13
+        version: 4.2.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.13
+        version: 4.2.5
 - !ruby/object:Gem::Dependency
   name: sprockets
   requirement: !ruby/object:Gem::Requirement
@@ -128,42 +128,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.0.1
+        version: 3.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.0.1
+        version: 3.0.1
 - !ruby/object:Gem::Dependency
   name: devise
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
   name: devise_invitable
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.5.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.5.3
 - !ruby/object:Gem::Dependency
   name: houston-devise_ldap_authenticatable
   requirement: !ruby/object:Gem::Requirement
@@ -464,42 +464,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: uglifier
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 2.7.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 2.7.2
 - !ruby/object:Gem::Dependency
   name: coffee-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.1.0
 - !ruby/object:Gem::Dependency
   name: rufus-scheduler
   requirement: !ruby/object:Gem::Requirement
@@ -830,6 +830,7 @@ files:
 - app/assets/stylesheets/application/forms.scss
 - app/assets/stylesheets/application/freight_train.css.scss
 - app/assets/stylesheets/application/full_screen.scss
+- app/assets/stylesheets/application/github_repos.scss
 - app/assets/stylesheets/application/infinite_scroll.scss
 - app/assets/stylesheets/application/keyboard_shortcuts.scss
 - app/assets/stylesheets/application/markdown.scss
@@ -918,6 +919,7 @@ files:
 - app/controllers/commits_controller.rb
 - app/controllers/concerns/.keep
 - app/controllers/deploys_controller.rb
+- app/controllers/github/pulls_controller.rb
 - app/controllers/home_controller.rb
 - app/controllers/hooks_controller.rb
 - app/controllers/jobs_controller.rb
@@ -964,6 +966,7 @@ files:
 - app/helpers/maintenance_light_helper.rb
 - app/helpers/markdown_helper.rb
 - app/helpers/navigation_helper.rb
+- app/helpers/oembed_helper.rb
 - app/helpers/project_helper.rb
 - app/helpers/release_helper.rb
 - app/helpers/score_card_helper.rb
@@ -975,6 +978,7 @@ files:
 - app/helpers/url_helper.rb
 - app/helpers/user_helper.rb
 - app/helpers/version_helper.rb
+- app/interactors/cache_key_dependencies.rb
 - app/interactors/test_run_comparer.rb
 - app/interactors/ticket_report.rb
 - app/jobs/sync_all_tickets_job.rb
@@ -1080,6 +1084,7 @@ files:
 - app/views/devise/registrations/new.html.erb
 - app/views/devise/sessions/new.html.erb
 - app/views/devise/unlocks/new.html.erb
+- app/views/github/pulls/index.html.erb
 - app/views/home/index.html.erb
 - app/views/jobs/show.html.erb
 - app/views/layouts/_mobile_navigation.html.erb
@@ -1121,6 +1126,7 @@ files:
 - app/views/projects/edit.html.erb
 - app/views/projects/index.html.erb
 - app/views/projects/new.html.erb
+- app/views/projects/new_from_github.html.erb
 - app/views/releases/_antecedents.html.erb
 - app/views/releases/_changelog.html.erb
 - app/views/releases/_commits.html.erb
@@ -1379,6 +1385,13 @@ files:
 - db/migrate/20151108221505_convert_pull_request_labels_to_array.rb
 - db/migrate/20151108223154_sync_body_also_for_pull_requests.rb
 - db/migrate/20151108233510_add_props_to_pull_requests.rb
+- db/migrate/20151201042126_require_projects_to_have_name_and_slug.rb
+- db/migrate/20151202005557_add_head_sha_to_projects.rb
+- db/migrate/20151202011812_require_projects_to_have_color.rb
+- db/migrate/20151205204922_require_project_slugs_to_be_unique.rb
+- db/migrate/20151205214647_add_avatar_url_to_pull_requests.rb
+- db/migrate/20151209004458_add_json_labels_to_pull_requests.rb
+- db/migrate/20151209030113_add_timestamps_to_pull_requests.rb
 - db/seeds.rb
 - db/structure.sql
 - houston.gemspec
@@ -1397,6 +1410,7 @@ files:
 - lib/houston_server.rb
 - lib/parallel_enumerable.rb
 - lib/patches/sprockets_output_path_for_assets.rb
+- lib/rack/oembed.rb
 - lib/tasks/.gitkeep
 - lib/tasks/.keep
 - lib/tasks/keypair.rake
@@ -1442,6 +1456,7 @@ files:
 - templates/new-instance/config/integrations/github.rb
 - templates/new-instance/config/integrations/jenkins.rb
 - templates/new-instance/config/integrations/ldap.rb
+- templates/new-instance/config/jobs/cache_key_dependencies.rb
 - templates/new-instance/config/jobs/email_about_open_alerts.rb
 - templates/new-instance/config/jobs/slack_reminders_about_alerts.rb
 - templates/new-instance/config/jobs/sync_commits.rb