houston-core 0.5.0.beta1 → 0.5.0

data/app/controllers/releases_controller.rb

@@ -2,39 +2,39 @@ class ReleasesController < ApplicationController
   include UrlHelper
   before_filter :get_project_and_environment
   before_filter :load_tickets, only: [:new, :edit, :create, :update]
-  
+
   def index
     @title = "Releases • #{@project.name}"
     @title << " (#{@environment})" if @environment
   end
-  
+
   def show
     @release = @releases.find(params[:id])
     authorize! :show, @release
-    
+
     @title = "Release #{@release.release_date.strftime("%b %-d")} • #{@project.name}"
   end
-  
+
   def new
     @title = "New Release (#{@environment}) • #{@project.name}"
-    
+
     @deploy = Deploy.find_by_id(params[:deploy_id])
     @releases = @releases.before(@deploy.completed_at) if @deploy
     @commit0 = params.fetch :commit0, @releases.most_recent_commit
     @commit1 = params.fetch :commit1, @deploy.try(:commit)
     @release = @releases.new(commit0: @commit0, commit1: @commit1, deploy: @deploy)
     authorize! :create, @release
-    
+
     @manual = params[:manual] == "true" || !@project.has_version_control?
-    
+
     if @release.can_read_commits?
       @release.load_commits!
       @release.load_tickets!
       @release.build_changes_from_commits
     end
-    
+
     @release.release_changes = [ReleaseChange.new(@release, "", "")] if @release.release_changes.none?
-    
+
     if request.headers["X-PJAX"]
       render template: "releases/_new_release", layout: false
     else
@@ -45,7 +45,7 @@ class ReleasesController < ApplicationController
   def edit
     @release = @releases.find(params[:id])
     authorize! :update, @release
-    
+
     if params[:recreate]
       if @release.can_read_commits?
         @release.load_commits!
@@ -53,7 +53,7 @@ class ReleasesController < ApplicationController
         @release.build_changes_from_commits
       end
     end
-    
+
     @release.release_changes = [ReleaseChange.new(@release, "", "")] if @release.release_changes.none?
     @release.valid?
   end
@@ -62,50 +62,50 @@ class ReleasesController < ApplicationController
     @release = @releases.new(params[:release])
     @release.user = current_user
     authorize! :create, @release
-    
+
     if @release.save
       ProjectNotification.release(@release).deliver! if params[:send_release_email]
       @release.tickets.resolve_all! if params[:resolve_tickets]
-      
+
       redirect_to @release
     else
       @commit0 = @release.commit0
       @commit1 = @release.commit1
-      
+
       if @release.can_read_commits?
         @release.load_commits!
         @release.load_tickets!
       end
-      
+
       render action: "new"
     end
   end
-  
+
   def update
     @release = @releases.find(params[:id])
     authorize! :update, @release
-    
+
     if @release.update_attributes(params[:release])
       redirect_to @release, notice: "Release was successfully updated."
     else
       render action: "edit"
     end
   end
-  
+
   def destroy
     @release = @releases.find(params[:id])
     authorize! :destroy, @release
-    
+
     @release.destroy
-    
+
     redirect_to releases_url
   end
-  
+
 private
-  
+
   def get_project_and_environment
     @project = Project.find_by_slug!(params[:project_id])
-    @environment = params[:environment] || @project.environments.first
+    @environment = params[:environment] || @project.environments_with_release_notes.first
     @deploys = @project.deploys
       .completed
       .to(@environment)
@@ -116,7 +116,7 @@ private
       .includes(:project)
       .includes(:deploy)
   end
-  
+
   def load_tickets
     @tickets = @project.tickets.includes(:project).map do |ticket|
       { id: ticket.id,
@@ -126,5 +126,5 @@ private
         number: ticket.number }
     end
   end
-  
+
 end

data/app/controllers/reports_controller.rb

@@ -2,13 +2,13 @@ class ReportsController < ApplicationController
   before_filter { authorize! :read, :reports }
   before_filter :find_tickets, only: [:queue_age, :cycle_time, :time_to_first_test, :time_to_release]
   layout "minimal"
-  
+
   attr_reader :tickets, :start_date, :end_date
-  
+
   def index
     @title = "Reports"
   end
-  
+
   def queue_age
     results = benchmark("pluck") do
       tickets.joins(<<-SQL)
@@ -20,13 +20,13 @@ class ReportsController < ApplicationController
         .reorder("months.month ASC")
         .pluck("months.month::date", "extract('epoch' from month - tickets.created_at)")
     end
-    
+
     results = benchmark("process") do
       results \
        .each_with_object(Hash.new { |h, k| h[k] = [] }) { |(date, age), map| map[date].push(age) }
        .map { |date, ages| [date] + to_age_bins(ages) }
     end
-    
+
     line = benchmark("line") do
       tickets.closed
         .group("date_trunc('month', closed_at)::date")
@@ -34,12 +34,12 @@ class ReportsController < ApplicationController
         .pluck("date_trunc('month', closed_at)::date", "COUNT(id)")
         .map { |(month, count)| {date: month, y: count} }
     end
-    
+
     benchmark("present") do
       render json: {data: results, line: line}
     end
   end
-  
+
   def cycle_time
     results = benchmark("pluck") do
       tickets.joins(<<-SQL)
@@ -52,12 +52,12 @@ class ReportsController < ApplicationController
         .reorder("months.month ASC")
         .pluck("months.month::date", "AVG(extract('epoch' from month - tickets.created_at)) / 86400")
     end
-    
+
     benchmark("present") do
       render json: results
     end
   end
-  
+
   def time_to_release
     results = benchmark("pluck") do
       Ticket.connection.select_rows(<<-SQL)
@@ -72,7 +72,7 @@ class ReportsController < ApplicationController
             tickets.closed_at,
             to_production.created_at "released_at"
           FROM tickets
-          
+
           INNER JOIN (
             SELECT rt1.ticket_id, MIN(r1.created_at) "created_at"
             FROM releases r1
@@ -80,7 +80,7 @@ class ReportsController < ApplicationController
             WHERE r1.environment_name = 'Staging'
             GROUP BY rt1.ticket_id
           ) AS to_staging ON to_staging.ticket_id=tickets.id
-          
+
           INNER JOIN (
             SELECT rt2.ticket_id, MIN(r2.created_at) "created_at"
             FROM releases r2
@@ -88,7 +88,7 @@ class ReportsController < ApplicationController
             WHERE r2.environment_name = 'Production'
             GROUP BY rt2.ticket_id
           ) AS to_production ON to_production.ticket_id=tickets.id
-          
+
         ) AS q
           ON q.released_at >= months.month
           AND q.released_at < (months.month + interval '1 month')
@@ -99,12 +99,12 @@ class ReportsController < ApplicationController
       SQL
         .map { |(date, v1, v2, v3)| [date.to_date, v1.to_i, v2.to_i, v3.to_i] }
     end
-    
+
     benchmark("present") do
       render json: results
     end
   end
-  
+
   def time_to_first_test
     results = benchmark("pluck") do
       Ticket.connection.select_rows(<<-SQL)
@@ -117,7 +117,7 @@ class ReportsController < ApplicationController
             to_staging.created_at "to_staging_at",
             first_test.created_at "testing_started_at"
           FROM tickets
-          
+
           INNER JOIN (
             SELECT rt1.ticket_id, MIN(r1.created_at) "created_at"
             FROM releases r1
@@ -125,13 +125,13 @@ class ReportsController < ApplicationController
             WHERE r1.environment_name = 'Staging'
             GROUP BY rt1.ticket_id
           ) AS to_staging ON to_staging.ticket_id=tickets.id
-          
+
           INNER JOIN (
             SELECT tn.ticket_id, MIN(tn.created_at) "created_at"
             FROM testing_notes tn
             GROUP BY tn.ticket_id
           ) AS first_test ON first_test.ticket_id=tickets.id
-          
+
         ) AS q
           ON q.to_staging_at >= months.month
           AND q.to_staging_at < (months.month + interval '1 month')
@@ -141,30 +141,30 @@ class ReportsController < ApplicationController
       SQL
         .map { |(date, v1, v2, v3)| [date.to_date, v1.to_i, v2.to_i, v3.to_i] }
     end
-    
+
     benchmark("present") do
       render json: results
     end
   end
-  
-  
-  
+
+
+
   def velocity
     @title = "Reports"
     @tickets = ::Ticket.includes(:project, :tasks).estimated.closed
       .select { |ticket| ticket.commit_time > 0 } # <-- speed up
   end
-  
+
   def sprint
     @title = "Sprint Reports"
     @start_date = Date.parse(params.fetch(:since, "2014-05-18")) # when tasks were added
     @start_date = Date.parse(params.fetch(:since, "2014-08-07"))
     @end_date = Date.today
-    
+
     @users = []
     ([nil] + User.developers).each do |user|
       data = SprintReport.new(user, start_date, end_date).to_a
-      
+
       next if data.all? { |(_, completed, missed)| (completed + missed).zero? }
       average = data
         .select { |_, completed, missed| (completed + missed) > 0 }
@@ -173,9 +173,9 @@ class ReportsController < ApplicationController
     end
     @users.sort_by! { |(_, average, _)| -average }
   end
-  
-  
-  
+
+
+
   def tasks_excel
     authorize! :read, "Report"
     tasks = Task.completed
@@ -184,32 +184,32 @@ class ReportsController < ApplicationController
       filename: "Tasks.xlsx",
       disposition: "attachment"
   end
-  
-  
-  
+
+
+
 private
-  
+
   CUTOFFS = [3.weeks, 3.months, 9.months, 2.years, 99.years].freeze
-  
+
   def to_age_bins(ages)
     ages.each_with_object([0, 0, 0, 0, 0]) do |age, bins|
       bins[to_bin(age)] += 1
     end
   end
-  
+
   def to_bin(age)
     CUTOFFS.each_with_index do |cutoff, i|
       return i if age < cutoff
     end
   end
-  
+
   def find_tickets
     @tickets = Ticket.reorder(:created_at)
     @tickets = tickets.where(project_id: params[:project_id]) if params[:project_id]
     @tickets = tickets.where(project_id: params[:projects].split(",")) if params[:projects]
-    
+
     @start_date = params.fetch(:since, "2010-01-01")
     @end_date = Date.today.strftime "%Y-%m-%d"
   end
-  
+
 end

data/app/controllers/sessions_controller.rb

@@ -1,8 +1,8 @@
 class SessionsController < Devise::SessionsController
   before_filter :store_location, :only => [:new]
-  
+
   def store_location
     session["user_redirect_to"] = request.referer unless request.referer =~ /\/users\/sign_in/
   end
-  
+
 end

data/app/controllers/settings_controller.rb

@@ -1,14 +1,14 @@
 class SettingsController < ApplicationController
   load_and_authorize_resource
-  
+
   def show
     @settings = Settings.new
   end
-  
+
   def update
     @settings = Settings.new(params[:settings])
     @settings.save!
     redirect_to settings_path, :notice => "Changes saved"
   end
-  
+
 end

data/app/controllers/sprint_task_locks_controller.rb

@@ -1,16 +1,16 @@
 class SprintTaskLocksController < ApplicationController
   before_filter :authenticate_user!
   before_filter :find_sprint_and_task
-  
+
   attr_reader :sprint, :task
-  
-  
+
+
   def create
     if sprint.completed?
       render json: {base: ["The Sprint is completed. You cannot check out or check in tasks."]}, status: :unprocessable_entity
       return
     end
-    
+
     if task.checked_out?(sprint)
       render json: {base: ["Task ##{task.shorthand} is already checked out"]}, status: 422
     else
@@ -18,14 +18,14 @@ class SprintTaskLocksController < ApplicationController
       head :ok
     end
   end
-  
-  
+
+
   def destroy
     if sprint.completed?
       render json: {base: ["The Sprint is completed. You cannot check out or check in tasks."]}, status: :unprocessable_entity
       return
     end
-    
+
     if task.checked_out_by_me?(sprint, current_user)
       task.check_in!(sprint)
       head :ok
@@ -35,13 +35,13 @@ class SprintTaskLocksController < ApplicationController
       head :ok
     end
   end
-  
-  
+
+
 private
-  
+
   def find_sprint_and_task
     @sprint = Sprint.find params[:id]
     @task = Task.find params[:task_id]
   end
-  
+
 end

data/app/controllers/sprints_controller.rb

@@ -1,17 +1,17 @@
 class SprintsController < ApplicationController
   attr_reader :sprint, :task
-  
+
   before_filter :authenticate_user!, except: [:dashboard]
   before_filter :find_sprint, only: [:show, :lock, :add_task, :remove_task]
   before_filter :find_task, only: [:add_task, :remove_task]
-  
-  
+
+
   def current
     @sprint = Sprint.current || Sprint.create!
     redirect_to sprint
   end
-  
-  
+
+
   def show
     authorize! :read, sprint
     @title = "Sprint #{sprint.end_date.strftime("%-m/%-d")}"
@@ -19,12 +19,12 @@ class SprintsController < ApplicationController
     @tasks = @sprint.tasks
     render template: "sprints/show"
   end
-  
-  
+
+
   def dashboard
     @title = "Sprint"
     @sprint = Sprint.find_by_id(params[:id]) || Sprint.current || Sprint.create!
-    
+
     respond_to do |format|
       format.json { render json: {
         start: @sprint.start_date,
@@ -32,31 +32,31 @@ class SprintsController < ApplicationController
       format.html { render layout: "dashboard" }
     end
   end
-  
-  
+
+
   def lock
     authorize! :manage, sprint
     sprint.lock!
     head :ok
   end
-  
-  
+
+
   def add_task
     authorize! :update, sprint
-    
+
     if sprint.completed?
       render json: {base: ["The Sprint is completed. You cannot add or remove tasks."]}, status: :unprocessable_entity
       return
     end
-    
+
     if sprint.locked? && !task.ticket_id.in?(sprint.ticket_ids)
       render json: {base: ["The Sprint is locked. You can add tasks for tickets that are already in the Sprint, but you can't add new tickets to the Sprint."]}, status: :unprocessable_entity
       return
     end
-    
+
     # Putting a task into a Sprint implies that you're able to estimate this ticket
     task.ticket.able_to_estimate! if task.ticket.respond_to?(:able_to_estimate!)
-    
+
     if task.completed? && task.completed_at < sprint.starts_at
       render json: {base: ["Task ##{task.shorthand} cannot be added to the Sprint because it was completed before the Sprint began"]}, status: :unprocessable_entity
     elsif task.effort.nil? or task.effort.zero?
@@ -67,33 +67,33 @@ class SprintsController < ApplicationController
       render json: SprintTaskPresenter.new(sprint, task).to_json
     end
   end
-  
+
   def remove_task
     authorize! :update, sprint
-    
+
     if sprint.completed?
       render json: {base: ["The Sprint is completed. You cannot add or remove tasks."]}, status: :unprocessable_entity
       return
     end
-    
+
     if sprint.locked?
       render json: {base: ["The Sprint is locked; tasks cannot be removed"]}, status: :unprocessable_entity
       return
     end
-    
+
     SprintTask.where(sprint_id: sprint.id, task_id: task.id).delete_all
     head :ok
   end
-  
-  
+
+
 private
-  
+
   def find_sprint
     @sprint = Sprint.find(params[:id])
   end
-  
+
   def find_task
     @task = Task.find(params[:task_id])
   end
-  
+
 end

data/app/controllers/tasks_controller.rb

@@ -1,11 +1,11 @@
 class TasksController < ApplicationController
   before_filter :find_task
-  
+
   attr_reader :task
-  
+
   def update
     authorize! :update, task
-    
+
     project = task.project
     effort = params[:effort]
     effort = effort.to_d if effort
@@ -14,27 +14,27 @@ class TasksController < ApplicationController
     task.update_attributes effort: effort
     render json: [], status: :ok
   end
-  
+
   def complete
     authorize! :update, task
-    
+
     # !todo: authorize completing a task
     task.complete! unless task.completed?
     render json: TaskPresenter.new(task)
   end
-  
+
   def reopen
     authorize! :update, task
-    
+
     # !todo: authorize completing a task
     task.reopen! unless task.open?
     render json: TaskPresenter.new(task)
   end
-  
+
 private
-  
+
   def find_task
     @task = Task.find params[:id]
   end
-  
+
 end

data/app/controllers/test_runs_controller.rb

@@ -1,35 +1,35 @@
 class TestRunsController < ApplicationController
   before_filter :find_test_run
-  
+
   def show
     @title = "Test Results for #{@test_run.sha[0...8]}"
     render template: "project_notification/test_run"
   end
-  
+
   def confirm_retry
   end
-  
+
   def retry
     @test_run.retry!
-    
+
     build_url = if @project.ci_server.respond_to? :last_build_progress_url
       @project.ci_server.last_build_progress_url
     elsif @project.ci_server.respond_to? :last_build_url
       @project.ci_server.last_build_url
     end
-    
+
     if build_url
       redirect_to build_url
     else
       redirect_to root_url, notice: "Build for #{@project.name} retried"
     end
   end
-  
+
 private
-  
+
   def find_test_run
     @project = Project.find_by_slug!(params[:slug])
     @test_run = @project.test_runs.find_by_sha(params[:commit]) || (raise ActiveRecord::RecordNotFound)
   end
-  
+
 end

data/app/controllers/tester_bar_controller.rb

@@ -1,5 +1,5 @@
 class TesterBarController < ApplicationController
-  
+
   def login_as
     user = User.find_by_email(params[:email])
     if user
@@ -8,5 +8,5 @@ class TesterBarController < ApplicationController
     end
     redirect_to request.referrer || root_url
   end
-  
+
 end