house_style 4.0.2 → 4.0.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +10 -0
- data/house_style.gemspec +2 -2
- data/rspec/rubocop.yml +1 -1
- data/ruby/rubocop.yml +7 -1
- metadata +3 -3
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: d7d486909e392dafd10a890e1adde07b917cc40517a2066fcca31fb52410c817
|
|
4
|
+
data.tar.gz: '048057b7acf64971789b8f802af691412e6f5aaff08989ecb1b474e6f445b03e'
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: e897e5032089371b2608febcf3996c97694ab7907adde2bb83352840e2c06a6031a37e9eae1b320f47506b83748d25ec5234de9fbae15f00e2c7ff2844c4ebd2
|
|
7
|
+
data.tar.gz: ab866d11183ad3ccd7128cd81aa2dd455c18280be1377ab479dc5f710c598e1633e15c6fea6f5f41af02dc6a163d9b7c09c3b821c73d6dacd6aaa0107406dd59
|
data/CHANGELOG.md
CHANGED
|
@@ -2,6 +2,16 @@
|
|
|
2
2
|
|
|
3
3
|
## CURRENT
|
|
4
4
|
|
|
5
|
+
## 4.0.4
|
|
6
|
+
|
|
7
|
+
### Changes
|
|
8
|
+
- Disable `Style/IfUnlessModifier`. rubocop 1.89.0 centralised the modifier line-fit check so modifier cops now defer to `Layout/LineLength`'s exemption ladder (rubocop/rubocop#15493). Our `Layout/LineLength` `AllowedPatterns` exempt any line containing a quoted string, so the cop read almost every line as unbounded and demanded modifier form for conditionals that collapse to between 121 and 247 characters. This broke `rubocop` across eight repos at once. The cop stays off until `AllowedPatterns` is narrowed to match genuinely long strings rather than any line that contains one.
|
|
9
|
+
|
|
10
|
+
## 4.0.3
|
|
11
|
+
|
|
12
|
+
### Changes
|
|
13
|
+
- Rename `Capybara/CurrentPathExpectation` to `Capybara/RSpec/CurrentPathExpectation`. rubocop-capybara 2.23.0 moved the cop under the `Capybara/RSpec` namespace and flags the old name as obsolete config, which fails `rubocop` in consuming repos. Bump the `rubocop-capybara` floor to `~> 2.23` so the new cop name is always recognised.
|
|
14
|
+
|
|
5
15
|
## 4.0.2
|
|
6
16
|
|
|
7
17
|
### Changes
|
data/house_style.gemspec
CHANGED
|
@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
|
|
|
3
3
|
|
|
4
4
|
Gem::Specification.new do |spec|
|
|
5
5
|
spec.name = 'house_style'
|
|
6
|
-
spec.version = '4.0.
|
|
6
|
+
spec.version = '4.0.4'
|
|
7
7
|
spec.authors = ['Altmetric', 'Scott Matthewman']
|
|
8
8
|
spec.email = ['engineering@altmetric.com', 'scott.matthewman@gmail.com']
|
|
9
9
|
|
|
@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
|
|
|
19
19
|
spec.add_dependency 'rubocop-performance', '~> 1.26'
|
|
20
20
|
spec.add_dependency 'rubocop-rails', '~> 2.32'
|
|
21
21
|
spec.add_dependency 'rubocop-rspec', '~> 3.7'
|
|
22
|
-
spec.add_dependency 'rubocop-capybara', '~> 2.
|
|
22
|
+
spec.add_dependency 'rubocop-capybara', '~> 2.23'
|
|
23
23
|
spec.add_dependency 'rubocop-factory_bot', '~> 2.27'
|
|
24
24
|
|
|
25
25
|
spec.add_development_dependency 'bundler', '~> 2.0'
|
data/rspec/rubocop.yml
CHANGED
data/ruby/rubocop.yml
CHANGED
|
@@ -538,7 +538,13 @@ Style/IdenticalConditionalBranches:
|
|
|
538
538
|
Style/IfInsideElse:
|
|
539
539
|
Enabled: true
|
|
540
540
|
Style/IfUnlessModifier:
|
|
541
|
-
|
|
541
|
+
# Off since rubocop 1.89, which made modifier cops defer to
|
|
542
|
+
# Layout/LineLength's exemption ladder (rubocop/rubocop#15493). Our
|
|
543
|
+
# AllowedPatterns exempt any line holding a quoted string, so the cop treats
|
|
544
|
+
# almost every line as unbounded and demands modifier form for conditionals
|
|
545
|
+
# that collapse to between 121 and 247 characters. Re-enable once
|
|
546
|
+
# AllowedPatterns matches genuinely long strings, not any line containing one.
|
|
547
|
+
Enabled: false
|
|
542
548
|
Style/IfUnlessModifierOfIfUnless:
|
|
543
549
|
Enabled: true
|
|
544
550
|
Style/IfWithBooleanLiteralBranches:
|
metadata
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: house_style
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 4.0.
|
|
4
|
+
version: 4.0.4
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Altmetric
|
|
@@ -78,14 +78,14 @@ dependencies:
|
|
|
78
78
|
requirements:
|
|
79
79
|
- - "~>"
|
|
80
80
|
- !ruby/object:Gem::Version
|
|
81
|
-
version: '2.
|
|
81
|
+
version: '2.23'
|
|
82
82
|
type: :runtime
|
|
83
83
|
prerelease: false
|
|
84
84
|
version_requirements: !ruby/object:Gem::Requirement
|
|
85
85
|
requirements:
|
|
86
86
|
- - "~>"
|
|
87
87
|
- !ruby/object:Gem::Version
|
|
88
|
-
version: '2.
|
|
88
|
+
version: '2.23'
|
|
89
89
|
- !ruby/object:Gem::Dependency
|
|
90
90
|
name: rubocop-factory_bot
|
|
91
91
|
requirement: !ruby/object:Gem::Requirement
|