house_style 2.1.0 → 2.3.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 60dd79ae28c2a1699e7484038e09b801a34f6a61d7657ab7ba64a7cbf70db40d
4
- data.tar.gz: 78084875ed16986c3b8291e356498ec97607454d3364b0532e744d81074af377
3
+ metadata.gz: 29e5114e9c83f5b90caceb9be694f39637960c5795e9f9246666302be796836d
4
+ data.tar.gz: 7633b076ec8d475f44675cbcbbb215d5423e7c5159c9096aa4f8aa916ecc6a07
5
5
  SHA512:
6
- metadata.gz: b3eeb1147984ef9a73d8ec6510dd6df3300e61abc487e66d88ec84c3cc27b00ee00c8bb9756e0283b2ebba06f85ab8fe95980ddae2b9f4fc0cfcf2d916217032
7
- data.tar.gz: 7edfe2d0ebff0553ff58c1c582196e5ef17c80e32dbc9f7805f2fa43fa85d3e9efc6bab11675707218d5a4a4ff0d0b7f64e9c396a6fd95e5feab18de42755214
6
+ metadata.gz: bef45d1bc0b477eac9da7d8525b2202cc0fb6f80cf14908bdecdcf988a16021e8454f701d645d3c26a34502693b6aa97a89c6357b91fdc33a1280cafdae4f8a6
7
+ data.tar.gz: 80177fd9d2e22aec9f3c8f33749d1b9d44113cd72c9ce5233212d8d740a6c0aeff3c2d6679ee0af622a2e3f829c686435d28267022e25a8c7299f676411eea8e
data/CHANGELOG.md CHANGED
@@ -1,5 +1,24 @@
1
1
  # CHANGELOG
2
2
 
3
+ ## CURRENT
4
+
5
+ ## 2.3.0
6
+ ### Changes
7
+ - Exclude more Rails configuration files affected by rails app:update.
8
+
9
+ ## 2.2.1
10
+ ### Bug fixes
11
+ - Do not skip features/ directory in the gem when packaging.
12
+
13
+ ## 2.2.0
14
+ ### Bug fixes
15
+ - Install db_migrate.yml only if `db/migrate/` folder exists rather than just `db/` folder.
16
+ ### Changes
17
+ - Rails: Move the AllCops to the Ruby one instead of repeating the same block. Disable Rails/SquishedSQLHeredocs and Rails/SkipsModelValidations.
18
+ - RSpec: Disable Spec/ContextWording, RSpec/NestedGroups, RSpec/DescribeClass and Style/BlockDelimiters.
19
+ ### New features
20
+ - Add new configuration for feature tests inside `features/` folder.
21
+
3
22
  ## 2.1.0
4
23
  - Enable NewCops by default
5
24
  - Support Rubocop up to 1.22.x and latest extensions
@@ -0,0 +1,15 @@
1
+ inherit_from: ../ruby/rubocop.yml
2
+
3
+ Layout/LineLength:
4
+ Enabled: false
5
+ Metrics/BlockLength:
6
+ Enabled: false
7
+ Metrics/ModuleLength:
8
+ Enabled: false
9
+ Style/BlockDelimiters:
10
+ Exclude:
11
+ - factories/**/*
12
+ Style/Documentation:
13
+ Enabled: false
14
+ Style/WordArray:
15
+ Enabled: false
data/house_style.gemspec CHANGED
@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
3
3
 
4
4
  Gem::Specification.new do |spec|
5
5
  spec.name = 'house_style'
6
- spec.version = '2.1.0'
6
+ spec.version = '2.3.0'
7
7
  spec.authors = ['Altmetric', 'Scott Matthewman']
8
8
  spec.email = ['engineering@altmetric.com', 'scott.matthewman@gmail.com']
9
9
 
@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
12
12
  spec.homepage = 'https://github.com/altmetric/house_style'
13
13
  spec.license = 'MIT'
14
14
 
15
- spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
15
+ spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|.gitignore|)/}) }
16
16
  spec.require_paths = ['lib']
17
17
 
18
18
  spec.add_dependency 'rubocop', '>= 1.0', '< 1.23'
@@ -12,17 +12,25 @@ module HouseStyle
12
12
  end
13
13
 
14
14
  def create_rspec_rubocop_yml
15
- template 'rspec-rubocop.yml', 'spec/.rubocop.yml'
15
+ template 'rspec_rubocop.yml', 'spec/.rubocop.yml'
16
16
  end
17
17
 
18
18
  def create_db_migrate_rubocop_yml
19
19
  template 'db_migrate_rubocop.yml', 'db/migrate/.rubocop.yml' if Dir.exist?(db_path)
20
20
  end
21
21
 
22
+ def create_features_rubocop_yml
23
+ template 'features_rubocop.yml', 'features/.rubocop.yml' if Dir.exist?(features_path)
24
+ end
25
+
22
26
  private
23
27
 
24
28
  def db_path
25
- File.join(Rails.root, 'db')
29
+ File.join(Rails.root, 'db', 'migrate')
30
+ end
31
+
32
+ def features_path
33
+ File.join(Rails.root, 'features')
26
34
  end
27
35
  end
28
36
  end
@@ -0,0 +1,3 @@
1
+ inherit_from: ../.rubocop.yml
2
+ inherit_gem:
3
+ house_style: features/rubocop.yml
data/rails/rubocop.yml CHANGED
@@ -3,13 +3,6 @@ inherit_from:
3
3
  - ./default_rules.yml
4
4
  - ./style.yml
5
5
 
6
- AllCops:
7
- Exclude:
8
- - bin/**/*
9
- - vendor/**/*
10
- - db/*schema.rb
11
- - lib/tasks/cucumber.rake
12
- - Guardfile
13
6
  Rails:
14
7
  Enabled: true
15
8
  Rails/InverseOf:
@@ -21,5 +14,9 @@ Rails/EnvironmentVariableAccess:
21
14
  AllowReads: true
22
15
  Rails/ShortI18n:
23
16
  Enabled: false
17
+ Rails/SquishedSQLHeredocs:
18
+ Enabled: false
19
+ Rails/SkipsModelValidations:
20
+ Enabled: false
24
21
 
25
22
  require: rubocop-rails
data/rails/style.yml CHANGED
@@ -22,10 +22,8 @@ Style/StringLiterals:
22
22
  - config/environments/test.rb
23
23
  - config/initializers/**
24
24
  - config/puma.rb
25
- - config.ru
26
25
  - Rakefile
27
26
 
28
27
  Style/SymbolArray:
29
28
  Exclude:
30
29
  - config/initializers/filter_parameter_logging.rb
31
-
data/rspec/rubocop.yml CHANGED
@@ -14,8 +14,7 @@ Metrics/BlockLength:
14
14
  Metrics/ModuleLength:
15
15
  Enabled: false
16
16
  RSpec/ContextWording:
17
- Exclude:
18
- - spec/support/shared_contexts/rake.rb
17
+ Enabled: false
19
18
  RSpec/ExampleLength:
20
19
  Enabled: false
21
20
  RSpec/MultipleExpectations:
@@ -24,9 +23,12 @@ RSpec/MultipleMemoizedHelpers:
24
23
  Max: 10
25
24
  RSpec/NotToNot:
26
25
  EnforcedStyle: to_not
26
+ RSpec/NestedGroups:
27
+ Enabled: false
28
+ RSpec/DescribeClass:
29
+ Enabled: false
27
30
  Style/BlockDelimiters:
28
- Exclude:
29
- - spec/factories/**/*.rb
31
+ Enabled: false
30
32
  Style/Documentation:
31
33
  Enabled: false
32
34
  Style/SymbolProc:
@@ -6,9 +6,17 @@ AllCops:
6
6
  NewCops: enable
7
7
 
8
8
  Exclude:
9
- - 'bin/**/*'
10
- - 'vendor/**/*'
11
- - 'Guardfile'
9
+ - bin/**/*
10
+ - vendor/**/*
11
+ - Guardfile
12
+ - lib/tasks/cucumber.rake
13
+ - node_modules/**/*
14
+ - tmp/**/*
15
+ - db/*schema.rb
16
+ - config.ru
17
+ - config/environments/**/*
18
+ - config/puma.rb
19
+ - config/spring.rb
12
20
 
13
21
  Gemspec/RequiredRubyVersion:
14
22
  Enabled: false
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: house_style
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.1.0
4
+ version: 2.3.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Altmetric
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2021-10-08 00:00:00.000000000 Z
12
+ date: 2022-06-03 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rubocop
@@ -135,12 +135,12 @@ files:
135
135
  - LICENSE.txt
136
136
  - README.md
137
137
  - Rakefile
138
- - bin/console
139
- - bin/setup
138
+ - features/rubocop.yml
140
139
  - house_style.gemspec
141
140
  - lib/generators/house_style/install_generator.rb
142
141
  - lib/generators/house_style/templates/db_migrate_rubocop.yml
143
- - lib/generators/house_style/templates/rspec-rubocop.yml
142
+ - lib/generators/house_style/templates/features_rubocop.yml
143
+ - lib/generators/house_style/templates/rspec_rubocop.yml
144
144
  - lib/generators/house_style/templates/rubocop.yml
145
145
  - performance/default_rules.yml
146
146
  - performance/rubocop.yml
@@ -174,7 +174,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
174
174
  - !ruby/object:Gem::Version
175
175
  version: '0'
176
176
  requirements: []
177
- rubygems_version: 3.2.22
177
+ rubygems_version: 3.2.33
178
178
  signing_key:
179
179
  specification_version: 4
180
180
  summary: A centralised store of house style rules
data/bin/console DELETED
@@ -1,14 +0,0 @@
1
- #!/usr/bin/env ruby
2
-
3
- require 'bundler/setup'
4
- require 'house_style'
5
-
6
- # You can add fixtures and/or initialization code here to make experimenting
7
- # with your gem easier. You can also use a different console, if you like.
8
-
9
- # (If you use this, don't forget to add pry to your Gemfile!)
10
- # require 'pry'
11
- # Pry.start
12
-
13
- require 'irb'
14
- IRB.start
data/bin/setup DELETED
@@ -1,7 +0,0 @@
1
- #!/bin/bash
2
- set -euo pipefail
3
- IFS=$'\n\t'
4
-
5
- bundle install
6
-
7
- # Do any other automated setup that you need to do here