house_style 2.1.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60dd79ae28c2a1699e7484038e09b801a34f6a61d7657ab7ba64a7cbf70db40d
-  data.tar.gz: 78084875ed16986c3b8291e356498ec97607454d3364b0532e744d81074af377
+  metadata.gz: 29e5114e9c83f5b90caceb9be694f39637960c5795e9f9246666302be796836d
+  data.tar.gz: 7633b076ec8d475f44675cbcbbb215d5423e7c5159c9096aa4f8aa916ecc6a07
 SHA512:
-  metadata.gz: b3eeb1147984ef9a73d8ec6510dd6df3300e61abc487e66d88ec84c3cc27b00ee00c8bb9756e0283b2ebba06f85ab8fe95980ddae2b9f4fc0cfcf2d916217032
-  data.tar.gz: 7edfe2d0ebff0553ff58c1c582196e5ef17c80e32dbc9f7805f2fa43fa85d3e9efc6bab11675707218d5a4a4ff0d0b7f64e9c396a6fd95e5feab18de42755214
+  metadata.gz: bef45d1bc0b477eac9da7d8525b2202cc0fb6f80cf14908bdecdcf988a16021e8454f701d645d3c26a34502693b6aa97a89c6357b91fdc33a1280cafdae4f8a6
+  data.tar.gz: 80177fd9d2e22aec9f3c8f33749d1b9d44113cd72c9ce5233212d8d740a6c0aeff3c2d6679ee0af622a2e3f829c686435d28267022e25a8c7299f676411eea8e

data/CHANGELOG.md

@@ -1,5 +1,24 @@
 # CHANGELOG
 
+## CURRENT
+
+## 2.3.0
+### Changes
+- Exclude more Rails configuration files affected by rails app:update.
+
+## 2.2.1
+### Bug fixes
+- Do not skip features/ directory in the gem when packaging.
+
+## 2.2.0
+### Bug fixes
+- Install db_migrate.yml only if `db/migrate/` folder exists rather than just `db/` folder.
+### Changes
+- Rails: Move the AllCops to the Ruby one instead of repeating the same block. Disable Rails/SquishedSQLHeredocs and Rails/SkipsModelValidations.
+- RSpec: Disable Spec/ContextWording, RSpec/NestedGroups, RSpec/DescribeClass and Style/BlockDelimiters.
+### New features
+- Add new configuration for feature tests inside `features/` folder.
+
 ## 2.1.0
 - Enable NewCops by default
 - Support Rubocop up to 1.22.x and latest extensions

data/features/rubocop.yml

@@ -0,0 +1,15 @@
+inherit_from: ../ruby/rubocop.yml
+
+Layout/LineLength:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/ModuleLength:
+  Enabled: false
+Style/BlockDelimiters:
+  Exclude:
+    - factories/**/*
+Style/Documentation:
+  Enabled: false
+Style/WordArray:
+  Enabled: false

data/house_style.gemspec

@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'house_style'
-  spec.version       = '2.1.0'
+  spec.version       = '2.3.0'
   spec.authors       = ['Altmetric', 'Scott Matthewman']
   spec.email         = ['engineering@altmetric.com', 'scott.matthewman@gmail.com']
 
@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/altmetric/house_style'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|.gitignore|)/}) }
   spec.require_paths = ['lib']
 
   spec.add_dependency 'rubocop', '>= 1.0', '< 1.23'

data/lib/generators/house_style/install_generator.rb

@@ -12,17 +12,25 @@ module HouseStyle
     end
 
     def create_rspec_rubocop_yml
-      template 'rspec-rubocop.yml', 'spec/.rubocop.yml'
+      template 'rspec_rubocop.yml', 'spec/.rubocop.yml'
     end
 
     def create_db_migrate_rubocop_yml
       template 'db_migrate_rubocop.yml', 'db/migrate/.rubocop.yml' if Dir.exist?(db_path)
     end
 
+    def create_features_rubocop_yml
+      template 'features_rubocop.yml', 'features/.rubocop.yml' if Dir.exist?(features_path)
+    end
+
     private
 
     def db_path
-      File.join(Rails.root, 'db')
+      File.join(Rails.root, 'db', 'migrate')
+    end
+
+    def features_path
+      File.join(Rails.root, 'features')
     end
   end
 end

data/lib/generators/house_style/templates/features_rubocop.yml

@@ -0,0 +1,3 @@
+inherit_from: ../.rubocop.yml
+inherit_gem:
+  house_style: features/rubocop.yml

data/rails/rubocop.yml

@@ -3,13 +3,6 @@ inherit_from:
   - ./default_rules.yml
   - ./style.yml
 
-AllCops:
-  Exclude:
-    - bin/**/*
-    - vendor/**/*
-    - db/*schema.rb
-    - lib/tasks/cucumber.rake
-    - Guardfile
 Rails:
   Enabled: true
 Rails/InverseOf:
@@ -21,5 +14,9 @@ Rails/EnvironmentVariableAccess:
   AllowReads: true
 Rails/ShortI18n:
   Enabled: false
+Rails/SquishedSQLHeredocs:
+  Enabled: false
+Rails/SkipsModelValidations:
+  Enabled: false
 
 require: rubocop-rails

data/rails/style.yml

@@ -22,10 +22,8 @@ Style/StringLiterals:
     - config/environments/test.rb
     - config/initializers/**
     - config/puma.rb
-    - config.ru
     - Rakefile
 
 Style/SymbolArray:
   Exclude:
     - config/initializers/filter_parameter_logging.rb
-

data/rspec/rubocop.yml

@@ -14,8 +14,7 @@ Metrics/BlockLength:
 Metrics/ModuleLength:
   Enabled: false
 RSpec/ContextWording:
-  Exclude:
-    - spec/support/shared_contexts/rake.rb
+  Enabled: false
 RSpec/ExampleLength:
   Enabled: false
 RSpec/MultipleExpectations:
@@ -24,9 +23,12 @@ RSpec/MultipleMemoizedHelpers:
   Max: 10
 RSpec/NotToNot:
   EnforcedStyle: to_not
+RSpec/NestedGroups:
+  Enabled: false
+RSpec/DescribeClass:
+  Enabled: false
 Style/BlockDelimiters:
-  Exclude:
-    - spec/factories/**/*.rb
+  Enabled: false
 Style/Documentation:
   Enabled: false
 Style/SymbolProc:

data/ruby/configuration.yml

@@ -6,9 +6,17 @@ AllCops:
   NewCops: enable
 
   Exclude:
-    - 'bin/**/*'
-    - 'vendor/**/*'
-    - 'Guardfile'
+    - bin/**/*
+    - vendor/**/*
+    - Guardfile
+    - lib/tasks/cucumber.rake
+    - node_modules/**/*
+    - tmp/**/*
+    - db/*schema.rb
+    - config.ru
+    - config/environments/**/*
+    - config/puma.rb
+    - config/spring.rb
 
 Gemspec/RequiredRubyVersion:
   Enabled: false

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: house_style
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Altmetric
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-10-08 00:00:00.000000000 Z
+date: 2022-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -135,12 +135,12 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/console
-- bin/setup
+- features/rubocop.yml
 - house_style.gemspec
 - lib/generators/house_style/install_generator.rb
 - lib/generators/house_style/templates/db_migrate_rubocop.yml
-- lib/generators/house_style/templates/rspec-rubocop.yml
+- lib/generators/house_style/templates/features_rubocop.yml
+- lib/generators/house_style/templates/rspec_rubocop.yml
 - lib/generators/house_style/templates/rubocop.yml
 - performance/default_rules.yml
 - performance/rubocop.yml
@@ -174,7 +174,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.2.33
 signing_key:
 specification_version: 4
 summary: A centralised store of house style rules

data/bin/console

@@ -1,14 +0,0 @@
-#!/usr/bin/env ruby
-
-require 'bundler/setup'
-require 'house_style'
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require 'pry'
-# Pry.start
-
-require 'irb'
-IRB.start

data/bin/setup

@@ -1,7 +0,0 @@
-#!/bin/bash
-set -euo pipefail
-IFS=$'\n\t'
-
-bundle install
-
-# Do any other automated setup that you need to do here