hotspots 0.0.9 → 0.0.10

data/.gitignore

@@ -1 +1,2 @@
+coverage
 *.gem

data/CHANGELOG.markdown

@@ -0,0 +1,18 @@
+v0.0.10
+-------
+
+* Handle '\r' line endings
+* *Don't disregard file-name case*
+* Tests and coverage via rake
+
+v0.0.9
+------
+
+* Add installation procedure
+* Change website link
+* Bump up version
+
+v0.0.8
+------
+
+* Initial release

data/README.markdown

@@ -57,7 +57,7 @@ Running tests
 Clone the repository and run the following command from the repository.
 
 ``` script
-ruby test/hotspots_test.rb
+rake
 ```
 
 License

data/Rakefile

@@ -0,0 +1,37 @@
+def load_all_tests
+  require 'rake/runtest'
+  require 'minitest/autorun'
+  require 'minitest/spec'
+
+  lib = File.expand_path(File.dirname(__FILE__) + '/lib')
+  $LOAD_PATH.unshift(lib) if File.directory?(lib) && !$LOAD_PATH.include?(lib)
+end
+
+def run_all_tests
+  Dir[File.join(File.expand_path(File.dirname(__FILE__)), "test", "**", "*_test.rb")].each do |file|
+    Rake.run_tests file
+  end
+end
+
+task :test do
+  load_all_tests
+  run_all_tests
+end
+
+task :coverage do
+  require 'simplecov'
+
+  SimpleCov.start do
+    add_filter "/test/"
+  end
+
+  load_all_tests
+
+  Dir[File.join(File.expand_path(File.dirname(__FILE__)), "lib", "**", "*.rb")].each do |file|
+    require file
+  end
+
+  run_all_tests
+end
+
+task :default => [:test]

data/bin/hotspots

@@ -5,4 +5,4 @@ $LOAD_PATH.unshift(lib) if File.directory?(lib) && !$LOAD_PATH.include?(lib)
 
 require 'hotspots'
 
-Repository::Main.new.execute!
+Hotspots::Main.new.execute!

data/lib/hotspots.rb

@@ -4,19 +4,19 @@ require 'hotspots/store'
 require 'hotspots/options_parser'
 require 'hotspots/repository'
 
-module Repository
+module Hotspots
   class Main
     attr_reader :logger, :options, :repository, :verbose,
                 :exit_code, :exit_message,
                 :driver, :parser, :store
 
     def initialize
-      @logger       = Hotspots::Logger.new
       @options      = Hotspots::OptionsParser.new.parse(*ARGV)
       @repository   = options[:repository]
       @verbose      = options[:verbose]
       @exit_code    = options[:exit][:code]
       @exit_message = options[:exit][:message]
+      @logger       = Hotspots::Logger.new
     end
 
     def execute!
@@ -58,7 +58,7 @@ module Repository
 
     def set_logger
       if verbose
-        logger.set Hotspots::Logger::Console
+        logger.set_console
       end
     end
 

data/lib/hotspots/logger.rb

@@ -11,17 +11,17 @@ module Hotspots
       end
     end
 
-    attr_reader :drain
+    attr_reader :sink
     def initialize
-      @drain = Null
+      @sink = Null
     end
 
-    def set(logger)
-      @drain = logger
+    def set_console
+      @sink = Console
     end
 
     def log(message)
-      @drain << format(message)
+      @sink << format(message)
     end
 
     def format(message)

data/lib/hotspots/options_parser.rb

@@ -48,9 +48,10 @@ module Hotspots
     end
 
     def set_banner_on(opts)
-      opts.banner = "Tool to find most modified files over the past few days in a git repository. version #{::Hotspots::VERSION}"
+      opts.banner = "Tool to find most modified files over the past few days in a git repository."
 
-      opts.separator "Copyright (C) 2011 Chirantan Mitra"
+      opts.separator "Version #{::Hotspots::VERSION}"
+      opts.separator "Copyright (C) 2011-2012 Chirantan Mitra"
       opts.separator ""
       opts.separator "Usage: ruby hotspots [options]"
       opts.separator ""
@@ -73,14 +74,16 @@ module Hotspots
 
     def handle_file_filter_on(opts)
       opts.on("-f", "--file-filter [REGEX]", String,
-              "Regular expression to filtering file names. All files are allowed when not specified") do |o|
+              "Regular expression to filtering file names.",
+              "All files are allowed when not specified") do |o|
         @options[:file_filter] = o.to_s
       end
     end
 
     def handle_message_filter_on(opts)
       opts.on("-m", "--message-filter [PIPE SEPARATED]", String,
-              "Pipe separated values to filter files names against each commit message separated by pipe. All files are allowed when not specified") do |o|
+              "Pipe separated values to filter files names against each commit message separated by pipe.",
+              "All files are allowed when not specified") do |o|
         @options[:message_filters] = o.to_s.split("|")
       end
     end

data/lib/hotspots/repository/driver/git.rb

@@ -13,7 +13,6 @@ module Hotspots
             .tap {|raw| logger.log "<Input> #{raw}"}
           %x(#{command})
             .tap {|raw| logger.log raw}
-            .gsub("\r", "")
         end
 
         def show_one_line_names(options)
@@ -21,7 +20,6 @@ module Hotspots
             .tap {|raw| logger.log "<Input> #{raw}"}
           %x(#{command})
             .tap {|raw| logger.log "<Output> #{raw}"}
-            .gsub("\r", "")
         end
       end
     end

data/lib/hotspots/repository/parser/git.rb

@@ -10,13 +10,19 @@ module Hotspots
 
         def files
           filtered_commit_hashes.map do |commit_hash|
-            @driver.show_one_line_names(:commit_hash => commit_hash).split("\n")[1..-1]
+            @driver.show_one_line_names(:commit_hash => commit_hash)
+              .gsub("\r\n", "\n")
+              .gsub("\r", "\n")
+              .split("\n")[1..-1]
           end.flatten
         end
 
         def filtered_commit_hashes
           @message_filters.map do |filter|
-            @driver.pretty_log(:since_days => @time, :message_filter => filter).split("\n")
+            @driver.pretty_log(:since_days => @time, :message_filter => filter)
+              .gsub("\r\n", "\n")
+              .gsub("\r", "\n")
+              .split("\n")
           end.flatten.uniq
         end
       end

data/lib/hotspots/store.rb

@@ -6,7 +6,7 @@ module Hotspots
       @cutoff = options[:cutoff]      || 0
       @filter = options[:file_filter] || ""
 
-      @lines.map   { |line| line.strip.downcase }
+      @lines.map   { |line| line.strip }
             .select{ |line| not line.empty? and line =~ Regexp.new(@filter) }
             .each  { |line| @store[line] += 1 }
     end

data/lib/hotspots/version.rb

@@ -1,3 +1,3 @@
 module Hotspots
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/test/hotspots/options_parser_test.rb

@@ -1,5 +1,4 @@
-require 'hotspots/logger'
-require 'hotspots/options_parser'
+require File.join(File.expand_path(File.dirname(__FILE__)), '..', '..', 'lib', 'hotspots', 'options_parser')
 
 module Hotspots
   describe "OptionsParser" do

data/test/hotspots/repository/parser/git_test.rb

@@ -1,4 +1,4 @@
-require 'hotspots/repository/parser/git'
+require File.join(File.expand_path(File.dirname(__FILE__)), '..', '..', '..', '..', 'lib', 'hotspots', 'repository', 'parser', 'git')
 
 module Hotspots::Repository
   describe "Parser::Git test" do
@@ -16,7 +16,7 @@ module Hotspots::Repository
 
     it "fetches multiple commit hashes" do
       options    = {:time => 10, :message_filters => ["Foo", "Bar"]}
-      git_parser = Parser::Git.new StubGitDriver, options
+      git_parser = Parser::Git.new StubGitDriver.new, options
 
       git_parser.filtered_commit_hashes.must_equal(["SHA1", "SHA2", "SHA3"])
     end
@@ -36,39 +36,60 @@ module Hotspots::Repository
 
     it "finds all affected files for multiple commit messages" do
       options    = {:time => 10, :message_filters => ["Foo", "Bar"]}
-      git_parser = Parser::Git.new StubGitDriver, options
+      git_parser = Parser::Git.new StubGitDriver.new, options
 
       git_parser.files.must_equal(["file1", "file2", "file2", "file3", "file5", "file4"])
     end
+
+    describe "handles line ending" do
+      it "of type \r\n" do
+        options    = {:time => 10, :message_filters => ["Foo", "Bar"]}
+        git_parser = Parser::Git.new StubGitDriver.new(:line_ending => "\r\n"), options
+
+        git_parser.files.must_equal(["file1", "file2", "file2", "file3", "file5", "file4"])
+      end
+
+      it "of type \r" do
+        options    = {:time => 10, :message_filters => ["Foo", "Bar"]}
+        git_parser = Parser::Git.new StubGitDriver.new(:line_ending => "\r"), options
+
+        git_parser.files.must_equal(["file1", "file2", "file2", "file3", "file5", "file4"])
+      end
+    end
   end
 
   describe "git driver stub" do
-    it "pretty log is sane" do
-      StubGitDriver.pretty_log(:time => 10, :message_filter => "Foo").must_equal "SHA1\nSHA2"
-      StubGitDriver.pretty_log(:time => 10, :message_filter => "Bar").must_equal "SHA2\nSHA3"
+    it "has a sane pretty log" do
+      driver = StubGitDriver.new
+      driver.pretty_log(:time => 10, :message_filter => "Foo").must_equal "SHA1\nSHA2"
+      driver.pretty_log(:time => 10, :message_filter => "Bar").must_equal "SHA2\nSHA3"
     end
 
-    it "show one line names is sane" do
-      StubGitDriver.show_one_line_names(:commit_hash => "SHA2").must_equal "SHA1 commit message\nfile2\nfile3\nfile5"
+    it "has a sane show one line names" do
+      StubGitDriver.new.show_one_line_names(:commit_hash => "SHA2")
+          .must_equal "SHA1 commit message\nfile2\nfile3\nfile5"
+      StubGitDriver.new(:line_ending => "\r\n").show_one_line_names(:commit_hash => "SHA2")
+          .must_equal "SHA1 commit message\r\nfile2\r\nfile3\r\nfile5"
     end
   end
 
   class StubGitDriver
-    @pretty_log_enum = ["SHA1\nSHA2", "SHA2\nSHA3"].cycle
-    @commits = {
-      "SHA1" => "SHA1 commit message\nfile1\nfile2",
-      "SHA2" => "SHA1 commit message\nfile2\nfile3\nfile5",
-      "SHA3" => "SHA1 commit message\nfile4",
-    }
-
-    class << self
-      def pretty_log(options)
-        @pretty_log_enum.next
-      end
+    def initialize(options = {})
+      line_ending = options[:line_ending] || "\n"
+      @pretty_log_enum = ["SHA1#{line_ending}SHA2", "SHA2#{line_ending}SHA3"].cycle
+      @commits = {
+        "SHA1" => "SHA1 commit message#{line_ending}file1#{line_ending}file2",
+        "SHA2" => "SHA1 commit message#{line_ending}file2#{line_ending}file3#{line_ending}file5",
+        "SHA3" => "SHA1 commit message#{line_ending}file4",
+      }
+    end
 
-      def show_one_line_names(options)
-        @commits[options[:commit_hash]]
-      end
+    def pretty_log(options)
+      @pretty_log_enum.next
+    end
+
+    def show_one_line_names(options)
+      @commits[options[:commit_hash]]
     end
   end
 end

data/test/hotspots/store_test.rb

@@ -1,4 +1,4 @@
-require 'hotspots/store'
+require File.join(File.expand_path(File.dirname(__FILE__)), '..', '..', 'lib', 'hotspots', 'store')
 
 module Hotspots
   describe "Store test" do
@@ -31,14 +31,6 @@ module Hotspots
       store.on("absent.txt").must_equal 0
     end
 
-    it "disregards file case" do
-      lines = [
-        "ABC.TXT"
-      ]
-      store = Store.new(lines)
-      store.on("abc.txt").must_equal 1
-    end
-
     it "neglects empty lines" do
       lines = [
         " "
@@ -73,6 +65,14 @@ module Hotspots
       store.to_s.must_equal "abc.txt,1\nefg.txt,1\n"
     end
 
+    it "has a case-sensitive string representation" do
+      lines = [
+        "aBc.tXt"
+      ]
+      store = Store.new(lines)
+      store.to_s.must_equal "aBc.tXt,1\n"
+    end
+
     it "string representation has maximum occuring string at the top" do
       lines = [
         "abc.txt",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hotspots
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-12-26 00:00:00.000000000 Z
+date: 2012-01-08 00:00:00.000000000 Z
 dependencies: []
 description: ! 'Find all files that changed over the past days for a git repository.
   If the same file is modified over
@@ -28,9 +28,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CHANGELOG.markdown
 - Gemfile
 - LICENSE
 - README.markdown
+- Rakefile
 - bin/hotspots
 - hotspots.gemspec
 - lib/hotspots.rb
@@ -46,7 +48,6 @@ files:
 - test/hotspots/options_parser_test.rb
 - test/hotspots/repository/parser/git_test.rb
 - test/hotspots/store_test.rb
-- test/hotspots_test.rb
 homepage: https://github.com/chiku/hotspots
 licenses: []
 post_install_message: 

data/test/hotspots_test.rb

@@ -1,11 +0,0 @@
-#!/usr/bin/env ruby
-
-require 'minitest/autorun'
-require 'minitest/spec'
-
-lib = File.expand_path(File.dirname(__FILE__) + '/../lib')
-$LOAD_PATH.unshift(lib) if File.directory?(lib) && !$LOAD_PATH.include?(lib)
-
-Dir[File.join(File.expand_path(File.dirname(__FILE__)), "hotspots", "**", "*_test.rb")].each do |file|
-  require file
-end