hotcell-core 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 214b910102e639e8d5e5d7f5f145046c53d7fe45146a661054097731303d12db
-  data.tar.gz: 02db6536062e350ae67eefae22b50d83d8aa629b24487fdb01339e97308c045e
+  metadata.gz: 6649b9636b553b02ac5d1a178dd39eadb95884a83665b15d7d0278ae8af20260
+  data.tar.gz: 6726a7fa1abff37e8c478e2d7ee0818b7c1038983da282b237c4575c67da4e07
 SHA512:
-  metadata.gz: e4be2dd15734d9b3958ee98408866b9302f0a854a6ad16d652954e42f7f986a53286034b2af38eef9f09dc2ba2cc348d20b9707cf07c0e473a74a5742c2f9076
-  data.tar.gz: 6251a4224a51c24ce0b8bc245335973e2ccc33670594e41bb374242e8d70a46d0226247225415d61945ec1c2220db0ce6bd837779c9477e22b5529582a43f112
+  metadata.gz: ea9a2f0004527eef4f9078df8e4acef195fe86988372991a1488900b2d1e6c122de3f1bb5abd29cd8edd371538776a6a8a5b456a2db592b15cb1bf9760b35b9b
+  data.tar.gz: 8ab1b757c91463fe99380c7af6a878545578c5b1bf74b70c65a87ff61312c5cd6d905fe5be5b3804c5f4bb59cbb0e50e5563b80d50d09ffabf0d085de542ca9d

data/lib/hot_cell/core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HotCell
-  VERSION = "0.3.1"
+  VERSION = "0.4.0"
 end

data/lib/hot_cell/payload.rb

@@ -22,27 +22,21 @@ module HotCell
         JSON.generate object
       end
 
-      # Keys are deep-symbolized here rather than in an operation, so an operation never has to know
-      # whether to reach for payload[:format] or payload["format"], and a nested hash can be splatted
-      # straight into a library's keyword arguments. Only keys: a Symbol value would not survive the
-      # round trip, which the JSON-native rule already forbids.
+      # Keys are symbolized so operations read payload[:format] and can splat a nested hash into keyword
+      # arguments. Values are not: a Symbol would not survive the round trip, which the JSON-native rule
+      # already forbids.
       #
-      # JSON.parse only. Never JSON.load, and never create_additions, both of which instantiate
-      # arbitrary classes named by a json_class key in the document.
+      # One rescue for the whole JSON layer. Naming what JSON.parse raises has been wrong twice: a report
+      # that was not an object raised TypeError past a rescue for JSON::ParserError, and a key holding
+      # invalid UTF-8 raised EncodingError past both. The supervisor parses worker reports inside its
+      # deadline loop with nothing above it rescuing, so each miss denies service to every request in the
+      # cell.
       #
-      # Every way this can fail becomes one named failure, and the catch-all is the point rather than
-      # laziness. Callers used to name what JSON.parse raises, and naming it has now been wrong twice: a
-      # report that was not an object raised TypeError past a rescue for JSON::ParserError, and a key
-      # holding bytes that are not valid UTF-8 raises EncodingError past both. The supervisor reads worker
-      # reports through here inside the loop that enforces every request's deadline, and nothing above it
-      # rescues anything, so each miss is a one-line denial of service against every request in the cell.
-      #
-      # The body is a single JSON.parse call, so this is scoped to "the JSON layer failed" and cannot
-      # swallow a bug in our own code. NoMemoryError is deliberately not caught: it is not a StandardError,
-      # and a document large enough to raise it is the worker's own memory verdict rather than a bad line.
+      # The body is one JSON.parse call, so the rescue cannot hide a bug of our own. NoMemoryError is not
+      # a StandardError and stays uncaught: a document that large is the worker's memory verdict, not a
+      # bad line.
       def parse(json)
-        JSON.parse json, symbolize_names: true, max_nesting: MAX_NESTING, allow_nan: false,
-                         create_additions: false
+        JSON.parse json, symbolize_names: true, max_nesting: MAX_NESTING, allow_nan: false
       rescue StandardError => error
         raise MessageError, "#{error.class}: #{Failure.sanitize(error.message)}"
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hotcell-core
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Mike Dalessio
@@ -43,8 +43,8 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/basecamp/hotcell
-  source_code_uri: https://github.com/basecamp/hotcell/tree/v0.3.1/hotcell-core
-  changelog_uri: https://github.com/basecamp/hotcell/blob/v0.3.1/CHANGELOG.md
+  source_code_uri: https://github.com/basecamp/hotcell/tree/v0.4.0/hotcell-core
+  changelog_uri: https://github.com/basecamp/hotcell/blob/v0.4.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/basecamp/hotcell/issues
   rubygems_mfa_required: 'true'
 rdoc_options: []