hoptoad_notifier 2.4.10 → 2.4.11

data/Rakefile

@@ -155,7 +155,7 @@ end
 
 LOCAL_GEM_ROOT = File.join(GEM_ROOT, 'tmp', 'local_gems').freeze
 RAILS_VERSIONS = IO.read('SUPPORTED_RAILS_VERSIONS').strip.split("\n")
-LOCAL_GEMS = [['sham_rack', nil], ['capistrano', nil], ['sqlite3-ruby', nil], ['sinatra', nil]] +
+LOCAL_GEMS = [['sham_rack', nil], ['capistrano', nil], ['sqlite3-ruby', nil], ['sinatra', nil], ['rake', '0.8.7']] +
   RAILS_VERSIONS.collect { |version| ['rails', version] }
 
 desc "Vendor test gems: Run this once to prepare your test environment"

data/SUPPORTED_RAILS_VERSIONS

@@ -10,3 +10,5 @@
 3.0.3
 3.0.4
 3.0.5
+3.0.6
+3.0.7

data/lib/hoptoad_notifier/notice.rb

@@ -1,4 +1,5 @@
 require 'builder'
+require 'socket'
 
 module HoptoadNotifier
   class Notice
@@ -65,6 +66,9 @@ module HoptoadNotifier
     # A URL for more information about the notifier library sending this notice
     attr_reader :notifier_url
 
+    # The host name where this error occurred (if any)
+    attr_reader :hostname
+
     def initialize(args)
       self.args         = args
       self.exception    = args[:exception]
@@ -95,6 +99,8 @@ module HoptoadNotifier
         "#{exception.class.name}: #{exception.message}"
       end
 
+      self.hostname        = local_hostname
+
       also_use_rack_params_filters
       find_session_data
       clean_params
@@ -153,6 +159,7 @@ module HoptoadNotifier
         notice.tag!("server-environment") do |env|
           env.tag!("project-root", project_root)
           env.tag!("environment-name", environment_name)
+          env.tag!("hostname", hostname)
         end
       end
       xml.to_s
@@ -185,7 +192,7 @@ module HoptoadNotifier
       :backtrace_filters, :parameters, :params_filters,
       :environment_filters, :session_data, :project_root, :url, :ignore,
       :ignore_by_filters, :notifier_name, :notifier_url, :notifier_version,
-      :component, :action, :cgi_data, :environment_name
+      :component, :action, :cgi_data, :environment_name, :hostname
 
     # Arguments given in the initializer
     attr_accessor :args
@@ -333,5 +340,9 @@ module HoptoadNotifier
       end
     end
 
+    def local_hostname
+      Socket.gethostname
+    end
+
   end
 end

data/lib/hoptoad_notifier/rails/controller_methods.rb

@@ -59,7 +59,7 @@ module HoptoadNotifier
           url << ":#{request.port}"
         end
 
-        url << request.request_uri
+        url << request.fullpath
         url
       end
     end

data/lib/hoptoad_notifier/version.rb

@@ -1,3 +1,3 @@
 module HoptoadNotifier
-  VERSION = "2.4.9".freeze
+  VERSION = "2.4.11".freeze
 end

data/test/catcher_test.rb

@@ -112,6 +112,8 @@ class ActionControllerCatcherTest < Test::Unit::TestCase
     controller.stubs(:rescue_action_in_public_without_hoptoad)
     opts[:request].query_parameters = opts[:request].query_parameters.merge(opts[:params] || {})
     opts[:request].session = ActionController::TestSession.new(opts[:session] || {})
+    # Prevents request.fullpath from crashing Rails in tests
+    opts[:request].env['REQUEST_URI'] = opts[:request].request_uri
     controller.process(opts[:request], opts[:response])
     controller
   end

data/test/notice_test.rb

@@ -55,6 +55,11 @@ class NoticeTest < Test::Unit::TestCase
     assert_equal url, notice.url
   end
 
+  should "set the host name" do
+    notice = build_notice
+    assert_equal hostname, notice.hostname
+  end
+
   should "accept a backtrace from an exception or hash" do
     array = ["user.rb:34:in `crazy'"]
     exception = build_exception
@@ -241,6 +246,7 @@ class NoticeTest < Test::Unit::TestCase
 
       assert_valid_node(@document, "//server-environment/project-root",     "RAILS_ROOT")
       assert_valid_node(@document, "//server-environment/environment-name", "RAILS_ENV")
+      assert_valid_node(@document, "//server-environment/hostname", hostname)
     end
   end
 
@@ -421,7 +427,7 @@ class NoticeTest < Test::Unit::TestCase
   end
 
   def assert_valid_notice_document(document)
-    xsd_path = File.join(File.dirname(__FILE__), "hoptoad_2_0.xsd")
+    xsd_path = File.join(File.dirname(__FILE__), "hoptoad_2_2.xsd")
     schema = Nokogiri::XML::Schema.new(IO.read(xsd_path))
     errors = schema.validate(document)
     assert errors.empty?, errors.collect{|e| e.message }.join
@@ -445,4 +451,9 @@ class NoticeTest < Test::Unit::TestCase
     ["app/models/user.rb:13:in `magic'",
       "app/controllers/users_controller.rb:8:in `index'"]
   end
+
+  def hostname
+    `hostname`.chomp
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_notifier
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: 
   segments: 
   - 2
   - 4
-  - 10
-  version: 2.4.10
+  - 11
+  version: 2.4.11
 platform: ruby
 authors: 
 - thoughtbot, inc
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-03 00:00:00 Z
+date: 2011-05-26 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: builder