hoptoad_notifier 2.3.5 → 2.3.6

data/CHANGELOG

@@ -1,3 +1,16 @@
+Version 2.3.6 - 2010-08-30
+===============================================================================
+
+Daniel Barron (1):
+      Initializer configuration overrides Railtie configuration if set
+
+Joshua Clayton (1):
+      Remove rack.request.form_vars
+
+Tristan Dunn (1):
+      Move Rails JS scenarios into separate feature and correctly support HTTPS when secure is enabled on the notifier.
+
+
 Version 2.3.5 - 2010-08-13
 ===============================================================================
 
@@ -202,3 +215,4 @@ Nick Quaranto (3):
 
 
 
+

data/Rakefile

@@ -198,7 +198,7 @@ def define_rails_cucumber_tasks(additional_cucumber_args = '')
       task version => [:gemspec, :vendor_test_gems] do
         puts "Testing Rails #{version}"
         ENV['RAILS_VERSION'] = version
-        system("cucumber --format #{ENV['CUCUMBER_FORMAT'] || 'progress'} #{additional_cucumber_args} features/rails.feature")
+        system("cucumber --format #{ENV['CUCUMBER_FORMAT'] || 'progress'} #{additional_cucumber_args} features/rails.feature features/rails_with_js_notifier.feature")
       end
     end
 

data/lib/hoptoad_notifier/notice.rb

@@ -98,6 +98,7 @@ module HoptoadNotifier
       also_use_rack_params_filters
       find_session_data
       clean_params
+      clean_rack_request_data
     end
 
     # Converts the given notice to XML
@@ -254,6 +255,12 @@ module HoptoadNotifier
       end
     end
 
+    def clean_rack_request_data
+      if cgi_data
+        cgi_data.delete("rack.request.form_vars")
+      end
+    end
+
     def filter(hash)
       if params_filters
         hash.each do |key, value|

data/lib/hoptoad_notifier/rails/javascript_notifier.rb

@@ -14,7 +14,7 @@ module HoptoadNotifier
         path = File.join(File.dirname(__FILE__), '..', '..', 'templates', 'javascript_notifier.erb')
         host = HoptoadNotifier.configuration.host.dup
         port = HoptoadNotifier.configuration.port
-        host << ":#{port}" unless port == 80
+        host << ":#{port}" unless [80, 443].include?(port)
 
         options = {
           :file          => path,
@@ -22,6 +22,7 @@ module HoptoadNotifier
           :use_full_path => false,
           :locals        => {
             :host        => host,
+            :secure      => HoptoadNotifier.configuration.secure,
             :api_key     => HoptoadNotifier.configuration.api_key,
             :environment => HoptoadNotifier.configuration.environment_name
           }

data/lib/hoptoad_notifier/railtie.rb

@@ -13,9 +13,9 @@ module HoptoadNotifier
 
     config.after_initialize do
       HoptoadNotifier.configure(true) do |config|
-        config.logger           = Rails.logger
-        config.environment_name = Rails.env
-        config.project_root     = Rails.root
+        config.logger           ||= Rails.logger
+        config.environment_name ||= Rails.env
+        config.project_root     ||= Rails.root
         config.framework        = "Rails: #{::Rails::VERSION::STRING}"
       end
 

data/lib/hoptoad_notifier/version.rb

@@ -1,3 +1,3 @@
 module HoptoadNotifier
-  VERSION = "2.3.5".freeze
+  VERSION = "2.3.6".freeze
 end

data/lib/templates/javascript_notifier.erb

@@ -1,4 +1,4 @@
-<script type="text/javascript" src="http://<%= host %>/javascripts/notifier.js"></script>
+<script type="text/javascript" src="http<%= 's' if secure %>://<%= host %>/javascripts/notifier.js"></script>
 <script type="text/javascript">
   Hoptoad.setKey('<%= api_key %>');
   Hoptoad.setHost('<%= host %>');

data/test/notice_test.rb

@@ -168,6 +168,16 @@ class NoticeTest < Test::Unit::TestCase
     assert_filters_hash(:session_data)
   end
 
+  should "remove rack.request.form_vars" do
+    original = {
+      "rack.request.form_vars" => "story%5Btitle%5D=The+TODO+label",
+      "abc" => "123"
+    }
+
+    notice = build_notice(:cgi_data => original)
+    assert_equal({"abc" => "123"}, notice.cgi_data)
+  end
+
   context "a Notice turned into XML" do
     setup do
       HoptoadNotifier.configure do |config|

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_notifier
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 15
   prerelease: false
   segments: 
   - 2
   - 3
-  - 5
-  version: 2.3.5
+  - 6
+  version: 2.3.6
 platform: ruby
 authors: 
 - thoughtbot, inc
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-13 00:00:00 -04:00
+date: 2010-08-30 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency