hoptoad_notifier 2.3.11 → 2.3.12

data/CHANGELOG

@@ -1,3 +1,34 @@
+Version 2.3.12 - Wed Nov 03 13:53:18 -0400 2010
+===============================================================================
+
+In general: Update gems, improve testing, improve documentation, improve
+javascript notifier.
+
+Emma Lindsay (4):
+      Sends more javascript information back to hoptaod
+      Merge branch 'js_notifier_default_fields'
+      Bumping to version 2.3.10
+      Updated jferris-mocha to bourne
+
+Jason Morrison (5):
+      wip: Supply default url, component, action for JS notifier
+      gracefully fall back to require 'activesupport' if require 'active_support' fails
+      Add non-capistrano deploy instructions
+      Add instructions for heroku gem to Heroku addon README
+      Add AbstractController::ActionNotFound to default ignore list
+
+Jon Yurek (9):
+      Require bourne, run right cucumber task
+      Get the API key from Heroku
+      Bumped version: 2.3.11
+      Getting green cucumber stories
+      Fakes out the heroku command for cucumber.
+      Mount the metal endpoint in Rails 3 tests.
+      Metal test mounts at /metal
+      Supported versions: 2.3.9, 2.3.10, and 3.0.1
+      Return non-zero on cucumber failure.
+
+
 Version 2.3.10 - Mon Oct 18 17:07:56 -0400 2010
 ===============================================================================
 
@@ -275,3 +306,4 @@ Nick Quaranto (3):
 
 
 
+

data/README_FOR_HEROKU_ADDON.md

@@ -18,9 +18,10 @@ application in `ENV['HOPTOAD_API_KEY']`, so installation should be a snap!
 
 ### Rails 3.x
 
-Add the hoptoad_notifier gem to your Gemfile.  In Gemfile:
+Add the hoptoad_notifier and heroku gems to your Gemfile.  In Gemfile:
 
     gem 'hoptoad_notifier'
+    gem 'heroku'
 
 Then from your project's RAILS_ROOT, run:
 
@@ -29,6 +30,10 @@ Then from your project's RAILS_ROOT, run:
 
 ### Rails 2.x
 
+Install the heroku gem if you haven't already:
+
+    gem install heroku
+
 Add the hoptoad_notifier gem to your app. In config/environment.rb:
 
     config.gem 'hoptoad_notifier'

data/Rakefile

@@ -192,22 +192,32 @@ end
 
 task :cucumber => [:gemspec, :vendor_test_gems]
 
+def run_rails_cucumbr_task(version, additional_cucumber_args)
+  puts "Testing Rails #{version}"
+  if version.empty?
+    raise "No Rails version specified - make sure ENV['RAILS_VERSION'] is set, e.g. with `rake cucumber:rails:all`"
+  end
+  ENV['RAILS_VERSION'] = version
+  system("cucumber --format #{ENV['CUCUMBER_FORMAT'] || 'progress'} #{additional_cucumber_args} features/rails.feature features/rails_with_js_notifier.feature")
+end
+
 def define_rails_cucumber_tasks(additional_cucumber_args = '')
   namespace :rails do
     RAILS_VERSIONS.each do |version|
       desc "Test integration of the gem with Rails #{version}"
       task version => [:gemspec, :vendor_test_gems] do
-        puts "Testing Rails #{version}"
-        if version.empty?
-          raise "No Rails version specified - make sure ENV['RAILS_VERSION'] is set, e.g. with `rake cucumber:rails:all`"
-        end
-        ENV['RAILS_VERSION'] = version
-        system("cucumber --format #{ENV['CUCUMBER_FORMAT'] || 'progress'} #{additional_cucumber_args} features/rails.feature features/rails_with_js_notifier.feature")
+        exit 1 unless run_rails_cucumbr_task(version, additional_cucumber_args)
       end
     end
 
     desc "Test integration of the gem with all Rails versions"
-    task :all => RAILS_VERSIONS
+    task :all do
+      results = RAILS_VERSIONS.map do |version|
+        run_rails_cucumbr_task(version, additional_cucumber_args)
+      end
+
+      exit 1 unless results.all?
+    end
   end
 end
 

data/SUPPORTED_RAILS_VERSIONS

@@ -7,4 +7,7 @@
 2.3.4
 2.3.5
 2.3.8
+2.3.9
+2.3.10
 3.0.0
+3.0.1

data/generators/hoptoad/hoptoad_generator.rb

@@ -47,7 +47,7 @@ class HoptoadGenerator < Rails::Generator::Base
 
   def determine_api_key
     puts "Attempting to determine your API Key from Heroku..."
-    ENV['HOPTOAD_API_KEY'] = `heroku console 'puts ENV[%{HOPTOAD_API_KEY}]'`.split("\n").first
+    ENV['HOPTOAD_API_KEY'] = heroku_api_key
     if ENV['HOPTOAD_API_KEY'].blank?
       puts "... Failed."
       puts "WARNING: We were unable to detect the Hoptoad API Key from your Heroku environment."
@@ -59,6 +59,10 @@ class HoptoadGenerator < Rails::Generator::Base
     end
   end
 
+  def heroku_api_key
+    `heroku console 'puts ENV[%{HOPTOAD_API_KEY}]'`.split("\n").first
+  end
+
   def heroku?
     options[:heroku] ||
       system("grep HOPTOAD_API_KEY config/initializers/hoptoad.rb") ||

data/lib/hoptoad_notifier/configuration.rb

@@ -111,7 +111,8 @@ module HoptoadNotifier
                       'ActionController::RoutingError',
                       'ActionController::InvalidAuthenticityToken',
                       'CGI::Session::CookieStore::TamperedWithCookie',
-                      'ActionController::UnknownAction']
+                      'ActionController::UnknownAction',
+                      'AbstractController::ActionNotFound']
 
     alias_method :secure?, :secure
 

data/lib/hoptoad_notifier/version.rb

@@ -1,3 +1,3 @@
 module HoptoadNotifier
-  VERSION = "2.3.11".freeze
+  VERSION = "2.3.12".freeze
 end

data/lib/rails/generators/hoptoad/hoptoad_generator.rb

@@ -58,7 +58,7 @@ class HoptoadGenerator < Rails::Generators::Base
 
   def determine_api_key
     puts "Attempting to determine your API Key from Heroku..."
-    ENV['HOPTOAD_API_KEY'] = `heroku console 'puts ENV[%{HOPTOAD_API_KEY}]'`.split("\n").first
+    ENV['HOPTOAD_API_KEY'] = heroku_api_key
     if ENV['HOPTOAD_API_KEY'].blank?
       puts "... Failed."
       puts "WARNING: We were unable to detect the Hoptoad API Key from your Heroku environment."
@@ -70,6 +70,10 @@ class HoptoadGenerator < Rails::Generators::Base
     end
   end
 
+  def heroku_api_key
+    `heroku console 'puts ENV[%{HOPTOAD_API_KEY}]'`.split("\n").first
+  end
+
   def heroku?
     options[:heroku] ||
       system("grep HOPTOAD_API_KEY config/initializers/hoptoad.rb") ||

data/test/notice_test.rb

@@ -310,29 +310,20 @@ class NoticeTest < Test::Unit::TestCase
     end
   end
 
-  should "ignore RecordNotFound error by default" do
-    notice = build_notice(:error_class => 'ActiveRecord::RecordNotFound')
-    assert notice.ignore?
-  end
-
-  should "ignore RoutingError error by default" do
-    notice = build_notice(:error_class => 'ActionController::RoutingError')
-    assert notice.ignore?
-  end
-
-  should "ignore InvalidAuthenticityToken error by default" do
-    notice = build_notice(:error_class => 'ActionController::InvalidAuthenticityToken')
-    assert notice.ignore?
-  end
-
-  should "ignore TamperedWithCookie error by default" do
-    notice = build_notice(:error_class => 'CGI::Session::CookieStore::TamperedWithCookie')
-    assert notice.ignore?
-  end
-
-  should "ignore UnknownAction error by default" do
-    notice = build_notice(:error_class => 'ActionController::UnknownAction')
-    assert notice.ignore?
+  ignored_error_classes = %w(
+    ActiveRecord::RecordNotFound
+    AbstractController::ActionNotFound
+    ActionController::RoutingError
+    ActionController::InvalidAuthenticityToken
+    CGI::Session::CookieStore::TamperedWithCookie
+    ActionController::UnknownAction
+  )
+
+  ignored_error_classes.each do |ignored_error_class|
+    should "ignore #{ignored_error_class} error by default" do
+      notice = build_notice(:error_class => ignored_error_class)
+      assert notice.ignore?
+    end
   end
 
   should "act like a hash" do

metadata

@@ -1,13 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_notifier
 version: !ruby/object:Gem::Version 
-  hash: 21
   prerelease: false
   segments: 
   - 2
   - 3
-  - 11
-  version: 2.3.11
+  - 12
+  version: 2.3.12
 platform: ruby
 authors: 
 - thoughtbot, inc
@@ -15,18 +14,16 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-25 00:00:00 -04:00
+date: 2010-11-03 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: builder
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
         version: "0"
@@ -36,11 +33,9 @@ dependencies:
   name: activesupport
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
         version: "0"
@@ -50,11 +45,9 @@ dependencies:
   name: activerecord
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
         version: "0"
@@ -64,11 +57,9 @@ dependencies:
   name: actionpack
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
         version: "0"
@@ -78,11 +69,9 @@ dependencies:
   name: bourne
   prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
         version: "0"
@@ -92,11 +81,9 @@ dependencies:
   name: nokogiri
   prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
         version: "0"
@@ -106,11 +93,9 @@ dependencies:
   name: shoulda
   prerelease: false
   requirement: &id007 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
         version: "0"
@@ -184,27 +169,23 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Send your application errors to our hosted service and reclaim your inbox.