hoptoad_notifier 2.3.0 → 2.3.2

data/CHANGELOG

@@ -1,3 +1,18 @@
+Version 2.3.2 - 2010-07-06
+===============================================================================
+
+Josh Clayton(1):
+      Handle instances when Rack's action_dispach.parameter_filter is nil
+
+
+Version 2.3.1 - 2010-07-02
+===============================================================================
+
+Jason Morrison (2):
+      Use the Rails 3 params filters when available
+      Filter session hash using Hoptoad config.params_filters, in addition to params
+
+
 Version 2.3.0 - 2010-06-24
 ===============================================================================
 
@@ -159,3 +174,4 @@ Nick Quaranto (3):
 
 
 
+

data/README.rdoc

@@ -342,7 +342,7 @@ To replace sensitive information sent to the Hoptoad service with [FILTERED] use
   end
 
 Note that, when rescuing exceptions within an ActionController method,
-hoptoad_notifier will reuse filters specified by #filter_params_logging.
+hoptoad_notifier will reuse filters specified by #filter_parameter_logging.
 
 == Testing
 

data/lib/hoptoad_notifier/notice.rb

@@ -95,6 +95,7 @@ module HoptoadNotifier
         "#{exception.class.name}: #{exception.message}"
       end
 
+      also_use_rack_params_filters
       find_session_data
       clean_params
     end
@@ -249,6 +250,7 @@ module HoptoadNotifier
       end
       if session_data
         clean_unserializable_data_from(:session_data)
+        filter(session_data)
       end
     end
 
@@ -266,7 +268,7 @@ module HoptoadNotifier
 
     def filter_key?(key)
       params_filters.any? do |filter|
-        key.to_s.include?(filter)
+        key.to_s.include?(filter.to_s)
       end
     end
 
@@ -314,5 +316,12 @@ module HoptoadNotifier
     def rack_session
       args[:rack_env]['rack.session'] if args[:rack_env]
     end
+
+    def also_use_rack_params_filters
+      if args[:rack_env]
+        self.params_filters += rack_request.env["action_dispatch.parameter_filter"] || []
+      end
+    end
+
   end
 end

data/lib/hoptoad_notifier/rails/controller_methods.rb

@@ -19,7 +19,7 @@ module HoptoadNotifier
 
       def hoptoad_request_data
         { :parameters       => hoptoad_filter_if_filtering(params.to_hash),
-          :session_data     => hoptoad_session_data,
+          :session_data     => hoptoad_filter_if_filtering(hoptoad_session_data),
           :controller       => params[:controller],
           :action           => params[:action],
           :url              => hoptoad_request_url,
@@ -27,6 +27,8 @@ module HoptoadNotifier
       end
 
       def hoptoad_filter_if_filtering(hash)
+        return hash if ! hash.is_a?(Hash)
+
         if respond_to?(:filter_parameters)
           filter_parameters(hash) rescue hash
         else

data/lib/hoptoad_notifier/version.rb

@@ -1,3 +1,3 @@
 module HoptoadNotifier
-  VERSION = "2.3.0".freeze
+  VERSION = "2.3.2".freeze
 end

data/test/catcher_test.rb

@@ -239,10 +239,12 @@ class ActionControllerCatcherTest < Test::Unit::TestCase
     assert_sent_request_info_for controller.request
   end
 
-  should "use standard rails logging filters on params and env" do
+  should "use standard rails logging filters on params and session and env" do
     filtered_params = { "abc" => "123",
                         "def" => "456",
                         "ghi" => "[FILTERED]" }
+    filtered_session = { "abc" => "123",
+                         "ghi" => "[FILTERED]" }
     ENV['ghi'] = 'abc'
     filtered_env = { 'ghi' => '[FILTERED]' }
     filtered_cgi = { 'REQUEST_METHOD' => '[FILTERED]' }
@@ -250,9 +252,12 @@ class ActionControllerCatcherTest < Test::Unit::TestCase
     process_action_with_automatic_notification(:filters => [:ghi, :request_method],
                                                :params => { "abc" => "123",
                                                             "def" => "456",
-                                                            "ghi" => "789" })
+                                                            "ghi" => "789" },
+                                               :session => { "abc" => "123",
+                                                             "ghi" => "789" })
     assert_sent_hash filtered_params, '/notice/request/params'
     assert_sent_hash filtered_cgi, '/notice/request/cgi-data'
+    assert_sent_hash filtered_session, '/notice/request/session'
   end
 
   context "for a local error with development lookup enabled" do

data/test/notice_test.rb

@@ -164,6 +164,10 @@ class NoticeTest < Test::Unit::TestCase
     assert_filters_hash(:cgi_data)
   end
 
+  should "filter session" do
+    assert_filters_hash(:session_data)
+  end
+
   context "a Notice turned into XML" do
     setup do
       HoptoadNotifier.configure do |config|
@@ -423,7 +427,7 @@ class NoticeTest < Test::Unit::TestCase
   end
 
   def assert_filters_hash(attribute)
-    filters  = %w(abc def)
+    filters  = ["abc", :def]
     original = { 'abc' => "123", 'def' => "456", 'ghi' => "789", 'nested' => { 'abc' => '100' } }
     filtered = { 'abc'    => "[FILTERED]",
                  'def'    => "[FILTERED]",

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_notifier
 version: !ruby/object:Gem::Version 
+  hash: 7
   prerelease: false
   segments: 
   - 2
   - 3
-  - 0
-  version: 2.3.0
+  - 2
+  version: 2.3.2
 platform: ruby
 authors: 
 - thoughtbot, inc
@@ -14,16 +15,18 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-06-24 00:00:00 -04:00
+date: 2010-07-06 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -33,9 +36,11 @@ dependencies:
   name: activerecord
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -45,9 +50,11 @@ dependencies:
   name: actionpack
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -57,9 +64,11 @@ dependencies:
   name: jferris-mocha
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -69,9 +78,11 @@ dependencies:
   name: nokogiri
   prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -81,9 +92,11 @@ dependencies:
   name: shoulda
   prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -154,23 +167,27 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Send your application errors to our hosted service and reclaim your inbox.