hoptoad_handler 0.1.2 → 0.1.3

data/Gemfile

@@ -1,3 +1,6 @@
-source "http://rubygems.org"
+source :rubygems
+
+gem "minitest", :platform => :ruby_18
+gem "rake"
 
 gemspec

data/README.rdoc

@@ -2,6 +2,8 @@
 
 Report chef exceptions to hoptoad.
 
+Works fine with chef versions: 0.9.x and 0.10.x
+
 == Usage
 
   gem install hoptoad_handler

data/hoptoad_handler.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency("chef", "~> 0.9.0")
+  s.add_dependency("chef", ">= 0.9.0")
   s.add_dependency("toadhopper")
 
-  s.add_development_dependency("test-unit", "~> 2.2.0")
+  s.add_development_dependency("mocha")
 end

data/lib/hoptoad_handler.rb

@@ -16,12 +16,11 @@
 # limitations under the License.
 #
 
-require "chef"
 require "chef/handler"
 require "toadhopper"
 
 class HoptoadHandler < Chef::Handler
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 
   attr_accessor :options, :api_key
 
@@ -53,7 +52,7 @@ class HoptoadHandler < Chef::Handler
   end
 
   def client
-    raise "You must specify Hoptoad api key" unless api_key
+    raise ArgumentError.new("You must specify Hoptoad api key") unless api_key
     Toadhopper.new(api_key)
   end
 end

data/test/helper.rb

@@ -1,7 +1,6 @@
-require 'rubygems'
-gem 'test-unit'
-require 'test/unit'
+require "bundler/setup"
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'hoptoad_handler'
+require "minitest/autorun"
+require "mocha"
+
+require "hoptoad_handler"

data/test/hoptoad_notifier_test.rb

@@ -1,22 +1,39 @@
-require 'helper'
+require "helper"
 
-class HoptoadHandlerTest < Test::Unit::TestCase
-  test "raise error when api_key is not specified" do
-    assert_raise_message("You must specify Hoptoad api key") do
-      HoptoadHandler.new.client
-    end
+describe HoptoadHandler do
+  before do
+    Chef::Log.stubs(:error)
   end
 
-  test "not raise error when api_key is specified" do
-    assert_nothing_raised do
-      HoptoadHandler.new(:api_key => "fake").client
+  it "should raise error when api_key is not specified" do
+    assert_raises ArgumentError do
+      HoptoadHandler.new.client
     end
   end
 
-  test "setting options" do
+  it "should setting options" do
     handler = HoptoadHandler.new(:framework_env => "staging")
     assert_equal "staging", handler.options[:framework_env]
   end
 
-  # TODO: write more tests
+  it "should reporting exception using client" do
+    run_status = stub(:failed? => true, :exception => "Exception")
+    client = mock
+    handler = HoptoadHandler.new(:api_key => "fake")
+    handler.stubs(:run_status).returns(run_status)
+    handler.stubs(:client).returns(client)
+    handler.stubs(:hoptoad_params).returns({})
+
+    client.expects(:post!).with("Exception", {})
+    handler.report
+  end
+
+  it "should returning hoptoad params" do
+    node = stub(:name => "node-name", :run_list => "cookbook::recipe")
+    run_status = stub(:node => node, :start_time => Time.mktime(2011,1,1),
+      :end_time => Time.mktime(2011,1,2), :elapsed_time => Time.mktime(2011,1,3))
+    handler = HoptoadHandler.new(:api_key => "fake")
+    handler.stubs(:run_status => run_status)
+    assert_equal Hash, handler.hoptoad_params.class
+  end
 end

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_handler
 version: !ruby/object:Gem::Version 
-  hash: 31
   prerelease: 
-  segments: 
-  - 0
-  - 1
-  - 2
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors: 
 - Adam Jacob
@@ -16,8 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-16 00:00:00 +01:00
-default_executable: 
+date: 2011-05-06 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: chef
@@ -25,13 +19,8 @@ dependencies:
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
-        hash: 59
-        segments: 
-        - 0
-        - 9
-        - 0
         version: 0.9.0
   type: :runtime
   version_requirements: *id001
@@ -43,26 +32,18 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: test-unit
+  name: mocha
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 2
-        - 2
-        - 0
-        version: 2.2.0
+        version: "0"
   type: :development
   version_requirements: *id003
 description: Chef handler for sending exceptions to Hoptoad
@@ -85,7 +66,6 @@ files:
 - lib/hoptoad_handler.rb
 - test/helper.rb
 - test/hoptoad_notifier_test.rb
-has_rdoc: true
 homepage: https://github.com/morgoth/hoptoad_handler
 licenses: []
 
@@ -99,23 +79,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: hoptoad_handler
-rubygems_version: 1.6.2
+rubygems_version: 1.8.1
 signing_key: 
 specification_version: 3
 summary: Chef handler for sending exceptions to Hoptoad