hoover 0.0.4 → 0.0.5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Version 0.0.5 - Oct 24, 2011
+
+* Sanitize hash objects coming in instead of relying on implicit to_json which sometimes crashes.
+
 ## Version 0.0.4 - Oct 22, 2011
 
 * Fix some crashes in the middleware

data/README.md

@@ -54,9 +54,10 @@ If you add with the same key more than once, Hoover automatically rolls it up in
 
 ## Todo
 
-* Write tests for Rails components
-* Provide config option to set the logglier during initialization
-* Provide config option to choose which log subscribers to enable
+* Provide config option to set the logglier during Rails initialization, thus guaranteeing its presence beyond what is
+  possible with simple ActionController filters.
+* Write specs for Rails components.
+* Provide config option to choose which log subscribers to enable.
 
 
 ## Contributing to Hoover

data/lib/hoover/job.rb

@@ -9,7 +9,7 @@ module Hoover
     end
 
     def add(hash)
-      hash.each do |k,v|
+      sanitize(hash).each do |k,v|
         if @hash.key?(k)
           @hash[k] << v
         else
@@ -27,5 +27,26 @@ module Hoover
       @hash.each{ |k,v| @hash[k] = @hash[k].first if v.size == 1 }
       @logglier.info(@hash)
     end
+
+    private
+
+    def sanitize(value)
+      if value.is_a?(Hash)
+        value.inject({}){ |out,(k,v)| out[k] = sanitize(v); out }
+      elsif value.is_a?(Array)
+        value.map{ |v| sanitize(v) }
+      else
+        sanitize_object(value)
+      end
+    end
+
+    def sanitize_object(value)
+      case value
+      when String, Fixnum, Date, Time, NilClass
+        value
+      else
+        value.to_s
+      end
+    end
   end
 end

data/lib/hoover/version.rb

@@ -1,3 +1,3 @@
 module Hoover
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/job_spec.rb

@@ -68,4 +68,15 @@ describe Hoover::Job do
       @job.post
     end
   end
+
+  describe "unexpected object type" do
+    it "converts to string" do
+      @object = Object.new
+      def @object.to_s
+        "My String Representation"
+      end
+      @job.add(:foo => @object)
+      @job.hash.must_equal({:foo => ["My String Representation"]})
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hoover
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-22 00:00:00.000000000Z
+date: 2011-10-24 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logglier
-  requirement: &70213345909620 !ruby/object:Gem::Requirement
+  requirement: &70110723980740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 0.2.6
   type: :runtime
   prerelease: false
-  version_requirements: *70213345909620
+  version_requirements: *70110723980740
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70213345909200 !ruby/object:Gem::Requirement
+  requirement: &70110723980320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70213345909200
+  version_requirements: *70110723980320
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70213345908540 !ruby/object:Gem::Requirement
+  requirement: &70110723979860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70213345908540
+  version_requirements: *70110723979860
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70213345907880 !ruby/object:Gem::Requirement
+  requirement: &70110723979440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70213345907880
+  version_requirements: *70110723979440
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70213345907420 !ruby/object:Gem::Requirement
+  requirement: &70110723979020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70213345907420
+  version_requirements: *70110723979020
 description: Sets up a hash at the beginning of each request and flushes it to Loggly
   at the end of the request.  Also comes with standard Rails 3 log subscribers.
 email: