hookworm-base 0.1.1 → 0.2.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MDMyMzVkMGNlZmVkZDcxNmIyMmU3NGU4NjY1NjllOTc3ZDVmNzFjNQ==
-  data.tar.gz: !binary |-
-    YWMwYTRlODUwMWIyYmY1ZWRjZDhiYjJkMzBjZDI4MmI3Zjg5ZGM4YQ==
+SHA1:
+  metadata.gz: 13e89f5d28ed939f78bbea239eb25c40dc0171c5
+  data.tar.gz: b5b69f545de283979ad673cb5bc6399bf05d0d04
 SHA512:
-  metadata.gz: !binary |-
-    M2JkODczNjQ4NzM2MTc2ZTBmMjE5ODkwZTMwMDE2ZTg1NWNhMTA1MTEwYTE5
-    ZmNjNmM4NGEyYTkzZGZiNTQ5ODZkNTA2Mjg4MmZlYWQ2NWFkZDc3NTM1ZWUy
-    MTNmNmVlOGFjYWUzZjAxMzY1YzVhZGU1M2ZhNTFhYTg0ZjAxYWY=
-  data.tar.gz: !binary |-
-    MmU3MTJkMzgzMTJjMWRiNWFhZDhjMTE2MDExMzJkYWYyNWZjNWUzOGEwYjA3
-    Y2I1NzE5M2JjMTY4NjdhMzZkNDdlMjE4OWFkNTE2ZmMyZTAzMmZlMjlkMWRm
-    MWJiYmU0OTg4ZWEyOTZkZTM1NzE2Y2U2NzgzMjliMmMzYmNlZTk=
+  metadata.gz: 5eca4e7746b16a2d0c4b29d56054cac26fac6b03e46a130c769a846e3112363d9cf60e5369515e1b8f106bd464a5c3b7f6406fa4ee3f7a780c68a40f2d03b2b2
+  data.tar.gz: 7d6c29fc9ca25f6a2767025e9c15160a297e7f2d7ca7a2532b4a02cdf7e2494c5500111cc2cda1c5827de5230a4659a82e867dc8cf8e79f37ce4ded7d0375fdf

data/lib/hookworm/base/version.rb

@@ -1,5 +1,5 @@
 module Hookworm
   module Base
-    VERSION = '0.1.1'
+    VERSION = '0.2.0'
   end
 end

data/lib/hookworm/emailer.rb

@@ -3,13 +3,16 @@ require 'uri'
 
 module Hookworm
   class Emailer
-    def initialize(email_uri)
+    attr_reader :email_uri, :helo
+
+    def initialize(email_uri, helo = 'localhost')
       @email_uri = URI(email_uri)
+      @helo = helo
     end
 
-    def send(from, to, msg)
+    def send_email(from, to, msg)
       Net::SMTP.start(*smtp_args) do |smtp|
-        smtp.enable_ssl if @email_uri.scheme == 'smtps'
+        smtp.enable_ssl if email_uri.scheme == 'smtps'
         smtp.send_message(msg, from, to)
       end
     end
@@ -18,12 +21,12 @@ module Hookworm
 
     def smtp_args
       [
-        @email_uri.host,
-        @email_uri.port,
-        'localhost',
-        @email_uri.user,
-        @email_uri.password,
-        @email_uri.user ? :plain : nil
+        email_uri.host,
+        email_uri.port,
+        helo,
+        email_uri.user ? URI.unescape(email_uri.user) : nil,
+        email_uri.password ? URI.unescape(email_uri.password) : nil,
+        email_uri.user ? :plain : nil
       ]
     end
   end

data/spec/lib/hookworm/emailer_spec.rb

@@ -1,4 +1,73 @@
 require 'hookworm/emailer'
 
 describe Hookworm::Emailer do
+  subject { described_class.new(email_uri) }
+  let(:email_uri) { 'smtp://localhost:25' }
+  let(:mock_smtp) { double('smtp', enable_ssl: true, send_message: true) }
+
+  before do
+    Net::SMTP.stub(:start).and_yield(mock_smtp)
+  end
+
+  context 'when the email uri is invalid' do
+    let(:email_uri) { 'fribble://@@@../bzz:;xr?!!' }
+    it { expect { subject }.to raise_error }
+  end
+
+  it 'defaults helo to localhost' do
+    subject.helo.should == 'localhost'
+  end
+
+  context 'when helo is given' do
+    subject { described_class.new(email_uri, 'app.example.com') }
+
+    it 'uses the given helo' do
+      subject.send(:smtp_args)[2].should == 'app.example.com'
+    end
+  end
+
+  context 'when auth is given' do
+    let(:email_uri) { 'smtp://foo:bar@mail.example.com:587' }
+
+    it 'sets auth type to :plain' do
+      subject.send(:smtp_args)[5].should == :plain
+    end
+  end
+
+  context 'when the auth is urlencoded' do
+    let(:email_uri) { 'smtp://foo%40bar:h%40mmer@mail.example.com:587' }
+
+    it 'unescapes the user' do
+      subject.send(:smtp_args)[3].should == 'foo@bar'
+    end
+
+    it 'unescapes the password' do
+      subject.send(:smtp_args)[4].should == 'h@mmer'
+    end
+  end
+
+  context 'when there is no auth' do
+    let(:email_uri) { 'smtp://mail.example.com:587' }
+
+    it 'has nil user' do
+      subject.send(:smtp_args)[3].should be_nil
+    end
+
+    it 'has nil password' do
+      subject.send(:smtp_args)[4].should be_nil
+    end
+
+    it 'has nil auth type' do
+      subject.send(:smtp_args)[5].should be_nil
+    end
+  end
+
+  context 'when scheme is smtps' do
+    let(:email_uri) { 'smtps://mail.example.com:587' }
+
+    it 'enables ssl' do
+      mock_smtp.should_receive(:enable_ssl)
+      subject.send_email('from', 'to', 'w00t')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hookworm-base
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Dan Buch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-30 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,70 +28,70 @@ dependencies:
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: ''
@@ -139,17 +139,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: ''