hoodoo 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28c5549a689e0e841a9c435f0c6a5bfe502f4b592b4bdcec929d0680818e5d3c
-  data.tar.gz: c41b08c154c94b959c674b4c5acf3da3e9174b83fd3ab7b210adcc51aeaa8991
+  metadata.gz: 15b068238ef0e8f90fc5cedd67ce619250ff4ee1babf3025ce2f64808d2cab5f
+  data.tar.gz: 5528ad58d765ad928bf41879199f2c17a2786f63aa7646152da797cd5aa4f5c4
 SHA512:
-  metadata.gz: 271dbaf036afd87732ff3f702fc82b0a1e8abc334531f9b62f2bac266f9b258b65e8fe42c8bc865a70f39e6624e7e15611ed17ca158cc8b59ecd4ef501a8a77a
-  data.tar.gz: f3355e88dabae561eaf7ef72adccb57606f33df0f2593e0ef0963aa7c85c3526831bdc95012bf6a4f0954bd1e9d5fed9f89d0c6aaca69447afffc75df1d1f237
+  metadata.gz: 7d6a965fdeae003aeede10bd9a0153bf663186e5fa0b7318d5abe9fc288f647e334e44bb00d6092f2ff52062fd460c422f715519a600b09ebb0b2743ec8c21a9
+  data.tar.gz: 9295602ffeb5a2b40cf660aa7ddb913bcc35b5f4e4cd4e3ceadcd834dc6288ee1faa6cf3c13a072309078517cf6b723a955215f56080ef1f31ac0ae818ffda9e

data/lib/hoodoo/client/endpoint/endpoint.rb

@@ -342,7 +342,6 @@ module Hoodoo
 
         end
 
-
       public
 
         # Obtain a list of resource instance representations.

data/lib/hoodoo/client/endpoint/endpoints/http_based.rb

@@ -358,7 +358,7 @@ module Hoodoo
               parsed.dataset_size           = size
               parsed.estimated_dataset_size = estimated_size
 
-            elsif ( parsed[ 'kind' ] == 'Errors' )
+            elsif ( ( code < 200 || code > 299 ) && parsed[ 'kind' ] == 'Errors' )
 
               # This isn't an array, it's an AugmentedHash describing errors.
               # Turn this into a formal errors collection.

data/lib/hoodoo/version.rb

@@ -12,11 +12,11 @@ module Hoodoo
   # The Hoodoo gem version. If this changes, be sure to re-run
   # <tt>bundle install</tt> or <tt>bundle update</tt>.
   #
-  VERSION = '2.4.0'
+  VERSION = '2.4.1'
 
   # The Hoodoo gem date. If this changes, be sure to re-run
   # <tt>bundle install</tt> or <tt>bundle update</tt>.
   #
-  DATE = '2018-03-21'
+  DATE = '2018-04-13'
 
 end

data/spec/client/client_spec.rb

@@ -66,6 +66,27 @@ class RSpecClientTestTargetImplementation < Hoodoo::Services::Implementation
         return
       end
 
+      # Deliberate 'return an error-like object but with a 200 response
+      # code' hook, as if implementing the Errors resource endpoint and
+      # successfully processing a request.
+      #
+      if context.request.ident == 'return_200_with_errors_body'
+        context.response.set_resource( {
+          'id'         => Hoodoo::UUID.generate(),
+          'kind'       => 'Errors',
+          'created_at' => Hoodoo::Utilities.standard_datetime( Time.now ),
+          'errors'     => [
+            {
+              'code'      => 'generic.not_found',
+              'message'   => 'Resource not found',
+              'reference' => '1234'
+            }
+          ]
+        } )
+
+        return
+      end
+
       context.response.set_resource( mock( context ) )
     end
 
@@ -344,6 +365,20 @@ describe Hoodoo::Client do
         expect( result.platform_errors.has_errors? ).to eq( true )
         expect( result.platform_errors.errors[ 0 ][ 'code' ] ).to eq( 'platform.invalid_session' )
       end
+
+      # An endpoint returns an Errors resource *because it's meant to*, e.g.
+      # it's implementing the Errors resource and successfully processed a
+      # request; once upon a time, Hoodoo::Client misinterpreted the JSON
+      # response and treated it as an error condition. This test ensures
+      # that HTTP response codes are properly considered in conjunction, so
+      # that Errors payloads under 2xx response codes are non-error states.
+      #
+      it '(interprets errors properly)' do
+        result = @endpoint.show( 'return_200_with_errors_body' )
+
+        expect( result.platform_errors.has_errors? ).to eq( false )
+        expect( result[ 'kind' ] ).to eq( 'Errors' )
+      end
     end
 
     before :each do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hoodoo
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Loyalty New Zealand
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-21 00:00:00.000000000 Z
+date: 2018-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dalli