hoodoo 1.15.0 → 1.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fad91d3880f61878b0df4c509f63f8afd7b7ed21
-  data.tar.gz: 0c2502907dd97eda85b8ede8369c85935bc2a89a
+  metadata.gz: 1074a01d7b0b249400765334f2991cd5c00b9e85
+  data.tar.gz: 2e2473fbe2031ea3433a660e4a7bdc80a5012e03
 SHA512:
-  metadata.gz: c011115dcfee583a769f46deb6e167847208860c3fcb7f878191d5c6ef8f51757845530d44ab07f01b387522e730215911865b447e6f93bd78480f28a78abb8a
-  data.tar.gz: 2df1b22163e1944e86e4d546bcc950ada63eba410d841e94e144aadcb2696531dfa7f1c3c0427c5bc8ba9184f8ba438a5b9def124c2dc1cc96a21b30586d171f
+  metadata.gz: 89f72453d4d3ba63e7d22676864171272fb2a8fb6caf5c38704ca3993fbde88a3993f7e1f6cd70b6fa880ba2e439171b975cf33db6a27a91e81dd382de45092a
+  data.tar.gz: 3c1e9c6dc2e6f00955869055cee8f431364b3891fa72f68d2f7ca9dc6cfd6886d1501228d53aa2e95d4a7886362f193f96c2d4f77b7de8d3ba2c71fb30a57f6d

data/lib/hoodoo/client/client.rb

@@ -67,8 +67,8 @@ module Hoodoo
       #       :limit     => 25,
       #       :sort      => :created_at,
       #       :direction => :asc,
-      #       :embeds    => 'account',
-      #       :search    => { :surname => 'Smith' }
+      #       :search    => { :surname => 'Smith' },
+      #       :_embed    => 'account'
       #     )
       #
       # This will return a Hoodoo::Client::AugmentedArray. This is an Array

data/lib/hoodoo/client/endpoint/endpoints/auto_session.rb

@@ -134,12 +134,11 @@ module Hoodoo
             end
 
             result      = @wrapped_endpoint.send( action, *args )
-            bad_session = result.platform_errors.has_errors? &&
-                          result.platform_errors.errors.find do | error_hash |
+            bad_session = result.platform_errors.errors.find do | error_hash |
                             error_hash[ 'code' ] == 'platform.invalid_session'
                           end
 
-            if bad_session == false
+            if bad_session.nil?
               return result
             else
               session_creation_result = acquire_session_for( action )

data/lib/hoodoo/services/services/interface.rb

@@ -487,7 +487,7 @@ module Hoodoo; module Services
     # Example: An interface permits lists that request embedding or
     # referencing of "vouchers", "balances" and "member":
     #
-    #     embed :vouchers, :balances, :member
+    #     embeds :vouchers, :balances, :member
     #
     # As a result, #embeds would return:
     #

data/lib/hoodoo/version.rb

@@ -12,6 +12,6 @@ module Hoodoo
   # The Hoodoo gem version. If this changes, ensure that the date in
   # "hoodoo.gemspec" is correct and run "bundle install" (or "update").
   #
-  VERSION = '1.15.0'
+  VERSION = '1.15.1'
 
 end

data/spec/client/client_spec.rb

@@ -985,6 +985,43 @@ describe Hoodoo::Client do
         expect( result.platform_errors.has_errors? ).to eq( false )
       end
 
+      it 'does not retry for errors other than "platform.invalid_session"' do
+
+        # When we list first, Client has no session so will acquire one. The
+        # wrapping endpoint is asked to list, it pushes that through the
+        # session mechanism, gets the session and then calls the wrapped
+        # endpoint.
+
+        expect( @endpoint ).to receive( :acquire_session_for ).once.with( :list ).and_call_original
+        expect( @endpoint.instance_variable_get( '@wrapped_endpoint' ) ).to receive( :list ).once.and_call_original
+
+        result = @endpoint.list()
+        expect( result.platform_errors.has_errors? ).to eq( false )
+
+        # When we list the second time, the wrapping endpoint has a session
+        # but we fake a simple "generic.malformed" response from the wrapped
+        # endpoint (probably impossible from a 'list' call in reality, but
+        # just some easy error that we can check for afterwards and is not as
+        # likely to be generated incidentally from other pieces of code as
+        # e.g. "generic.invalid_parameters").
+
+        expect( @endpoint.instance_variable_get( '@wrapped_endpoint' ) ).to receive( :list ).once do
+          array = Hoodoo::Client::AugmentedArray.new
+          array.platform_errors.add_error( 'generic.malformed' )
+          array
+        end
+
+        # This is just a normal error; we do not expect another session
+        # acquisition attempt or a retried call to #list.
+
+        expect( @endpoint ).to_not receive( :acquire_session_for )
+        expect( @endpoint.instance_variable_get( '@wrapped_endpoint' ) ).to_not receive( :list )
+
+        result = @endpoint.list()
+        expect( result.platform_errors.has_errors? ).to eq( true )
+        expect( result.platform_errors.errors[ 0 ][ 'code' ] ).to eq( 'generic.malformed' )
+      end
+
       it 'handles errors from the session resource' do
         expect_any_instance_of( RSpecClientTestSessionImplementation ).to receive( :create ).and_raise( "boo!" )
 

data/spec/services/services/session_spec.rb

@@ -453,7 +453,28 @@ describe Hoodoo::Services::Session do
       expect( s.save_to_store() ).to eq( :fail )
     end
 
-    it 'handles unknown Hoodoo::TransientStore engine failures' do
+    it 'handles unknown Hoodoo::TransientStore engine failures when saving' do
+      s = described_class.new(
+        :session_id => '1234',
+        :memcached_host => 'abcd',
+        :caller_id => '0987',
+        :caller_version => 1
+      )
+
+      expect_any_instance_of( Hoodoo::TransientStore::Memcached ).to receive( :set ).once.and_call_original
+      expect_any_instance_of( Hoodoo::TransientStore::Memcached ).to receive( :set ).once.and_return( false )
+
+      expect( Hoodoo::Services::Middleware.logger ).to(
+        receive( :warn ).once.with(
+          'Hoodoo::Services::Session\\#save_to_store: Session saving failed - connection fault or session corrupt',
+          'Unknown storage engine failure'
+        ).and_call_original
+      )
+
+      expect( s.save_to_store() ).to eq( :fail )
+    end
+
+    it 'handles unknown Hoodoo::TransientStore engine failures when deleting' do
       s = described_class.new(
         :session_id => '1234',
         :memcached_host => 'abcd',

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hoodoo
 version: !ruby/object:Gem::Version
-  version: 1.15.0
+  version: 1.15.1
 platform: ruby
 authors:
 - Loyalty New Zealand
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-08 00:00:00.000000000 Z
+date: 2017-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dalli