honeymaker 0.9.5 → 0.9.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 69e45233bef585a60e1dfc06d139aebbfefd2d5f39264a6890df53314dc17991
-  data.tar.gz: 223eb0d6e9dc4a0d0fbda81f21a6bb3db62b8e07ee5a1622b224330c50f25953
+  metadata.gz: 632a9bc63075c21713722ff28baece102104084e83a6b20675c7a0604c0a49e6
+  data.tar.gz: 4d2d63654b5fedd397945f72dd21eca95ca2762b1f658f73cf80b02cb1a7285b
 SHA512:
-  metadata.gz: 02ea3cba844521f5710d79c80f9316c222ca167a70e08c690822e483738bba4f2b283719c7c209b3cb21ba81f4cd1d4b4b0dea09c12c38066f9e3ff27892c280
-  data.tar.gz: 43175c9aef0356ac764ceb5492ae574b7e0b6b96846027ddbc5a8e41e095d34477877aa903338721eb89f70eb77321d10e7ea677cb2fe96da20c909af0be03ee
+  metadata.gz: 3a5f15c7d5163ef0013998fa7cccb81aa661018ff65561d7d55e606c7e70969e4172fca70ec3cfdc1529ad03c4637c69b6bff2eefaa9586627710aefe15710a1
+  data.tar.gz: 15b53a301be6c936a90d3ac96c505ebe9946448783d07fbfb4832d5e294e6ca2cd44bd726e86f7fa34eda0074b1febf24142c2206f0e743d3edda9609e091f26

data/lib/honeymaker/clients/bitget.rb

@@ -238,8 +238,8 @@ module Honeymaker
       def parse_order_status(status)
         case status
         when "init", "new" then :unknown
-        when "partial_fill", "live" then :open
-        when "full_fill" then :closed
+        when "partially_filled", "live" then :open
+        when "filled" then :closed
         when "cancelled" then :cancelled
         else :unknown
         end

data/lib/honeymaker/exchanges/kraken.rb

@@ -9,10 +9,21 @@ module Honeymaker
         "COPM" # has the same external_id (ecomi) as OMI
       ].freeze
 
+      # Patterns are unanchored (except regional_restriction) because the consumer may
+      # pass a sentence-joined error string. transient_nonce is matched first as it is
+      # the more specific/actionable case.
       ERROR_PATTERNS = [
         {
           code: :regional_restriction,
           pattern: /\AEAccount:Invalid permissions:(?<asset>\S+) trading restricted for (?<country>\w+)\.?\z/
+        },
+        {
+          code: :transient_nonce,
+          pattern: /EAPI:Invalid nonce/
+        },
+        {
+          code: :transient_unavailable,
+          pattern: /EGeneral:Internal error|EService:(?:Unavailable|Busy|Deadline elapsed)/
         }
       ].freeze
 

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.9.5"
+  VERSION = "0.9.7"
 end

data/test/honeymaker/clients/bitget_client_test.rb

@@ -51,7 +51,7 @@ class Honeymaker::Clients::BitgetTest < Minitest::Test
 
   def test_get_order
     stub_connection(:get, { "code" => "00000", "data" => [{
-      "orderId" => "123", "orderType" => "market", "side" => "buy", "status" => "full_fill",
+      "orderId" => "123", "orderType" => "market", "side" => "buy", "status" => "filled",
       "priceAvg" => "50000", "size" => "0.001", "baseVolume" => "0.001", "quoteVolume" => "50"
     }] })
     result = @client.get_order(order_id: "123")

data/test/honeymaker/exchanges/kraken_test.rb

@@ -117,8 +117,22 @@ class Honeymaker::Exchanges::KrakenTest < Minitest::Test
     assert_equal({ code: :regional_restriction, asset: "XAUT", country: "DK" }, result)
   end
 
+  def test_classify_error_invalid_nonce
+    assert_equal({ code: :transient_nonce }, @exchange.classify_error("EAPI:Invalid nonce"))
+  end
+
+  def test_classify_error_internal_error_is_transient_unavailable
+    assert_equal({ code: :transient_unavailable }, @exchange.classify_error("EGeneral:Internal error"))
+  end
+
+  def test_classify_error_service_codes_are_transient_unavailable
+    assert_equal({ code: :transient_unavailable }, @exchange.classify_error("EService:Unavailable"))
+    assert_equal({ code: :transient_unavailable }, @exchange.classify_error("EService:Busy"))
+    assert_equal({ code: :transient_unavailable }, @exchange.classify_error("EService:Deadline elapsed"))
+  end
+
   def test_classify_error_returns_nil_for_unknown_message
-    assert_nil @exchange.classify_error("EGeneral:Internal error")
+    assert_nil @exchange.classify_error("EOrder:Unknown order")
   end
 
   def test_classify_error_returns_nil_for_nil_message

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.9.5
+  version: 0.9.7
 platform: ruby
 authors:
 - Deltabadger