honeymaker 0.9.0 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 12080b0cbcae6a52a2680efde8f4131b30f4ebcf70647c1c297ac88217c459ba
-  data.tar.gz: c475a4e5da6e8f7ac2e0b5f3eaa84e12192eec504876871028935a6b3be05cae
+  metadata.gz: ac4aba6f18266cfffed7dfe3939a60198cb6bdb7361818db8f25f435e19d92f9
+  data.tar.gz: e0e398092c55d7483ac386a94846fd5eff4abf115feb9dffd59a85c59462da37
 SHA512:
-  metadata.gz: c6c9bffcfa55f7f096a4128c2b09119e06d11e5be58bc04dde162a693600595e7662334034d38a049b7faaa2f9535976668b22890564bf6ddcf82f8f1c1ade2e
-  data.tar.gz: eedbdfab0c9fa12e8b4ae86362eafcd90b4d8319caace49bdb642405ca99a90836af69a6c8a50d9a13e555f6f1be4008175fb7e019927d8198060d7835a3754c
+  metadata.gz: aabbbc8fdd2c884c85770fc21a5862fe05c014860775f44e362e59c7db7c841cf92e74494af5028abdf10f4af70d88dc5fe13cc4fdc1838e359dc44f6f5c6dd5
+  data.tar.gz: a6cb39b92b07b6a5d04bb9b5d3adc14f11f7ea045b628c3b7dc09dd7501ddc0b9268bd3b477d8f2aac5072cfd379afe527738899c706b3d60ace82edd91073ad

data/lib/honeymaker/clients/kraken.rb

@@ -237,8 +237,25 @@ module Honeymaker
         end
       end
 
+      # Kraken rejects any request whose nonce is <= the last nonce it saw for the
+      # same API key. We protect against in-process collisions (microsecond bursts,
+      # backward clock corrections) by tracking the last issued nonce per API key
+      # under a mutex. Cross-process reuse of the same API key (other workers,
+      # other containers, other tools) is not protected here — affected users
+      # should increase the Nonce Window on their Kraken API key.
+      @@nonce_mutex = Mutex.new
+      @@last_nonces = {}
+
+      def self.reset_nonce_state!
+        @@nonce_mutex.synchronize { @@last_nonces.clear }
+      end
+
       def nonce
-        (Time.now.utc.to_f * 1_000_000).to_i
+        key = @api_key ? Digest::SHA256.hexdigest(@api_key) : :__no_api_key__
+        @@nonce_mutex.synchronize do
+          candidate = (Time.now.utc.to_f * 1_000_000).to_i
+          @@last_nonces[key] = [candidate, (@@last_nonces[key] || 0) + 1].max
+        end
       end
 
       def private_headers(path, body)

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.9.0"
+  VERSION = "0.9.2"
 end

data/test/honeymaker/clients/kraken_client_test.rb

@@ -4,6 +4,7 @@ require "test_helper"
 
 class Honeymaker::Clients::KrakenTest < Minitest::Test
   def setup
+    Honeymaker::Clients::Kraken.reset_nonce_state! if Honeymaker::Clients::Kraken.respond_to?(:reset_nonce_state!)
     @client = Honeymaker::Clients::Kraken.new(
       api_key: "test_key",
       api_secret: Base64.strict_encode64("test_secret_key_1234567890123456")
@@ -74,8 +75,65 @@ class Honeymaker::Clients::KrakenTest < Minitest::Test
     refute headers.key?(:"API-Key")
   end
 
+  def test_reset_nonce_state_is_available_for_test_isolation
+    assert_respond_to Honeymaker::Clients::Kraken, :reset_nonce_state!
+  end
+
+  def test_nonce_is_strictly_increasing_in_a_tight_loop
+    nonces = Array.new(10_000) { @client.send(:nonce) }
+
+    assert_strictly_increasing nonces
+  end
+
+  def test_nonce_is_strictly_increasing_when_clock_is_frozen
+    frozen_time = Time.utc(2026, 1, 1, 12, 0, 0)
+    Time.stubs(:now).returns(frozen_time)
+
+    nonces = Array.new(3) { @client.send(:nonce) }
+
+    assert_strictly_increasing nonces
+  end
+
+  def test_nonce_is_strictly_increasing_across_clients_with_the_same_api_key
+    frozen_time = Time.utc(2026, 1, 1, 12, 0, 0)
+    Time.stubs(:now).returns(frozen_time)
+    other_client = Honeymaker::Clients::Kraken.new(
+      api_key: "test_key",
+      api_secret: Base64.strict_encode64("test_secret_key_1234567890123456")
+    )
+
+    nonces = [
+      @client.send(:nonce),
+      other_client.send(:nonce),
+      @client.send(:nonce),
+      other_client.send(:nonce)
+    ]
+
+    assert_strictly_increasing nonces
+  end
+
+  def test_nonce_sequences_are_independent_for_different_api_keys
+    frozen_time = Time.utc(2026, 1, 1, 12, 0, 0)
+    Time.stubs(:now).returns(frozen_time)
+    first_key_client = Honeymaker::Clients::Kraken.new(api_key: "first_key", api_secret: @client.api_secret)
+    second_key_client = Honeymaker::Clients::Kraken.new(api_key: "second_key", api_secret: @client.api_secret)
+
+    first_key_first_nonce = first_key_client.send(:nonce)
+    first_key_second_nonce = first_key_client.send(:nonce)
+    second_key_first_nonce = second_key_client.send(:nonce)
+
+    assert_operator first_key_second_nonce, :>, first_key_first_nonce
+    assert_equal first_key_first_nonce, second_key_first_nonce
+  end
+
   private
 
+  def assert_strictly_increasing(values)
+    values.each_cons(2) do |previous, current|
+      assert_operator current, :>, previous
+    end
+  end
+
   def stub_connection(method, body)
     response = stub(body: body)
     connection = stub

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.2
 platform: ruby
 authors:
 - Deltabadger