honeymaker 0.8.0 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 329432e2569d62afa1bd99352d9f9075dbfb93004b27856f3ae535e03aba2a00
-  data.tar.gz: fe3f83098b328ad88e41c385efd8fe855ba8386c838beae26caab2d02a479a45
+  metadata.gz: ac4aba6f18266cfffed7dfe3939a60198cb6bdb7361818db8f25f435e19d92f9
+  data.tar.gz: e0e398092c55d7483ac386a94846fd5eff4abf115feb9dffd59a85c59462da37
 SHA512:
-  metadata.gz: 1f38749e06bf4b3fbf03da5830bcc68bfe581b8f901f566894ee51d81a0b6883cd59bd8646ed98ca2fa119db70beee055b10dce2068387b85377b1b1e6cef6bc
-  data.tar.gz: b83aa96da78eab87f3004321175b470ade7caa34b7843f326c72a3b479d548cedf223328a70700afadc46e96bca17844002ab6467fc9cfd31313bd7ea5118825
+  metadata.gz: aabbbc8fdd2c884c85770fc21a5862fe05c014860775f44e362e59c7db7c841cf92e74494af5028abdf10f4af70d88dc5fe13cc4fdc1838e359dc44f6f5c6dd5
+  data.tar.gz: a6cb39b92b07b6a5d04bb9b5d3adc14f11f7ea045b628c3b7dc09dd7501ddc0b9268bd3b477d8f2aac5072cfd379afe527738899c706b3d60ace82edd91073ad

data/Rakefile

@@ -29,26 +29,38 @@ def bump_version(segment)
   puts "Bumped version to #{new_version}"
 end
 
-task :bump_version do
-  bump_version(@bump_segment || :patch)
-end
+# Bundler's `release` task is defined when this Rakefile loads — it captures
+# the gemspec version at that moment in `Bundler::GemHelper`. If we bump the
+# version mid-run (as a build prerequisite), the gem is published correctly
+# but the final "Pushed <gem> <ver>" log line still prints the old cached
+# version. Fix: bump first, then invoke bundler's release in a subprocess so
+# it re-reads the gemspec fresh.
+
+Rake::Task[:release].clear
 
-task release_preflight: :bump_version do
+def do_release(segment)
+  bump_version(segment)
   sh "bundle install"
   Rake::Task[:test].invoke
-  sh 'git add -A && git diff --cached --quiet || git commit -m "$(ruby -e "require_relative \'lib/honeymaker/version\'; puts Honeymaker::VERSION")"'
+  sh %(git add -A && git diff --cached --quiet || git commit -m "v#{current_version}")
+  sh "bundle exec rake _bundler_release"
 end
 
-Rake::Task[:build].enhance([:release_preflight])
+task _bundler_release: %w[build release:guard_clean release:source_control_push release:rubygem_push]
+
+desc "Bump patch, run tests, push to rubygems"
+task :release do
+  do_release(:patch)
+end
 
 namespace :release do
+  desc "Bump minor, run tests, push to rubygems"
   task :minor do
-    @bump_segment = :minor
-    Rake::Task[:release].invoke
+    do_release(:minor)
   end
 
+  desc "Bump major, run tests, push to rubygems"
   task :major do
-    @bump_segment = :major
-    Rake::Task[:release].invoke
+    do_release(:major)
   end
 end

data/lib/honeymaker/clients/kraken.rb

@@ -237,8 +237,25 @@ module Honeymaker
         end
       end
 
+      # Kraken rejects any request whose nonce is <= the last nonce it saw for the
+      # same API key. We protect against in-process collisions (microsecond bursts,
+      # backward clock corrections) by tracking the last issued nonce per API key
+      # under a mutex. Cross-process reuse of the same API key (other workers,
+      # other containers, other tools) is not protected here — affected users
+      # should increase the Nonce Window on their Kraken API key.
+      @@nonce_mutex = Mutex.new
+      @@last_nonces = {}
+
+      def self.reset_nonce_state!
+        @@nonce_mutex.synchronize { @@last_nonces.clear }
+      end
+
       def nonce
-        (Time.now.utc.to_f * 1_000_000).to_i
+        key = @api_key ? Digest::SHA256.hexdigest(@api_key) : :__no_api_key__
+        @@nonce_mutex.synchronize do
+          candidate = (Time.now.utc.to_f * 1_000_000).to_i
+          @@last_nonces[key] = [candidate, (@@last_nonces[key] || 0) + 1].max
+        end
       end
 
       def private_headers(path, body)

data/lib/honeymaker/exchanges/binance.rb

@@ -25,7 +25,8 @@ module Honeymaker
               base_decimals: Utils.decimals(f[:lot_size]["stepSize"]),
               quote_decimals: product["quoteAssetPrecision"],
               price_decimals: Utils.decimals(f[:price]["tickSize"]),
-              available: product["status"] == "TRADING"
+              available: true,
+              trading_enabled: product["status"] == "TRADING"
             }
           end
         end

data/lib/honeymaker/exchanges/bingx.rb

@@ -25,7 +25,8 @@ module Honeymaker
               base_decimals: Utils.decimals(product["stepSize"]),
               quote_decimals: Utils.decimals(product["tickSize"]),
               price_decimals: Utils.decimals(product["tickSize"]),
-              available: product["status"].to_i == 1
+              available: true,
+              trading_enabled: product["status"].to_i == 1
             }
           end
         end

data/lib/honeymaker/exchanges/bitget.rb

@@ -21,7 +21,8 @@ module Honeymaker
               base_decimals: product["quantityPrecision"].to_i,
               quote_decimals: product["quotePrecision"].to_i,
               price_decimals: product["pricePrecision"].to_i,
-              available: product["status"] == "online"
+              available: true,
+              trading_enabled: product["status"] == "online"
             }
           end
         end

data/lib/honeymaker/exchanges/bitmart.rb

@@ -21,7 +21,8 @@ module Honeymaker
               base_decimals: Utils.decimals(product["base_min_size"]),
               quote_decimals: Utils.decimals(product["quote_increment"]),
               price_decimals: product["price_max_precision"].to_i,
-              available: product["trade_status"] == "trading"
+              available: true,
+              trading_enabled: product["trade_status"] == "trading"
             }
           end
         end

data/lib/honeymaker/exchanges/bitrue.rb

@@ -23,7 +23,8 @@ module Honeymaker
               base_decimals: f[:lot_size] ? Utils.decimals(f[:lot_size]["stepSize"]) : product["baseAssetPrecision"],
               quote_decimals: product["quotePrecision"],
               price_decimals: f[:price] ? Utils.decimals(f[:price]["tickSize"]) : product["quotePrecision"],
-              available: product["status"] == "TRADING"
+              available: true,
+              trading_enabled: product["status"] == "TRADING"
             }
           end
         end

data/lib/honeymaker/exchanges/bitvavo.rb

@@ -24,7 +24,8 @@ module Honeymaker
               base_decimals: product["pricePrecision"] || 8,
               quote_decimals: product["pricePrecision"] || 8,
               price_decimals: product["pricePrecision"] || 8,
-              available: product["status"] == "trading"
+              available: true,
+              trading_enabled: product["status"] == "trading"
             }
           end
         end

data/lib/honeymaker/exchanges/bybit.rb

@@ -26,7 +26,8 @@ module Honeymaker
               base_decimals: Utils.decimals(lot_size_filter["basePrecision"]),
               quote_decimals: Utils.decimals(lot_size_filter["quotePrecision"]),
               price_decimals: Utils.decimals(price_filter["tickSize"]),
-              available: product["status"] == "Trading"
+              available: true,
+              trading_enabled: product["status"] == "Trading"
             }
           end
         end

data/lib/honeymaker/exchanges/coinbase.rb

@@ -31,7 +31,8 @@ module Honeymaker
               base_decimals: Utils.decimals(product["base_increment"]),
               quote_decimals: Utils.decimals(product["quote_increment"]),
               price_decimals: Utils.decimals(product["price_increment"]),
-              available: true
+              available: true,
+              trading_enabled: trading_enabled?(product)
             }
           end
         end
@@ -50,6 +51,15 @@ module Honeymaker
 
       private
 
+      # Coinbase only signals problems explicitly: a `trading_disabled` flag or a non-"online"
+      # `status`. Absent either signal, treat the pair as enabled.
+      def trading_enabled?(product)
+        return false if product["trading_disabled"] == true
+        return false if product.key?("status") && product["status"] != "online"
+
+        true
+      end
+
       def connection
         @connection ||= build_connection(BASE_URL)
       end

data/lib/honeymaker/exchanges/gemini.rb

@@ -27,7 +27,8 @@ module Honeymaker
               base_decimals: Utils.decimals(tick_size),
               quote_decimals: Utils.decimals(quote_increment),
               price_decimals: Utils.decimals(quote_increment),
-              available: detail["status"] == "open"
+              available: true,
+              trading_enabled: detail["status"] == "open"
             }
           end
         end

data/lib/honeymaker/exchanges/hyperliquid.rb

@@ -31,7 +31,8 @@ module Honeymaker
               base_decimals: base_token["szDecimals"] || 0,
               quote_decimals: 2,
               price_decimals: 5,
-              available: true
+              available: true,
+              trading_enabled: true
             }
           end
         end

data/lib/honeymaker/exchanges/kraken.rb

@@ -59,7 +59,8 @@ module Honeymaker
               base_decimals: info["lot_decimals"],
               quote_decimals: info["cost_decimals"],
               price_decimals: info["pair_decimals"],
-              available: true
+              available: true,
+              trading_enabled: info.key?("status") ? info["status"] == "online" : true
             }
           end
         end

data/lib/honeymaker/exchanges/kucoin.rb

@@ -21,7 +21,8 @@ module Honeymaker
               base_decimals: Utils.decimals(product["baseIncrement"]),
               quote_decimals: Utils.decimals(product["quoteIncrement"]),
               price_decimals: Utils.decimals(product["priceIncrement"]),
-              available: product["enableTrading"]
+              available: true,
+              trading_enabled: product["enableTrading"]
             }
           end
         end

data/lib/honeymaker/exchanges/mexc.rb

@@ -23,7 +23,8 @@ module Honeymaker
               base_decimals: f[:lot_size] ? Utils.decimals(f[:lot_size]["stepSize"]) : product["baseAssetPrecision"],
               quote_decimals: product["quoteAssetPrecision"],
               price_decimals: f[:price] ? Utils.decimals(f[:price]["tickSize"]) : product["quotePrecision"],
-              available: product["status"] == "TRADING"
+              available: true,
+              trading_enabled: product["status"] == "TRADING"
             }
           end
         end

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.8.0"
+  VERSION = "0.9.2"
 end

data/test/honeymaker/clients/kraken_client_test.rb

@@ -4,6 +4,7 @@ require "test_helper"
 
 class Honeymaker::Clients::KrakenTest < Minitest::Test
   def setup
+    Honeymaker::Clients::Kraken.reset_nonce_state! if Honeymaker::Clients::Kraken.respond_to?(:reset_nonce_state!)
     @client = Honeymaker::Clients::Kraken.new(
       api_key: "test_key",
       api_secret: Base64.strict_encode64("test_secret_key_1234567890123456")
@@ -74,8 +75,65 @@ class Honeymaker::Clients::KrakenTest < Minitest::Test
     refute headers.key?(:"API-Key")
   end
 
+  def test_reset_nonce_state_is_available_for_test_isolation
+    assert_respond_to Honeymaker::Clients::Kraken, :reset_nonce_state!
+  end
+
+  def test_nonce_is_strictly_increasing_in_a_tight_loop
+    nonces = Array.new(10_000) { @client.send(:nonce) }
+
+    assert_strictly_increasing nonces
+  end
+
+  def test_nonce_is_strictly_increasing_when_clock_is_frozen
+    frozen_time = Time.utc(2026, 1, 1, 12, 0, 0)
+    Time.stubs(:now).returns(frozen_time)
+
+    nonces = Array.new(3) { @client.send(:nonce) }
+
+    assert_strictly_increasing nonces
+  end
+
+  def test_nonce_is_strictly_increasing_across_clients_with_the_same_api_key
+    frozen_time = Time.utc(2026, 1, 1, 12, 0, 0)
+    Time.stubs(:now).returns(frozen_time)
+    other_client = Honeymaker::Clients::Kraken.new(
+      api_key: "test_key",
+      api_secret: Base64.strict_encode64("test_secret_key_1234567890123456")
+    )
+
+    nonces = [
+      @client.send(:nonce),
+      other_client.send(:nonce),
+      @client.send(:nonce),
+      other_client.send(:nonce)
+    ]
+
+    assert_strictly_increasing nonces
+  end
+
+  def test_nonce_sequences_are_independent_for_different_api_keys
+    frozen_time = Time.utc(2026, 1, 1, 12, 0, 0)
+    Time.stubs(:now).returns(frozen_time)
+    first_key_client = Honeymaker::Clients::Kraken.new(api_key: "first_key", api_secret: @client.api_secret)
+    second_key_client = Honeymaker::Clients::Kraken.new(api_key: "second_key", api_secret: @client.api_secret)
+
+    first_key_first_nonce = first_key_client.send(:nonce)
+    first_key_second_nonce = first_key_client.send(:nonce)
+    second_key_first_nonce = second_key_client.send(:nonce)
+
+    assert_operator first_key_second_nonce, :>, first_key_first_nonce
+    assert_equal first_key_first_nonce, second_key_first_nonce
+  end
+
   private
 
+  def assert_strictly_increasing(values)
+    values.each_cons(2) do |previous, current|
+      assert_operator current, :>, previous
+    end
+  end
+
   def stub_connection(method, body)
     response = stub(body: body)
     connection = stub

data/test/honeymaker/exchanges/binance_test.rb

@@ -26,6 +26,19 @@ class Honeymaker::Exchanges::BinanceTest < Minitest::Test
     assert_equal 8, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
+  end
+
+  def test_get_tickers_info_marks_non_trading_pairs_disabled
+    body = load_fixture("binance_exchange_info.json")
+    body["symbols"].first["status"] = "BREAK"
+    stub_connection(body)
+
+    result = @exchange.get_tickers_info
+
+    ticker = result.data.first
+    assert ticker[:available]        # still listed
+    refute ticker[:trading_enabled]  # but not trading
   end
 
   def test_get_tickers_info_handles_api_error

data/test/honeymaker/exchanges/binance_us_test.rb

@@ -27,6 +27,8 @@ class Honeymaker::Exchanges::BinanceUsTest < Minitest::Test
     ticker = result.data.first
     assert_equal "BTCUSDT", ticker[:ticker]
     assert_equal "BTC", ticker[:base]
+    assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
   def test_get_bid_ask_parses_response

data/test/honeymaker/exchanges/bingx_test.rb

@@ -30,6 +30,7 @@ class Honeymaker::Exchanges::BingXTest < Minitest::Test
     assert_equal 2, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
   def test_skips_symbols_without_dash

data/test/honeymaker/exchanges/bitget_test.rb

@@ -29,16 +29,18 @@ class Honeymaker::Exchanges::BitgetTest < Minitest::Test
     assert_equal 8, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
-  def test_offline_symbol_not_available
+  def test_offline_symbol_listed_but_not_trading_enabled
     body = load_fixture("bitget_symbols.json")
     stub_connection(body)
 
     result = @exchange.get_tickers_info
 
     eth = result.data.find { |t| t[:ticker] == "ETHUSDT" }
-    refute eth[:available]
+    assert eth[:available]          # still listed
+    refute eth[:trading_enabled]    # but not trading
   end
 
   def test_get_bid_ask_parses_response

data/test/honeymaker/exchanges/bitmart_test.rb

@@ -29,16 +29,18 @@ class Honeymaker::Exchanges::BitMartTest < Minitest::Test
     assert_equal 2, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
-  def test_pre_trade_not_available
+  def test_pre_trade_listed_but_not_trading_enabled
     body = load_fixture("bitmart_symbols.json")
     stub_connection(body)
 
     result = @exchange.get_tickers_info
 
     eth = result.data.find { |t| t[:ticker] == "ETH_USDT" }
-    refute eth[:available]
+    assert eth[:available]          # still listed
+    refute eth[:trading_enabled]    # but not trading
   end
 
   def test_get_bid_ask_parses_response

data/test/honeymaker/exchanges/bitrue_test.rb

@@ -29,6 +29,7 @@ class Honeymaker::Exchanges::BitrueTest < Minitest::Test
     assert_equal 2, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
   def test_falls_back_to_precision_fields_when_no_filters

data/test/honeymaker/exchanges/bitvavo_test.rb

@@ -29,16 +29,18 @@ class Honeymaker::Exchanges::BitvavoTest < Minitest::Test
     assert_equal 5, ticker[:quote_decimals]
     assert_equal 5, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
-  def test_halted_market_not_available
+  def test_halted_market_listed_but_not_trading_enabled
     body = load_fixture("bitvavo_markets.json")
     stub_connection(body)
 
     result = @exchange.get_tickers_info
 
     eth = result.data.find { |t| t[:ticker] == "ETH-EUR" }
-    refute eth[:available]
+    assert eth[:available]          # still listed
+    refute eth[:trading_enabled]    # but not trading
   end
 
   def test_get_bid_ask_parses_response

data/test/honeymaker/exchanges/bybit_test.rb

@@ -30,6 +30,7 @@ class Honeymaker::Exchanges::BybitTest < Minitest::Test
     assert_equal 8, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
   def test_get_bid_ask_parses_response

data/test/honeymaker/exchanges/coinbase_test.rb

@@ -29,6 +29,29 @@ class Honeymaker::Exchanges::CoinbaseTest < Minitest::Test
     assert_equal 2, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled] # no disabled signal -> defaults to true
+  end
+
+  def test_get_tickers_info_disables_when_trading_disabled
+    body = load_fixture("coinbase_products.json")
+    body["products"].first["trading_disabled"] = true
+    stub_connection(body)
+
+    result = @exchange.get_tickers_info
+
+    ticker = result.data.first
+    assert ticker[:available]        # still listed
+    refute ticker[:trading_enabled]  # but not trading
+  end
+
+  def test_get_tickers_info_disables_when_status_not_online
+    body = load_fixture("coinbase_products.json")
+    body["products"].first["status"] = "delisted"
+    stub_connection(body)
+
+    result = @exchange.get_tickers_info
+
+    refute result.data.first[:trading_enabled]
   end
 
   def test_filters_blacklisted_assets

data/test/honeymaker/exchanges/gemini_test.rb

@@ -35,6 +35,7 @@ class Honeymaker::Exchanges::GeminiTest < Minitest::Test
     assert_equal 2, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
   def test_get_bid_ask_parses_response

data/test/honeymaker/exchanges/hyperliquid_test.rb

@@ -28,6 +28,7 @@ class Honeymaker::Exchanges::HyperliquidTest < Minitest::Test
     assert_equal 2, ticker[:quote_decimals]
     assert_equal 5, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled] # no native status -> always true
   end
 
   def test_skips_pairs_with_missing_tokens

data/test/honeymaker/exchanges/kraken_test.rb

@@ -26,6 +26,38 @@ class Honeymaker::Exchanges::KrakenTest < Minitest::Test
     assert_equal 5, ticker[:quote_decimals]
     assert_equal 1, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled] # fixture has no status -> defaults to true
+  end
+
+  def test_get_tickers_info_disables_non_online_status
+    body = load_fixture("kraken_asset_pairs.json")
+    body["result"]["XBTUSDT"]["status"] = "cancel_only"
+    stub_request(body)
+
+    result = @exchange.get_tickers_info
+
+    ticker = result.data.first
+    assert ticker[:available]        # still listed
+    refute ticker[:trading_enabled]  # but not trading
+  end
+
+  def test_get_tickers_info_enables_online_status
+    body = load_fixture("kraken_asset_pairs.json")
+    body["result"]["XBTUSDT"]["status"] = "online"
+    stub_request(body)
+
+    result = @exchange.get_tickers_info
+
+    assert result.data.first[:trading_enabled]
+  end
+
+  def test_get_tickers_info_defaults_trading_enabled_when_status_absent
+    body = load_fixture("kraken_asset_pairs.json") # no status key
+    stub_request(body)
+
+    result = @exchange.get_tickers_info
+
+    assert result.data.first[:trading_enabled]
   end
 
   def test_get_tickers_info_skips_pairs_without_wsname

data/test/honeymaker/exchanges/kucoin_test.rb

@@ -30,6 +30,7 @@ class Honeymaker::Exchanges::KucoinTest < Minitest::Test
     assert_equal 6, ticker[:quote_decimals]
     assert_equal 1, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
   def test_get_bid_ask_parses_response

data/test/honeymaker/exchanges/mexc_test.rb

@@ -29,16 +29,18 @@ class Honeymaker::Exchanges::MexcTest < Minitest::Test
     assert_equal 8, ticker[:quote_decimals]
     assert_equal 2, ticker[:price_decimals]
     assert ticker[:available]
+    assert ticker[:trading_enabled]
   end
 
-  def test_halted_symbol_not_available
+  def test_halted_symbol_listed_but_not_trading_enabled
     body = load_fixture("mexc_exchange_info.json")
     stub_connection(body)
 
     result = @exchange.get_tickers_info
 
     halted = result.data.find { |t| t[:ticker] == "ETHUSDT" }
-    refute halted[:available]
+    assert halted[:available]        # still listed
+    refute halted[:trading_enabled]  # but not trading
   end
 
   def test_falls_back_to_precision_fields_when_no_filters

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.2
 platform: ruby
 authors:
 - Deltabadger