honeymaker 0.12.1 → 0.12.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 490f356afca4a4979a1926d396a86790bb48931476252fa2b26b578dcc8f293c
-  data.tar.gz: 1d9e2be37ff533e69c07f91879e82c3fe7a80dd399d59106a9a1fef5bcd95ebb
+  metadata.gz: 2306f41b9132fa6da84591b6ec38ca160a3fd052ef74a0893d3c27f01f64e8f3
+  data.tar.gz: 40bb6abacd74cfbd7fded2bb0d560700be9be0bf29c4fbf2aa7ab725d816a294
 SHA512:
-  metadata.gz: 336d17418b800025c21b423b033416f78fc8ac47448e8959833fab49e7f77fd2568904d757a2d68487c3fab9373092a8ab4f7645285d96fba9a1bf1c0e0c73d8
-  data.tar.gz: b616e6aed2b85c593cf18523071966d697530407c963b7d1c97c1031e2cc6d0e4711be06ea974488aa22fa61c1cc5de7f66e601247436fc9ab475dbc9b5699e5
+  metadata.gz: 326a5af73ef2f8564dda06d0d6f82a3f873d5b05f725d579666ccbb1df42a74603221904190972ac8b7b7fbe74d673898f1bc5e08da799655fd11d3959dfc1a6
+  data.tar.gz: 1c24efe089db21b89d7c24bd563da3841f5cfd3899c339d5524a3c55970245632bcdf8c36b2f060bbae6bc50e8a2f7e918c87684ba9e7e2e91002cdabf14c31e

data/lib/honeymaker/clients/gemini.rb

@@ -168,7 +168,8 @@ module Honeymaker
         with_rescue do
           payload = body.compact.merge(request: path, nonce: timestamp_ms.to_s)
           encoded_payload = Base64.strict_encode64(payload.to_json)
-          signature = hmac_sha256(@api_secret, encoded_payload)
+          # HMAC-SHA384, not SHA256: https://developer.gemini.com/authentication/api-key
+          signature = OpenSSL::HMAC.hexdigest("sha384", @api_secret, encoded_payload)
 
           response = connection.post do |req|
             req.url path

data/lib/honeymaker/clients/kraken.rb

@@ -7,6 +7,7 @@ module Honeymaker
   module Clients
     class Kraken < Client
       URL = "https://api.kraken.com"
+      UNREADABLE = "Kraken: unreadable response"
 
       RATE_LIMITS = { default: 1000, orders: 1000 }.freeze
 
@@ -23,6 +24,7 @@ module Honeymaker
           txid: txid, consolidate_taker: consolidate_taker
         })
         return result if result.failure?
+        return unreadable unless result.data.is_a?(Hash)
 
         errors = result.data["error"]
         return Result::Failure.new(*errors) if errors.is_a?(Array) && errors.any?
@@ -53,6 +55,7 @@ module Honeymaker
           "deadline" => deadline, "validate" => validate
         })
         return result if result.failure?
+        return unreadable unless result.data.is_a?(Hash)
 
         errors = result.data["error"]
         return Result::Failure.new(*errors) if errors.is_a?(Array) && errors.any?
@@ -96,6 +99,7 @@ module Honeymaker
       def get_balances
         result = get_extended_balance
         return result if result.failure?
+        return unreadable unless result.data.is_a?(Hash)
 
         errors = result.data["error"]
         return Result::Failure.new(*errors) if errors.is_a?(Array) && errors.any?
@@ -149,6 +153,7 @@ module Honeymaker
         loop do
           result = get_trades_history(start: start, ofs: offset)
           return result if result.failure?
+          return unreadable unless result.data.is_a?(Hash)
 
           errors = result.data["error"]
           return Result::Failure.new(*errors) if errors.is_a?(Array) && errors.any?
@@ -196,6 +201,12 @@ module Honeymaker
 
       private
 
+      # A 2xx body that isn't a JSON object (a maintenance page, "null"): the venue's answer is
+      # unknown, which is not the same as empty. Callers treat data[:unreadable] as ambiguous.
+      def unreadable
+        Result::Failure.new(UNREADABLE, data: { unreadable: true })
+      end
+
       def aggregate_trades(trades)
         first = trades.first
         vol  = trades.sum { |t| BigDecimal(t["vol"].to_s) }

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.12.1"
+  VERSION = "0.12.3"
 end

data/test/honeymaker/clients/gemini_client_test.rb

@@ -72,6 +72,23 @@ class Honeymaker::Clients::GeminiTest < Minitest::Test
     assert result.success?
   end
 
+  # Gemini signs with HMAC-SHA384 of the base64 payload
+  # (https://developer.gemini.com/authentication/api-key); any other digest is rejected.
+  def test_private_requests_are_signed_with_hmac_sha384
+    request = Struct.new(:headers) { def url(_path) = nil }.new
+    connection = Object.new
+    connection.define_singleton_method(:post) do |&block|
+      block.call(request)
+      Struct.new(:body).new({})
+    end
+    @client.instance_variable_set(:@connection, connection)
+
+    @client.get_balances
+
+    payload = request.headers[:"X-GEMINI-PAYLOAD"]
+    assert_equal OpenSSL::HMAC.hexdigest("sha384", "test_secret", payload), request.headers[:"X-GEMINI-SIGNATURE"]
+  end
+
   private
 
   def stub_connection(method, body)

data/test/honeymaker/clients/kraken_client_test.rb

@@ -15,6 +15,18 @@ class Honeymaker::Clients::KrakenTest < Minitest::Test
     assert_equal "https://api.kraken.com", Honeymaker::Clients::Kraken::URL
   end
 
+  def test_non_object_2xx_is_unreadable_not_empty
+    [["<html>maintenance</html>", ->(c) { c.get_balances }],
+     [nil, ->(c) { c.query_orders_info(txid: "O1") }],
+     ["oops", ->(c) { c.add_order(ordertype: "market", type: "buy", volume: "1", pair: "XBTUSD") }],
+     ["oops", ->(c) { c.closed_orders_from_trades(order_ids: ["O1"]) }]].each do |body, call|
+      stub_connection(:post, body)
+      r = call.call(@client)
+      assert_equal ["Kraken: unreadable response"], r.errors
+      assert_equal({ unreadable: true }, r.data)
+    end
+  end
+
   def test_get_tradable_asset_pairs
     stub_connection(:get, { "error" => [], "result" => { "XBTUSDT" => { "altname" => "XBTUSDT" } } })
     result = @client.get_tradable_asset_pairs

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.12.1
+  version: 0.12.3
 platform: ruby
 authors:
 - Deltabadger