honeymaker 0.12.0 → 0.12.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc3033c53052a7498aff900daa5751df3c7fc335d141e44fb411ddcd644fbb60
-  data.tar.gz: 783c314037519d4e404e6145b98d6107cced8c46f180f7aff7d6ee123b145691
+  metadata.gz: 6862c70498fbf141e4808db14c19d5bd63a5dc59d7877797048756252b1d2836
+  data.tar.gz: e593c15692fcf4fb4677349b269076314cfac14fbe09b65b1c05b7aada91894d
 SHA512:
-  metadata.gz: f192d993e87591038536d8edf6e02546d2320d73840fa1c1610f826f3721805eb4fa8021dba486ed752c90d5db7c707fecf4552285f8534c95c98aac6cc65f21
-  data.tar.gz: f54ef09c03a5c461700148ed7a58782ad654dad0af0c626d7093f524218e03a57fd49e09694f28dda606546baf612567415b821aa9f0b67c6268eea31c02e81e
+  metadata.gz: f1547ddeaa92b66ba371d21f5452d88dc5aec87895649d28dec3ea9d54b36cb76582084b923381aadcbc004a95ba17291951b717ad4a7601a4401966f72af760
+  data.tar.gz: 96ad193d8d2ca903ac26e261c7a493ce77f25f2e644e4e5e152d8d4a3f717b5ae5cb6bfa6d1f3f33d49656b3a5decd5ee98402ce85ea5d3c72f28819858a93c2

data/lib/honeymaker/clients/gemini.rb

@@ -168,7 +168,8 @@ module Honeymaker
         with_rescue do
           payload = body.compact.merge(request: path, nonce: timestamp_ms.to_s)
           encoded_payload = Base64.strict_encode64(payload.to_json)
-          signature = hmac_sha256(@api_secret, encoded_payload)
+          # HMAC-SHA384, not SHA256: https://developer.gemini.com/authentication/api-key
+          signature = OpenSSL::HMAC.hexdigest("sha384", @api_secret, encoded_payload)
 
           response = connection.post do |req|
             req.url path

data/lib/honeymaker/clients/kraken.rb

@@ -87,6 +87,12 @@ module Honeymaker
         post_private("/0/private/BalanceEx", { nonce: nonce })
       end
 
+      # The key's own permission flags (query-funds, withdraw-funds, modify-trades, query-ledger, ...).
+      # Needs no permission itself, so it answers for any valid key.
+      def get_api_key_info
+        post_private("/0/private/GetApiKeyInfo", { nonce: nonce })
+      end
+
       def get_balances
         result = get_extended_balance
         return result if result.failure?

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.12.0"
+  VERSION = "0.12.2"
 end

data/test/honeymaker/clients/gemini_client_test.rb

@@ -72,6 +72,23 @@ class Honeymaker::Clients::GeminiTest < Minitest::Test
     assert result.success?
   end
 
+  # Gemini signs with HMAC-SHA384 of the base64 payload
+  # (https://developer.gemini.com/authentication/api-key); any other digest is rejected.
+  def test_private_requests_are_signed_with_hmac_sha384
+    request = Struct.new(:headers) { def url(_path) = nil }.new
+    connection = Object.new
+    connection.define_singleton_method(:post) do |&block|
+      block.call(request)
+      Struct.new(:body).new({})
+    end
+    @client.instance_variable_set(:@connection, connection)
+
+    @client.get_balances
+
+    payload = request.headers[:"X-GEMINI-PAYLOAD"]
+    assert_equal OpenSSL::HMAC.hexdigest("sha384", "test_secret", payload), request.headers[:"X-GEMINI-SIGNATURE"]
+  end
+
   private
 
   def stub_connection(method, body)

data/test/honeymaker/clients/kraken_client_test.rb

@@ -78,6 +78,14 @@ class Honeymaker::Clients::KrakenTest < Minitest::Test
     assert result.success?
   end
 
+  def test_get_api_key_info
+    stub_connection(:post, { "error" => [], "result" => { "apiKeyName" => "bot",
+                                                          "permissions" => %w[query-funds query-ledger] } })
+    result = @client.get_api_key_info
+    assert result.success?
+    assert_equal %w[query-funds query-ledger], result.data["result"]["permissions"]
+  end
+
   def test_get_trades_history
     stub_connection(:post, { "error" => [], "result" => { "trades" => { "T1" => { "pair" => "XBTUSDT" } }, "count" => 1 } })
     result = @client.get_trades_history

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.12.2
 platform: ruby
 authors:
 - Deltabadger