honeymaker 0.11.5 → 0.11.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d279d1416ac845778e5bf48218fbacf23498cae10bc1ed589cae28752aa4af8c
-  data.tar.gz: 2aebe8b36d740f1c09bb9ecf21ab205b911f6ce11fc41b0a7bc80898602d016f
+  metadata.gz: 79df37d9e336e6aae8b38cbe4af40655742da763a47842b3b0128355130c2c48
+  data.tar.gz: 8a821ce866ad46433104a085375f5ac3073ac159c44e0b31f4f57170414a99fc
 SHA512:
-  metadata.gz: ae37fa13ff7ce2db5366a408a4d006f671fcbda1c8931c8bca9c8df8a3c13c1256101a73b364bbffc58971923090d5dd8b0e44b49fdc35f73a0ecee8979f67b6
-  data.tar.gz: 0a00d2949aeba2b30b681a8021b59083de3498d201446e70ba88e1c2ccfa135f6137036620559f1e79cc2f216328639a3bf61d47f1082fa73040aa60389967c0
+  metadata.gz: ea5bbaf9abffab526e1929b0c6e9d3ebc80af1e609fdb696a5c141585d57e643d99370acb1dcf458f6fe7c02df22c269b240e316ca68dfbd8295ef1b882ae4a4
+  data.tar.gz: 8dca53d930a98f7259f3c73d6e3827e40647fbf6ceaefd857c2795e1c499c630f335912c23a030a2a72aa326d578b1529d55bb825e2e54c08db56e794339da1f

data/lib/honeymaker/exchanges/gemini.rb

@@ -5,13 +5,24 @@ module Honeymaker
     class Gemini < Exchange
       BASE_URL = "https://api.gemini.com"
 
+      # Gemini has no bulk symbol-details endpoint, so the catalogue is one request per symbol --
+      # ~350 of them against a public limit of 120/min. Unpaced they ran at ~208/min, and a single
+      # dropped connection failed the whole catalogue: the adapter retries nothing on its own.
+      REQUEST_INTERVAL = 0.5
+      REQUEST_ATTEMPTS = 3
+      TRANSIENT_ERRORS = [
+        Faraday::ConnectionFailed, Faraday::TimeoutError, Faraday::RequestTimeoutError,
+        Faraday::TooManyRequestsError, Faraday::ServerError
+      ].freeze
+
       def get_tickers_info
         with_rescue do
-          symbols_response = connection.get("/v1/symbols")
-          symbols = symbols_response.body
+          symbols = catalogue_get("/v1/symbols")
 
           symbols.filter_map do |symbol|
-            detail = connection.get("/v1/symbols/details/#{symbol}").body
+            # A symbol that still fails raises, failing the WHOLE catalogue. Never skip it: callers
+            # read a pair missing from the catalogue as delisted, and data-api revokes it.
+            detail = catalogue_get("/v1/symbols/details/#{symbol}")
 
             tick_size = detail["tick_size"]&.to_s || "0.01"
             quote_increment = detail["quote_increment"]&.to_s || "0.01"
@@ -50,6 +61,20 @@ module Honeymaker
       def connection
         @connection ||= build_connection(BASE_URL)
       end
+
+      def catalogue_get(path)
+        attempt = 1
+        begin
+          sleep(REQUEST_INTERVAL)
+          connection.get(path).body
+        rescue *TRANSIENT_ERRORS
+          raise if attempt >= REQUEST_ATTEMPTS
+
+          sleep(2**attempt)
+          attempt += 1
+          retry
+        end
+      end
     end
   end
 end

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.11.5"
+  VERSION = "0.11.6"
 end

data/test/honeymaker/exchanges/gemini_test.rb

@@ -7,6 +7,9 @@ class Honeymaker::Exchanges::GeminiTest < Minitest::Test
 
   def setup
     @exchange = Honeymaker::Exchanges::Gemini.new
+    # Recorded, not slept: the pacing and the backoff are asserted as a sequence.
+    sleeps = @sleeps = []
+    @exchange.define_singleton_method(:sleep) { |seconds| sleeps << seconds }
   end
 
   def test_get_tickers_info_parses_response
@@ -38,6 +41,73 @@ class Honeymaker::Exchanges::GeminiTest < Minitest::Test
     assert ticker[:trading_enabled]
   end
 
+  def test_get_tickers_info_paces_every_request
+    stub_catalogue(%w[btcusd ethusd])
+
+    assert @exchange.get_tickers_info.success?
+    assert_equal [0.5, 0.5, 0.5], @sleeps
+  end
+
+  def test_get_tickers_info_retries_a_dropped_detail_request
+    connection = stub_catalogue(%w[btcusd ethusd])
+    connection.stubs(:get).with("/v1/symbols/details/ethusd")
+              .raises(Faraday::ConnectionFailed, "end of file reached")
+              .then.returns(detail_response)
+
+    result = @exchange.get_tickers_info
+
+    assert result.success?
+    assert_equal 2, result.data.size
+    assert_equal [0.5, 0.5, 0.5, 2, 0.5], @sleeps
+  end
+
+  def test_get_tickers_info_retries_the_symbols_request
+    connection = stub_catalogue(%w[btcusd])
+    connection.stubs(:get).with("/v1/symbols")
+              .raises(Faraday::TooManyRequestsError, "429")
+              .then.returns(stub(body: %w[btcusd]))
+
+    result = @exchange.get_tickers_info
+
+    assert result.success?
+    assert_equal 1, result.data.size
+  end
+
+  def test_get_tickers_info_retries_every_transient_error_class
+    Honeymaker::Exchanges::Gemini::TRANSIENT_ERRORS.each do |error_class|
+      setup
+      connection = stub_catalogue(%w[btcusd])
+      connection.stubs(:get).with("/v1/symbols/details/btcusd")
+                .raises(error_class, "transient").then.returns(detail_response)
+
+      assert @exchange.get_tickers_info.success?, "#{error_class} should be retried"
+    end
+  end
+
+  # All or nothing: data-api reads a pair missing from the catalogue as delisted, so a symbol that
+  # keeps failing must fail the whole catalogue, and nothing after it is fetched.
+  def test_get_tickers_info_fails_whole_catalogue_when_a_symbol_keeps_failing
+    connection = stub_catalogue(%w[btcusd ethusd solusd])
+    connection.expects(:get).with("/v1/symbols/details/ethusd").times(3)
+              .raises(Faraday::ConnectionFailed, "end of file reached")
+    connection.expects(:get).with("/v1/symbols/details/solusd").never
+
+    result = @exchange.get_tickers_info
+
+    assert result.failure?
+    assert_nil result.data
+    assert_equal ["end of file reached"], result.errors
+    assert_equal [0.5, 0.5, 0.5, 2, 0.5, 4, 0.5], @sleeps
+  end
+
+  def test_get_tickers_info_does_not_retry_a_non_transient_error
+    connection = stub_catalogue(%w[btcusd])
+    connection.expects(:get).with("/v1/symbols/details/btcusd").once
+              .raises(Faraday::ResourceNotFound, "404")
+
+    assert @exchange.get_tickers_info.failure?
+  end
+
   def test_get_bid_ask_parses_response
     body = load_fixture("gemini_pubticker.json")
     stub_connection(body)
@@ -51,6 +121,19 @@ class Honeymaker::Exchanges::GeminiTest < Minitest::Test
 
   private
 
+  def detail_response
+    stub(body: load_fixture("gemini_symbol_detail.json"))
+  end
+
+  # Every symbol resolves to the one detail fixture; a test overrides a path to make it fail.
+  def stub_catalogue(symbols)
+    connection = stub
+    connection.stubs(:get).with("/v1/symbols").returns(stub(body: symbols))
+    connection.stubs(:get).with { |path| path.start_with?("/v1/symbols/details/") }.returns(detail_response)
+    @exchange.instance_variable_set(:@connection, connection)
+    connection
+  end
+
   def stub_connection(body)
     response = stub(body: body)
     connection = stub

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.11.5
+  version: 0.11.6
 platform: ruby
 authors:
 - Deltabadger