honeymaker 0.11.4 → 0.11.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2367ab9c6994586eb565f383f4b897d7a7bdcfb5cf68c0593da80f6b4d4b0497
-  data.tar.gz: 585589c4bc524266bed905b142913b6072e5ff8824602cdf5691e6ac2046bf39
+  metadata.gz: d279d1416ac845778e5bf48218fbacf23498cae10bc1ed589cae28752aa4af8c
+  data.tar.gz: 2aebe8b36d740f1c09bb9ecf21ab205b911f6ce11fc41b0a7bc80898602d016f
 SHA512:
-  metadata.gz: b4d5824b776181fff4494c1f4fe76e8ff46e21faf198cb23a894ea836fcfb4bc4f3eb8c0eec2315cc072a065ce9de5b4fd9e34d50f52390368069c5fbd091b13
-  data.tar.gz: f63b8235706bc5257bc1710939fc68f315316650966476a55ff4a25c1de35bb3035f42f54a94105fd1e446bcb4c6e684b65b2418bb16db68f7310c5bdb17dd16
+  metadata.gz: ae37fa13ff7ce2db5366a408a4d006f671fcbda1c8931c8bca9c8df8a3c13c1256101a73b364bbffc58971923090d5dd8b0e44b49fdc35f73a0ecee8979f67b6
+  data.tar.gz: 0a00d2949aeba2b30b681a8021b59083de3498d201446e70ba88e1c2ccfa135f6137036620559f1e79cc2f216328639a3bf61d47f1082fa73040aa60389967c0

data/lib/honeymaker/clients/hyperliquid.rb

@@ -130,13 +130,13 @@ module Honeymaker
       # --- Trading (requires hyperliquid-rb gem) ---
 
       def order(coin:, is_buy:, size:, limit_px:, order_type: { limit: { tif: "Gtc" } })
-        with_rescue do
+        with_status_rescue do
           exchange_client.order(coin, is_buy: is_buy, sz: size, limit_px: limit_px, order_type: order_type)
         end
       end
 
       def cancel(coin:, oid:)
-        with_rescue do
+        with_status_rescue do
           exchange_client.cancel(coin, oid)
         end
       end
@@ -157,6 +157,28 @@ module Honeymaker
 
       private
 
+      # Trading does not go over this client's Faraday connection: it goes through hyperliquid-rb,
+      # which raises its own error for every non-2xx instead of answering. Client#with_rescue can
+      # only see an unlabelled StandardError there, so it flags it `client_error` — "no clean
+      # answer" — and a caller reading an order placement has to treat that as a request whose fate
+      # is unknown: nothing recorded as rejected, no retry, a line for a human to reconcile against
+      # the venue. But the status is right there on the exception, and it is exactly what tells a
+      # refusal (4xx — the gateway answered, nothing reached the matching engine) from a request the
+      # venue may still have taken (5xx). Hand it back in the same shape every other HTTP failure
+      # has, so one classifier covers both paths.
+      #
+      # Duck-typed on purpose: hyperliquid-rb is an optional dependency loaded only when trading is
+      # used, so its error classes cannot be named here. Anything without a status is classified
+      # exactly as it is everywhere else.
+      def with_status_rescue
+        Result::Success.new(yield)
+      rescue StandardError => e
+        status = e.respond_to?(:status) ? e.status.to_i : 0
+        return with_rescue { raise e } unless status.positive?
+
+        Result::Failure.new(e.message.to_s.empty? ? e.class.to_s : e.message, data: { status: status })
+      end
+
       # Suffix-aware so the whole Hyperliquid cancel family (marginCanceled, scheduledCancel,
       # reduceOnlyCanceled, siblingFilledCanceled, …) maps correctly. A triggered order has fired
       # and become a live resting order → :open. An unmapped status is logged, never swallowed.

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.11.4"
+  VERSION = "0.11.5"
 end

data/test/honeymaker/clients/hyperliquid_client_test.rb

@@ -190,6 +190,76 @@ class Honeymaker::Clients::HyperliquidTest < Minitest::Test
     assert result.success?
   end
 
+  # == Raised trading errors keep their HTTP status ==
+  #
+  # Order placement goes through hyperliquid-rb, which raises instead of answering. Whether the
+  # venue REFUSED the request or may have TAKEN it is the whole question for a caller deciding
+  # between "record a rejected order" and "a human has to go and look" — and the status is the only
+  # thing that answers it. It must survive the trip.
+
+  # hyperliquid-rb's ClientError/ServerError shape. Rebuilt here because the gem is an optional
+  # dependency this one does not carry.
+  class RaisedWithStatus < StandardError
+    attr_reader :status
+
+    def initialize(message, status:)
+      @status = status
+      super(message)
+    end
+  end
+
+  def test_order_reports_a_refusal_with_its_status
+    @client.stubs(:exchange_client).raises(RaisedWithStatus.new("HTTP 429: rate limited", status: 429))
+
+    result = @client.order(coin: "@142", is_buy: true, size: 1, limit_px: 100)
+
+    assert result.failure?
+    assert_equal 429, result.data[:status]
+    assert_nil result.data[:client_error], "the venue answered — this is not an unknown outcome"
+    assert_equal ["HTTP 429: rate limited"], result.errors
+  end
+
+  # 5xx stays 5xx: a gateway that may have passed the order on is exactly the case a caller must
+  # keep treating as unresolved.
+  def test_order_reports_a_gateway_failure_with_its_status
+    @client.stubs(:exchange_client).raises(RaisedWithStatus.new("HTTP 502: bad gateway", status: 502))
+
+    result = @client.order(coin: "@142", is_buy: true, size: 1, limit_px: 100)
+
+    assert result.failure?
+    assert_equal 502, result.data[:status]
+  end
+
+  def test_cancel_reports_a_refusal_with_its_status
+    @client.stubs(:exchange_client).raises(RaisedWithStatus.new("HTTP 422: unknown oid", status: 422))
+
+    result = @client.cancel(coin: "@142", oid: 1)
+
+    assert result.failure?
+    assert_equal 422, result.data[:status]
+  end
+
+  # Everything the venue did not answer is untouched: a signing crash inside the gem, a network
+  # failure, a bug here. Those stay flagged as ours and unclassifiable.
+  def test_order_leaves_a_statusless_error_classified_as_before
+    @client.stubs(:exchange_client).raises(TypeError, "String can't be coerced into Float")
+
+    result = @client.order(coin: "@142", is_buy: true, size: 1, limit_px: 100)
+
+    assert result.failure?
+    assert result.data[:client_error], "no status means no answer from the venue"
+    assert_equal ["TypeError: String can't be coerced into Float"], result.errors
+  end
+
+  def test_order_wraps_an_accepted_placement
+    @client.stubs(:exchange_client).returns(stub(order: { "status" => "ok" }))
+
+    result = @client.order(coin: "@142", is_buy: true, size: 1, limit_px: 100)
+
+    assert result.success?
+    assert_equal({ "status" => "ok" }, result.data)
+  end
+
   private
 
   def stub_connection(method, body)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.11.4
+  version: 0.11.5
 platform: ruby
 authors:
 - Deltabadger