honeycomb-rails 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a2b71f4dd7faf9e77bb9c81f3ff4accefb56ff90b80f6aec3146968e9cb4aae
-  data.tar.gz: 0d41717e62b0c6a2f0ec8095e19e4e4380d72ea73f05a95a8e16c02a9db872d1
+  metadata.gz: 017fdc196902aa439d9db39265aa6184ca8c13c40bb79bcb770c29d7f8621ab1
+  data.tar.gz: 575023c210eade7f3f1dd18ba720937f82e055b72c9c7d556879acdf84807bd2
 SHA512:
-  metadata.gz: 749e9fdfe9b1c29368e03a4758e71aa1add18def3cf9b9147fd1a77fd81b065e7bd9e4bd16bfc053b6252c668b7aba678a2df26f706fa63e2491e869977cbc3e
-  data.tar.gz: 4f232b225976ff82f71d93a866cefef47c31bb72244a7e6f06f56e756aca8045f27d1c89b6af76a2e7afd151d7986f514acc7d452c9aaafd9283995b1727776e
+  metadata.gz: 4d630a38edf0578e6cd0eccdcaaf82a3347225f477c1bb239c2b67a796f32b21dd6eba172870fae4216cb344f4d8c95092c5d6e1552ea8c885b2fbcb2189aaa5
+  data.tar.gz: 36d6080273a54706b3e57cd61b1231418ecd45b082134a4bf9c103697abba09f02a485ca33966d3eddcac6b96e5a6f7fbc7ab0f3cacc3e953935a45fd2237f0c

data/lib/honeycomb-rails/railtie.rb

@@ -21,37 +21,30 @@ module HoneycombRails
 
       @libhoney = HoneycombRails.config.client || begin
         writekey = HoneycombRails.config.writekey
-        if writekey.blank?
-          HoneycombRails.config.logger.warn("No write key defined! (Check your config's `writekey` value in config/initializers/honeycomb.rb) No events will be sent to Honeycomb.")
+        default_dataset = HoneycombRails.config.dataset
+        if writekey.blank? || default_dataset.blank?
+          missing = writekey.blank? ? 'writekey' : 'dataset'
+          warn "No #{missing} defined! (Check your config's `#{missing}` value in config/initializers/honeycomb.rb) No events will be sent to Honeycomb."
+          Libhoney::NullClient.new
+        else
+          Libhoney::Client.new(
+            writekey: writekey,
+            dataset: default_dataset,
+            user_agent_addition: HoneycombRails::USER_AGENT_SUFFIX,
+          )
         end
-
-        Libhoney::Client.new(
-          writekey: writekey,
-          user_agent_addition: HoneycombRails::USER_AGENT_SUFFIX,
-        )
       end
     end
 
     config.after_initialize do
-      subscribers = []
-
-      if !HoneycombRails.config.dataset.blank?
-        req_builder = @libhoney.builder
-        req_builder.dataset = HoneycombRails.config.dataset
-        subscribers.push(Subscribers::ProcessAction.new(req_builder))
-      end
+      req_builder = @libhoney.builder
+      Subscribers::ProcessAction.new(req_builder).subscribe!
 
       if !HoneycombRails.config.db_dataset.blank?
         db_builder = @libhoney.builder
         db_builder.dataset = HoneycombRails.config.db_dataset
-        subscribers.push(Subscribers::ActiveRecord.new(db_builder))
+        Subscribers::ActiveRecord.new(db_builder).subscribe!
       end
-
-      if subscribers.empty?
-        HoneycombRails.config.logger.warn("No subscribers defined (are both HoneycombRails.config.dataset and HoneycombRails.config.db_dataset both blank?)")
-      end
-
-      subscribers.each(&:subscribe!)
     end
   end
 end

data/lib/honeycomb-rails/version.rb

@@ -1,7 +1,7 @@
 module HoneycombRails
   GEM_NAME = 'honeycomb-rails'
 
-  VERSION = '0.7.1'
+  VERSION = '0.7.2'
 
   USER_AGENT_SUFFIX = "#{GEM_NAME}/#{VERSION}".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeycomb-rails
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Sam Stokes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-22 00:00:00.000000000 Z
+date: 2018-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: libhoney
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement