honeycomb-rails 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20540b339eef388e9906ce50a0c3b7efbb8cb282189400bf7230d1005f166ea7
-  data.tar.gz: 855af5e90804fdab8f7f2aba2641352673ef5e6ce1abff2953f9926077b2b968
+  metadata.gz: 3ce38870b1d7d5dc68b425b3e4bf323ea3e26b4d59b2bad85270b17f4f444b2e
+  data.tar.gz: 8f30aa96990892d0cb6515b119bff5aac96045e1b9fc1bb1137febd72b7ac91a
 SHA512:
-  metadata.gz: be8cb30c03e21a4ca871d85817526dc627b5c35b8192f047a5342a86656bf45fde7bcf1ac8270603a1d8daec7ac02e54f356a3d0e7449f0f3fbffb668e7ecefa
-  data.tar.gz: ce2c4b9085ac5e8471619b3747cc99eb07e7a759ebdd5f8a223bd9decc3ad368fc07789fbd46416cd31caf44f6279c624b1a6f972a384f8bb49c1563976d2582
+  metadata.gz: ca245585297cb2f654828cf2729b064a174c13187023dfdd9b113c793ad39dd0084edb065a6476e75fd35bd5d8c36e08527065d3b48a8887b8fdf8a4fa89d1a6
+  data.tar.gz: ee159ce39880ac7438fb904d5d8600d824df005fce2d42002bc63d934f8e861f9bc84047a6c5046f3122ebb594bada4128e73c8912377f89038d76f97bb6f50d

data/lib/honeycomb-rails/config.rb

@@ -9,6 +9,9 @@ module HoneycombRails
       @record_flash = true
       @record_user = :detect
       @logger = Rails.logger
+      @capture_exceptions = true
+      @capture_exception_backtraces = true
+      @sample_rate = 1
     end
 
     # Whether to record flash messages (default: true).
@@ -45,6 +48,27 @@ module HoneycombRails
 
     # The Honeycomb write key for your team (must be specified).
     attr_accessor :writekey
+
+    # If set, determines how to record the sample rate for a given Honeycomb
+    # event. (default: 1, do not sample)
+    #
+    # Valid values:
+    # * Integer - sample Honeycomb events at a constant rate
+    # * 1 or lower - disable sampling on this dataset; capture all events
+    # * TODO: :rails - default Rails dynamic sampling?
+    #
+    # You can also pass a Proc, which will be called with the current controller
+    # instance during each request, and which should return a sample rate for
+    # the request in question.
+    attr_accessor :sample_rate
+
+    # If set to true, captures exception class name / message along with Rails
+    # request events. (default: true)
+    attr_accessor :capture_exceptions
+
+    # If set to true, captures backtraces when capturing exception metadata.
+    # No-op if capture_exceptions is false. (default: true)
+    attr_accessor :capture_exception_backtraces
   end
 
   class << self

data/lib/honeycomb-rails/overrides/action_controller_instrumentation.rb

@@ -65,5 +65,24 @@ module HoneycombRails
         end
       end
     end
+    module ActionControllerFilters
+      def self.included(controller_class)
+        controller_class.around_action :honeycomb_attach_exception_metadata
+      end
+
+      def honeycomb_attach_exception_metadata
+        begin
+          yield
+        rescue StandardError => exception
+          honeycomb_metadata[:exception_class] = exception.class.to_s
+          honeycomb_metadata[:exception_message] = exception.message
+          if HoneycombRails.config.capture_exception_backtraces
+            honeycomb_metadata[:exception_source] = Rails.backtrace_cleaner.clean(exception.backtrace)
+          end
+
+          raise
+        end
+      end
+    end
   end
 end

data/lib/honeycomb-rails/railtie.rb

@@ -19,6 +19,10 @@ module HoneycombRails
     config.after_initialize do
       writekey = HoneycombRails.config.writekey
       @libhoney = Libhoney::Client.new(writekey: writekey)
+
+      if HoneycombRails.config.capture_exceptions
+        ::ActionController::Base.include(Overrides::ActionControllerFilters)
+      end
     end
 
     config.after_initialize do

data/lib/honeycomb-rails/subscribers/process_action.rb

@@ -37,7 +37,19 @@ module HoneycombRails
           data.merge!(event.payload[Constants::EVENT_METADATA_KEY])
         end
 
-        @libhoney.send_now(data)
+        honeycomb_event = @libhoney.event
+        honeycomb_event.add(data)
+
+        case HoneycombRails.config.sample_rate
+        when Proc
+          honeycomb_event.sample_rate = HoneycombRails.config.sample_rate.call(event.payload)
+        when Integer
+          if HoneycombRails.config.sample_rate > 1
+            honeycomb_event.sample_rate = HoneycombRails.config.sample_rate
+          end
+        end
+
+        honeycomb_event.send
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeycomb-rails
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Sam Stokes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-05 00:00:00.000000000 Z
+date: 2017-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: libhoney