honeybee-openstudio 2.38.9 → 2.38.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a2f2bfb60c9779aff40ac4d86c6d2d3416fd1c34722b5378874b6b85cceaf8cd
-  data.tar.gz: e1638526a3701c0035efdb8695fdbb026364ecc85c42a38e262de43e9beb729f
+  metadata.gz: 0b69248c9b67508ffd7d9c499d98a0165b2257bb463c1966aa91581ba811e02c
+  data.tar.gz: cabde69403755a50ac598c0cae2c7e5978fef001add4b606a7e4b66d09a6ce4f
 SHA512:
-  metadata.gz: 619bfa717c81e91aea5f481a6f86f538fb7c1cb4a508b4e8fa1695826096bde37e892de9fae98b3df71036c295b1ba2aed9f5f008a154e8ecfee2b6643e8b9e8
-  data.tar.gz: 22b5002543933e86a89192ae2fb6e0780306ca94308fd808651c93135f0f9f67145894e04f6188ac330d4345fb13ea49c8709dff26869af4eb6ea08548d77267
+  metadata.gz: bf9e067fb6e40fe5ec1ec04d062759116ee6cfd927c22ad2b0f8f38a11b731421ffb23e54d3773d2cf9b4612cb897075e1946e1469caab49452e7f4fe5082a3d
+  data.tar.gz: 34c1b468a61d6411cf414ba30d5299f312b09c1503a59fd01df89e47848d1e5f0bc5fedf86ca1959e1c11c10a60f69666b4cc8ab5130a5756fb7a3d45841e33b

data/.github/workflows/ci.yaml

@@ -31,9 +31,9 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - name: set up node  # we need node for for semantic release
-        uses: actions/setup-node@v3.6.0
+        uses: actions/setup-node@v4
         with:
-          node-version: 14.17.0
+          node-version: 22.2.0
       - name: install semantic-release
         run:
           npm install @semantic-release/exec

data/.releaserc.json

@@ -2,6 +2,12 @@
     "plugins": [
         "@semantic-release/commit-analyzer",
         "@semantic-release/release-notes-generator",
-        "@semantic-release/github"
+        [
+            "@semantic-release/github",
+            {
+                "successComment": false,
+                "failTitle": false
+            }
+        ]
     ]
 }

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.38.9'
+  spec.version       = '2.38.11'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/to_openstudio/load/service_hot_water.rb

@@ -233,6 +233,11 @@ module Honeybee
     end
 
     def to_openstudio(openstudio_model, os_space, shw_name)
+      # if there's no name, assume that we're using the default district water heater
+      if shw_name.nil?
+        shw_name = 'default_district_shw'
+      end
+
       # create water use equipment + connection and set identifier
       os_shw_def = OpenStudio::Model::WaterUseEquipmentDefinition.new(openstudio_model)
       os_shw = OpenStudio::Model::WaterUseEquipment.new(os_shw_def)
@@ -273,9 +278,6 @@ module Honeybee
         @@max_target_temp = target_temp
         @@max_temp_schedule = target_water_sch
       end
-      if shw_name.nil?
-        shw_name = 'default_district_shw'
-      end
       if @@shw_connections[shw_name].nil?
         @@shw_connections[shw_name] = []
       end

data/lib/to_openstudio/ventcool/fan.rb

@@ -105,7 +105,7 @@ module Honeybee
           vent_sch = openstudio_model.getScheduleByName(vent_control_hash[:schedule])
           unless vent_sch.empty?
             vent_sch_object = vent_sch.get
-            os_zone_vent.setOpeningAreaFractionSchedule(vent_sch_object)
+            os_zone_vent.setSchedule(vent_sch_object)
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.38.9
+  version: 2.38.11
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-05-24 00:00:00.000000000 Z
+date: 2024-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_pure