honeybee-openstudio 2.38.8 → 2.38.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 149f0edae2e446e882a6fb962684366c187b6dcd2f703efabecf9d20fb623a29
-  data.tar.gz: 02aca6abeb6bfe134b30269cd044e1942e64e1e56ec0b010c329e9d3e7a46c55
+  metadata.gz: a2f2bfb60c9779aff40ac4d86c6d2d3416fd1c34722b5378874b6b85cceaf8cd
+  data.tar.gz: e1638526a3701c0035efdb8695fdbb026364ecc85c42a38e262de43e9beb729f
 SHA512:
-  metadata.gz: 9fc393de3df070bd30390d747b2c8e8007f7c1cf75e0e8d7ac5a9133c16748384f8d0c7758b72b9c147b6765ec01fabb122099c706e89995516842fb083c4d16
-  data.tar.gz: d2cd89048f5d5d39e65b901570e38d686a6b69c3f6c02c94a64a82131b94bd556a5b535160bd87e16ba47e77f374181db9dccf73ff8b11e3a8f6b4359ae47436
+  metadata.gz: 619bfa717c81e91aea5f481a6f86f538fb7c1cb4a508b4e8fa1695826096bde37e892de9fae98b3df71036c295b1ba2aed9f5f008a154e8ecfee2b6643e8b9e8
+  data.tar.gz: 22b5002543933e86a89192ae2fb6e0780306ca94308fd808651c93135f0f9f67145894e04f6188ac330d4345fb13ea49c8709dff26869af4eb6ea08548d77267

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.38.8'
+  spec.version       = '2.38.9'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/to_openstudio/hvac/radiant.rb

@@ -128,20 +128,12 @@ class OpenStudio::Model::Model
     end
 
     # get the various controls for the radiant system
-    if rad_props[:minimum_operation_time]
-      minimum_operation = rad_props[:minimum_operation_time]
-    else
-      minimum_operation = 1
-    end
     if rad_props[:switch_over_time]
       switch_over_time = rad_props[:switch_over_time]
     else
       switch_over_time = 24
     end
 
-    # get the start and end hour from the input zones
-    start_hour, end_hour = start_end_hour_from_zones_occupancy(zones)
-
     # add radiant system to the conditioned zones
     include_carpet = false
     control_strategy = 'proportional_control'
@@ -162,9 +154,6 @@ class OpenStudio::Model::Model
       radiant_type: radiant_type,
       control_strategy: control_strategy,
       include_carpet: include_carpet,
-      model_occ_hr_start: start_hour,
-      model_occ_hr_end: end_hour,
-      minimum_operation: minimum_operation,
       switch_over_time: switch_over_time,
       cz_mult: cz_mult)
 
@@ -175,93 +164,6 @@ class OpenStudio::Model::Model
 
   end
 
-  # get the start and end hour from the occupancy schedules of thermal zones
-  def start_end_hour_from_zones_occupancy(thermal_zones, threshold: 0.1)
-    # set the default start and end hour in the event there's no occupancy
-    start_hour = 12
-    end_hour = 12
-    # loop through the occupancy schedules and get the lowest start hour; highest end hour
-    thermal_zones.each do |zone|
-      zone.spaces.each do |space|
-        # gather all of the people objects assigned to the sapce
-        peoples = []
-        unless space.spaceType.empty?
-          space_type = space.spaceType.get
-          unless space_type.people.empty?
-            space_type.people.each do |ppl|
-              peoples << ppl
-            end
-          end
-        end
-        space.people.each do |ppl|
-          peoples << ppl
-        end
-        # loop through the pople and gather all occupancy schedules
-        peoples.each do |people|
-          occupancy_sch_opt = people.numberofPeopleSchedule
-          unless occupancy_sch_opt.empty?
-            occupancy_sch = occupancy_sch_opt.get
-            if occupancy_sch.to_ScheduleRuleset.is_initialized
-              occupancy_sch = occupancy_sch.to_ScheduleRuleset.get
-              # gather all of the day schedules across the schedule ruleset
-              schedule_days, day_ids = [], []
-              required_days = [
-                occupancy_sch.defaultDaySchedule,
-                occupancy_sch.summerDesignDaySchedule,
-                occupancy_sch.winterDesignDaySchedule,
-                occupancy_sch.holidaySchedule
-              ]
-              required_days.each do |day_sch|
-                unless day_ids.include? day_sch.nameString
-                  schedule_days << day_sch
-                  day_ids << day_sch.nameString
-                end
-              end
-              occupancy_sch.scheduleRules.each do |schedule_rule|
-                day_sch = schedule_rule.daySchedule
-                unless day_ids.include? day_sch.nameString
-                  schedule_days << day_sch
-                  day_ids << day_sch.nameString
-                end
-              end
-              # loop through the day schedules and see if the start and end hours should be changed
-              schedule_days.each do |day_sch|
-                time_until = [1]
-                day_sch.times.each do |time|
-                  time_until << time.hours
-                end
-                final_time = time_until[-2]
-                day_sch.values.zip(time_until).each do |value, time|
-                  if value > threshold
-                    if time < start_hour
-                      start_hour = time
-                    end
-                    if time > end_hour
-                      end_hour = time
-                    end
-                    if time == final_time
-                      start_hour = 1
-                      end_hour = 24
-                    end
-                  end
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-
-    # if no values were set, just set the system to be on all of the time
-    if start_hour == 12 or start_hour == 0
-      start_hour = 1
-    end
-    if end_hour == 12
-      end_hour = 24
-    end
-    return start_hour, end_hour
-  end
-
   def model_add_low_temp_radiant(std,
                                  thermal_zones,
                                  hot_water_loop,
@@ -273,9 +175,6 @@ class OpenStudio::Model::Model
                                  model_occ_hr_end: 24.0,
                                  control_strategy: 'proportional_control',
                                  proportional_gain: 0.3,
-                                 minimum_operation: 1,
-                                 weekend_temperature_reset: 2,
-                                 early_reset_out_arg: 20,
                                  switch_over_time: 24.0,
                                  cz_mult: 4)
 
@@ -598,18 +497,18 @@ class OpenStudio::Model::Model
       # rename nodes before adding EMS code
       std.rename_plant_loop_nodes(self)
 
+      # TODO: Un-comment this once these controls are fixed (Matt made a lot of changes for OpenStudio 3.8)
       # set radiant loop controls
-      if control_strategy == 'proportional_control'
-        std.model_add_radiant_proportional_controls(self, zone, radiant_loop,
-                                                    radiant_type: radiant_type,
-                                                    model_occ_hr_start: model_occ_hr_start,
-                                                    model_occ_hr_end: model_occ_hr_end,
-                                                    proportional_gain: proportional_gain,
-                                                    minimum_operation: minimum_operation,
-                                                    weekend_temperature_reset: weekend_temperature_reset,
-                                                    early_reset_out_arg: early_reset_out_arg,
-                                                    switch_over_time: switch_over_time)
-      end
+      #if control_strategy == 'proportional_control'
+      #  std.model_add_radiant_proportional_controls(self, zone, radiant_loop,
+      #                                              radiant_temperature_control_type: 'SurfaceFaceTemperature',
+      #                                              use_zone_occupancy_for_control: true,
+      #                                              occupied_percentage_threshold: 0.10,
+      #                                              model_occ_hr_start: model_occ_hr_start,
+      #                                              model_occ_hr_end: model_occ_hr_end,
+      #                                              proportional_gain: proportional_gain,
+      #                                              switch_over_time: switch_over_time)
+      #end
     end
 
     return radiant_loops

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.38.8
+  version: 2.38.9
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-04-10 00:00:00.000000000 Z
+date: 2024-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_pure