honeybee-openstudio 2.38.6 → 2.38.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b77ef2ddbd689cf19abe8c48c85b61eb1fb3b010b4fc68813dc9331a5c906c8d
-  data.tar.gz: f7d2cefe7765c6a59a580cec468c2f3271e1708b706414dab9d0d03153ef2769
+  metadata.gz: 149f0edae2e446e882a6fb962684366c187b6dcd2f703efabecf9d20fb623a29
+  data.tar.gz: 02aca6abeb6bfe134b30269cd044e1942e64e1e56ec0b010c329e9d3e7a46c55
 SHA512:
-  metadata.gz: 94ece34b71cca0e294656b6e68f7099e500bc79c6a8c3d0a880990d2301a119fd6b9c18757d15122e7aa78998fe96913c330c21e677bfe388e2aa9cae35e06c5
-  data.tar.gz: 9334ccee3a16ebf15fc3163c416916db9a50039c416c568fe2710dd9de7045e9e691f5445cabcdc4f42fceeda3c9b85939ec69509c501d6c0c27c13371c9a071
+  metadata.gz: 9fc393de3df070bd30390d747b2c8e8007f7c1cf75e0e8d7ac5a9133c16748384f8d0c7758b72b9c147b6765ec01fabb122099c706e89995516842fb083c4d16
+  data.tar.gz: d2cd89048f5d5d39e65b901570e38d686a6b69c3f6c02c94a64a82131b94bd556a5b535160bd87e16ba47e77f374181db9dccf73ff8b11e3a8f6b4359ae47436

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.38.6'
+  spec.version       = '2.38.8'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/honeybee/model_object.rb

@@ -112,8 +112,9 @@ module Honeybee
 
     # remove illegal characters in identifier
     def self.clean_name(str)
-      ascii = str.encode(Encoding.find('ASCII'), **@@encoding_options)
-      ascii = truncate(ascii, 97)
+      encode_str = str.encode(Encoding.find('ASCII'), **@@encoding_options)
+      encode_str = truncate(encode_str, 97)
+      encode_str.gsub(/[,;!]/, '_')
     end
 
     # remove illegal characters in identifier

data/lib/to_openstudio/geometry/aperture.rb

@@ -170,7 +170,7 @@ module Honeybee
       return result
     end
 
-    def to_openstudio_shade(openstudio_model, shading_surface_group)
+    def to_openstudio_shade(openstudio_model)
       # get the vertices from the aperture
       if @hash[:geometry][:vertices].nil?
         hb_verts = @hash[:geometry][:boundary]
@@ -217,9 +217,6 @@ module Honeybee
         end
       end
 
-      # add the shade to the group
-      os_shading_surface.setShadingSurfaceGroup(shading_surface_group)
-
       os_shading_surface
     end
   

data/lib/to_openstudio/geometry/door.rb

@@ -163,7 +163,7 @@ module Honeybee
       return result
     end
 
-    def to_openstudio_shade(openstudio_model, shading_surface_group)
+    def to_openstudio_shade(openstudio_model)
       # get the vertices from the door
       if @hash[:geometry][:vertices].nil?
         hb_verts = @hash[:geometry][:boundary]
@@ -212,9 +212,6 @@ module Honeybee
         end
       end
 
-      # add the shade to the group
-      os_shading_surface.setShadingSurfaceGroup(shading_surface_group)
-
       os_shading_surface
     end
 

data/lib/to_openstudio/geometry/face.rb

@@ -248,25 +248,6 @@ module Honeybee
         end
       end
 
-      # add the shade to the group
-      os_shading_surface.setShadingSurfaceGroup(shading_surface_group)
-
-      # convert the apertures to shade objects
-      if @hash[:apertures]
-        @hash[:apertures].each do |aperture|
-          hb_aperture = Aperture.new(aperture)
-          os_subsurface_aperture = hb_aperture.to_openstudio_shade(openstudio_model, shading_surface_group)
-        end
-      end
-
-      # convert the apertures to shade objects
-      if @hash[:doors]
-        @hash[:doors].each do |door|
-          hb_door = Door.new(door)
-          os_subsurface_door = hb_door.to_openstudio_shade(openstudio_model, shading_surface_group)
-        end
-      end
-
       os_shading_surface
     end
 

data/lib/to_openstudio/model.rb

@@ -649,7 +649,7 @@ module Honeybee
         end
         @hash[:orphaned_faces].each do |face|
           face_object = Face.new(face)
-          openstudio_shade = face_object.to_openstudio_shade(@openstudio_model, shading_surface_group)
+          openstudio_shade = face_object.to_openstudio_shade(@openstudio_model)
           if $orphan_groups
             openstudio_shade.setShadingSurfaceGroup(shading_surface_group)
           end
@@ -663,9 +663,9 @@ module Honeybee
           shading_surface_group = OpenStudio::Model::ShadingSurfaceGroup.new(@openstudio_model)
           shading_surface_group.setShadingSurfaceType('Building')
         end
-          @hash[:orphaned_apertures].each do |ap|
+        @hash[:orphaned_apertures].each do |ap|
           ap_object = Aperture.new(ap)
-          openstudio_shade = ap_object.to_openstudio_shade(@openstudio_model, shading_surface_group)
+          openstudio_shade = ap_object.to_openstudio_shade(@openstudio_model)
           if $orphan_groups
             openstudio_shade.setShadingSurfaceGroup(shading_surface_group)
           end
@@ -679,9 +679,9 @@ module Honeybee
           shading_surface_group = OpenStudio::Model::ShadingSurfaceGroup.new(@openstudio_model)
           shading_surface_group.setShadingSurfaceType('Building')
         end
-          @hash[:orphaned_doors].each do |dr|
+        @hash[:orphaned_doors].each do |dr|
           dr_object = Door.new(dr)
-          openstudio_shade = dr_object.to_openstudio_shade(@openstudio_model, shading_surface_group)
+          openstudio_shade = dr_object.to_openstudio_shade(@openstudio_model)
           if $orphan_groups
             openstudio_shade.setShadingSurfaceGroup(shading_surface_group)
           end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.38.6
+  version: 2.38.8
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-03-12 00:00:00.000000000 Z
+date: 2024-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_pure