honeybee-openstudio 2.38.5 → 2.38.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6d0c0fa833bdb3f833eecade1c1d74936685962d69b3efb6cf41517b86fb4b8
-  data.tar.gz: 1a77bbfc0da58fdc289398f69583e9a53ea1930d410e93c47b5ce4c31cc9c0d8
+  metadata.gz: 00dbd4e1a8ff317244a829844ed85f824e52cd22dfbb671310d4a9ede84a8103
+  data.tar.gz: b1f445898204f6af213451b219f9c2dc0fc00df1770b01ddce712ea85cdb7cf9
 SHA512:
-  metadata.gz: 2c49d214e7185f1379bbedf900566ef24d046fd95fc22d52ffcea5455c487124f6c8779b056d7d7da1775760691e9c1cbf6b338018307ba1003b93f29f9ef687
-  data.tar.gz: f1d93d95d81bf0db97bd540b653686235ecf710a077756bb790ea531eb3ba7c1ce906611ede9d6584574ed0ccc7eb3250dd1515ee615cfee9424fc11a7a8ba45
+  metadata.gz: ac40630d69c86a9d7e2a874ef341253e8ade7cdaf5227b9e377f5a3a7febb138506789aa1e9e4d0f0d5aa1158c5df99d798b6bf7f87c2a3ab3976b19fc26cacd
+  data.tar.gz: edd6e41aa96ee53efec65c7cfd24a10fa18a230f0426950168fba654ece99b1fb6411684bb26e71a847410c9d18b13f7634ba0dd096a1f41296ba0f6c54fec4a

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.38.5'
+  spec.version       = '2.38.7'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/from_openstudio/simulation/design_day.rb

@@ -60,7 +60,7 @@ module Honeybee
     end
 
     def self.humidity_type_from_design_day(design_day)
-      humidity_type = design_day.humidityIndicatingType
+      humidity_type = design_day.humidityConditionType
       allowed_types = ['WetBulb', 'Dewpoint', 'HumidityRatio', 'Enthalpy']
       if !allowed_types.any?{ |s| s.casecmp(humidity_type)==0 }
         raise "'#{humidity_type}' is not an allowed humidity type"
@@ -72,7 +72,13 @@ module Honeybee
       hash = {}
       hash[:type] = 'HumidityCondition'
       hash[:humidity_type] = humidity_type_from_design_day(design_day)
-      hash[:humidity_value] = design_day.humidityIndicatingConditionsAtMaximumDryBulb
+      if hash[:humidity_type] == 'HumidityRatio'
+        hash[:humidity_value] = design_day.humidityRatioAtMaximumDryBulb
+      elsif hash[:humidity_type] == 'Enthalpy'
+        hash[:humidity_value] = design_day.enthalpyAtMaximumDryBulb
+      else
+        hash[:humidity_value] = design_day.wetBulbOrDewPointAtMaximumDryBulb
+      end
       hash[:barometric_pressure] = design_day.barometricPressure
       hash[:rain] = design_day.rainIndicator
       hash[:snow_on_ground] = design_day.snowIndicator

data/lib/honeybee/model_object.rb

@@ -112,8 +112,9 @@ module Honeybee
 
     # remove illegal characters in identifier
     def self.clean_name(str)
-      ascii = str.encode(Encoding.find('ASCII'), **@@encoding_options)
-      ascii = truncate(ascii, 97)
+      encode_str = str.encode(Encoding.find('ASCII'), **@@encoding_options)
+      encode_str = truncate(encode_str, 97)
+      encode_str.gsub(/[,;!]/, '_')
     end
 
     # remove illegal characters in identifier

data/lib/to_openstudio/simulation/design_day.rb

@@ -53,8 +53,15 @@ module Honeybee
       os_des_day.setDailyDryBulbTemperatureRange(@hash[:dry_bulb_condition][:dry_bulb_range])
 
       # set the HumidityCondition properties
-      os_des_day.setHumidityIndicatingType(@hash[:humidity_condition][:humidity_type])
-      os_des_day.setHumidityIndicatingConditionsAtMaximumDryBulb(@hash[:humidity_condition][:humidity_value])
+      humid_type = @hash[:humidity_condition][:humidity_type]
+      os_des_day.setHumidityConditionType(@hash[:humidity_condition][:humidity_type])
+      if humid_type == 'HumidityRatio'
+        os_des_day.setHumidityRatioAtMaximumDryBulb(@hash[:humidity_condition][:humidity_value])
+      elsif humid_type == 'Enthalpy'
+        os_des_day.setEnthalpyAtMaximumDryBulb(@hash[:humidity_condition][:humidity_value])
+      else
+        os_des_day.setWetBulbOrDewPointAtMaximumDryBulb(@hash[:humidity_condition][:humidity_value])
+      end
       if @hash[:humidity_condition][:barometric_pressure]
         os_des_day.setBarometricPressure(@hash[:humidity_condition][:barometric_pressure])
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.38.5
+  version: 2.38.7
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-03-09 00:00:00.000000000 Z
+date: 2024-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_pure