honeybee-openstudio 2.35.0 → 2.35.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8253cfd61ddf3f1e838d50f9c72d650e4373b3b19347f9975f2efe48c1ed81b9
-  data.tar.gz: 9d862528a0f8dd57a82964aa50e897096e03dbbc7d3d0ccadcde6bc7e3d4a7c8
+  metadata.gz: eadf72cc6184d0f30705481227c69a6bb35a17485856a641a841c797f720bd46
+  data.tar.gz: cbff4e6067b9be01c1df2b545c4a181f863f9a51a5c5cc4f2c6bd5a301558e19
 SHA512:
-  metadata.gz: ee63cd76ff125f23eada0492a8fe65ddfa6e07a550fdb8683b9595ff3024f48a9526a891be463d0ae4ad1fd96f3385ff00b748deda58041340783f469553a186
-  data.tar.gz: ac10d61f84602af26558f4a2091cee8200ba1c2be0330cf0ac114035439dc8b6729eee52c9457afed7af2de1102eff23571dfbf3b82558dc214f567e313e2e57
+  metadata.gz: 4e91999590b5b8b2f15bca7cc073beafd4d310507064b2eea7e883069fcfb761301d3cf22147ef9cdb1fe11cb6db967d06417d1c82534d7b821ef69cc3dc8300
+  data.tar.gz: 6c3aaad16d195b28a4434365d2d94dacd6e639f4baba7ff016b53c16bb0d31105157b59c9417ee5c0d2f9b25f5a735fad265751e771a82e131e9a089482323f4

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.35.0'
+  spec.version       = '2.35.2'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/from_openstudio/model.rb

@@ -112,8 +112,8 @@ module Honeybee
     end
 
     # Create Honeybee Model JSON from SDD file
-    def translate_from_sdd_file(file)
-      translator = OpenStudio::SDD::ReverseTranslator.new
+    def self.translate_from_sdd_file(file)
+      translator = OpenStudio::SDD::SddReverseTranslator.new
       openstudio_model = translator.loadModel(file)
       raise "Cannot load SDD file at '#{}'" if openstudio_model.empty?
       self.translate_from_openstudio(openstudio_model.get)

data/lib/measures/from_honeybee_model/measure.rb

@@ -37,6 +37,7 @@ require 'to_openstudio'
 require 'fileutils'
 require 'pathname'
 require 'json'
+require 'open3'
 
 # start the measure
 class FromHoneybeeModel < OpenStudio::Measure::ModelMeasure
@@ -133,7 +134,12 @@ class FromHoneybeeModel < OpenStudio::Measure::ModelMeasure
         model.save(osm_path, true)
         # call the Ironbug console to add the HVAC to the OSM
         ironbug_exe = '"' + $ironbug_exe + '"'
-        system(ironbug_exe + ' "' + osm_path + '" "' + hvac_json_path + '"')
+        ib_cmd = ironbug_exe + ' "' + osm_path + '" "' + hvac_json_path + '"'
+        stdout, stderr, status = Open3.capture3(ib_cmd)
+        if status.exitstatus != 0
+          runner.registerError('Failed to apply IronBug HVAC:' + stderr)
+          return false
+        end
         # load the new model
         translator = OpenStudio::OSVersion::VersionTranslator.new
         o_model = translator.loadModel(osm_path)

data/lib/to_openstudio/geometry/door.rb

@@ -162,61 +162,61 @@ module Honeybee
 
       return result
     end
-  end # Door
 
-  def to_openstudio_shade(openstudio_model, shading_surface_group)
-    # get the vertices from the door
-    if @hash[:geometry][:vertices].nil?
-      hb_verts = @hash[:geometry][:boundary]
-    else
-      hb_verts = @hash[:geometry][:vertices]
-    end
+    def to_openstudio_shade(openstudio_model, shading_surface_group)
+      # get the vertices from the door
+      if @hash[:geometry][:vertices].nil?
+        hb_verts = @hash[:geometry][:boundary]
+      else
+        hb_verts = @hash[:geometry][:vertices]
+      end
 
-    # create the openstudio shading surface
-    os_vertices = OpenStudio::Point3dVector.new
-    hb_verts.each do |vertex|
-      os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
-    end
+      # create the openstudio shading surface
+      os_vertices = OpenStudio::Point3dVector.new
+      hb_verts.each do |vertex|
+        os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
+      end
 
-    os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
-    os_shading_surface.setName(@hash[:identifier])
-    unless @hash[:display_name].nil?
-      os_shading_surface.setDisplayName(@hash[:display_name])
-    end
+      os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
+      os_shading_surface.setName(@hash[:identifier])
+      unless @hash[:display_name].nil?
+        os_shading_surface.setDisplayName(@hash[:display_name])
+      end
 
-    # get the approriate construction id
-    construction_id = nil
-    if @hash[:properties].key?(:energy) && @hash[:properties][:energy][:construction]
-      construction_id = @hash[:properties][:energy][:construction]
-    elsif @hash[:is_glass] == true
-      construction_id = 'Generic Double Pane'
-    else
-      construction_id = 'Generic Exterior Door'
-    end
+      # get the approriate construction id
+      construction_id = nil
+      if @hash[:properties].key?(:energy) && @hash[:properties][:energy][:construction]
+        construction_id = @hash[:properties][:energy][:construction]
+      elsif @hash[:is_glass] == true
+        construction_id = 'Generic Double Pane'
+      else
+        construction_id = 'Generic Exterior Door'
+      end
 
-    # assign the construction
-    unless construction_id.nil?
-      construction = openstudio_model.getConstructionByName(construction_id)
-      unless construction.empty?
-        os_construction = construction.get
-        os_shading_surface.setConstruction(os_construction)
+      # assign the construction
+      unless construction_id.nil?
+        construction = openstudio_model.getConstructionByName(construction_id)
+        unless construction.empty?
+          os_construction = construction.get
+          os_shading_surface.setConstruction(os_construction)
+        end
       end
-    end
 
-    # add a transmittance schedule if a value is found
-    if @hash[:transmit]
-      schedule_identifier = 'Constant ' + @hash[:transmit] + ' Transmittance'
-      schedule = openstudio_model.getScheduleByName(schedule_identifier)
-      unless schedule.empty?
-        os_schedule = schedule.get
-        os_shading_surface.setTransmittanceSchedule(os_schedule)
+      # add a transmittance schedule if a value is found
+      if @hash[:transmit]
+        schedule_identifier = 'Constant ' + @hash[:transmit] + ' Transmittance'
+        schedule = openstudio_model.getScheduleByName(schedule_identifier)
+        unless schedule.empty?
+          os_schedule = schedule.get
+          os_shading_surface.setTransmittanceSchedule(os_schedule)
+        end
       end
-    end
 
-    # add the shade to the group
-    os_shading_surface.setShadingSurfaceGroup(shading_surface_group)
+      # add the shade to the group
+      os_shading_surface.setShadingSurfaceGroup(shading_surface_group)
 
-    os_shading_surface
-  end
+      os_shading_surface
+    end
 
+  end # Door
 end # Honeybee

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.35.0
+  version: 2.35.2
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-08-09 00:00:00.000000000 Z
+date: 2023-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_pure