honeybee-openstudio 2.34.2 → 2.34.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6947078e38b09ec6c7ee9a64b5d530a3fd7eb3b86137c02471e60d9d7422c08a
-  data.tar.gz: 2b9c9771fc008175bef01a951ec104e4df61173ad305da5606e0703e933a43e6
+  metadata.gz: 21b7c8dc0db0e3178e812bb64d257b2ba15de99b0cf8e3beab63a222cef1ed48
+  data.tar.gz: febcc1e11448e74bd06c0647e5fb1ece0466fe789c8ffe7d72a25a61b7172ffc
 SHA512:
-  metadata.gz: 45fb3ea19af186fbb5a1dda5946714e80c9c8347839d33b00376f86658e5f9d7329d8a3c2bb96c8c68d5fcd2b6ff2699c47cc9259c102a8103da9fda824b9ccd
-  data.tar.gz: 52cbe21e52ceb223c5cb333e1332b5a18db6e2a00859485946813bd65c27bb18483219a0bf4e09f9f977d9a3ed212d287ac49ff724401a7fec151dbcc76ba80e
+  metadata.gz: 47ff85499f08b127dd2d09b37c4782e63e07101e28239c423959c886e27554c165c35b5917c0875edd5a0fc3a409e9027c1e268cd60f9e17d49f9b0b9210eb3b
+  data.tar.gz: f77b8acde4bd316832a8c8a5c085a7c7fdcfb38c773b941e6253b4c3423a8d737f57dfe6d5d7c6bc12d0eee97b26fe3118f04a35375cd32b08064097a251f9b4

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.34.2'
+  spec.version       = '2.34.4'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/files/urbanopt_Gemfile

@@ -4,6 +4,9 @@ ruby '~> 2.7.0'
 
 allow_local = ENV['FAVOR_LOCAL_GEMS']
 
+# pin this dependency to avoid unicode_normalize error
+gem 'addressable', '2.8.1'
+
 if allow_local && File.exist?('../openstudio-common-measures-gem')
   gem 'openstudio-common-measures', path: '../openstudio-common-measures-gem'
 elsif allow_local

data/lib/to_openstudio/hvac/radiant.rb

@@ -490,36 +490,15 @@ class OpenStudio::Model::Model
         OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', "Thermal zone '#{zone.name}' has a restricted character ':' in the name and will not work with some EMS and output reporting objects. Please rename the zone.")
       end
 
-      # create radiant coils
-      if hot_water_loop
-        radiant_loop_htg_coil = OpenStudio::Model::CoilHeatingLowTempRadiantVarFlow.new(self, htg_control_temp_sch)
-        radiant_loop_htg_coil.setName("#{zone.name} Radiant Loop Heating Coil")
-        radiant_loop_htg_coil.setHeatingControlThrottlingRange(throttling_range_c)
-        hot_water_loop.addDemandBranchForComponent(radiant_loop_htg_coil)
-      else
-        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a hot water loop, but none was provided.')
-      end
-
-      if chilled_water_loop
-        radiant_loop_clg_coil = OpenStudio::Model::CoilCoolingLowTempRadiantVarFlow.new(self, clg_control_temp_sch)
-        radiant_loop_clg_coil.setName("#{zone.name} Radiant Loop Cooling Coil")
-        radiant_loop_clg_coil.setCoolingControlThrottlingRange(throttling_range_c)
-        chilled_water_loop.addDemandBranchForComponent(radiant_loop_clg_coil)
-      else
-        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a chilled water loop, but none was provided.')
-      end
-
-      radiant_avail_sch = self.alwaysOnDiscreteSchedule
-      radiant_loop = OpenStudio::Model::ZoneHVACLowTempRadiantVarFlow.new(self,
-                                                                          radiant_avail_sch,
-                                                                          radiant_loop_htg_coil,
-                                                                          radiant_loop_clg_coil)
-
       # assign internal source construction to floors in zone
+      srf_count = 0
       zone.spaces.each do |space|
         space.surfaces.each do |surface|
-          if radiant_type == 'floor'
+          if surface.isAirWall
+            OpenStudio.logFree(OpenStudio::Info, 'openstudio.Model.Model', "Surface #{surface.name} cannot be set to a Radiant Construction as it is an AirBoundary.")
+          elsif radiant_type == 'floor'
             if surface.surfaceType == 'Floor'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Ground'
                 surface.setConstruction(radiant_ground_slab_construction)
               elsif surface.outsideBoundaryCondition == 'Outdoors'
@@ -530,6 +509,7 @@ class OpenStudio::Model::Model
             end
           elsif radiant_type == 'ceiling'
             if surface.surfaceType == 'RoofCeiling'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Outdoors'
                 surface.setConstruction(radiant_ceiling_slab_construction)
               else # interior ceiling
@@ -538,6 +518,7 @@ class OpenStudio::Model::Model
             end
           elsif radiant_type == 'ceilingmetalpanel'
             if surface.surfaceType == 'RoofCeiling'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Outdoors'
                 surface.setConstruction(radiant_ceiling_metal_construction)
               else # interior ceiling
@@ -546,6 +527,7 @@ class OpenStudio::Model::Model
             end
           elsif radiant_type == 'floorwithhardwood'
             if surface.surfaceType == 'Floor'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Ground'
                 surface.setConstruction(radiant_ground_wood_construction)
               elsif surface.outsideBoundaryCondition == 'Outdoors'
@@ -558,6 +540,36 @@ class OpenStudio::Model::Model
         end
       end
 
+      # ignore the Zone if it has not thermally active Faces
+      if srf_count == 0
+        next
+      end
+
+      # create radiant coils
+      if hot_water_loop
+        radiant_loop_htg_coil = OpenStudio::Model::CoilHeatingLowTempRadiantVarFlow.new(self, htg_control_temp_sch)
+        radiant_loop_htg_coil.setName("#{zone.name} Radiant Loop Heating Coil")
+        radiant_loop_htg_coil.setHeatingControlThrottlingRange(throttling_range_c)
+        hot_water_loop.addDemandBranchForComponent(radiant_loop_htg_coil)
+      else
+        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a hot water loop, but none was provided.')
+      end
+
+      if chilled_water_loop
+        radiant_loop_clg_coil = OpenStudio::Model::CoilCoolingLowTempRadiantVarFlow.new(self, clg_control_temp_sch)
+        radiant_loop_clg_coil.setName("#{zone.name} Radiant Loop Cooling Coil")
+        radiant_loop_clg_coil.setCoolingControlThrottlingRange(throttling_range_c)
+        chilled_water_loop.addDemandBranchForComponent(radiant_loop_clg_coil)
+      else
+        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a chilled water loop, but none was provided.')
+      end
+
+      radiant_avail_sch = self.alwaysOnDiscreteSchedule
+      radiant_loop = OpenStudio::Model::ZoneHVACLowTempRadiantVarFlow.new(self,
+                                                                          radiant_avail_sch,
+                                                                          radiant_loop_htg_coil,
+                                                                          radiant_loop_clg_coil)
+
       # radiant loop surfaces
       radiant_loop.setName("#{zone.name} Radiant Loop")
       if radiant_type == 'floor'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.34.2
+  version: 2.34.4
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-04-10 00:00:00.000000000 Z
+date: 2023-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_pure