honeybee-openstudio 2.34.1 → 2.34.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4dfa78bd619d4e0ee96bedcae85ed99bce737a61516a8abf6d3be8ad1fa2b7b
-  data.tar.gz: 0eae35ad7865b835097a4454215d965ee76499c9174162bb3865e7ce9d768c15
+  metadata.gz: d4c9a3f73cadaedf8f1e13e0b20b1392952936a24c1b89d4ffd7532275fcb603
+  data.tar.gz: db9b5fbbecb023ff4465d5d88ab3fda0ab36dd1e6d5835bdb3f072a7ef9d7f64
 SHA512:
-  metadata.gz: 6aed2c7158f039c171832d76e3d791bca8fffb5a0d2710d534afe4cc20959e993b8de3ce8747b0fefd30933eadb64b896d554c3d64cb135ac88d9f890e3e435d
-  data.tar.gz: 4b0ea7396722cd43895fc8a79cdae978135f747fc5e34b533b1409be7a8fcef48579352df59c571b26df8e0cf535c13fb770c4055ed3daf20b861e324dc44ea8
+  metadata.gz: 135307618dc282c797521be37b65b7494eead11ed66e11409fe0459afbeb7e9cc1a6d07bfb6b11ae73410eb3fc9639c7d386905fff0a8adf0ec775d46a18f874
+  data.tar.gz: 2e54d8e090017dd82d63388ed8a44f03c5439631f23bb56d9af68c13ad2ede5f4b8c6dfd1c2d9ab44c7329fff8708bb6593fb399d8768a690bcb00d3af3c0115

data/.github/workflows/ci.yaml

@@ -6,7 +6,7 @@ jobs:
 
   test:
     name: Unit tests
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
 
     steps:
     - name: Check out repository

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.34.1'
+  spec.version       = '2.34.3'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/to_openstudio/hvac/radiant.rb

@@ -490,36 +490,15 @@ class OpenStudio::Model::Model
         OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', "Thermal zone '#{zone.name}' has a restricted character ':' in the name and will not work with some EMS and output reporting objects. Please rename the zone.")
       end
 
-      # create radiant coils
-      if hot_water_loop
-        radiant_loop_htg_coil = OpenStudio::Model::CoilHeatingLowTempRadiantVarFlow.new(self, htg_control_temp_sch)
-        radiant_loop_htg_coil.setName("#{zone.name} Radiant Loop Heating Coil")
-        radiant_loop_htg_coil.setHeatingControlThrottlingRange(throttling_range_c)
-        hot_water_loop.addDemandBranchForComponent(radiant_loop_htg_coil)
-      else
-        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a hot water loop, but none was provided.')
-      end
-
-      if chilled_water_loop
-        radiant_loop_clg_coil = OpenStudio::Model::CoilCoolingLowTempRadiantVarFlow.new(self, clg_control_temp_sch)
-        radiant_loop_clg_coil.setName("#{zone.name} Radiant Loop Cooling Coil")
-        radiant_loop_clg_coil.setCoolingControlThrottlingRange(throttling_range_c)
-        chilled_water_loop.addDemandBranchForComponent(radiant_loop_clg_coil)
-      else
-        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a chilled water loop, but none was provided.')
-      end
-
-      radiant_avail_sch = self.alwaysOnDiscreteSchedule
-      radiant_loop = OpenStudio::Model::ZoneHVACLowTempRadiantVarFlow.new(self,
-                                                                          radiant_avail_sch,
-                                                                          radiant_loop_htg_coil,
-                                                                          radiant_loop_clg_coil)
-
       # assign internal source construction to floors in zone
+      srf_count = 0
       zone.spaces.each do |space|
         space.surfaces.each do |surface|
-          if radiant_type == 'floor'
+          if surface.isAirWall
+            OpenStudio.logFree(OpenStudio::Info, 'openstudio.Model.Model', "Surface #{surface.name} cannot be set to a Radiant Construction as it is an AirBoundary.")
+          elsif radiant_type == 'floor'
             if surface.surfaceType == 'Floor'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Ground'
                 surface.setConstruction(radiant_ground_slab_construction)
               elsif surface.outsideBoundaryCondition == 'Outdoors'
@@ -530,6 +509,7 @@ class OpenStudio::Model::Model
             end
           elsif radiant_type == 'ceiling'
             if surface.surfaceType == 'RoofCeiling'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Outdoors'
                 surface.setConstruction(radiant_ceiling_slab_construction)
               else # interior ceiling
@@ -538,6 +518,7 @@ class OpenStudio::Model::Model
             end
           elsif radiant_type == 'ceilingmetalpanel'
             if surface.surfaceType == 'RoofCeiling'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Outdoors'
                 surface.setConstruction(radiant_ceiling_metal_construction)
               else # interior ceiling
@@ -546,6 +527,7 @@ class OpenStudio::Model::Model
             end
           elsif radiant_type == 'floorwithhardwood'
             if surface.surfaceType == 'Floor'
+              srf_count += 1
               if surface.outsideBoundaryCondition == 'Ground'
                 surface.setConstruction(radiant_ground_wood_construction)
               elsif surface.outsideBoundaryCondition == 'Outdoors'
@@ -558,6 +540,36 @@ class OpenStudio::Model::Model
         end
       end
 
+      # ignore the Zone if it has not thermally active Faces
+      if srf_count == 0
+        next
+      end
+
+      # create radiant coils
+      if hot_water_loop
+        radiant_loop_htg_coil = OpenStudio::Model::CoilHeatingLowTempRadiantVarFlow.new(self, htg_control_temp_sch)
+        radiant_loop_htg_coil.setName("#{zone.name} Radiant Loop Heating Coil")
+        radiant_loop_htg_coil.setHeatingControlThrottlingRange(throttling_range_c)
+        hot_water_loop.addDemandBranchForComponent(radiant_loop_htg_coil)
+      else
+        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a hot water loop, but none was provided.')
+      end
+
+      if chilled_water_loop
+        radiant_loop_clg_coil = OpenStudio::Model::CoilCoolingLowTempRadiantVarFlow.new(self, clg_control_temp_sch)
+        radiant_loop_clg_coil.setName("#{zone.name} Radiant Loop Cooling Coil")
+        radiant_loop_clg_coil.setCoolingControlThrottlingRange(throttling_range_c)
+        chilled_water_loop.addDemandBranchForComponent(radiant_loop_clg_coil)
+      else
+        OpenStudio.logFree(OpenStudio::Error, 'openstudio.Model.Model', 'Radiant loops require a chilled water loop, but none was provided.')
+      end
+
+      radiant_avail_sch = self.alwaysOnDiscreteSchedule
+      radiant_loop = OpenStudio::Model::ZoneHVACLowTempRadiantVarFlow.new(self,
+                                                                          radiant_avail_sch,
+                                                                          radiant_loop_htg_coil,
+                                                                          radiant_loop_clg_coil)
+
       # radiant loop surfaces
       radiant_loop.setName("#{zone.name} Radiant Loop")
       if radiant_type == 'floor'

data/lib/to_openstudio/simulation/parameter_model.rb

@@ -238,15 +238,15 @@ module Honeybee
 
       # note any efficency standards that have been assigned to the 
       if @hash[:sizing_parameter]
-        if @hash[:sizing_parameter][:efficiency_standard]
+        if @hash[:sizing_parameter][:efficiency_standard] && @hash[:sizing_parameter][:efficiency_standard] != 0
           std_gem_standard = @@standard_mapper[@hash[:sizing_parameter][:efficiency_standard].to_sym]
           building = @openstudio_model.getBuilding
           building.setStandardsTemplate(std_gem_standard)
         end
-        if @hash[:sizing_parameter][:climate_zone]
+        if @hash[:sizing_parameter][:climate_zone] && @hash[:sizing_parameter][:climate_zone] != 0
           climate_zone_objs.setClimateZone('ASHRAE', @hash[:sizing_parameter][:climate_zone])
         end
-        if @hash[:sizing_parameter][:building_type]
+        if @hash[:sizing_parameter][:building_type] && @hash[:sizing_parameter][:building_type] != 0
           building = @openstudio_model.getBuilding
           building.setStandardsBuildingType(@hash[:sizing_parameter][:building_type])
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.34.1
+  version: 2.34.3
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-02-27 00:00:00.000000000 Z
+date: 2023-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_pure