honeybee-openstudio 2.33.2 → 2.33.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f0ab9bc81366ae4f3cecd686b7b84f27116f85d279f19b70debffcbfea19be4
-  data.tar.gz: e3a6188aba6202306fee8a740469a1c0c2420bce2404f899df8371a8c7c2469f
+  metadata.gz: 450b27915cd3a6c85132220d29aa7a3289f7adcfd22d1917bb7ef77ca2813484
+  data.tar.gz: 6c78e0191422c5931c9ae976c2151c9f8f7c15b2b67f761ddc6fca30822b03c6
 SHA512:
-  metadata.gz: ee8d75b9ac45f6de8187d1945988f880050faf2c762d643a36adf2e513a50931451e52e05b604ff19a476d9bfb43a3b50872d4cd2037f05471307bf617385fb3
-  data.tar.gz: 54a8536d0fd02be9f1829776adc0b8eefc45dfaef920fed8cfc46feabac79777218a257fbdba3a88d195d77f137ec6fc6c22be5d2bef8ad197b3ca9e8ec67c15
+  metadata.gz: 27a76b0edd1eb349023133b5d9a59c3ab36ea223ac959c2e93bc7d34c1ebb32010a4bf6aa040787530e2606b2875697e93ddd86e23e6368c509864f3a14686a2
+  data.tar.gz: ad155d83f8ffa75cd56a56c49b386b0f61efbeaeca1f0a445e9a8280547fac0a4dd873df556b968a6ab7fa62172ebe78d721e6f5d0f0fe334d3be878a07ed1f5

data/.github/workflows/ci.yaml

@@ -15,8 +15,8 @@ jobs:
       run: |
         echo $(pwd)
         echo $(ls)
-        docker pull nrel/openstudio:3.4.0
-        docker run --name test --rm -d -t -v $(pwd):/work -w /work nrel/openstudio:3.4.0
+        docker pull nrel/openstudio:3.5.0
+        docker run --name test --rm -d -t -v $(pwd):/work -w /work nrel/openstudio:3.5.0
         docker exec -t test pwd
         docker exec -t test ls
         docker exec -t test bundle update

data/Gemfile

@@ -7,7 +7,7 @@ gemspec
 if File.exist?('../OpenStudio-extension-gem')  # local development copy
   gem 'openstudio-extension', path: '../OpenStudio-extension-gem'
 else  # get it from rubygems.org
-  gem 'openstudio-extension', '0.5.1'
+  gem 'openstudio-extension', '0.6.0'
 end
 
 # coveralls gem is used to generate coverage reports through CI

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.33.2'
+  spec.version       = '2.33.4'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 
@@ -33,6 +33,6 @@ Gem::Specification.new do |spec|
   end
 
   spec.add_dependency 'json_pure'
-  spec.add_dependency 'openstudio-extension', '0.5.1'
-  spec.add_dependency 'openstudio-standards', '~> 0.2.15'
+  spec.add_dependency 'openstudio-extension', '0.6.0'
+  spec.add_dependency 'openstudio-standards', '~> 0.3.0'
 end

data/lib/honeybee/extension.rb

@@ -109,21 +109,5 @@ module Honeybee
       @@standards
     end
 
-    # check if the model schema is valid
-    def schema_valid?
-      if Gem.loaded_specs.has_key?("json-schema")
-        require 'json-schema'
-        metaschema = JSON::Validator.validator_for_name('draft6').metaschema
-        JSON::Validator.validate(metaschema, @@schema)
-      end
-    end
-
-    # return detailed schema validation errors
-    def schema_validation_errors
-      if Gem.loaded_specs.has_key?("json-schema")
-        metaschema = JSON::Validator.validator_for_name('draft6').metaschema
-        JSON::Validator.fully_validate(metaschema, @@schema)
-      end
-    end
   end
 end

data/lib/honeybee/model.rb

@@ -66,23 +66,6 @@ module Honeybee
       end
     end
 
-    # check if the model is valid
-    def valid?
-      if Gem.loaded_specs.has_key?("json-schema")
-        return validation_errors.empty?
-      else
-        return true
-      end
-    end
-
-    # return detailed model validation errors
-    def validation_errors
-      if Gem.loaded_specs.has_key?("json-schema")
-        require 'json-schema'
-        JSON::Validator.fully_validate(@@schema, @hash, :fragment => "#/components/schemas/Model")
-      end
-    end
-
     def defaults
       @@schema[:components][:schemas][:ModelEnergyProperties][:properties]
     end

data/lib/honeybee/model_object.rb

@@ -106,21 +106,6 @@ module Honeybee
       raise 'defaults not implemented for ModelObject, override in your class'
     end
 
-    # check if the ModelObject is valid
-    def valid?
-      return validation_errors.empty?
-    end
-
-    # return detailed model validation errors
-    def validation_errors
-      if Gem.loaded_specs.has_key?("json-schema")
-        require 'json-schema'
-        # if this raises a 'Invalid fragment resolution for :fragment option' it is because @type
-        # does not correspond to a definition in the schema
-        JSON::Validator.fully_validate(@@schema, @hash, :fragment => "#/components/schemas/#{@type}")
-      end
-    end
-
     # remove illegal characters in identifier
     def self.clean_name(str)
       ascii = str.encode(Encoding.find('ASCII'), **@@encoding_options)

data/lib/honeybee/simulation/parameter_model.rb

@@ -62,23 +62,6 @@ module Honeybee
       raise "Incorrect model type for SimulationParameter '#{@type}'" unless @type == 'SimulationParameter'
     end
 
-    # check if the model is valid
-    def valid?
-      if Gem.loaded_specs.has_key?("json-schema")
-        return validation_errors.empty?
-      else
-        return true
-      end
-    end
-
-    # return detailed model validation errors
-    def validation_errors
-      if Gem.loaded_specs.has_key?("json-schema")
-        require 'json-schema'
-        JSON::Validator.fully_validate(@@schema, @hash, :fragment => "#/components/schemas/#{@type}")
-      end
-    end
-
     def defaults
       @@schema[:components][:schemas]
     end

data/lib/measures/from_honeybee_simulation_parameter/measure.rb

@@ -80,10 +80,6 @@ class FromHoneybeeSimulationParameter < OpenStudio::Measure::ModelMeasure
 
     sim_par_object = Honeybee::SimulationParameter.read_from_disk(simulation_parameter_json)
 
-    if !sim_par_object.valid?
-      # runner.registerError("File '#{simulation_parameter_json}' is not valid")
-      # return false
-    end
     STDOUT.flush
     sim_par_object.to_openstudio_model(model)
     STDOUT.flush

data/lib/to_openstudio/hvac/radiant.rb

@@ -345,8 +345,6 @@ class OpenStudio::Model::Model
     mat_roof_insulation.setName("Radiant Exterior Ceiling Insulation - #{(cz_mult + 1) * 2} in.")
 
     # create radiant internal source constructions
-    OpenStudio.logFree(OpenStudio::Warn, 'openstudio.Model.Model', 'New constructions exclude the metal deck, as high thermal diffusivity materials cause errors in EnergyPlus internal source construction calculations.')
-
     radiant_ground_slab_construction = nil
     radiant_exterior_slab_construction = nil
     radiant_interior_floor_slab_construction = nil

data/lib/to_openstudio/hvac/template.rb

@@ -115,18 +115,23 @@ module Honeybee
         end
       end
 
-      # set the efficiencies of supply components in the air loop
+      # set the efficiencies of fans to be reasonable for DOAS vs. All-Air loops
       if !os_air_loops.empty?
+        if equipment_type.to_s.include? 'DOAS'
+          fan_size = 0.2
+        else
+          fan_size = 2
+        end
         os_air_loops.each do |os_air_loop|
           # set the supply fan efficiency
           unless os_air_loop.supplyFan.empty?
             s_fan = os_air_loop.supplyFan.get
             s_fan = fan_from_component(s_fan)
             unless s_fan.nil?
-              s_fan.setMaximumFlowRate(1)
+              s_fan.setMaximumFlowRate(fan_size)  # set to a typical value
               standard.fan_apply_standard_minimum_motor_efficiency(
                 s_fan, standard.fan_brake_horsepower(s_fan))
-              s_fan.autosizeMaximumFlowRate()
+              s_fan.autosizeMaximumFlowRate()  # set it back to autosize
             end
           end
           # set the return fan efficiency
@@ -134,31 +139,35 @@ module Honeybee
             ex_fan = os_air_loop.returnFan.get
             ex_fan = fan_from_component(ex_fan)
             unless ex_fan.nil?
-              ex_fan.setMaximumFlowRate(1)
+              ex_fan.setMaximumFlowRate(fan_size)  # set to a typical value
               standard.fan_apply_standard_minimum_motor_efficiency(
                 ex_fan, standard.fan_brake_horsepower(ex_fan))
-              ex_fan.autosizeMaximumFlowRate()
+              ex_fan.autosizeMaximumFlowRate()  # set it back to autosize
             end
           end
         end
       end
 
-      # get the boilers and assign the correct efficiency
+      # get the boilers and assign a reasonable efficiency (assuming 40kW boilers)
       if equipment_type.to_s.include? 'Boiler'
         openstudio_model.getBoilerHotWaters.sort.each do |obj|
-          obj.setNominalCapacity(40000)  # set to a dummy value for the method
+          obj.setNominalCapacity(40000)  # set to a typical value
           standard.boiler_hot_water_apply_efficiency_and_curves(obj)
           obj.autosizeNominalCapacity()  # set it back to autosize
           obj.setName(standard_id + ' Boiler')
         end
       end
 
-      # get the chillers and assign a reasonable COP from the standard
+      # get the chillers and assign a reasonable COP (assuming 2000kW water-cooled; 600kW air-cooled)
       if equipment_type.to_s.include? 'Chiller'
-        # set the chiller efficiency
+        if equipment_type.to_s.include? 'ACChiller'
+          chiller_size = 600000
+        else
+          chiller_size = 2000000
+        end
         clg_tower_objs = openstudio_model.getCoolingTowerSingleSpeeds
         openstudio_model.getChillerElectricEIRs.sort.each do |obj|
-          obj.setReferenceCapacity(2000000)  # set to a dummy value for method
+          obj.setReferenceCapacity(chiller_size)  # set to a typical value
           if obj.name.empty?
             obj_name = standard_id + ' Chiller'
           else
@@ -170,7 +179,7 @@ module Honeybee
         end
       end
 
-      # set the efficiency of any gas heaters
+      # set the efficiency of any gas heaters (assuming 10kW heaters)
       if equipment_type.to_s.include? 'GasHeaters'
         zones.each do |zon|
           zon.equipment.each do |equp|
@@ -179,7 +188,7 @@ module Honeybee
               coil = unit_heater.heatingCoil
               unless coil.to_CoilHeatingGas.empty?
                 coil = coil.to_CoilHeatingGas.get
-                coil.setNominalCapacity(10000)  # set to a dummy value for method
+                coil.setNominalCapacity(10000)  # set to a typical value
                 standard.coil_heating_gas_apply_efficiency_and_curves(coil)
                 coil.autosizeNominalCapacity()  # set it back to autosize
               end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.33.2
+  version: 2.33.4
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-10-10 00:00:00.000000000 Z
+date: 2022-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -117,28 +117,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: openstudio-standards
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.15
+        version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.15
+        version: 0.3.0
 description: Library and measures for translating between Honeybee JSON schema and
   OpenStudio Model schema (OSM).
 email: