honeybee-openstudio 2.30.5 → 2.30.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c093a7ba23305db86e618c8480375e646242ff00c18d51a68d1452a2811116ce
-  data.tar.gz: 6fe7d668d07db8a0104d14f964e08b65b166bdffe66170bb88352d5390de1197
+  metadata.gz: 3152d4118f8b8ed6aedfeff6e4ae46b7965e1956d4049d86056f54bd423cad7c
+  data.tar.gz: d2fba53c5594e7c7f88da70ef8f317161bb36ef7272dc3e22bebed25d2b9990f
 SHA512:
-  metadata.gz: 4014954666bee170a8cd83ff13468f907529fa4ddef7709cc307d9a1262f3eeb893487480697a897f5649dacc8eef5514c2d20e96b15a913c0129b32c3fc6005
-  data.tar.gz: 8300e8718f8f28bbec2366935651cedc1bb145653dec3ea7cce508f4ca01c9117a49498101d5bc41fcc652ad848a8bc19ddb1b4c82e158113ae0e11dfeb2d112
+  metadata.gz: 26297730ec9926925ec8338abd9e650af554905eaf612114a6d1527f6d84e05d15e38015462da699e18479ce037fec213e6c0a8098795d1f4885996ff167109c
+  data.tar.gz: 669b0bf005d96be102d4bf8c8138c2e86a60c2af03c0f16b27034cdf2e3b0a582855f6a03d614d17fcc64813512d60d06a8b761706365b3722607d5afc5b0072

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.30.5'
+  spec.version       = '2.30.6'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/to_openstudio/hvac/template.rb

@@ -80,119 +80,132 @@ module Honeybee
       end
 
       # create the HVAC system and assign the display name to the air loop name if it exists
-      os_hvac = openstudio_model.add_cbecs_hvac_system(standard, equipment_type, zones)
-      os_air_loop = nil
+      openstudio_model.add_cbecs_hvac_system(standard, equipment_type, zones)
+      os_air_loops = []
       air_loops = openstudio_model.getAirLoopHVACs
       unless air_loops.length == $air_loop_count  # check if any new loops were added
         $air_loop_count = air_loops.length
-        os_air_terminal = []
         zones.each do |zon|
           os_air_terminal = zon.airLoopHVACTerminal
-          break if !os_air_terminal.empty?
-        end
-        unless os_air_terminal.empty?
-          os_air_terminal = os_air_terminal.get
-          os_air_loop_opt = os_air_terminal.airLoopHVAC
-          unless os_air_loop_opt.empty?
-            os_air_loop = os_air_loop_opt.get
-            loop_name = os_air_loop.name
-            unless loop_name.empty?
-              # set the name of the air loop to align with the HVAC name
-              if @hash[:display_name]
-                clean_name = @hash[:display_name].to_s.gsub(/[^.A-Za-z0-9_-] /, " ")
-                os_air_loop.setName(clean_name + ' - ' + loop_name.get)
+          unless os_air_terminal.empty?
+            os_air_terminal = os_air_terminal.get
+            os_air_loop_opt = os_air_terminal.airLoopHVAC
+            unless os_air_loop_opt.empty?
+              os_air_loop = os_air_loop_opt.get
+              os_air_loops << os_air_loop
+              loop_name = os_air_loop.name
+              unless loop_name.empty?
+                # set the name of the air loop to align with the HVAC name
+                if @hash[:display_name]
+                  clean_name = @hash[:display_name].to_s.gsub(/[^.A-Za-z0-9_-] /, " ")
+                  os_air_loop.setName(clean_name + ' - ' + loop_name.get)
+                end
               end
+              break if !equipment_type.include? 'PSZ'  # multiple air loops have been added
             end
           end
         end
       end
 
       # assign the economizer type if there's an air loop and the economizer is specified
-      if @hash[:economizer_type] && os_air_loop
-        oasys = os_air_loop.airLoopHVACOutdoorAirSystem
-        unless oasys.empty?
-          os_oasys = oasys.get
-          oactrl = os_oasys.getControllerOutdoorAir
-          oactrl.setEconomizerControlType(@hash[:economizer_type])
+      if @hash[:economizer_type] && !os_air_loops.empty?
+        os_air_loops.each do |os_air_loop|
+          oasys = os_air_loop.airLoopHVACOutdoorAirSystem
+          unless oasys.empty?
+            os_oasys = oasys.get
+            oactrl = os_oasys.getControllerOutdoorAir
+            oactrl.setEconomizerControlType(@hash[:economizer_type])
+          end
         end
       end
 
       # set the sensible heat recovery if there's an air loop and the heat recovery is specified
-      if @hash[:sensible_heat_recovery] && @hash[:sensible_heat_recovery] != 0 && os_air_loop
-        erv = get_existing_erv(os_air_loop)
-        unless erv
-          erv = create_erv(openstudio_model, os_air_loop)
+      if @hash[:sensible_heat_recovery] && @hash[:sensible_heat_recovery] != 0 && !os_air_loops.empty?
+        os_air_loops.each do |os_air_loop|
+          erv = get_existing_erv(os_air_loop)
+          unless erv
+            erv = create_erv(openstudio_model, os_air_loop)
+          end
+          eff_at_max = @hash[:sensible_heat_recovery] * (0.76 / 0.81)  # taken from OpenStudio defaults
+          erv.setSensibleEffectivenessat100CoolingAirFlow(eff_at_max)
+          erv.setSensibleEffectivenessat100HeatingAirFlow(eff_at_max)
+          erv.setSensibleEffectivenessat75CoolingAirFlow(@hash[:sensible_heat_recovery])
+          erv.setSensibleEffectivenessat75HeatingAirFlow(@hash[:sensible_heat_recovery])
         end
-        eff_at_max = @hash[:sensible_heat_recovery] * (0.76 / 0.81)  # taken from OpenStudio defaults
-        erv.setSensibleEffectivenessat100CoolingAirFlow(eff_at_max)
-        erv.setSensibleEffectivenessat100HeatingAirFlow(eff_at_max)
-        erv.setSensibleEffectivenessat75CoolingAirFlow(@hash[:sensible_heat_recovery])
-        erv.setSensibleEffectivenessat75HeatingAirFlow(@hash[:sensible_heat_recovery])
       end
 
       # set the latent heat recovery if there's an air loop and the heat recovery is specified
-      if @hash[:latent_heat_recovery] && @hash[:latent_heat_recovery] != 0 && os_air_loop
-        erv = get_existing_erv(os_air_loop)
-        unless erv
-          erv = create_erv(openstudio_model, os_air_loop)
+      if @hash[:latent_heat_recovery] && @hash[:latent_heat_recovery] != 0 && !os_air_loops.empty?
+        os_air_loops.each do |os_air_loop|
+          erv = get_existing_erv(os_air_loop)
+          unless erv
+            erv = create_erv(openstudio_model, os_air_loop)
+          end
+          eff_at_max = @hash[:latent_heat_recovery] * (0.68 / 0.73)  # taken from OpenStudio defaults
+          erv.setLatentEffectivenessat100CoolingAirFlow(eff_at_max)
+          erv.setLatentEffectivenessat100HeatingAirFlow(eff_at_max)
+          erv.setLatentEffectivenessat75CoolingAirFlow(@hash[:latent_heat_recovery])
+          erv.setLatentEffectivenessat75HeatingAirFlow(@hash[:latent_heat_recovery])
         end
-        eff_at_max = @hash[:latent_heat_recovery] * (0.68 / 0.73)  # taken from OpenStudio defaults
-        erv.setLatentEffectivenessat100CoolingAirFlow(eff_at_max)
-        erv.setLatentEffectivenessat100HeatingAirFlow(eff_at_max)
-        erv.setLatentEffectivenessat75CoolingAirFlow(@hash[:latent_heat_recovery])
-        erv.setLatentEffectivenessat75HeatingAirFlow(@hash[:latent_heat_recovery])
       end
 
       # assign demand controlled ventilation if there's an air loop
-      if @hash[:demand_controlled_ventilation] && os_air_loop
-        oasys = os_air_loop.airLoopHVACOutdoorAirSystem
-        unless oasys.empty?
-          os_oasys = oasys.get
-          oactrl = os_oasys.getControllerOutdoorAir
-          vent_ctrl = oactrl.controllerMechanicalVentilation
-          vent_ctrl.setDemandControlledVentilationNoFail(true)
-          oactrl.resetMinimumFractionofOutdoorAirSchedule
+      if @hash[:demand_controlled_ventilation] && !os_air_loops.empty?
+        os_air_loops.each do |os_air_loop|
+          oasys = os_air_loop.airLoopHVACOutdoorAirSystem
+          unless oasys.empty?
+            os_oasys = oasys.get
+            oactrl = os_oasys.getControllerOutdoorAir
+            vent_ctrl = oactrl.controllerMechanicalVentilation
+            vent_ctrl.setDemandControlledVentilationNoFail(true)
+            oactrl.resetMinimumFractionofOutdoorAirSchedule
+          end
         end
       end
 
       # assign the DOAS availability schedule if there's an air loop and it is specified
-      if @hash[:doas_availability_schedule] && os_air_loop
-        schedule = openstudio_model.getScheduleByName(@hash[:doas_availability_schedule])
-        unless schedule.empty?
-          avail_sch = schedule.get
-          os_air_loop.setAvailabilitySchedule(avail_sch)
+      if @hash[:doas_availability_schedule] && !os_air_loops.empty?
+        os_air_loops.each do |os_air_loop|
+          schedule = openstudio_model.getScheduleByName(@hash[:doas_availability_schedule])
+          unless schedule.empty?
+            avail_sch = schedule.get
+            os_air_loop.setAvailabilitySchedule(avail_sch)
+          end
         end
       end
 
       # set the outdoor air controller to respect room-level ventilation schedules if they exist
-      if os_air_loop
-        oasys = os_air_loop.airLoopHVACOutdoorAirSystem
-        unless oasys.empty?
-          os_oasys = oasys.get
-          oactrl = os_oasys.getControllerOutdoorAir
-          oa_sch, oa_sch_name = nil, nil
-          zones.each do |zone|
-            oa_spec = zone.spaces[0].designSpecificationOutdoorAir
-            unless oa_spec.empty?
-              oa_spec = oa_spec.get
-              space_oa_sch = oa_spec.outdoorAirFlowRateFractionSchedule
-              unless space_oa_sch.empty?
-                space_oa_sch = space_oa_sch.get
-                space_oa_sch_name = space_oa_sch.name
-                unless space_oa_sch_name.empty?
-                  space_oa_sch_name = space_oa_sch_name.get
-                  if oa_sch_name.nil? || space_oa_sch_name == oa_sch_name
-                    oa_sch, oa_sch_name = space_oa_sch, space_oa_sch_name
-                  else
-                    oa_sch = nil
-                  end
+      if !os_air_loops.empty?
+        oa_sch, oa_sch_name = nil, nil
+        zones.each do |zone|
+          oa_spec = zone.spaces[0].designSpecificationOutdoorAir
+          unless oa_spec.empty?
+            oa_spec = oa_spec.get
+            space_oa_sch = oa_spec.outdoorAirFlowRateFractionSchedule
+            unless space_oa_sch.empty?
+              space_oa_sch = space_oa_sch.get
+              space_oa_sch_name = space_oa_sch.name
+              unless space_oa_sch_name.empty?
+                space_oa_sch_name = space_oa_sch_name.get
+                if oa_sch_name.nil? || space_oa_sch_name == oa_sch_name
+                  oa_sch, oa_sch_name = space_oa_sch, space_oa_sch_name
+                else
+                  oa_sch = nil
                 end
               end
             end
           end
-          if oa_sch
-            oactrl.resetMinimumFractionofOutdoorAirSchedule
-            oactrl.setMinimumOutdoorAirSchedule(oa_sch)
+        end
+
+        if oa_sch
+          os_air_loops.each do |os_air_loop|
+            oasys = os_air_loop.airLoopHVACOutdoorAirSystem
+            unless oasys.empty?
+              os_oasys = oasys.get
+              oactrl = os_oasys.getControllerOutdoorAir
+              oactrl.resetMinimumFractionofOutdoorAirSchedule
+              oactrl.setMinimumOutdoorAirSchedule(oa_sch)
+            end
           end
         end
       end
@@ -234,7 +247,7 @@ module Honeybee
       end
 
       # assign an electric humidifier if there's an air loop and the zones have a humidistat
-      if os_air_loop
+      if !os_air_loops.empty?
         humidistat_exists = false
         zones.each do |zone|
           h_stat = zone.zoneControlHumidistat
@@ -243,7 +256,9 @@ module Honeybee
           end
         end
         if humidistat_exists
-          humidifier = create_humidifier(openstudio_model, os_air_loop)
+          os_air_loops.each do |os_air_loop|
+            humidifier = create_humidifier(openstudio_model, os_air_loop)
+          end
         end
       end
 
@@ -253,7 +268,6 @@ module Honeybee
         sizing.setSizingOption('NonCoincident')
       end
 
-      os_hvac
     end
 
   private

data/lib/to_openstudio/model.rb

@@ -564,7 +564,7 @@ module Honeybee
             end
           elsif TemplateHVAC.types.include?(system_type)
             template_system = TemplateHVAC.new(hvac)
-            os_template_system = template_system.to_openstudio(@openstudio_model, hvac['rooms'])
+            template_system.to_openstudio(@openstudio_model, hvac['rooms'])
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.30.5
+  version: 2.30.6
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-03-09 00:00:00.000000000 Z
+date: 2022-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler