honeybee-openstudio 2.28.1 → 2.28.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f46d6897c585ff7082971de6ff24b62e1d4213697bb9e3fb08a9b4eefd069a6d
-  data.tar.gz: 4c231dc4b6622e5d9871eddb54e6b6e32ebb5302183372845ea690552f0407f3
+  metadata.gz: ad5296dcafd3fc2be5c3dd7262a6486cc032cc343e8f9096928ba1a8a2d44e31
+  data.tar.gz: c59e93091733132e6e6a3e285318a216f0908a78666ec9ae0d93e89eab0e301f
 SHA512:
-  metadata.gz: 8a9192fca6bf36375576eb5fd7efb3f104e4ed34b2607e8d80c36ce60f272cdd7c62b1badb4a43f1c0daa0e813b63e5dffc407e25032172c045d7523b5f05e7d
-  data.tar.gz: e2533183332b489d8ba275feddf184c56f7cdca3a5bb561ce9ae7ad6af3177b9983b57872a1623c316a1d4b3ddea060dec1ab2714429edbe1a450928c5a5bb01
+  metadata.gz: 1244240f77dc03a0806835535e7fd9f5f0c2e75753b52cdafcdd8ca73e8affec5c78d3bb281d33ace2c0cada3ebab33e56772b28b0209aaddc2ca9321dafd145
+  data.tar.gz: 846365ff7d278a183d8c91b401d65ab2a81112b55c5b1bd01f4799b37cca2e1985f633635a05894df015fc6364a99f57c3137a7182928da7ace34ce27ed8e1e8

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.28.1'
+  spec.version       = '2.28.5'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/files/urbanopt_Gemfile

@@ -9,7 +9,7 @@ if allow_local && File.exist?('../openstudio-common-measures-gem')
 elsif allow_local
   gem 'openstudio-common-measures', github: 'NREL/openstudio-common-measures-gem', branch: 'develop'
 else
-  gem 'openstudio-common-measures', '~> 0.4.0'
+  gem 'openstudio-common-measures', '~> 0.5.0'
 end
 
 if allow_local && File.exist?('../openstudio-model-articulation-gem')
@@ -17,7 +17,7 @@ if allow_local && File.exist?('../openstudio-model-articulation-gem')
 elsif allow_local
   gem 'openstudio-model-articulation', github: 'NREL/openstudio-model-articulation-gem', branch: 'develop'
 else
-  gem 'openstudio-model-articulation', '0.4.0'
+  gem 'openstudio-model-articulation', '0.5.0'
 end
 
 if allow_local && File.exist?('../urbanopt-geojson-gem')
@@ -25,7 +25,7 @@ if allow_local && File.exist?('../urbanopt-geojson-gem')
 elsif allow_local
   gem 'urbanopt-geojson', github: 'URBANopt/urbanopt-geojson-gem', branch: 'develop'
 else
-  gem 'urbanopt-geojson', '~> 0.6.1'
+  gem 'urbanopt-geojson', '~> 0.7.0'
 end
 
 if allow_local && File.exist?('../urbanopt-reporting-gem')
@@ -33,8 +33,8 @@ if allow_local && File.exist?('../urbanopt-reporting-gem')
 elsif allow_local
   gem 'urbanopt-reporting', github: 'URBANopt/urbanopt-reporting-gem', branch: 'develop'
 else
-  gem 'urbanopt-reporting', '~> 0.4.0'
+  gem 'urbanopt-reporting', '~> 0.5.0'
 end
 
 # include the honeybee-openstudio-gem
-gem 'honeybee-openstudio', '2.27.0'
+gem 'honeybee-openstudio', '2.28.4'

data/lib/to_openstudio/construction_set.rb

@@ -205,8 +205,12 @@ module Honeybee
 
       # assign any air boundary constructions to construction set
       if @hash[:air_boundary_construction]
-        air_ref = openstudio_model.getConstructionAirBoundaryByName(
-          @hash[:air_boundary_construction])
+        air_ref = openstudio_model.getConstructionAirBoundaryByName(@hash[:air_boundary_construction])
+        unless air_ref.empty?
+          air_construction = air_ref.get
+          os_constr_set.setInteriorPartitionConstruction(air_construction)
+        end
+        air_ref = openstudio_model.getConstructionByName(@hash[:air_boundary_construction])
         unless air_ref.empty?
           air_construction = air_ref.get
           os_constr_set.setInteriorPartitionConstruction(air_construction)

data/lib/to_openstudio/geometry/aperture.rb

@@ -48,14 +48,13 @@ module Honeybee
       @hash[:geometry][:boundary].each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
       # triangulate subsurface if neccesary
       triangulated = false
       final_vertices_list = []
       matching_os_subsurfaces = []
       matching_os_subsurface_indices = []
-      if reordered_vertices.size > 4
+      if os_vertices.size > 4
 
         # if this apeture has a matched apeture, see if the other one has already been created
         # the matched apeture should have been converted to multiple subsurfaces
@@ -75,9 +74,9 @@ module Honeybee
         if final_vertices_list.empty?
 
           # transform to face coordinates
-          t = OpenStudio::Transformation::alignFace(reordered_vertices)
+          t = OpenStudio::Transformation::alignFace(os_vertices)
           tInv = t.inverse
-          face_vertices = OpenStudio::reverse(tInv*reordered_vertices)
+          face_vertices = OpenStudio::reverse(tInv*os_vertices)
 
           # no holes in the subsurface
           holes = OpenStudio::Point3dVectorVector.new
@@ -85,7 +84,7 @@ module Honeybee
           # triangulate surface
           triangles = OpenStudio::computeTriangulation(face_vertices, holes)
           if triangles.empty?
-            raise "Failed to triangulate aperture #{@hash[:identifier]} with #{reordered_vertices.size} vertices"
+            raise "Failed to triangulate aperture #{@hash[:identifier]} with #{os_vertices.size} vertices"
           end
 
           # create new list of surfaces
@@ -98,13 +97,13 @@ module Honeybee
         end
 
       else
-        # reordered_vertices are good as is
-        final_vertices_list << reordered_vertices
+        # os_vertices are good as is
+        final_vertices_list << os_vertices
       end
 
       result = []
-      final_vertices_list.each_with_index do |reordered_vertices, index|
-        os_subsurface = OpenStudio::Model::SubSurface.new(reordered_vertices, openstudio_model)
+      final_vertices_list.each_with_index do |os_vertices, index|
+        os_subsurface = OpenStudio::Model::SubSurface.new(os_vertices, openstudio_model)
 
         if !matching_os_subsurfaces.empty?
           os_subsurface.setName(@hash[:identifier] + "..#{matching_os_subsurface_indices[index]}")
@@ -174,9 +173,8 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-      os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+      os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
       os_shading_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_shading_surface.setDisplayName(@hash[:display_name])

data/lib/to_openstudio/geometry/door.rb

@@ -48,14 +48,13 @@ module Honeybee
       @hash[:geometry][:boundary].each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
       # triangulate subsurface if neccesary
       triangulated = false
       final_vertices_list = []
       matching_os_subsurfaces = []
       matching_os_subsurface_indices = []
-      if reordered_vertices.size > 4
+      if os_vertices.size > 4
 
         # if this door has a matched door, see if the other one has already been created
         # the matched door should have been converted to multiple subsurfaces
@@ -75,9 +74,9 @@ module Honeybee
         if final_vertices_list.empty?
 
           # transform to face coordinates
-          t = OpenStudio::Transformation::alignFace(reordered_vertices)
+          t = OpenStudio::Transformation::alignFace(os_vertices)
           tInv = t.inverse
-          face_vertices = OpenStudio::reverse(tInv*reordered_vertices)
+          face_vertices = OpenStudio::reverse(tInv*os_vertices)
 
           # no holes in the subsurface
           holes = OpenStudio::Point3dVectorVector.new
@@ -85,7 +84,7 @@ module Honeybee
           # triangulate surface
           triangles = OpenStudio::computeTriangulation(face_vertices, holes)
           if triangles.empty?
-            raise "Failed to triangulate door #{@hash[:identifier]} with #{reordered_vertices.size} vertices"
+            raise "Failed to triangulate door #{@hash[:identifier]} with #{os_vertices.size} vertices"
           end
 
           # create new list of surfaces
@@ -98,13 +97,13 @@ module Honeybee
         end
 
       else
-        # reordered_vertices are good as is
-        final_vertices_list << reordered_vertices
+        # os_vertices are good as is
+        final_vertices_list << os_vertices
       end
 
       result = []
-      final_vertices_list.each_with_index do |reordered_vertices, index|
-        os_subsurface = OpenStudio::Model::SubSurface.new(reordered_vertices, openstudio_model)
+      final_vertices_list.each_with_index do |os_vertices, index|
+        os_subsurface = OpenStudio::Model::SubSurface.new(os_vertices, openstudio_model)
 
         if !matching_os_subsurfaces.empty?
           os_subsurface.setName(@hash[:identifier] + "..#{matching_os_subsurface_indices[index]}")
@@ -168,9 +167,8 @@ module Honeybee
     hb_verts.each do |vertex|
       os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
     end
-    reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-    os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+    os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
     os_shading_surface.setName(@hash[:identifier])
     unless @hash[:display_name].nil?
       os_shading_surface.setDisplayName(@hash[:display_name])

data/lib/to_openstudio/geometry/face.rb

@@ -55,10 +55,9 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
       # create the openstudio surface and assign the type
-      os_surface = OpenStudio::Model::Surface.new(reordered_vertices, openstudio_model)
+      os_surface = OpenStudio::Model::Surface.new(os_vertices, openstudio_model)
       os_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_surface.setDisplayName(@hash[:display_name])
@@ -198,9 +197,8 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-      os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+      os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
       os_shading_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_shading_surface.setDisplayName(@hash[:display_name])

data/lib/to_openstudio/geometry/room.rb

@@ -189,6 +189,7 @@ module Honeybee
           end
         end
 
+        # assign interior constructions for adiabatic Faces
         if !face[:properties][:energy][:construction]
           if face[:boundary_condition][:type] == 'Adiabatic'
             # assign default interior construction for Adiabatic Faces
@@ -198,28 +199,38 @@ module Honeybee
                 os_surface.setConstruction(interior_construction)
               end
             end
-          elsif face[:face_type] == 'AirBoundary'
-            # assign default air boundary construction for AirBoundary face types
-            air_construction = closest_air_construction(openstudio_model, os_space)
+          end
+        end
+
+        # assign air boundaries
+        if face[:face_type] == 'AirBoundary'
+          # assign default air boundary construction for AirBoundary face types
+          air_construction = closest_air_construction(openstudio_model, os_space)
+          if !face[:properties][:energy][:construction]
             unless air_construction.nil?
               os_surface.setConstruction(air_construction)
             end
-            # add air mixing properties to the global list that tracks them
-            if $use_simple_vent  # only use air mixing objects when simple ventilation is requested
-              air_hash = $air_boundary_hash[air_construction.name.to_s]
-              if air_hash[:air_mixing_per_area]
-                air_mix_area = air_hash[:air_mixing_per_area]
-              else
-                air_default = @@schema[:components][:schemas][:AirBoundaryConstructionAbridged]
-                air_mix_area = air_default[:properties][:air_mixing_per_area][:default]
-              end
-              flow_rate = os_surface.netArea * air_mix_area
+          end
+          # add air mixing properties to the global list that tracks them
+          if $use_simple_vent  # only use air mixing objects when simple ventilation is requested
+            air_hash = $air_boundary_hash[air_construction.name.to_s]
+            if air_hash && air_hash[:air_mixing_per_area]
+              air_mix_area = air_hash[:air_mixing_per_area]
+            else
+              air_default = @@schema[:components][:schemas][:AirBoundaryConstructionAbridged]
+              air_mix_area = air_default[:properties][:air_mixing_per_area][:default]
+            end
+            flow_rate = os_surface.netArea * air_mix_area
+            if air_hash
               flow_sch_id = air_hash[:air_mixing_schedule]
-              adj_zone_id = face[:boundary_condition][:boundary_condition_objects][-1]
-              $air_mxing_array << [os_thermal_zone, flow_rate, flow_sch_id, adj_zone_id]
+            else
+              flow_sch_id = 'Always On'
             end
+            adj_zone_id = face[:boundary_condition][:boundary_condition_objects][-1]
+            $air_mxing_array << [os_thermal_zone, flow_rate, flow_sch_id, adj_zone_id]
           end
         end
+      
       end
 
       # assign any room-level outdoor shades if they exist

data/lib/to_openstudio/geometry/shade.rb

@@ -55,9 +55,8 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-      os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+      os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
       os_shading_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_shading_surface.setDisplayName(@hash[:display_name])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.28.1
+  version: 2.28.5
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-12-06 00:00:00.000000000 Z
+date: 2022-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler